@angular/cli 9.0.0-rc.6 → 9.0.0

package/bin/postinstall/script.js

@@ -1,5 +1,8 @@
 #!/usr/bin/env node
 'use strict';
 
-require('./ng-update-message');
-require('./analytics-prompt');
+// These should not fail but if they do they should not block installation of the package
+try {
+  require('./ng-update-message');
+  require('./analytics-prompt');
+} catch (_) {}

package/commands/add-impl.d.ts

@@ -3,7 +3,6 @@ import { SchematicCommand } from '../models/schematic-command';
 import { Schema as AddCommandSchema } from './add';
 export declare class AddCommand extends SchematicCommand<AddCommandSchema> {
     readonly allowPrivateSchematics = true;
-    readonly allowAdditionalArgs = true;
     run(options: AddCommandSchema & Arguments): Promise<number | void>;
     reportAnalytics(paths: string[], options: AddCommandSchema & Arguments, dimensions?: (boolean | number | string)[], metrics?: (boolean | number | string)[]): Promise<void>;
     private isPackageInstalled;

package/commands/add-impl.js

@@ -23,7 +23,6 @@ class AddCommand extends schematic_command_1.SchematicCommand {
     constructor() {
         super(...arguments);
         this.allowPrivateSchematics = true;
-        this.allowAdditionalArgs = true;
     }
     async run(options) {
         if (!options.collection) {

package/commands/doc-impl.js

@@ -42,7 +42,7 @@ class DocCommand extends command_1.Command {
         }
         let searchUrl = `https://${domain}/api?query=${options.keyword}`;
         if (options.search) {
-            searchUrl = `https://www.google.com/search?q=site%3A${domain}+${options.keyword}`;
+            searchUrl = `https://${domain}/?search=${options.keyword}`;
         }
         // We should wrap `open` in a new Promise because `open` is already resolved
         await new Promise(() => {

package/commands/update-impl.js

@@ -27,6 +27,14 @@ const pickManifest = require('npm-pick-manifest');
 const oldConfigFileNames = ['.angular-cli.json', 'angular-cli.json'];
 const NG_VERSION_9_POST_MSG = color_1.colors.cyan('\nYour project has been updated to Angular version 9!\n' +
     'For more info, please see: https://v9.angular.io/guide/updating-to-version-9');
+/**
+ * Disable CLI version mismatch checks and forces usage of the invoked CLI
+ * instead of invoking the local installed version.
+ */
+const disableVersionCheckEnv = process.env['NG_DISABLE_VERSION_CHECK'];
+const disableVersionCheck = disableVersionCheckEnv !== undefined &&
+    disableVersionCheckEnv !== '0' &&
+    disableVersionCheckEnv.toLowerCase() !== 'false';
 class UpdateCommand extends command_1.Command {
     constructor() {
         super(...arguments);
@@ -174,8 +182,26 @@ class UpdateCommand extends command_1.Command {
     }
     // tslint:disable-next-line:no-big-function
     async run(options) {
+        // Check if the @angular-devkit/schematics package can be resolved from the workspace root
+        // This works around issues with packages containing migrations that cannot directly depend on the package
+        // This check can be removed once the schematic runtime handles this situation
+        try {
+            require.resolve('@angular-devkit/schematics', { paths: [this.workspace.root] });
+        }
+        catch (e) {
+            if (e.code === 'MODULE_NOT_FOUND') {
+                this.logger.fatal('The "@angular-devkit/schematics" package cannot be resolved from the workspace root directory. ' +
+                    'This may be due to an unsupported node modules structure.\n' +
+                    'Please remove both the "node_modules" directory and the package lock file; and then reinstall.\n' +
+                    'If this does not correct the problem, ' +
+                    'please temporarily install the "@angular-devkit/schematics" package within the workspace. ' +
+                    'It can be removed once the update is complete.');
+                return 1;
+            }
+            throw e;
+        }
         // Check if the current installed CLI version is older than the latest version.
-        if (await this.checkCLILatestVersion(options.verbose, options.next)) {
+        if (!disableVersionCheck && await this.checkCLILatestVersion(options.verbose, options.next)) {
             this.logger.warn(`The installed Angular CLI version is older than the latest ${options.next ? 'pre-release' : 'stable'} version.\n` +
                 'Installing a temporary version to perform the update.');
             return install_package_1.runTempPackageBin(`@angular/cli@${options.next ? 'next' : 'latest'}`, this.logger, this.packageManager, process.argv.slice(2));

package/lib/init.js

@@ -9,7 +9,6 @@ Object.defineProperty(exports, "__esModule", { value: true });
  */
 require("symbol-observable");
 // symbol polyfill must go first
-// tslint:disable: no-console
 // tslint:disable-next-line:ordered-imports import-groups
 const core_1 = require("@angular-devkit/core");
 const fs = require("fs");
@@ -61,6 +60,13 @@ if (process.env['NG_CLI_PROFILING']) {
     process.on('uncaughtException', () => exitHandler({ exit: true }));
 }
 (async () => {
+    /**
+     * Disable Browserslist old data warning as otherwise with every release we'd need to update this dependency
+     * which is cumbersome considering we pin versions and the warning is not user actionable.
+     * `Browserslist: caniuse-lite is outdated. Please run next command `npm update`
+     * See: https://github.com/browserslist/browserslist/blob/819c4337456996d19db6ba953014579329e9c6e1/node.js#L324
+     */
+    process.env.BROWSERSLIST_IGNORE_OLD_DATA = '1';
     const disableVersionCheckEnv = process.env['NG_DISABLE_VERSION_CHECK'];
     /**
      * Disable CLI version mismatch checks and forces usage of the invoked CLI
@@ -84,7 +90,7 @@ if (process.env['NG_CLI_PROFILING']) {
             shouldWarn = localVersion != null && globalVersion.compare(localVersion) > 0;
         }
         catch (e) {
-            // eslint-disable-next-line no-console
+            // tslint:disable-next-line no-console
             console.error(e);
             shouldWarn = true;
         }
@@ -97,11 +103,11 @@ if (process.env['NG_CLI_PROFILING']) {
       `);
             // Don't show warning colorised on `ng completion`
             if (process.argv[2] !== 'completion') {
-                // eslint-disable-next-line no-console
+                // tslint:disable-next-line no-console
                 console.error(warning);
             }
             else {
-                // eslint-disable-next-line no-console
+                // tslint:disable-next-line no-console
                 console.error(warning);
                 process.exit(1);
             }
@@ -141,6 +147,7 @@ if (process.env['NG_CLI_PROFILING']) {
     process.exit(exitCode);
 })
     .catch((err) => {
+    // tslint:disable-next-line no-console
     console.error('Unknown error: ' + err.toString());
     process.exit(127);
 });

package/models/schematic-command.d.ts

@@ -31,7 +31,6 @@ export declare class UnknownCollectionError extends Error {
 }
 export declare abstract class SchematicCommand<T extends BaseSchematicSchema & BaseCommandOptions> extends Command<T> {
     readonly allowPrivateSchematics: boolean;
-    readonly allowAdditionalArgs: boolean;
     private _host;
     private _workspace;
     protected _workflow: NodeWorkflow;

package/models/schematic-command.js

@@ -31,7 +31,6 @@ class SchematicCommand extends command_1.Command {
     constructor(context, description, logger) {
         super(context, description, logger);
         this.allowPrivateSchematics = false;
-        this.allowAdditionalArgs = false;
         this._host = new node_1.NodeJsSyncHost();
         this.defaultCollectionName = '@schematics/angular';
         this.collectionName = this.defaultCollectionName;
@@ -163,7 +162,7 @@ class SchematicCommand extends command_1.Command {
             registry: new core_1.schema.CoreSchemaRegistry(schematics_1.formats.standardFormats),
             resolvePaths: !!this.workspace.configFile
                 // Workspace
-                ? [process.cwd(), this.workspace.root]
+                ? [process.cwd(), this.workspace.root, __dirname]
                 // Global
                 : [__dirname, process.cwd()],
         });
@@ -341,8 +340,8 @@ class SchematicCommand extends command_1.Command {
             o = await json_schema_1.parseJsonSchemaToOptions(workflow.registry, schematic.description.schemaJson);
             args = await this.parseArguments(schematicOptions || [], o);
         }
-        // ng-add is special because we don't know all possible options at this point
-        if (args['--'] && !this.allowAdditionalArgs) {
+        const allowAdditionalProperties = typeof schematic.description.schemaJson === 'object' && schematic.description.schemaJson.additionalProperties;
+        if (args['--'] && !allowAdditionalProperties) {
             args['--'].forEach(additional => {
                 this.logger.fatal(`Unknown option: '${additional.split(/=/)[0]}'`);
             });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@angular/cli",
-  "version": "9.0.0-rc.6",
+  "version": "9.0.0",
   "description": "CLI tool for Angular",
   "main": "lib/cli/index.js",
   "bin": {
@@ -28,11 +28,11 @@
   },
   "homepage": "https://github.com/angular/angular-cli",
   "dependencies": {
-    "@angular-devkit/architect": "0.900.0-rc.6",
-    "@angular-devkit/core": "9.0.0-rc.6",
-    "@angular-devkit/schematics": "9.0.0-rc.6",
-    "@schematics/angular": "9.0.0-rc.6",
-    "@schematics/update": "0.900.0-rc.6",
+    "@angular-devkit/architect": "0.900.0",
+    "@angular-devkit/core": "9.0.0",
+    "@angular-devkit/schematics": "9.0.0",
+    "@schematics/angular": "9.0.0",
+    "@schematics/update": "0.900.0",
     "@yarnpkg/lockfile": "1.1.0",
     "ansi-colors": "4.1.1",
     "debug": "^4.1.1",
@@ -52,16 +52,17 @@
   "ng-update": {
     "migrations": "@schematics/angular/migrations/migration-collection.json",
     "packageGroup": {
-      "@angular/cli": "9.0.0-rc.6",
-      "@angular-devkit/build-angular": "0.900.0-rc.6",
-      "@angular-devkit/build-ng-packagr": "0.900.0-rc.6",
-      "@angular-devkit/build-webpack": "0.900.0-rc.6"
+      "@angular/cli": "9.0.0",
+      "@angular-devkit/build-angular": "0.900.0",
+      "@angular-devkit/build-ng-packagr": "0.900.0",
+      "@angular-devkit/build-webpack": "0.900.0",
+      "@angular-devkit/core": "9.0.0",
+      "@angular-devkit/schematics": "9.0.0"
     }
   },
   "engines": {
     "node": ">= 10.13.0",
     "npm": ">= 6.11.0",
-    "pnpm": ">= 3.2.0",
     "yarn": ">= 1.13.0"
   },
   "husky": {