@angular/cli 8.3.19 → 8.3.23

package/lib/init.js

@@ -9,7 +9,6 @@ Object.defineProperty(exports, "__esModule", { value: true });
  */
 require("symbol-observable");
 // symbol polyfill must go first
-// tslint:disable: no-console
 // tslint:disable-next-line:ordered-imports import-groups
 const core_1 = require("@angular-devkit/core");
 const fs = require("fs");
@@ -36,6 +35,13 @@ function _fromPackageJson(cwd = process.cwd()) {
     } while (cwd != path.dirname(cwd));
     return null;
 }
+/**
+ * Disable Browserslist old data warning as otherwise with every release we'd need to update this dependency
+ * which is cumbersome considering we pin versions and the warning is not user actionable.
+ * `Browserslist: caniuse-lite is outdated. Please run next command `npm update`
+ * See: https://github.com/browserslist/browserslist/blob/819c4337456996d19db6ba953014579329e9c6e1/node.js#L324
+ */
+process.env.BROWSERSLIST_IGNORE_OLD_DATA = '1';
 // Check if we need to profile this CLI run.
 if (process.env['NG_CLI_PROFILING']) {
     let profiler;
@@ -84,7 +90,7 @@ else {
             shouldWarn = localVersion != null && globalVersion.compare(localVersion) > 0;
         }
         catch (e) {
-            // eslint-disable-next-line no-console
+            // tslint:disable-next-line no-console
             console.error(e);
             shouldWarn = true;
         }
@@ -97,11 +103,11 @@ else {
       `);
             // Don't show warning colorised on `ng completion`
             if (process.argv[2] !== 'completion') {
-                // eslint-disable-next-line no-console
+                // tslint:disable-next-line no-console
                 console.error(warning);
             }
             else {
-                // eslint-disable-next-line no-console
+                // tslint:disable-next-line no-console
                 console.error(warning);
                 process.exit(1);
             }
@@ -140,6 +146,7 @@ cli({
     process.exit(exitCode);
 })
     .catch((err) => {
+    // tslint:disable-next-line no-console
     console.error('Unknown error: ' + err.toString());
     process.exit(127);
 });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@angular/cli",
-  "version": "8.3.19",
+  "version": "8.3.23",
   "description": "CLI tool for Angular",
   "main": "lib/cli/index.js",
   "bin": {
@@ -28,11 +28,11 @@
   },
   "homepage": "https://github.com/angular/angular-cli",
   "dependencies": {
-    "@angular-devkit/architect": "0.803.19",
-    "@angular-devkit/core": "8.3.19",
-    "@angular-devkit/schematics": "8.3.19",
-    "@schematics/angular": "8.3.19",
-    "@schematics/update": "0.803.19",
+    "@angular-devkit/architect": "0.803.23",
+    "@angular-devkit/core": "8.3.23",
+    "@angular-devkit/schematics": "8.3.23",
+    "@schematics/angular": "8.3.23",
+    "@schematics/update": "0.803.23",
     "@yarnpkg/lockfile": "1.1.0",
     "ansi-colors": "4.1.1",
     "debug": "^4.1.1",
@@ -52,10 +52,10 @@
   "ng-update": {
     "migrations": "@schematics/angular/migrations/migration-collection.json",
     "packageGroup": {
-      "@angular/cli": "8.3.19",
-      "@angular-devkit/build-angular": "0.803.19",
-      "@angular-devkit/build-ng-packagr": "0.803.19",
-      "@angular-devkit/build-webpack": "0.803.19"
+      "@angular/cli": "8.3.23",
+      "@angular-devkit/build-angular": "0.803.23",
+      "@angular-devkit/build-ng-packagr": "0.803.23",
+      "@angular-devkit/build-webpack": "0.803.23"
     }
   },
   "engines": {

package/tasks/install-package.js

@@ -23,16 +23,18 @@ function installPackage(packageName, logger, packageManager = schema_1.PackageMa
         packageManagerArgs.noLockfile,
     ];
     logger.info(color_1.colors.green(`Installing packages for tooling via ${packageManager}.`));
-    const { status } = child_process_1.spawnSync(packageManager, [
-        ...installArgs,
-        ...extraArgs,
-    ], {
-        stdio: 'inherit',
+    const { status, stderr, stdout, error } = child_process_1.spawnSync(packageManager, [...installArgs, ...extraArgs], {
+        stdio: 'pipe',
+        encoding: 'utf8',
         shell: true,
         cwd,
     });
     if (status !== 0) {
-        throw new Error('Package install failed, see above.');
+        let errorMessage = ((error && error.message) || stderr || stdout || '').trim();
+        if (errorMessage) {
+            errorMessage += '\n';
+        }
+        throw new Error(errorMessage + `Package install failed${errorMessage ? ', see above' : ''}.`);
     }
     logger.info(color_1.colors.green(`Installed packages for tooling via ${packageManager}.`));
 }
@@ -46,6 +48,20 @@ function installTempPackage(packageName, logger, packageManager = schema_1.Packa
         }
         catch (_a) { }
     });
+    // NPM will warn when a `package.json` is not found in the install directory
+    // Example:
+    // npm WARN enoent ENOENT: no such file or directory, open '/tmp/.ng-temp-packages-84Qi7y/package.json'
+    // npm WARN .ng-temp-packages-84Qi7y No description
+    // npm WARN .ng-temp-packages-84Qi7y No repository field.
+    // npm WARN .ng-temp-packages-84Qi7y No license field.
+    // While we can use `npm init -y` we will end up needing to update the 'package.json' anyways
+    // because of missing fields.
+    fs_1.writeFileSync(path_1.join(tempPath, 'package.json'), JSON.stringify({
+        name: 'temp-cli-install',
+        description: 'temp-cli-install',
+        repository: 'temp-cli-install',
+        license: 'MIT',
+    }));
     // setup prefix/global modules path
     const packageManagerArgs = getPackageManagerArguments(packageManager);
     const tempNodeModules = path_1.join(tempPath, 'node_modules');
@@ -85,10 +101,7 @@ function runTempPackageBin(packageName, logger, packageManager = schema_1.Packag
     if (!binPath) {
         throw new Error(`Cannot locate bin for temporary package: ${packageNameNoVersion}.`);
     }
-    const argv = [
-        binPath,
-        ...args,
-    ];
+    const argv = [binPath, ...args];
     const { status, error } = child_process_1.spawnSync('node', argv, {
         stdio: 'inherit',
         shell: true,