@angular/cli 14.2.5 → 14.2.6

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@angular/cli",
-  "version": "14.2.5",
+  "version": "14.2.6",
   "description": "CLI tool for Angular",
   "main": "lib/cli/index.js",
   "bin": {
@@ -25,10 +25,10 @@
   },
   "homepage": "https://github.com/angular/angular-cli",
   "dependencies": {
-    "@angular-devkit/architect": "0.1402.5",
-    "@angular-devkit/core": "14.2.5",
-    "@angular-devkit/schematics": "14.2.5",
-    "@schematics/angular": "14.2.5",
+    "@angular-devkit/architect": "0.1402.6",
+    "@angular-devkit/core": "14.2.6",
+    "@angular-devkit/schematics": "14.2.6",
+    "@schematics/angular": "14.2.6",
     "@yarnpkg/lockfile": "1.1.0",
     "ansi-colors": "4.1.3",
     "debug": "4.3.4",
@@ -49,12 +49,12 @@
   "ng-update": {
     "migrations": "@schematics/angular/migrations/migration-collection.json",
     "packageGroup": {
-      "@angular/cli": "14.2.5",
-      "@angular-devkit/architect": "0.1402.5",
-      "@angular-devkit/build-angular": "14.2.5",
-      "@angular-devkit/build-webpack": "0.1402.5",
-      "@angular-devkit/core": "14.2.5",
-      "@angular-devkit/schematics": "14.2.5"
+      "@angular/cli": "14.2.6",
+      "@angular-devkit/architect": "0.1402.6",
+      "@angular-devkit/build-angular": "14.2.6",
+      "@angular-devkit/build-webpack": "0.1402.6",
+      "@angular-devkit/core": "14.2.6",
+      "@angular-devkit/schematics": "14.2.6"
     }
   },
   "engines": {

package/src/commands/update/cli.js

@@ -144,11 +144,12 @@ class UpdateCommandModule extends command_module_1.CommandModule {
             .strict();
     }
     async run(options) {
-        var _a, _b;
+        var _a, _b, _c;
         const { logger, packageManager } = this.context;
         packageManager.ensureCompatibility();
         // Check if the current installed CLI version is older than the latest compatible version.
-        if (!environment_options_1.disableVersionCheck) {
+        // Skip when running `ng update` without a package name as this will not trigger an actual update.
+        if (!environment_options_1.disableVersionCheck && ((_a = options.packages) === null || _a === void 0 ? void 0 : _a.length)) {
             const cliVersionToInstall = await this.checkCLIVersion(options.packages, options.verbose, options.next);
             if (cliVersionToInstall) {
                 logger.warn('The installed Angular CLI version is outdated.\n' +
@@ -157,7 +158,7 @@ class UpdateCommandModule extends command_module_1.CommandModule {
             }
         }
         const packages = [];
-        for (const request of (_a = options.packages) !== null && _a !== void 0 ? _a : []) {
+        for (const request of (_b = options.packages) !== null && _b !== void 0 ? _b : []) {
             try {
                 const packageIdentifier = (0, npm_package_arg_1.default)(request);
                 // only registry identifiers are supported
@@ -209,7 +210,7 @@ class UpdateCommandModule extends command_module_1.CommandModule {
             return success ? 0 : 1;
         }
         return options.migrateOnly
-            ? this.migrateOnly(workflow, ((_b = options.packages) !== null && _b !== void 0 ? _b : [])[0], rootDependencies, options)
+            ? this.migrateOnly(workflow, ((_c = options.packages) !== null && _c !== void 0 ? _c : [])[0], rootDependencies, options)
             : this.updatePackagesAndMigrate(workflow, rootDependencies, options, packages);
     }
     async executeSchematic(workflow, collection, schematic, options = {}) {

package/src/utilities/completion.d.ts

@@ -21,10 +21,10 @@ export declare function considerSettingUpAutocompletion(command: string, logger:
  */
 export declare function initializeAutocomplete(): Promise<string>;
 /**
- * Returns whether the user has a global CLI install or `undefined` if this can't be determined.
+ * Returns whether the user has a global CLI install.
  * Execution from `npx` is *not* considered a global CLI install.
  *
  * This does *not* mean the current execution is from a global CLI install, only that a global
  * install exists on the system.
  */
-export declare function hasGlobalCliInstall(): Promise<boolean | undefined>;
+export declare function hasGlobalCliInstall(): Promise<boolean>;

package/src/utilities/completion.js

@@ -83,7 +83,7 @@ Appended \`source <(ng completion script)\` to \`${rcFile}\`. Restart your termi
 
     ${color_1.colors.yellow(`source <(ng completion script)`)}
     `.trim());
-    if ((await hasGlobalCliInstall()) === false) {
+    if (!(await hasGlobalCliInstall())) {
         logger.warn('Setup completed successfully, but there does not seem to be a global install of the' +
             ' Angular CLI. For autocompletion to work, the CLI will need to be on your `$PATH`, which' +
             ' is typically done with the `-g` flag in `npm install -g @angular/cli`.' +
@@ -234,27 +234,26 @@ function getShellRunCommandCandidates(shell, home) {
     }
 }
 /**
- * Returns whether the user has a global CLI install or `undefined` if this can't be determined.
+ * Returns whether the user has a global CLI install.
  * Execution from `npx` is *not* considered a global CLI install.
  *
  * This does *not* mean the current execution is from a global CLI install, only that a global
  * install exists on the system.
  */
-async function hasGlobalCliInstall() {
-    var _a;
+function hasGlobalCliInstall() {
     // List all binaries with the `ng` name on the user's `$PATH`.
-    const proc = (0, child_process_1.execFile)('which', ['-a', 'ng']);
-    let stdout = '';
-    (_a = proc.stdout) === null || _a === void 0 ? void 0 : _a.addListener('data', (content) => {
-        stdout += content;
-    });
-    const exitCode = await new Promise((resolve) => {
-        proc.addListener('exit', (exitCode) => {
-            resolve(exitCode);
-        });
-    });
-    switch (exitCode) {
-        case 0:
+    return new Promise((resolve) => {
+        (0, child_process_1.execFile)('which', ['-a', 'ng'], (error, stdout) => {
+            if (error) {
+                // No instances of `ng` on the user's `$PATH`
+                // `which` returns exit code 2 if an invalid option is specified and `-a` doesn't appear to be
+                // supported on all systems. Other exit codes mean unknown errors occurred. Can't tell whether
+                // CLI is globally installed, so treat this as inconclusive.
+                // `which` was killed by a signal and did not exit gracefully. Maybe it hung or something else
+                // went very wrong, so treat this as inconclusive.
+                resolve(false);
+                return;
+            }
             // Successfully listed all `ng` binaries on the `$PATH`. Look for at least one line which is a
             // global install. We can't easily identify global installs, but local installs are typically
             // placed in `node_modules/.bin` by NPM / Yarn. `npx` also currently caches files at
@@ -267,19 +266,8 @@ async function hasGlobalCliInstall() {
                 const localInstall = grandparent.base === 'node_modules' && parent.base === '.bin';
                 return !localInstall;
             });
-            return hasGlobalInstall;
-        case 1:
-            // No instances of `ng` on the user's `$PATH`.
-            return false;
-        case null:
-            // `which` was killed by a signal and did not exit gracefully. Maybe it hung or something else
-            // went very wrong, so treat this as inconclusive.
-            return undefined;
-        default:
-            // `which` returns exit code 2 if an invalid option is specified and `-a` doesn't appear to be
-            // supported on all systems. Other exit codes mean unknown errors occurred. Can't tell whether
-            // CLI is globally installed, so treat this as inconclusive.
-            return undefined;
-    }
+            return resolve(hasGlobalInstall);
+        });
+    });
 }
 exports.hasGlobalCliInstall = hasGlobalCliInstall;

package/src/utilities/package-metadata.js

@@ -222,16 +222,11 @@ async function getNpmPackageJson(packageName, logger, options = {}) {
     const { usingYarn = false, verbose = false, registry } = options;
     ensureNpmrc(logger, usingYarn, verbose);
     const { packument } = await Promise.resolve().then(() => __importStar(require('pacote')));
-    const resultPromise = packument(packageName, {
+    const response = packument(packageName, {
         fullMetadata: true,
         ...npmrc,
         ...(registry ? { registry } : {}),
     });
-    // TODO: find some way to test this
-    const response = resultPromise.catch((err) => {
-        logger.warn(err.message || err);
-        return { requestedName: packageName };
-    });
     npmPackageJsonCache.set(packageName, response);
     return response;
 }