@angular-wave/angular.ts 0.7.0-beta.1 → 0.7.1

package/src/core/scope/scope.js

@@ -227,6 +227,7 @@ export class Scope {
    * @param {Object} target - The target object.
    * @param {string} property - The name of the property being set.
    * @param {*} value - The new value being assigned to the property.
+   * @param {Proxy} proxy - The proxy intercepting property access
    * @returns {boolean} - Returns true to indicate success of the operation.
    */
   set(target, property, value, proxy) {
@@ -263,13 +264,13 @@ export class Scope {
           const listeners = this.watchers.get(property);
 
           if (listeners) {
-            this.scheduleListener(listeners);
+            this.#scheduleListener(listeners);
           }
 
           const foreignListeners = this.foreignListeners.get(property);
 
           if (foreignListeners) {
-            this.scheduleListener(foreignListeners);
+            this.#scheduleListener(foreignListeners);
           }
         }
 
@@ -294,16 +295,16 @@ export class Scope {
           const listeners = this.watchers.get(property);
 
           if (listeners) {
-            this.scheduleListener(listeners);
+            this.#scheduleListener(listeners);
           }
 
           const foreignListeners = this.foreignListeners.get(property);
 
           if (foreignListeners) {
-            this.scheduleListener(foreignListeners);
+            this.#scheduleListener(foreignListeners);
           }
 
-          this.checkeListenersForAllKeys(value);
+          this.#checkeListenersForAllKeys(value);
         }
         target[property] = createScope(value, this);
         //setDeepValue(target[property], value);
@@ -324,7 +325,7 @@ export class Scope {
           let listeners = this.watchers.get(property);
 
           if (listeners) {
-            this.scheduleListener(listeners);
+            this.#scheduleListener(listeners);
           }
         }
 
@@ -336,7 +337,7 @@ export class Scope {
         let listeners = this.watchers.get(property);
 
         if (listeners) {
-          this.scheduleListener(listeners);
+          this.#scheduleListener(listeners);
         }
 
         if (Array.isArray(target)) {
@@ -345,7 +346,7 @@ export class Scope {
             keys.forEach((key) => {
               const listeners = this.watchers.get(key);
               if (listeners) {
-                this.scheduleListener(listeners);
+                this.#scheduleListener(listeners);
               }
             });
             decodeURI;
@@ -359,9 +360,10 @@ export class Scope {
       if (isUndefined(target[property]) && isProxy(value)) {
         this.foreignProxies.add(value);
         target[property] = value;
-        return true;
+        if (!this.watchers.has(property)) {
+          return true;
+        }
       }
-
       if (isUndefined(value)) {
         target[property] = value;
       } else {
@@ -390,7 +392,7 @@ export class Scope {
         this.watchers.get(property)?.forEach((l) => listeners.push(l));
         if (listeners.length > 0) {
           // check if the listener actually appllies to this target
-          this.scheduleListener(listeners, (x) => {
+          this.#scheduleListener(listeners, (x) => {
             return x.filter((x) => {
               if (!x.watchProp) return true;
               // Compute the expected target based on `watchProp`
@@ -418,7 +420,7 @@ export class Scope {
             );
           }
 
-          this.scheduleListener(foreignListeners);
+          this.#scheduleListener(foreignListeners);
         }
       }
 
@@ -428,7 +430,7 @@ export class Scope {
           const listeners = this.watchers.get(key);
           if (listeners) {
             if (this.scheduled !== listeners) {
-              this.scheduleListener(listeners);
+              this.#scheduleListener(listeners);
             }
           }
         });
@@ -438,22 +440,6 @@ export class Scope {
     }
   }
 
-  checkeListenersForAllKeys(value) {
-    if (isUndefined(value)) {
-      return;
-    }
-    Object.keys(value).forEach((k) => {
-      const listeners = this.watchers.get(k);
-
-      if (listeners) {
-        this.scheduleListener(listeners);
-      }
-      if (isObject(value[k])) {
-        this.checkeListenersForAllKeys(value[k]);
-      }
-    });
-  }
-
   /**
    * Intercepts property access on the target object. It checks for specific
    * properties (`watch` and `sync`) and binds their methods. For other properties,
@@ -476,8 +462,6 @@ export class Scope {
 
     this.propertyMap = {
       $watch: this.$watch.bind(this),
-      $watchGroup: this.$watchGroup.bind(this),
-      $watchCollection: this.$watchCollection.bind(this),
       $new: this.$new.bind(this),
       $newIsolate: this.$newIsolate.bind(this),
       $destroy: this.$destroy.bind(this),
@@ -485,7 +469,7 @@ export class Scope {
       $apply: this.$apply.bind(this),
       $evalAsync: this.$evalAsync.bind(this),
       $postUpdate: this.$postUpdate.bind(this),
-      $isRoot: this.isRoot.bind(this),
+      $isRoot: this.#isRoot.bind(this),
       $target: target,
       $proxy: this.$proxy,
       $on: this.$on.bind(this),
@@ -497,8 +481,6 @@ export class Scope {
       $root: this.$root,
       $children: this.$children,
       $id: this.$id,
-      registerForeignKey: this.registerForeignKey.bind(this),
-      notifyListener: this.notifyListener.bind(this),
       $merge: this.$merge.bind(this),
       $getById: this.$getById.bind(this),
     };
@@ -519,7 +501,7 @@ export class Scope {
 
       // TODO aditional testing
       if (property === "unshift") {
-        this.scheduleListener(this.scheduled);
+        this.#scheduleListener(this.scheduled);
       }
     }
 
@@ -532,26 +514,6 @@ export class Scope {
     }
   }
 
-  /**
-   * @private
-   * @param {Listener[]} listeners
-   */
-  scheduleListener(listeners, filter = (val) => val) {
-    Promise.resolve().then(() => {
-      let index = 0;
-      let filteredListeners = filter(listeners);
-      while (index < filteredListeners.length) {
-        const listener = filteredListeners[index];
-        if (listener.foreignListener) {
-          listener.foreignListener.notifyListener(listener, this.$target);
-        } else {
-          this.notifyListener(listener, this.$target);
-        }
-        index++;
-      }
-    });
-  }
-
   deleteProperty(target, property) {
     // Currently deletes $model
     if (target[property] && target[property][isProxySymbol]) {
@@ -559,20 +521,20 @@ export class Scope {
 
       let listeners = this.watchers.get(property);
       if (listeners) {
-        this.scheduleListener(listeners);
+        this.#scheduleListener(listeners);
       }
       if (this.objectListeners.has(this.$proxy)) {
         let keys = this.objectListeners.get(this.$proxy);
         keys.forEach((key) => {
           listeners = this.watchers.get(key);
           if (listeners) {
-            this.scheduleListener(listeners);
+            this.#scheduleListener(listeners);
           }
         });
       }
 
       if (this.scheduled) {
-        this.scheduleListener(this.scheduled);
+        this.#scheduleListener(this.scheduled);
         this.scheduled = [];
       }
       return true;
@@ -585,19 +547,54 @@ export class Scope {
       keys.forEach((key) => {
         const listeners = this.watchers.get(key);
         if (listeners) {
-          this.scheduleListener(listeners);
+          this.#scheduleListener(listeners);
         }
       });
     } else {
       const listeners = this.watchers.get(property);
       if (listeners) {
-        this.scheduleListener(listeners, target[property]);
+        this.#scheduleListener(listeners, target[property]);
       }
     }
 
     return true;
   }
 
+  #checkeListenersForAllKeys(value) {
+    if (isUndefined(value)) {
+      return;
+    }
+    Object.keys(value).forEach((k) => {
+      const listeners = this.watchers.get(k);
+
+      if (listeners) {
+        this.#scheduleListener(listeners);
+      }
+      if (isObject(value[k])) {
+        this.#checkeListenersForAllKeys(value[k]);
+      }
+    });
+  }
+
+  /**
+   * @param {Listener[]} listeners
+   */
+  #scheduleListener(listeners, filter = (val) => val) {
+    Promise.resolve().then(() => {
+      let index = 0;
+      let filteredListeners = filter(listeners);
+      while (index < filteredListeners.length) {
+        const listener = filteredListeners[index];
+        if (listener.foreignListener) {
+          listener.foreignListener.#notifyListener(listener, this.$target);
+        } else {
+          this.#notifyListener(listener, this.$target);
+        }
+        index++;
+      }
+    });
+  }
+
   /**
    * Registers a watcher for a property along with a listener function. The listener
    * function is invoked when changes to that property are detected.
@@ -615,7 +612,6 @@ export class Scope {
     if (get.constant) {
       if (listenerFn) {
         Promise.resolve().then(() => {
-          // @ts-ignore
           let res = get();
           while (isFunction(res)) {
             res = res();
@@ -674,11 +670,11 @@ export class Scope {
         keys.push(get.decoratedNode.body[0].expression.left.toWatch[0]?.name);
         keys.push(get.decoratedNode.body[0].expression.right.toWatch[0]?.name);
         keys.forEach((key) => {
-          this.registerKey(key, listener);
+          this.#registerKey(key, listener);
         });
         return () => {
           keys.forEach((key) => {
-            this.deregisterKey(key, listener.id);
+            this.#deregisterKey(key, listener.id);
           });
         };
       }
@@ -715,13 +711,13 @@ export class Scope {
           }
         });
         keys.forEach((key) => {
-          this.registerKey(key, listener);
-          this.scheduleListener([listener]);
+          this.#registerKey(key, listener);
+          this.#scheduleListener([listener]);
         });
 
         return () => {
           keys.forEach((key) => {
-            this.deregisterKey(key, listener.id);
+            this.#deregisterKey(key, listener.id);
           });
         };
       }
@@ -744,10 +740,10 @@ export class Scope {
             watchProp.split(".").slice(0, -1).join("."),
           )(listener.originalTarget);
           if (potentialProxy && this.foreignProxies.has(potentialProxy)) {
-            potentialProxy.$handler.registerForeignKey(key, listener);
-            potentialProxy.$handler.scheduleListener([listener]);
+            potentialProxy.$handler.#registerForeignKey(key, listener);
+            potentialProxy.$handler.#scheduleListener([listener]);
             return () => {
-              return potentialProxy.$handler.deregisterKey(key, listener.id);
+              return potentialProxy.$handler.#deregisterKey(key, listener.id);
             };
           }
         }
@@ -778,12 +774,12 @@ export class Scope {
           })
           .filter((x) => !!x);
         keys.forEach((key) => {
-          this.registerKey(key, listener);
-          this.scheduleListener([listener]);
+          this.#registerKey(key, listener);
+          this.#scheduleListener([listener]);
         });
         return () => {
           keys.forEach((key) => {
-            this.deregisterKey(key, listener.id);
+            this.#deregisterKey(key, listener.id);
           });
         };
       }
@@ -845,39 +841,31 @@ export class Scope {
 
     if (keySet.length > 0) {
       keySet.forEach((key) => {
-        this.registerKey(key, listener);
+        this.#registerKey(key, listener);
       });
     } else {
-      this.registerKey(key, listener);
+      this.#registerKey(key, listener);
     }
 
     if (!lazy) {
-      this.scheduleListener([listener]);
+      this.#scheduleListener([listener]);
     }
     return () => {
       if (keySet.length > 0) {
         let res = true;
         keySet.forEach((key) => {
-          let success = this.deregisterKey(key, listener.id);
+          let success = this.#deregisterKey(key, listener.id);
           if (!success) {
             res = false;
           }
         });
         return res;
       } else {
-        return this.deregisterKey(key, listener.id);
+        return this.#deregisterKey(key, listener.id);
       }
     };
   }
 
-  $watchGroup(watchArray, listenerFn) {
-    watchArray.forEach((x) => this.$watch(x, listenerFn));
-  }
-
-  $watchCollection(watchProp, listenerFn) {
-    return this.$watch(watchProp, listenerFn);
-  }
-
   $new(childInstance) {
     let child;
     if (childInstance) {
@@ -907,7 +895,6 @@ export class Scope {
 
   $newIsolate(instance) {
     let child = instance ? Object.create(instance) : Object.create(null);
-    // child.$root = this.$root;
     const proxy = new Proxy(child, new Scope(this, this.$root));
     this.$children.push(proxy);
     return proxy;
@@ -920,7 +907,7 @@ export class Scope {
     return proxy;
   }
 
-  registerKey(key, listener) {
+  #registerKey(key, listener) {
     if (this.watchers.has(key)) {
       this.watchers.get(key).push(listener);
     } else {
@@ -928,7 +915,7 @@ export class Scope {
     }
   }
 
-  registerForeignKey(key, listener) {
+  #registerForeignKey(key, listener) {
     if (this.foreignListeners.has(key)) {
       this.foreignListeners.get(key).push(listener);
     } else {
@@ -936,7 +923,7 @@ export class Scope {
     }
   }
 
-  deregisterKey(key, id) {
+  #deregisterKey(key, id) {
     const listenerList = this.watchers.get(key);
     if (!listenerList) return false;
 
@@ -952,21 +939,21 @@ export class Scope {
     return true;
   }
 
-  deregisterForeignKey(key, id) {
-    const listenerList = this.foreignListeners.get(key);
-    if (!listenerList) return false;
+  // deregisterForeignKey(key, id) {
+  //   const listenerList = this.foreignListeners.get(key);
+  //   if (!listenerList) return false;
 
-    const index = listenerList.findIndex((x) => x.id === id);
-    if (index === -1) return false;
+  //   const index = listenerList.findIndex((x) => x.id === id);
+  //   if (index === -1) return false;
 
-    listenerList.splice(index, 1);
-    if (listenerList.length) {
-      this.foreignListeners.set(key, listenerList);
-    } else {
-      this.foreignListeners.delete(key);
-    }
-    return true;
-  }
+  //   listenerList.splice(index, 1);
+  //   if (listenerList.length) {
+  //     this.foreignListeners.set(key, listenerList);
+  //   } else {
+  //     this.foreignListeners.delete(key);
+  //   }
+  //   return true;
+  // }
 
   $eval(expr, locals) {
     const fn = $parse(expr);
@@ -994,12 +981,19 @@ export class Scope {
     return await this.$eval(expr, locals);
   }
 
+  /**
+   * @param {Object} newTarget
+   */
   $merge(newTarget) {
     Object.entries(newTarget).forEach(([key, value]) => {
-      this.set(this.$target, key, value);
+      this.set(this.$target, key, value, this.$proxy);
     });
   }
 
+  /**
+   * @param {import('../../interface.js').Expression} expr
+   * @returns {any}
+   */
   $apply(expr) {
     try {
       return $parse(expr)(this.$proxy);
@@ -1008,6 +1002,11 @@ export class Scope {
     }
   }
 
+  /**
+   * @param {string} name
+   * @param {Function} listener
+   * @returns {(function(): void)|*}
+   */
   $on(name, listener) {
     let namedListeners = this.$$listeners.get(name);
     if (!namedListeners) {
@@ -1030,10 +1029,10 @@ export class Scope {
   /**
    * @param {string} name
    * @param  {...any} args
-   * @returns
+   * @returns {void}
    */
   $emit(name, ...args) {
-    return this.eventHelper(
+    return this.#eventHelper(
       { name: name, event: undefined, broadcast: false },
       ...args,
     );
@@ -1045,21 +1044,20 @@ export class Scope {
    * @returns {any}
    */
   $broadcast(name, ...args) {
-    return this.eventHelper(
+    return this.#eventHelper(
       { name: name, event: undefined, broadcast: true },
       ...args,
     );
   }
 
   /**
-   * @private
    * @returns {void}
    */
-  eventHelper({ name, event, broadcast }, ...args) {
+  #eventHelper({ name, event, broadcast }, ...args) {
     if (!broadcast) {
       if (!this.$$listeners.has(name)) {
         if (this.$parent) {
-          return this.$parent.$handler.eventHelper(
+          return this.$parent.$handler.#eventHelper(
             { name: name, event: event, broadcast: broadcast },
             ...args,
           );
@@ -1114,7 +1112,7 @@ export class Scope {
     if (broadcast) {
       if (this.$children.length > 0) {
         this.$children.forEach((child) => {
-          event = child["$handler"].eventHelper(
+          event = child["$handler"].#eventHelper(
             { name: name, event: event, broadcast: broadcast },
             ...args,
           );
@@ -1123,7 +1121,7 @@ export class Scope {
       return event;
     } else {
       if (this.$parent) {
-        return this.$parent?.eventHelper(
+        return this.$parent.#eventHelper(
           { name: name, event: event, broadcast: broadcast },
           ...args,
         );
@@ -1134,10 +1132,9 @@ export class Scope {
   }
 
   /**
-   * @private
    * @returns {boolean}
    */
-  isRoot() {
+  #isRoot() {
     return this.$root == /** @type {Scope} */ (this);
   }
 
@@ -1156,7 +1153,7 @@ export class Scope {
       );
     });
 
-    if (this.isRoot()) {
+    if (this.#isRoot()) {
       this.watchers.clear();
     } else {
       let i = this.$parent.$children.filter((x) => x.$id == this.$id)[0];
@@ -1169,11 +1166,9 @@ export class Scope {
   }
 
   /**
-   * Invokes the registered listener function with watched property changes.
-   *
    * @param {Listener} listener - The property path that was changed.
    */
-  notifyListener(listener, target) {
+  #notifyListener(listener, target) {
     const { originalTarget, listenerFn, watchFn } = listener;
     try {
       let newVal = watchFn(originalTarget);
@@ -1232,6 +1227,8 @@ export class Scope {
   }
 }
 
+/*------------- Private helpers -------------*/
+
 /**
  * @param {Scope} model
  * @returns {number}

package/src/core/scope/scope.spec.js

@@ -423,7 +423,7 @@ describe("Scope", () => {
     });
 
     it("can register listeners via watch", async () => {
-      var listenerFn = jasmine.createSpy();
+      const listenerFn = jasmine.createSpy();
       scope.$watch("a", listenerFn);
       scope.a = 1;
       await wait();
@@ -431,7 +431,7 @@ describe("Scope", () => {
     });
 
     it("can calls a listener upon registration", async () => {
-      var listenerFn = jasmine.createSpy();
+      const listenerFn = jasmine.createSpy();
       scope.$watch("a", listenerFn);
       await wait();
       expect(listenerFn).toHaveBeenCalled();
@@ -636,7 +636,7 @@ describe("Scope", () => {
     });
 
     it("calls listener with undefined old value the first time", async () => {
-      var newValueGiven;
+      let newValueGiven;
       scope.$watch("someValue", function (newValue, scope) {
         newValueGiven = newValue;
       });
@@ -646,7 +646,7 @@ describe("Scope", () => {
     });
 
     it("calls listener with new value and old value the first time if defined", async () => {
-      var newValueGiven;
+      let newValueGiven;
       scope.someValue = 123;
 
       scope.$watch("someValue", function (newValue) {
@@ -659,7 +659,7 @@ describe("Scope", () => {
     });
 
     it("calls listener with with the instance of a scope as 2nd argument", async () => {
-      var scopeInstance;
+      let scopeInstance;
       scope.someValue = 123;
 
       scope.$watch("someValue", function (_1, m) {
@@ -1554,7 +1554,7 @@ describe("Scope", () => {
 
       it("can pass the new value of the array as well as the previous value of the dropped item", async () => {
         scope.aValue = [];
-        var newValueGiven;
+        let newValueGiven;
         scope.$watch("aValue", function (newValue) {
           newValueGiven = newValue;
         });
@@ -1578,7 +1578,7 @@ describe("Scope", () => {
 
       it("can detect removal of items", async () => {
         scope.aValue = [2, 3];
-        var newValueGiven;
+        let newValueGiven;
         scope.$watch("aValue", function (newValue) {
           newValueGiven = newValue;
         });
@@ -1592,7 +1592,7 @@ describe("Scope", () => {
         // first time should be identical
         scope.aValue = ["a", "b"];
         scope.counter = 0;
-        var newValueGiven;
+        let newValueGiven;
         scope.$watch("aValue", function (newValue, m) {
           newValueGiven = newValue;
           m.counter++;
@@ -1609,7 +1609,7 @@ describe("Scope", () => {
       it("should trigger when property changes into array", async () => {
         scope.aValue = "test";
         scope.counter = 0;
-        var newValue;
+        let newValue;
         scope.$watch("aValue", function (newV, m) {
           m.counter++;
           newValue = newV;
@@ -2064,7 +2064,7 @@ describe("Scope", () => {
 
     it("executes $eval'ed function and returns result", function () {
       scope.aValue = 42;
-      var result = scope.$eval(function (scope) {
+      const result = scope.$eval(function (scope) {
         return scope.aValue;
       });
       expect(result).toBe(42);
@@ -2072,7 +2072,7 @@ describe("Scope", () => {
 
     it("passes the second $eval argument straight through", function () {
       scope.aValue = 42;
-      var result = scope.$eval(function (scope, arg) {
+      const result = scope.$eval(function (scope, arg) {
         return scope.aValue + arg;
       }, 2);
       expect(result).toBe(44);

package/src/core/task-tracker-factory.js

@@ -1,4 +1,11 @@
+/** @typedef {import('../interface.ts').ServiceProvider} ServiceProvider */
+/** @typedef {import('../interface.ts').AnnotatedFactory} AnnotatedFactory */
+
+/**
+ * @implements {ServiceProvider}
+ */
 export class TaskTrackerFactoryProvider {
+  /** @type {AnnotatedFactory} */
   $get = [
     "$log",
     /**