@angular-wave/angular.ts 0.4.5 → 0.4.6

package/package.json

@@ -2,7 +2,7 @@
   "name": "@angular-wave/angular.ts",
   "description": "A modern, optimized and typesafe version of AngularJS",
   "license": "MIT",
-  "version": "0.4.5",
+  "version": "0.4.6",
   "type": "module",
   "main": "dist/angular-ts.esm.js",
   "browser": "dist/angular-ts.umd.js",

package/src/core/compile/compile.js

@@ -2394,7 +2394,7 @@ export function CompileProvider($provide, $$sanitizeUriProvider) {
           });
 
         return function delayedNodeLinkFn(
-          ignoreChildLinkFn,
+          _ignoreChildLinkFn,
           scope,
           node,
           rootElement,
@@ -2453,19 +2453,16 @@ export function CompileProvider($provide, $$sanitizeUriProvider) {
       }
 
       function addTextInterpolateDirective(directives, text) {
-        const interpolateFn = $interpolate(text, true);
+        const interpolateFn = $interpolate(text, true); // Create interpolation function
         if (interpolateFn) {
           directives.push({
             priority: 0,
-            compile: function textInterpolateCompileFn() {
-              // When transcluding a template that has bindings in the root
-              // we don't have a parent and thus need to add the class during linking fn.
-
-              return function textInterpolateLinkFn(scope, node) {
-                scope.$watch(interpolateFn, (value) => {
-                  node[0].nodeValue = value;
-                });
-              };
+            // When transcluding a template that has bindings in the root
+            // we don't have a parent and thus need to add the class during linking fn.
+            compile: () => (scope, node) => {
+              scope.$watch(interpolateFn, (value) => {
+                node[0].nodeValue = value; // Update text node with new interpolated value
+              });
             },
           });
         }

package/src/core/interpolate/interpolate.js

@@ -353,19 +353,16 @@ export class InterpolateProvider {
               expressions,
               $$watchDelegate(scope, listener) {
                 let lastValue;
-                return scope.$watchGroup(
-                  parseFns,
-                  function interpolateFnWatcher(values, oldValues) {
-                    const currValue = compute(values);
-                    listener.call(
-                      this,
-                      currValue,
-                      values !== oldValues ? lastValue : currValue,
-                      scope,
-                    );
-                    lastValue = currValue;
-                  },
-                );
+                return scope.$watchGroup(parseFns, (values, oldValues) => {
+                  const currValue = compute(values);
+                  listener.call(
+                    this,
+                    currValue,
+                    values !== oldValues ? lastValue : currValue,
+                    scope,
+                  );
+                  lastValue = currValue;
+                });
               },
             },
           );

package/src/core/location/location.js

@@ -42,6 +42,8 @@ export class Location {
    * @param {string} appBaseNoFile application base URL stripped of any filename
    */
   constructor(appBase, appBaseNoFile) {
+    const parsedUrl = urlResolve(appBase);
+
     /** @type {string} */
     this.appBase = appBase;
 
@@ -67,16 +69,17 @@ export class Location {
     this.$$replace = false;
 
     /** @type {import('../url-utils/url-utils').HttpProtocol} */
-    this.$$protocol = undefined;
+    this.$$protocol = parsedUrl.protocol;
 
     /** @type {string} */
-    this.$$host = undefined;
+    this.$$host = parsedUrl.hostname;
 
     /**
      * The port, without ":"
      * @type {number}
      */
-    this.$$port = undefined;
+    this.$$port =
+      toInt(parsedUrl.port) || DEFAULT_PORTS[parsedUrl.protocol] || null;
 
     /**
      * The pathname, beginning with "/"
@@ -359,7 +362,6 @@ export class LocationHtml5Url extends Location {
     super(appBase, appBaseNoFile);
     this.$$html5 = true;
     this.basePrefix = basePrefix || "";
-    parseAbsoluteUrl(appBase, this);
   }
 
   /**
@@ -442,10 +444,7 @@ export class LocationHtml5Url extends Location {
 export class LocationHashbangUrl extends Location {
   constructor(appBase, appBaseNoFile, hashPrefix) {
     super(appBase, appBaseNoFile);
-    this.appBase = appBase;
-    this.appBaseNoFile = appBaseNoFile;
     this.hashPrefix = hashPrefix;
-    parseAbsoluteUrl(appBase, this);
   }
 
   /**
@@ -890,19 +889,6 @@ function normalizePath(pathValue, searchValue, hashValue) {
   return path + (search ? `?${search}` : "") + hash;
 }
 
-/**
- * @param {string} absoluteUrl
- * @param {Location} locationObj
- */
-function parseAbsoluteUrl(absoluteUrl, locationObj) {
-  const parsedUrl = urlResolve(absoluteUrl);
-
-  locationObj.$$protocol = parsedUrl.protocol;
-  locationObj.$$host = parsedUrl.hostname;
-  locationObj.$$port =
-    toInt(parsedUrl.port) || DEFAULT_PORTS[parsedUrl.protocol] || null;
-}
-
 function parseAppUrl(url, locationObj, html5Mode) {
   if (/^\s*[\\/]{2,}/.test(url)) {
     throw $locationMinErr("badpath", 'Invalid url "{0}".', url);

package/src/directive/events/events.html

@@ -11,6 +11,7 @@
     <script src="/jasmine/jasmine-5.1.2/boot0.js"></script>
     <script src="/jasmine/jasmine-5.1.2/boot1.js"></script>
     <script type="module" src="/src/directive/events/event.spec.js"></script>
+    <script type="module" src="/src/directive/events/click.spec.js"></script>
   </head>
   <body>
     <div id="dummy"></div>

package/src/directive/observe/observe.js

@@ -6,8 +6,11 @@ export function ngObserveDirective() {
     restrict: "A",
     link: (scope, element, attrs) => {
       const targetElement = element[0];
-      const prop = targetElement.dataset["update"];
       const source = attrs["ngObserve"];
+      let prop = targetElement.dataset["update"];
+      if (!prop) {
+        prop = source;
+      }
 
       if (!scope[prop]) {
         scope[prop] = targetElement.getAttribute(source);

package/src/directive/observe/observe.spec.js

@@ -89,4 +89,25 @@ describe("observe", () => {
 
     expect(observerSpy.disconnect).toHaveBeenCalled();
   });
+
+  it("should observe attribute changes and update the same scope name if data-update attribute is absent", () => {
+    $scope.myProp = "";
+    const template = `<div ng-observe="test-attribute"></div>`;
+    element = $compile(template)($scope);
+    $scope.$digest();
+    spyOn($scope, "$digest").and.callThrough();
+
+    const mutationObserverCallback =
+      MutationObserver.calls.mostRecent().args[0];
+    const mutationRecord = {
+      target: element[0],
+      attributeName: "test-attribute",
+    };
+
+    element.attr("test-attribute", "newValue");
+    element[0].setAttribute("test-attribute", "newValue");
+
+    mutationObserverCallback([mutationRecord]);
+    expect($scope.$digest).toHaveBeenCalled();
+  });
 });

package/src/directive/observe/test.html

@@ -86,11 +86,7 @@
     <br />
 
     {{ activeid }}
-    <fluent-tabs
-      ng-observe="activeid"
-      data-update="activeid"
-      activeid="entrees"
-    >
+    <fluent-tabs ng-observe="activeid" activeid="entrees">
       <fluent-tab id="apps">Appetizers</fluent-tab>
       <fluent-tab id="entrees">Entrees</fluent-tab>
       <fluent-tab id="desserts">Desserts</fluent-tab>
@@ -173,13 +169,9 @@
       </fluent-tab-panel>
     </fluent-tabs>
 
-    {{ radio }}
+    {{ value }}
 
-    <fluent-radio-group
-      ng-observe="value"
-      data-update="radio"
-      orientation="vertical"
-    >
+    <fluent-radio-group ng-observe="value" orientation="vertical">
       <fluent-radio value="1">18-24</fluent-radio>
       <fluent-radio value="2">25-33</fluent-radio>
       <fluent-radio value="3">34-44</fluent-radio>

package/types/core/location/location.d.ts

@@ -230,15 +230,13 @@ export class LocationHtml5Url extends Location {
  */
 export class LocationHashbangUrl extends Location {
     constructor(appBase: any, appBaseNoFile: any, hashPrefix: any);
-    appBase: any;
-    appBaseNoFile: any;
     hashPrefix: any;
     /**
      * Parse given hashbang URL into properties
      * @param {string} url Hashbang URL
      */
     $$parse(url: string): void;
-    $$normalizeUrl(url: any): any;
+    $$normalizeUrl(url: any): string;
     /**
      * @param {string} url
      * @returns {boolean}