@angular-wave/angular.ts 0.4.2 → 0.4.4

package/src/directive/model-options/model-options.spec.js

@@ -49,8 +49,6 @@ describe("ngModelOptions", () => {
         ]);
         $compile = injector.get("$compile");
         $rootScope = injector.get("$rootScope");
-        $q = injector.get("$q");
-        $timeout = injector.get("$timeout");
       });
 
       describe("should fall back to `defaultModelOptions`", () => {
@@ -273,8 +271,6 @@ describe("ngModelOptions", () => {
               '<input type="text" ng-model="name" name="alias" />' +
               "</form>",
           )($rootScope);
-          $rootScope.$digest();
-
           inputElm = doc.find("input");
           changeGivenInputTo(inputElm, "a");
           expect($rootScope.name).toEqual(undefined);
@@ -935,7 +931,6 @@ describe("ngModelOptions", () => {
           expect($rootScope.value).toBe("12345");
           expect($rootScope.form.input.$pending.promiseValidator).toBe(true);
           defer.reject();
-          $rootScope.$digest();
           expect($rootScope.value).toBe("12345");
           expect(inputElm[0].classList.contains("ng-invalid")).toBeTrue();
         });
@@ -958,7 +953,6 @@ describe("ngModelOptions", () => {
           expect(inputElm.val()).toBe("12345");
           expect($rootScope.form.input.$pending.promiseValidator).toBe(true);
           defer.reject();
-          $rootScope.$digest();
           expect(inputElm.val()).toBe("12345");
           expect(inputElm[0].classList.contains("ng-invalid")).toBeTrue();
         });

package/src/directive/non-bindable/non-bindable.spec.js

@@ -43,7 +43,6 @@ describe("ngNonBindable", () => {
     )($rootScope);
     $rootScope.a = "one";
     $rootScope.b = "two";
-    $rootScope.$digest();
     // Bindings not contained by ng-non-bindable should resolve.
     const spans = element.find("span");
     expect(spans.eq(0).text()).toEqual("one");

package/src/directive/observe/observe.js

@@ -20,7 +20,6 @@ export function ngObserveDirective() {
         ).getAttribute(source);
         if (scope[prop] !== newValue) {
           scope[prop] = newValue;
-          scope.$digest();
         }
       });
 

package/src/directive/observe/observe.spec.js

@@ -25,7 +25,6 @@ describe("observe", () => {
   function createDirective(attributeValue, updateProp) {
     const template = `<div ng-observe="${attributeValue}" data-update="${updateProp}"></div>`;
     element = $compile(template)($scope);
-    $scope.$digest();
   }
 
   it("should set the scope property to the attribute value before any changes", () => {

package/src/directive/options/options.js

@@ -1,7 +1,6 @@
 import { JQLite, removeElement, startingTag } from "../../shared/jqlite/jqlite";
 import {
   equals,
-  forEach,
   hashKey,
   includes,
   isArrayLike,
@@ -328,8 +327,7 @@ export const ngOptionsDirective = [
         selectCtrl.readValue = function readNgOptionsMultiple() {
           const selectedValues = selectElement.val() || [];
           const selections = [];
-
-          forEach(selectedValues, (value) => {
+          selectedValues.forEach((value) => {
             const option = options.selectValueMap[value];
             if (option && !option.disabled)
               selections.push(options.getViewValueFromOption(option));

package/src/directive/options/options.spec.js

@@ -2,7 +2,6 @@ import { createInjector } from "../../core/di/injector";
 import { JQLite, dealoc } from "../../shared/jqlite/jqlite";
 import { Angular } from "../../loader";
 import {
-  forEach,
   isBoolean,
   hashKey,
   equals,
@@ -232,7 +231,7 @@ describe("ngOptions", () => {
 
   function createSelect(attrs, blank, unknown) {
     let html = "<select";
-    forEach(attrs, (value, key) => {
+    Object.entries(attrs).forEach(([key, value]) => {
       if (isBoolean(value)) {
         if (value) html += ` ${key}`;
       } else {
@@ -388,8 +387,6 @@ describe("ngOptions", () => {
       "ng-model": "selected",
       "ng-options": "option.id as option.display for option in values",
     });
-    scope.$digest();
-
     const options = element.find("option");
     expect(options.length).toEqual(2);
     expect(options.eq(0)).toEqualOption("FF0000", "red");
@@ -401,8 +398,6 @@ describe("ngOptions", () => {
     expect(options.eq(0)[0].selected).toBe(true);
 
     scope.selected = "0000FF";
-    scope.$digest();
-
     expect(options.eq(1)[0].getAttribute("selected")).toBe("selected");
     expect(options.eq(1).attr("selected")).toBe("selected");
     expect(options.eq(1)[0].selected).toBe(true);
@@ -439,7 +434,6 @@ describe("ngOptions", () => {
         { id: 0, label: "x" },
         { id: 1, label: "y" },
       ];
-      scope.$digest();
       const options = element.find("option");
       expect(options.length).toEqual(2);
       expect(options.eq(0)).toEqualOption(0, "x");
@@ -613,8 +607,6 @@ describe("ngOptions", () => {
     scope.array.other = "do not watch";
     scope.array.fn = function () {};
     scope.selected = "b";
-    scope.$digest();
-
     expect(scope.createLabel).toHaveBeenCalledWith("a");
     expect(scope.createLabel).toHaveBeenCalledWith("b");
     expect(scope.createLabel).toHaveBeenCalledWith("c");
@@ -636,8 +628,6 @@ describe("ngOptions", () => {
       $property: "invisible",
     };
     scope.selected = "regularProperty";
-    scope.$digest();
-
     expect(scope.createLabel).toHaveBeenCalledWith("regularProperty");
     expect(scope.createLabel).not.toHaveBeenCalledWith("$$private");
     expect(scope.createLabel).not.toHaveBeenCalledWith("$property");
@@ -689,8 +679,6 @@ describe("ngOptions", () => {
     expect(optionToSelect.text()).toBe("B");
 
     optionToSelect[0].selected = true;
-    scope.$digest();
-
     expect(optionToSelect[0].selected).toBe(true);
     expect(scope.selected).toBe(scope.values[0]);
   });
@@ -783,7 +771,6 @@ describe("ngOptions", () => {
 
     // Change the scope but the options should not change
     scope.arr = ["w", "x", "y", "z"];
-    scope.$digest();
     options = element.find("option");
     expect(options.length).toEqual(4);
     expect(options.eq(0)).toEqualUnknownOption();
@@ -812,30 +799,23 @@ describe("ngOptions", () => {
     expect(options[2].selected).not.toBe(true);
 
     scope.selected = scope.values[0];
-    scope.$digest();
-
     expect(options[0].selected).not.toBe(true);
     expect(options[1].selected).toBe(true);
     expect(options[2].selected).not.toBe(true);
 
     scope.selected = scope.values[1];
-    scope.$digest();
-
     expect(options[0].selected).not.toBe(true);
     expect(options[1].selected).not.toBe(true);
     expect(options[2].selected).toBe(true);
 
     // This will select the empty option
     scope.selected = null;
-    scope.$digest();
-
     expect(options[0].selected).toBe(true);
     expect(options[1].selected).not.toBe(true);
     expect(options[2].selected).not.toBe(true);
 
     // This will add and select the unknown option
     scope.selected = "unmatched value";
-    scope.$digest();
     options = element.find("option");
 
     expect(options[0].selected).toBe(true);
@@ -845,7 +825,6 @@ describe("ngOptions", () => {
 
     // Back to matched value
     scope.selected = scope.values[1];
-    scope.$digest();
     options = element.find("option");
 
     expect(options[0].selected).not.toBe(true);
@@ -1531,7 +1510,6 @@ describe("ngOptions", () => {
       expect(scope.selected).toEqual(scope.arr[1]);
 
       scope.selected = {};
-      scope.$digest();
       expect(options[0].selected).toBeTrue();
       expect(options[1].selected).not.toBeTrue();
       expect(options[2].selected).not.toBeTrue();
@@ -1869,8 +1847,6 @@ describe("ngOptions", () => {
         { cls: "one", name: "Beta" },
         { cls: "two", name: "Gamma" },
       ];
-      scope.$digest();
-
       optgroups = element.find("optgroup");
       expect(optgroups.length).toBe(2);
 
@@ -1896,8 +1872,6 @@ describe("ngOptions", () => {
         { cls: "two", name: "Delta" },
         { cls: "three", name: "Epsilon" },
       );
-      scope.$digest();
-
       optgroups = element.find("optgroup");
       expect(optgroups.length).toBe(3);
 
@@ -2355,8 +2329,6 @@ describe("ngOptions", () => {
       expect(element[0].value).toBe("?");
 
       scope.selected = undefined;
-      scope.$digest();
-
       expect(element[0].value).toBe("");
     });
 
@@ -2615,7 +2587,6 @@ describe("ngOptions", () => {
       createSingleSelect(true);
       // ensure the first option (the blank option) is selected
       expect(element[0].selectedIndex).toEqual(0);
-      scope.$digest();
       // ensure the option has not changed following the digest
       expect(element[0].selectedIndex).toEqual(0);
     });
@@ -2766,7 +2737,6 @@ describe("ngOptions", () => {
         element = $compile(
           '<custom-select ng-model="value" options="options"></custom-select>',
         )(scope);
-        scope.$digest();
       }).not.toThrow();
 
       dealoc(element);
@@ -2941,7 +2911,6 @@ describe("ngOptions", () => {
       scope.values = { 0: "A", 1: "B" };
 
       scope.selected = ["1"];
-      scope.$digest();
       expect(element.find("option")[1].selected).toBe(true);
 
       element.find("option")[0].selected = true;
@@ -2993,7 +2962,7 @@ describe("ngOptions", () => {
         const addSpiesOnProto =
           originalSelectedDescriptor && originalSelectedDescriptor.configurable;
 
-        forEach(options, (option, i) => {
+        Object.entries(options).forEach(([i, option]) => {
           const setSelected = function (value) {
             _selected[i] = value;
           };
@@ -3004,7 +2973,7 @@ describe("ngOptions", () => {
         });
 
         if (!addSpiesOnProto) {
-          forEach(options, (option, i) => {
+          Object.entries(options).forEach(([i, option]) => {
             Object.defineProperty(option, "selected", {
               get() {
                 return _selected[i];
@@ -3429,7 +3398,6 @@ describe("ngOptions", () => {
     });
 
     it("should fail validation when $asyncValidators fail", () => {
-      let $q = injector.get("$q");
       let defer;
       createSelect({
         name: "select",
@@ -3448,14 +3416,12 @@ describe("ngOptions", () => {
       expect(element).toEqualSelectValue("third");
 
       defer.reject();
-      scope.$digest();
       expect(scope.form.select.$pending).toBeUndefined();
       expect(scope.value).toBeUndefined();
       expect(element).toEqualSelectValue("third");
     });
 
     it("should pass validation when $asyncValidators pass", () => {
-      let $q = injector.get("$q");
       let defer;
       createSelect({
         name: "select",
@@ -3474,7 +3440,6 @@ describe("ngOptions", () => {
       expect(element).toEqualSelectValue("third");
 
       defer.resolve();
-      scope.$digest();
       expect(scope.form.select.$pending).toBeUndefined();
       expect(scope.value).toBe("third");
       expect(element).toEqualSelectValue("third");

package/src/directive/ref/href.spec.js

@@ -29,7 +29,6 @@ describe("ngHref", () => {
 
   it("should interpolate the expression and bind to href", () => {
     element = $compile('<a ng-href="some/{{id}}"></div>')($rootScope);
-    $rootScope.$digest();
     expect(element.attr("href")).toEqual("some/");
 
     $rootScope.$apply(() => {
@@ -42,31 +41,25 @@ describe("ngHref", () => {
     element = $compile('<a ng-href="{{url}}" rel="{{rel}}"></a>')($rootScope);
     $rootScope.url = "http://server";
     $rootScope.rel = "REL";
-    $rootScope.$digest();
     expect(element.attr("href")).toEqual("http://server");
     expect(element.attr("rel")).toEqual("REL");
   });
 
   it("should bind href even if no interpolation", () => {
     element = $compile('<a ng-href="http://server"></a>')($rootScope);
-    $rootScope.$digest();
     expect(element.attr("href")).toEqual("http://server");
   });
 
   it("should not set the href if ng-href is empty", () => {
     $rootScope.url = null;
     element = $compile('<a ng-href="{{url}}">')($rootScope);
-    $rootScope.$digest();
     expect(element.attr("href")).toEqual(undefined);
   });
 
   it("should remove the href if ng-href changes to empty", () => {
     $rootScope.url = "http://www.google.com/";
     element = $compile('<a ng-href="{{url}}">')($rootScope);
-    $rootScope.$digest();
-
     $rootScope.url = null;
-    $rootScope.$digest();
     expect(element.attr("href")).toEqual(undefined);
   });
 
@@ -74,26 +67,22 @@ describe("ngHref", () => {
     /* eslint no-script-url: "off" */
     $rootScope.imageUrl = "javascript:alert(1);";
     element = $compile('<a ng-href="{{imageUrl}}">')($rootScope);
-    $rootScope.$digest();
     expect(element.attr("href")).toBe("unsafe:javascript:alert(1);");
   });
 
   it("should sanitize non-interpolated url", () => {
     element = $compile('<a ng-href="javascript:alert(1);">')($rootScope);
-    $rootScope.$digest();
     expect(element.attr("href")).toBe("unsafe:javascript:alert(1);");
   });
 
   it("should bind numbers", () => {
     element = $compile('<a ng-href="{{1234}}"></a>')($rootScope);
-    $rootScope.$digest();
     expect(element.attr("href")).toEqual("1234");
   });
 
   it("should bind and sanitize the result of a (custom) toString() function", () => {
     $rootScope.value = {};
     element = $compile('<a ng-href="{{value}}"></a>')($rootScope);
-    $rootScope.$digest();
     expect(element.attr("href")).toEqual("[object Object]");
 
     function SafeClass() {}
@@ -103,7 +92,6 @@ describe("ngHref", () => {
     };
 
     $rootScope.value = new SafeClass();
-    $rootScope.$digest();
     expect(element.attr("href")).toEqual("custom value");
 
     function UnsafeClass() {}
@@ -113,7 +101,6 @@ describe("ngHref", () => {
     };
 
     $rootScope.value = new UnsafeClass();
-    $rootScope.$digest();
     expect(element.attr("href")).toEqual("unsafe:javascript:alert(1);");
   });
 
@@ -124,7 +111,6 @@ describe("ngHref", () => {
           $rootScope,
         );
         const child = element.children("a");
-        $rootScope.$digest();
         expect(child.attr("xlink:href")).toEqual("some/");
 
         $rootScope.$apply(() => {
@@ -138,7 +124,6 @@ describe("ngHref", () => {
           $rootScope,
         );
         const child = element.children("a");
-        $rootScope.$digest();
         expect(child.attr("xlink:href")).toEqual("http://server");
       });
     });

package/src/directive/repeat/repeat.js

@@ -1,4 +1,4 @@
-import { forEach, minErr, hashKey, isArrayLike } from "../../shared/utils";
+import { minErr, hashKey, isArrayLike } from "../../shared/utils";
 import { getBlockNodes } from "../../shared/jqlite/jqlite";
 
 export const ngRepeatDirective = [
@@ -188,7 +188,7 @@ export const ngRepeatDirective = [
                 nextBlockOrder[index] = block;
               } else if (nextBlockMap[trackById]) {
                 // if collision detected. restore lastBlockMap and throw an error
-                forEach(nextBlockOrder, function (block) {
+                Object.values(nextBlockOrder).forEach((block) => {
                   if (block && block.scope) lastBlockMap[block.id] = block;
                 });
                 throw ngRepeatMinErr(