@angular-wave/angular.ts 0.2.3 → 0.3.1

package/src/core/controller/controller.js

@@ -25,7 +25,7 @@ export function identifierForController(controller, ident) {
  * This provider allows controller registration via the
  * {@link ng.$controllerProvider#register register} method.
  */
-export class $ControllerProvider {
+export class ControllerProvider {
   constructor() {
     /**
      * @type {Map<string, Function|Object>}

package/src/core/exception-handler.js

@@ -52,7 +52,7 @@ export const errorHandler = (exception, cause) => {
  * @constructor
  * @this {ExceptionHandlerProvider}
  */
-export function $ExceptionHandlerProvider() {
+export function ExceptionHandlerProvider() {
   this.$get = [
     "$log",
     /**

package/src/core/filter/filter.js

@@ -8,8 +8,8 @@ import {
   $IsStateFilter,
 } from "../../router/state-filters";
 
-$FilterProvider.$inject = ["$provide"];
-export function $FilterProvider($provide) {
+FilterProvider.$inject = ["$provide"];
+export function FilterProvider($provide) {
   const suffix = "Filter";
 
   function register(name, factory) {

package/src/core/interpolate/interpolate.js

@@ -40,7 +40,7 @@ function interr(text, err) {
  * security bugs!
  * </div>
  */
-export function $InterpolateProvider() {
+export function InterpolateProvider() {
   let startSymbol = "{{";
   let endSymbol = "}}";
 
@@ -48,7 +48,7 @@ export function $InterpolateProvider() {
    * Symbol to denote start of expression in the interpolated string. Defaults to `{{`.
    *
    * @param {string=} value new value to set the starting symbol to.
-   * @returns {string|$InterpolateProvider} Returns the symbol when used as getter and self if used as setter.
+   * @returns {string|InterpolateProvider} Returns the symbol when used as getter and self if used as setter.
    */
   this.startSymbol = function (value) {
     if (value) {
@@ -62,7 +62,7 @@ export function $InterpolateProvider() {
    * Symbol to denote the end of expression in the interpolated string. Defaults to `}}`.
    *
    * @param {string=} value new value to set the ending symbol to.
-   * @returns {string|$InterpolateProvider} Returns the symbol when used as getter and self if used as setter.
+   * @returns {string|InterpolateProvider} Returns the symbol when used as getter and self if used as setter.
    */
   this.endSymbol = function (value) {
     if (value) {

package/src/core/interval/interval-factory.js

@@ -1,6 +1,6 @@
 import { isDefined, sliceArgs } from "../../shared/utils";
 
-export function $$IntervalFactoryProvider() {
+export function $IntervalFactoryProvider() {
   this.$get = [
     "$browser",
     "$q",

package/src/core/interval/interval.js

@@ -13,7 +13,7 @@ const $intervalMinErr = minErr("$interval");
  */
 const intervals = new Map();
 
-export function $IntervalProvider() {
+export function IntervalProvider() {
   this.$get = [
     "$$intervalFactory",
     // TODO Add type

package/src/core/location/location.js

@@ -544,7 +544,7 @@ export class LocationHashbangUrl extends Location {
   }
 }
 
-export function $LocationProvider() {
+export function LocationProvider() {
   let hashPrefix = "!";
   const html5Mode = {
     enabled: false,

package/src/core/location/location.spec.js

@@ -1,7 +1,7 @@
 import {
   LocationHtml5Url,
   LocationHashbangUrl,
-  $LocationProvider,
+  LocationProvider,
 } from "./location";
 import { Angular } from "../../loader";
 import { createInjector } from "../di/injector";
@@ -23,12 +23,12 @@ describe("$location", () => {
 
   describe("defaults", () => {
     it('should have hashPrefix of "!"', () => {
-      let provider = new $LocationProvider();
+      let provider = new LocationProvider();
       expect(provider.hashPrefix()).toBe("!");
     });
 
     it("should not be html5 mode", () => {
-      let provider = new $LocationProvider();
+      let provider = new LocationProvider();
       expect(provider.html5Mode().enabled).toBeFalse();
     });
   });

package/src/core/parser/parse.js

@@ -33,7 +33,7 @@ import { Parser } from "./parser";
  * @typedef {function(CompiledExpression|string|function(import('../scope/scope').Scope):any, function(any, import('../scope/scope').Scope, any):any=, boolean=): CompiledExpression} ParseService
  */
 
-export function $ParseProvider() {
+export function ParseProvider() {
   const cache = Object.create(null);
 
   /** @type {function(any):boolean?} */
@@ -60,7 +60,7 @@ export function $ParseProvider() {
    *   a valid identifier start character.
    * @param {function(any):boolean} [identifierContinue] The function that will decide whether the given character is
    *   a valid identifier continue character.
-   * @returns {$ParseProvider}
+   * @returns {ParseProvider}
    */
   this.setIdentifierFns = function (identifierStart, identifierContinue) {
     identStart = identifierStart;

package/src/core/sce/sce.js

@@ -162,7 +162,7 @@ export function adjustMatcher(matcher) {
  * of issues, like for instance attacker-controlled `ng-includes`.
  */
 
-export function $SceDelegateProvider() {
+export function SceDelegateProvider() {
   this.SCE_CONTEXTS = SCE_CONTEXTS;
 
   // Resource URLs can also be trusted by policy.
@@ -473,7 +473,7 @@ export function $SceDelegateProvider() {
   ];
 }
 
-export function $SceProvider() {
+export function SceProvider() {
   let enabled = true;
 
   /**

package/src/core/scope/scope.js

@@ -92,7 +92,7 @@ let rootScope;
  * The provider also injects runtime services to make them available to all scopes.
  *
  */
-export class $RootScopeProvider {
+export class RootScopeProvider {
   constructor() {
     rootScope = new Scope();
   }

package/src/core/task-tracker-factory.js

@@ -1,4 +1,4 @@
-export class $$TaskTrackerFactoryProvider {
+export class TaskTrackerFactoryProvider {
   $get = [
     "$log",
     /**

package/src/core/timeout/timeout.js

@@ -3,8 +3,8 @@ import { isDefined, minErr, sliceArgs } from "../../shared/utils";
 
 const $timeoutMinErr = minErr("$timeout");
 
-export function $TimeoutProvider() {
-  this.$get = [
+export class TimeoutProvider {
+  $get = [
     "$rootScope",
     "$browser",
     "$q",
@@ -19,7 +19,7 @@ export function $TimeoutProvider() {
      * @param {import('../exception-handler').ErrorHandler} $exceptionHandler
      * @returns
      */
-    function ($rootScope, $browser, $q, $$q, $exceptionHandler) {
+    ($rootScope, $browser, $q, $$q, $exceptionHandler) => {
       const deferreds = {};
 
       /**

package/src/directive/if/if.js

@@ -18,10 +18,10 @@ export function ngIfDirective($animate) {
     restrict: "A",
     /**
      *
-     * @param {*} $scope
-     * @param {*} $element
-     * @param {*} $attr
-     * @param {*} _ctrl
+     * @param {import("../../core/scope/scope").Scope} $scope
+     * @param {import("../../shared/jqlite/jqlite").JQLite} $element
+     * @param {import("../../core/compile/attributes").Attributes} $attr
+     * @param {Object} _ctrl
      * @param {*} $transclude
      */
     link($scope, $element, $attr, _ctrl, $transclude) {
@@ -32,7 +32,7 @@ export function ngIfDirective($animate) {
       let childScope;
       /** @type {import("../../shared/jqlite/jqlite").JQLite} */
       let previousElements;
-      $scope.$watch($attr.ngIf, (value) => {
+      $scope.$watch($attr["ngIf"], (value) => {
         if (value) {
           if (!childScope) {
             $transclude((clone, newScope) => {

package/src/directive/include/include.spec.js

@@ -70,7 +70,7 @@ describe("ngInclude", () => {
       const injector = angular.bootstrap(element);
       $rootScope = injector.get("$rootScope");
       $templateCache = injector.get("$templateCache");
-      $templateCache.put("myUrl", [200, "{{name}}", {}]);
+      $templateCache.set("myUrl", [200, "{{name}}", {}]);
       $rootScope.name = "misko";
       $rootScope.url = "myUrl";
       $rootScope.$digest();
@@ -709,7 +709,7 @@ describe("ngInclude", () => {
     //   it("should fire off the enter animation", () => {
     //     let item;
 
-    //     $templateCache.put("enter", [200, "<div>data</div>", {}]);
+    //     $templateCache.set("enter", [200, "<div>data</div>", {}]);
     //     $rootScope.tpl = "enter";
     //     element = $compile(
     //       html("<div><div " + 'ng-include="tpl">' + "</div></div>"),
@@ -723,7 +723,7 @@ describe("ngInclude", () => {
 
     //   it("should fire off the leave animation", () => {
     //     let item;
-    //     $templateCache.put("enter", [200, "<div>data</div>", {}]);
+    //     $templateCache.set("enter", [200, "<div>data</div>", {}]);
     //     $rootScope.tpl = "enter";
     //     element = $compile(
     //       html("<div><div " + 'ng-include="tpl">' + "</div></div>"),
@@ -744,8 +744,8 @@ describe("ngInclude", () => {
 
     //   it("should animate two separate ngInclude elements", () => {
     //     let item;
-    //     $templateCache.put("one", [200, "one", {}]);
-    //     $templateCache.put("two", [200, "two", {}]);
+    //     $templateCache.set("one", [200, "one", {}]);
+    //     $templateCache.set("two", [200, "two", {}]);
     //     $rootScope.tpl = "one";
     //     element = $compile(
     //       html("<div><div " + 'ng-include="tpl">' + "</div></div>"),
@@ -784,8 +784,8 @@ describe("ngInclude", () => {
     //         html("<div>" + '<div ng-include="inc">Yo</div>' + "</div>"),
     //       )($scope);
 
-    //       $templateCache.put("one", [200, "<div>one</div>", {}]);
-    //       $templateCache.put("two", [200, "<div>two</div>", {}]);
+    //       $templateCache.set("one", [200, "<div>one</div>", {}]);
+    //       $templateCache.set("two", [200, "<div>two</div>", {}]);
 
     //       $scope.$apply('inc = "one"');
 

package/src/directive/init/init.spec.js

@@ -34,8 +34,8 @@ describe("ngInit", () => {
         "ng-init=\"template='template2.tpl'\"></div></div>",
     );
     window.angular.module("myModule", []).run(($templateCache) => {
-      $templateCache.put("template1.tpl", "<span>1</span>");
-      $templateCache.put("template2.tpl", "<span>2</span>");
+      $templateCache.set("template1.tpl", "<span>1</span>");
+      $templateCache.set("template2.tpl", "<span>2</span>");
     });
     injector = angular.bootstrap(element, ["myModule"]);
     $rootScope = injector.get("$rootScope");

package/src/directive/messages/messages.spec.js

@@ -782,7 +782,7 @@ describe("ngMessages", () => {
     //   },
     //   (html) => {
     //     inject(($compile, $rootScope, $templateCache) => {
-    //       $templateCache.put(
+    //       $templateCache.set(
     //         "abc.html",
     //         '<div ng-message="a">A</div>' +
     //           '<div ng-message="b">B</div>' +
@@ -850,7 +850,7 @@ describe("ngMessages", () => {
     //   },
     //   (html) => {
     //     inject(($compile, $rootScope, $templateCache) => {
-    //       $templateCache.put("abc.html", "<div></div>");
+    //       $templateCache.set("abc.html", "<div></div>");
 
     //       element = $compile(html)($rootScope);
     //       $rootScope.$digest();
@@ -881,7 +881,7 @@ describe("ngMessages", () => {
     //   },
     //   (html) => {
     //     inject(($compile, $rootScope, $templateCache) => {
-    //       $templateCache.put(
+    //       $templateCache.set(
     //         "abc.html",
     //         '<div ng-message="a">A</div>' +
     //           '<div ng-message="b">B</div>' +
@@ -948,7 +948,7 @@ describe("ngMessages", () => {
     });
 
     it("should allow for overriding the remote template messages within the element depending on where the remote template is placed", () => {
-      $templateCache.put(
+      $templateCache.set(
         "abc.html",
         '<div ng-message="a">A</div>' +
           '<div ng-message="b">B</div>' +
@@ -995,7 +995,7 @@ describe("ngMessages", () => {
     });
 
     // it("should properly detect a previous message, even if it was registered later", () => {
-    //   $templateCache.put("include.html", '<div ng-message="a">A</div>');
+    //   $templateCache.set("include.html", '<div ng-message="a">A</div>');
     //   const html =
     //     '<div ng-messages="items">' +
     //     "<div ng-include=\"'include.html'\"></div>" +
@@ -1031,8 +1031,8 @@ describe("ngMessages", () => {
         '<div ng-messages-include="messages2.html"></div>' +
         "</div>";
 
-      $templateCache.put("messages1.html", "");
-      $templateCache.put("messages2.html", "   ");
+      $templateCache.set("messages1.html", "");
+      $templateCache.set("messages2.html", "   ");
       element = $compile(html)($rootScope);
       $rootScope.$digest();
 
@@ -1070,7 +1070,7 @@ describe("ngMessages", () => {
     // );
 
     it("should render all truthy messages from a remote template", () => {
-      $templateCache.put(
+      $templateCache.set(
         "xyz.html",
         '<div ng-message="x">X</div>' +
           '<div ng-message="y">Y</div>' +
@@ -1103,7 +1103,7 @@ describe("ngMessages", () => {
     });
 
     it("should render and override all truthy messages from a remote template", () => {
-      $templateCache.put(
+      $templateCache.set(
         "xyz.html",
         '<div ng-message="x">X</div>' +
           '<div ng-message="y">Y</div>' +

package/src/directive/options/options.spec.js

@@ -2755,7 +2755,7 @@ describe("ngOptions", () => {
 
     it("should not throw with a directive that replaces", () => {
       let $templateCache = injector.get("$templateCache");
-      $templateCache.put(
+      $templateCache.set(
         "select_template.html",
         '<select ng-options="option as option for option in selectable_options"> <option value="">This is a test</option> </select>',
       );

package/src/directive/repeat/repeat.spec.js

@@ -950,7 +950,7 @@ describe("ngRepeat", () => {
         templateUrl: "rr.html",
       }));
 
-      $templateCache.put("rr.html", '<div ng-repeat="i in items">{{i}}|</div>');
+      $templateCache.set("rr.html", '<div ng-repeat="i in items">{{i}}|</div>');
 
       element = JQLite("<div><span rr>{{i}}|</span></div>");
       $compile(element)(scope);
@@ -994,7 +994,7 @@ describe("ngRepeat", () => {
         replace: true,
         templateUrl: "replace-me-with-repeater.html",
       }));
-      $templateCache.put(
+      $templateCache.set(
         "replace-me-with-repeater.html",
         '<div ng-repeat="i in items">{{log(i)}}</div>',
       );
@@ -1042,7 +1042,7 @@ describe("ngRepeat", () => {
         replace: true,
         templateUrl: "replace-me-with-repeater.html",
       }));
-      $templateCache.put(
+      $templateCache.set(
         "replace-me-with-repeater.html",
         '<div ng-repeat="i in [1,2,3]">{{i}}</div>',
       );
@@ -1294,7 +1294,7 @@ describe("ngRepeat", () => {
       const injector = window.angular.bootstrap(element);
       scope = injector.get("$rootScope");
       $templateCache = injector.get("$templateCache");
-      $templateCache.put("test.html", "hello");
+      $templateCache.set("test.html", "hello");
       scope.$digest();
       setTimeout(() => {
         expect(element.text()).toBe("hellohello");

package/src/directive/script/script.js

@@ -1,15 +1,17 @@
-export const scriptDirective = [
-  "$templateCache",
-  ($templateCache) => ({
+scriptDirective.$inject = ["$templateCache"];
+
+/**
+ * @param {import('../../core/cache/cache-factory').TemplateCache} $templateCache
+ * @returns {import('../../types').Directive}
+ */
+export function scriptDirective($templateCache) {
+  return {
     restrict: "E",
     terminal: true,
     compile(element, attr) {
       if (attr.type === "text/ng-template") {
-        const templateUrl = attr.id;
-        const { text } = element[0];
-
-        $templateCache.put(templateUrl, text);
+        $templateCache.set(attr.id, element[0].text);
       }
     },
-  }),
-];
+  };
+}

package/src/directive/validators/validators.js

@@ -33,33 +33,45 @@ import { startingTag } from "../../shared/jqlite/jqlite";
  */
 export const requiredDirective = [
   "$parse",
+  /**
+   * @param {import("../../core/parser/parse.js").ParseService} $parse
+   * @returns {import("../../types.js").Directive}
+   */
   ($parse) => ({
     restrict: "A",
     require: "?ngModel",
-    link(scope, elm, attr, ctrl) {
-      if (!ctrl) return;
-      // For boolean attributes like required, presence means true
-      let value =
-        Object.prototype.hasOwnProperty.call(attr, "required") ||
-        $parse(attr.ngRequired)(scope);
+    link:
+      /**
+       * @param {import("../../core/scope/scope.js").Scope} scope
+       * @param {*} _elm
+       * @param {import("../../types.js").Attributes} attr
+       * @param {import("../../types.js").NgModelController} ctrl
+       * @returns
+       */
+      (scope, _elm, attr, ctrl) => {
+        if (!ctrl) return;
+        // For boolean attributes like required, presence means true
+        let value =
+          Object.prototype.hasOwnProperty.call(attr, "required") ||
+          $parse(attr.ngRequired)(scope);
 
-      if (!attr.ngRequired) {
-        // force truthy in case we are on non input element
-        // (input elements do this automatically for boolean attributes like required)
-        attr.required = true;
-      }
+        if (!attr.ngRequired) {
+          // force truthy in case we are on non input element
+          // (input elements do this automatically for boolean attributes like required)
+          attr.required = true;
+        }
 
-      ctrl.$validators.required = function (modelValue, viewValue) {
-        return !value || !ctrl.$isEmpty(viewValue);
-      };
+        ctrl.$validators.required = (_modelValue, viewValue) => {
+          return !value || !ctrl.$isEmpty(viewValue);
+        };
 
-      attr.$observe("required", (newVal) => {
-        if (value !== newVal) {
-          value = newVal;
-          ctrl.$validate();
-        }
-      });
-    },
+        attr.$observe("required", (newVal) => {
+          if (value !== newVal) {
+            value = newVal;
+            ctrl.$validate();
+          }
+        });
+      },
   }),
 ];
 
@@ -104,11 +116,15 @@ export const requiredDirective = [
  */
 export const patternDirective = [
   "$parse",
-  function ($parse) {
+  /**
+   * @param {import("../../core/parser/parse.js").ParseService} $parse
+   * @returns {import("../../types.js").Directive}
+   */
+  ($parse) => {
     return {
       restrict: "A",
       require: "?ngModel",
-      compile: function (tElm, tAttr) {
+      compile: (_Elm, tAttr) => {
         var patternExp;
         var parseFn;
 
@@ -201,30 +217,42 @@ export const patternDirective = [
  */
 export const maxlengthDirective = [
   "$parse",
+  /**
+   * @param {import("../../core/parser/parse.js").ParseService} $parse
+   * @returns {import("../../types.js").Directive}
+   */
   ($parse) => ({
     restrict: "A",
     require: "?ngModel",
-    link(scope, elm, attr, ctrl) {
-      if (!ctrl) return;
+    link:
+      /**
+       * @param {import("../../core/scope/scope.js").Scope} scope
+       * @param {*} _elm
+       * @param {import("../../types.js").Attributes} attr
+       * @param {import("../../types.js").NgModelController} ctrl
+       * @returns
+       */
+      (scope, _elm, attr, ctrl) => {
+        if (!ctrl) return;
 
-      let maxlength = attr.maxlength || $parse(attr.ngMaxlength)(scope);
-      let maxlengthParsed = parseLength(maxlength);
+        let maxlength = attr.maxlength || $parse(attr.ngMaxlength)(scope);
+        let maxlengthParsed = parseLength(maxlength);
 
-      attr.$observe("maxlength", (value) => {
-        if (maxlength !== value) {
-          maxlengthParsed = parseLength(value);
-          maxlength = value;
-          ctrl.$validate();
-        }
-      });
-      ctrl.$validators.maxlength = function (modelValue, viewValue) {
-        return (
-          maxlengthParsed < 0 ||
-          ctrl.$isEmpty(viewValue) ||
-          viewValue.length <= maxlengthParsed
-        );
-      };
-    },
+        attr.$observe("maxlength", (value) => {
+          if (maxlength !== value) {
+            maxlengthParsed = parseLength(value);
+            maxlength = value;
+            ctrl.$validate();
+          }
+        });
+        ctrl.$validators.maxlength = function (modelValue, viewValue) {
+          return (
+            maxlengthParsed < 0 ||
+            ctrl.$isEmpty(viewValue) ||
+            viewValue.length <= maxlengthParsed
+          );
+        };
+      },
   }),
 ];