@angular-wave/angular.ts 0.2.2 → 0.2.3

package/src/directive/include/include.spec.js

@@ -689,7 +689,7 @@ describe("ngInclude", () => {
     //   //       // we need to run animation on attached elements;
     //   //       function (_$rootElement_) {
     //   //         $rootElement = _$rootElement_;
-    //   //         body = JQLite(window.document.body);
+    //   //         body = JQLite(document.body);
     //   //         body.append($rootElement);
     //   //       },
     //   //   ),

package/src/directive/input/input.js

@@ -113,7 +113,7 @@ function textInputType(scope, element, attr, ctrl, $browser) {
 }
 
 function baseInputType(scope, element, attr, ctrl, $browser) {
-  const type = lowercase(element[0].type);
+  const type = element[0].type.toLowerCase();
   let composing = false;
   // In composition mode, users are still inputting intermediate text buffer,
   // hold the listener until composition is done.

package/src/directive/model/model.js

@@ -146,17 +146,23 @@ export class NgModelController {
 
     this.$$parsedNgModel = $parse($attr["ngModel"]);
     this.$$parsedNgModelAssign = this.$$parsedNgModel.assign;
+
     /** @type {import("../../core/parser/parse").CompiledExpression|((Scope) => any)} */
     this.$$ngModelGet = this.$$parsedNgModel;
     this.$$ngModelSet = this.$$parsedNgModelAssign;
     this.$$pendingDebounce = null;
     this.$$parserValid = undefined;
+
+    /** @type {string} */
     this.$$parserName = "parse";
 
     /** @type {number} */
     this.$$currentValidationRunId = 0;
 
+    /** @type {import('../../core/scope/scope.js').Scope} */
     this.$$scope = $scope;
+
+    /** @type {import('../../core/scope/scope.js').Scope} */
     this.$$rootScope = $scope.$root;
     this.$$attr = $attr;
     this.$$element = $element;
@@ -1095,54 +1101,56 @@ export function ngModelDirective($rootScope) {
     // so that we can set the NgModelOptions in NgModelController
     // before anyone else uses it.
     priority: 1,
-    compile: function ngModelCompile(element) {
-      // Setup initial state of the control
-      element[0].classList.add(PRISTINE_CLASS, UNTOUCHED_CLASS, VALID_CLASS);
-
-      return {
-        pre: function (scope, _element, attr, ctrls) {
-          const modelCtrl = ctrls[0];
-          const formCtrl = ctrls[1] || modelCtrl.$$parentForm;
-          const optionsCtrl = ctrls[2];
-
-          if (optionsCtrl) {
-            modelCtrl.$options = optionsCtrl.$options;
-          }
+    compile:
+      /** @param {import("../../shared/jqlite/jqlite.js").JQLite} element  */
+      (element) => {
+        // Setup initial state of the control
+        element[0].classList.add(PRISTINE_CLASS, UNTOUCHED_CLASS, VALID_CLASS);
+
+        return {
+          pre: (scope, _element, attr, ctrls) => {
+            const modelCtrl = ctrls[0];
+            const formCtrl = ctrls[1] || modelCtrl.$$parentForm;
+            const optionsCtrl = ctrls[2];
+
+            if (optionsCtrl) {
+              modelCtrl.$options = optionsCtrl.$options;
+            }
 
-          modelCtrl.$$initGetterSetters();
+            modelCtrl.$$initGetterSetters();
 
-          // notify others, especially parent forms
-          formCtrl.$addControl(modelCtrl);
+            // notify others, especially parent forms
+            formCtrl.$addControl(modelCtrl);
 
-          attr.$observe("name", (newValue) => {
-            if (modelCtrl.$name !== newValue) {
-              modelCtrl.$$parentForm.$$renameControl(modelCtrl, newValue);
-            }
-          });
+            attr.$observe("name", (newValue) => {
+              if (modelCtrl.$name !== newValue) {
+                modelCtrl.$$parentForm.$$renameControl(modelCtrl, newValue);
+              }
+            });
 
-          scope.$on("$destroy", () => {
-            modelCtrl.$$parentForm.$removeControl(modelCtrl);
-          });
-        },
-        post: function (scope, element, _attr, ctrls) {
-          const modelCtrl = ctrls[0];
-          modelCtrl.$$setUpdateOnEvents();
+            scope.$on("$destroy", () => {
+              modelCtrl.$$parentForm.$removeControl(modelCtrl);
+            });
+          },
+          post: (scope, element, _attr, ctrls) => {
+            const modelCtrl = ctrls[0];
+            modelCtrl.$$setUpdateOnEvents();
 
-          function setTouched() {
-            modelCtrl.$setTouched();
-          }
+            function setTouched() {
+              modelCtrl.$setTouched();
+            }
 
-          element.on("blur", () => {
-            if (modelCtrl.$touched) return;
+            element.on("blur", () => {
+              if (modelCtrl.$touched) return;
 
-            if ($rootScope.$$phase !== ScopePhase.NONE) {
-              scope.$evalAsync(setTouched);
-            } else {
-              scope.$apply(setTouched);
-            }
-          });
-        },
-      };
-    },
+              if ($rootScope.$$phase !== ScopePhase.NONE) {
+                scope.$evalAsync(setTouched);
+              } else {
+                scope.$apply(setTouched);
+              }
+            });
+          },
+        };
+      },
   };
 }

package/src/directive/options/options.js

@@ -209,8 +209,8 @@ export const ngOptionsDirective = [
     // Support: IE 9 only
     // We can't just JQLite('<option>') since JQLite is not smart enough
     // to create it in <select> and IE barfs otherwise.
-    const optionTemplate = window.document.createElement("option");
-    const optGroupTemplate = window.document.createElement("optgroup");
+    const optionTemplate = document.createElement("option");
+    const optGroupTemplate = document.createElement("optgroup");
 
     function ngOptionsPostLink(scope, selectElement, attr, ctrls) {
       const selectCtrl = ctrls[0];

package/src/directive/repeat/repeat.spec.js

@@ -119,7 +119,7 @@ describe("ngRepeat", () => {
       "<a class='test' name='y'>b</a>" +
       "<a class='test' name='x'>c</a>";
 
-    const htmlCollection = window.document.getElementsByClassName("test");
+    const htmlCollection = document.getElementsByClassName("test");
     scope.items = htmlCollection;
     scope.$digest();
     expect(element.find("li").length).toEqual(3);
@@ -382,7 +382,7 @@ describe("ngRepeat", () => {
           "</li>" +
           "</ul>",
       )(scope);
-      window.document.getElementById("dummy").appendChild(element[0]);
+      document.getElementById("dummy").appendChild(element[0]);
       scope.items = { misko: true, shyam: true, zhenbo: true };
       scope.$digest();
       expect(element.find("li").length).toEqual(3);
@@ -413,7 +413,7 @@ describe("ngRepeat", () => {
       expect(element.find("input")[1].checked).toBe(true);
       expect(element.find("input")[2].checked).toBe(true);
 
-      window.document.getElementById("dummy").innerHTML = "";
+      document.getElementById("dummy").innerHTML = "";
     });
 
     it("should invoke track by with correct locals", () => {
@@ -1466,7 +1466,7 @@ describe("ngRepeat", () => {
 //         // we need to run animation on attached elements;
 //         function (_$rootElement_) {
 //           $rootElement = _$rootElement_;
-//           body = JQLite(window.document.body);
+//           body = JQLite(document.body);
 //           body.append($rootElement);
 //         },
 //     ),

package/src/directive/select/select.js

@@ -49,7 +49,7 @@ function SelectController($element, $scope) {
   // Support: IE 9 only
   // We can't just JQLite('<option>') since JQLite is not smart enough
   // to create it in <select> and IE barfs otherwise.
-  self.unknownOption = JQLite(window.document.createElement("option"));
+  self.unknownOption = JQLite(document.createElement("option"));
 
   // The empty option is an option with the value '' that the application developer can
   // provide inside the select. It is always selectable and indicates that a "null" selection has

package/src/directive/show-hide/show-hide.spec.js

@@ -130,7 +130,7 @@ describe("ngShow / ngHide", () => {
 
 //   beforeEach(() => {
 //     // we need to run animation on attached elements;
-//     body = JQLite(window.document.body);
+//     body = JQLite(document.body);
 //   });
 
 //   afterEach(() => {

package/src/directive/style/style.spec.js

@@ -86,7 +86,7 @@ describe("ng-style", () => {
       postCompVal = "100px";
       element = JQLite('<div ng-style="styleObj"></div>');
       element[0].style[preCompStyle] = preCompVal;
-      JQLite(window.document.body).append(element);
+      JQLite(document.body).append(element);
       $compile(element)($scope);
       scope = $scope;
       scope.styleObj = { "margin-top": "44px" };

package/src/directive/switch/switch.spec.js

@@ -499,7 +499,7 @@ describe("ngSwitch", () => {
 //         // we need to run animation on attached elements;
 //         function (_$rootElement_) {
 //           $rootElement = _$rootElement_;
-//           body = JQLite(window.document.body);
+//           body = JQLite(document.body);
 //           body.append($rootElement);
 //         },
 //     ),

package/src/directive/validators/validators.js

@@ -10,7 +10,7 @@ import { startingTag } from "../../shared/jqlite/jqlite";
 
 /**
  *
- * @param {String} ngRequired AngularJS expression. If it evaluates to `true`, it sets the
+ * @param {string} ngRequired AngularJS expression. If it evaluates to `true`, it sets the
  *                                `required` attribute to the element and adds the `required`
  *                                {@link ngModel.NgModelController#$validators `validator`}.
  *
@@ -170,7 +170,7 @@ export const patternDirective = [
 ];
 
 /**
- * @param {String} ngMaxlength AngularJS expression that must evaluate to a `Number` or `String`
+ * @param {string} ngMaxlength AngularJS expression that must evaluate to a `Number` or `String`
  *                                 parsable into a `Number`. Used as value for the `maxlength`
  *                                 {@link ngModel.NgModelController#$validators validator}.
  *

package/src/filters/filter.js

@@ -4,7 +4,6 @@ import {
   isFunction,
   isUndefined,
   isObject,
-  lowercase,
   hasCustomToString,
   equals,
 } from "../shared/utils";
@@ -95,8 +94,8 @@ function createPredicateFn(
         return false;
       }
 
-      actual = lowercase(`${actual}`);
-      expected = lowercase(`${expected}`);
+      actual = `${actual}`.toLowerCase();
+      expected = `${expected}`.toLowerCase();
       return actual.indexOf(expected) !== -1;
     };
   }

package/src/filters/limit-to.js

@@ -19,7 +19,7 @@ export function limitToFilter() {
     if (Math.abs(Number(limit)) === Infinity) {
       limit = Number(limit);
     } else {
-      limit = toInt(/** @type {String} */ (limit));
+      limit = toInt(/** @type {string} */ (limit));
     }
     if (isNumberNaN(limit)) return input;
 
@@ -29,7 +29,7 @@ export function limitToFilter() {
     begin =
       !begin || isNaN(/** @type {any} */ (begin))
         ? 0
-        : toInt(/** @type {String} */ (begin));
+        : toInt(/** @type {string} */ (begin));
     begin =
       begin < 0 ? Math.max(0, /** @type {[]} */ (input).length + begin) : begin;
 

package/src/services/cookie-reader.js

@@ -12,7 +12,7 @@ export function getCookies() {
   let i;
   let index;
   let name;
-  const currentCookieString = window.document.cookie;
+  const currentCookieString = document.cookie;
 
   if (currentCookieString !== lastCookieString) {
     lastCookieString = currentCookieString;

package/src/services/http/http.js

@@ -5,7 +5,6 @@ import {
   isObject,
   isDate,
   toJson,
-  forEachSorted,
   isUndefined,
   isFunction,
   forEach,
@@ -60,20 +59,23 @@ export function $HttpParamSerializerProvider() {
     return function ngParamSerializer(params) {
       if (!params) return "";
       const parts = [];
-      forEachSorted(params, (value, key) => {
-        if (value === null || isUndefined(value) || isFunction(value)) return;
-        if (Array.isArray(value)) {
-          value.forEach((v) => {
+      Object.keys(params)
+        .sort()
+        .forEach((key) => {
+          const value = params[key];
+          if (value === null || isUndefined(value) || isFunction(value)) return;
+          if (Array.isArray(value)) {
+            value.forEach((v) => {
+              parts.push(
+                `${encodeUriQuery(key)}=${encodeUriQuery(serializeValue(v))}`,
+              );
+            });
+          } else {
             parts.push(
-              `${encodeUriQuery(key)}=${encodeUriQuery(serializeValue(v))}`,
+              `${encodeUriQuery(key)}=${encodeUriQuery(serializeValue(value))}`,
             );
-          });
-        } else {
-          parts.push(
-            `${encodeUriQuery(key)}=${encodeUriQuery(serializeValue(value))}`,
-          );
-        }
-      });
+          }
+        });
 
       return parts.join("&");
     };
@@ -134,12 +136,15 @@ export function $HttpParamSerializerJQLikeProvider() {
             serialize(value, `${prefix}[${isObject(value) ? index : ""}]`);
           });
         } else if (isObject(toSerialize) && !isDate(toSerialize)) {
-          forEachSorted(toSerialize, (value, key) => {
-            serialize(
-              value,
-              prefix + (topLevel ? "" : "[") + key + (topLevel ? "" : "]"),
-            );
-          });
+          Object.keys(toSerialize)
+            .sort()
+            .forEach((key) => {
+              const value = toSerialize[key];
+              serialize(
+                value,
+                prefix + (topLevel ? "" : "[") + key + (topLevel ? "" : "]"),
+              );
+            });
         } else {
           if (isFunction(toSerialize)) {
             toSerialize = toSerialize();

package/src/shared/common.spec.js

@@ -1,5 +1,5 @@
 import { defaults, filter, map, pick } from "./common";
-import { is, eq, pattern, val } from "./hof";
+import { is, pattern, val } from "./hof";
 import { isInjectable } from "./predicates";
 import { Queue } from "../router/common/queue";
 
@@ -76,14 +76,12 @@ describe("common", function () {
         [is(Number), val("number!")],
         [is(String), val("string!")],
         [is(Boolean), val("boolean!")],
-        [eq(null), val("null!")],
       ]);
 
       expect(typeChecker(1)).toBe("number!");
       expect(typeChecker("foo!")).toBe("string!");
       expect(typeChecker(true)).toBe("boolean!");
       expect(typeChecker(false)).toBe("boolean!");
-      expect(typeChecker(null)).toBe("null!");
       expect(typeChecker(undefined)).toBe(undefined);
     });
   });

package/src/shared/hof.js

@@ -115,8 +115,7 @@ export const all = (fn1) => (arr) => arr.reduce((b, x) => b && !!fn1(x), true);
 /** Given a class, returns a Predicate function that returns true if the object is of that class */
 export const is = (ctor) => (obj) =>
   (obj != null && obj.constructor === ctor) || obj instanceof ctor;
-/** Given a value, returns a Predicate function that returns true if another value is === equal to the original value */
-export const eq = (value) => (other) => value === other;
+
 /** Given a value, returns a function which returns the value */
 export const val = (v) => () => v;
 /**

package/src/shared/jqlite/jqlite.js

@@ -59,8 +59,8 @@ const BOOLEAN_ELEMENTS = {};
   });
 
 /**
- * JQLite both a function and an array-like data structure for manipulation of DOM, linking elements to expando cache,
- * and execution of chain functions.
+ * JQLite is both a function and an array-like data structure for manipulation of DOM, linking elements to expando cache,
+ * and execution of chains of functions.
  *
  * @param {string|Node|Node[]|NodeList|JQLite|ArrayLike<Element>|(() => void)|Window} element
  * @returns {JQLite}
@@ -841,7 +841,7 @@ export function buildFragment(html) {
     // Create wrappers & descend into them
     i = wrap.length;
     while (--i > -1) {
-      tmp.appendChild(window.document.createElement(wrap[i]));
+      tmp.appendChild(document.createElement(wrap[i]));
       tmp = /** @type {HTMLDivElement} */ (tmp.firstChild);
     }
     tmp.innerHTML = html;
@@ -953,29 +953,28 @@ export function getOrSetCacheData(element, key, value) {
  * @param {(Node|Array|NodeList|Object)} elements - The elements to add to the root. This can be a single DOM node, an array-like object (such as an Array or NodeList), or any other object.
  */
 function addNodes(root, elements) {
-  // THIS CODE IS VERY HOT. Don't make changes without benchmarking.
-
-  if (elements) {
-    // if a Node (the most common case)
-    if (elements.nodeType) {
-      root[root.length++] = elements;
-    } else {
-      const { length } = elements;
-
-      // if an Array or NodeList and not a Window
-      if (typeof length === "number" && elements.window !== elements) {
-        if (length) {
-          for (let i = 0; i < length; i++) {
-            root[root.length++] = elements[i];
-          }
-        }
-      } else {
-        root[root.length++] = elements;
-      }
+  if (!elements) return;
+  // If a Node (the most common case)
+  if (elements.nodeType) {
+    root[root.length++] = elements;
+    return;
+  }
+  const length = elements.length;
+  // If elements is an Array or NodeList, but not a Window object
+  if (typeof length === "number" && elements.window !== elements) {
+    for (let i = 0; i < length; i++) {
+      root[root.length++] = elements[i];
     }
+  } else {
+    root[root.length++] = elements;
   }
 }
 
+/**
+ * @param {Node} element
+ * @param {string} name
+ * @returns
+ */
 function getController(element, name) {
   return getInheritedData(element, `$${name || "ngController"}Controller`);
 }
@@ -991,7 +990,6 @@ function getInheritedData(element, name, value) {
   // if element is the document object work with the html element instead
   // this makes $(document).scope() possible
   if (element.nodeType === Node.DOCUMENT_NODE) {
-    // TODO Fix types
     element = /** @type {Document} */ (element).documentElement;
   }
   const names = Array.isArray(name) ? name : [name];
@@ -1031,20 +1029,20 @@ export function removeElement(element, keepData = false) {
 }
 
 /**
- * Executea a function on `DOMContentLoaded`
+ * Execute a function on `DOMContentLoaded`
  * @param {Function} fn
  */
 function onReady(fn) {
   function trigger() {
-    window.document.removeEventListener("DOMContentLoaded", trigger);
+    document.removeEventListener("DOMContentLoaded", trigger);
     fn();
   }
   // check if document is already loaded
-  if (window.document.readyState === "complete") {
-    window.setTimeout(fn);
+  if (document.readyState === "complete") {
+    setTimeout(fn);
   } else {
     // We can not use JQLite since we are not done loading.
-    window.document.addEventListener("DOMContentLoaded", trigger);
+    document.addEventListener("DOMContentLoaded", trigger);
   }
 }
 

package/src/shared/jqlite/jqlite.spec.js

@@ -122,7 +122,7 @@ describe("jqLite", () => {
     });
 
     it("should wrap document fragment", () => {
-      const fragment = JQLite(window.document.createDocumentFragment());
+      const fragment = JQLite(document.createDocumentFragment());
       expect(fragment.length).toBe(1);
       expect(fragment[0].nodeType).toBe(11);
     });
@@ -194,7 +194,7 @@ describe("jqLite", () => {
             done();
           }
         }
-        JQLite(window.document.body).append(container);
+        JQLite(document.body).append(container);
         window.xss = jasmine.createSpy("xss");
 
         // Thanks to Masato Kinugawa from Cure53 for providing the following test cases.
@@ -280,7 +280,7 @@ describe("jqLite", () => {
 
     it("should pass through DocumentFragment boundaries via host", () => {
       const host = JQLite("<div></div>");
-      const frag = window.document.createDocumentFragment();
+      const frag = document.createDocumentFragment();
       const $frag = JQLite(frag);
       frag.host = host[0];
       host.data("foo", 123);
@@ -848,7 +848,7 @@ describe("jqLite", () => {
     });
 
     it("should do nothing when setting or getting on attribute nodes", () => {
-      const attrNode = JQLite(window.document.createAttribute("myattr"));
+      const attrNode = JQLite(document.createAttribute("myattr"));
       expect(attrNode).toBeDefined();
       expect(attrNode[0].nodeType).toEqual(2);
       expect(attrNode.attr("some-attribute", "somevalue")).toEqual(attrNode);
@@ -856,7 +856,7 @@ describe("jqLite", () => {
     });
 
     it("should do nothing when setting or getting on text nodes", () => {
-      const textNode = JQLite(window.document.createTextNode("some text"));
+      const textNode = JQLite(document.createTextNode("some text"));
       expect(textNode).toBeDefined();
       expect(textNode[0].nodeType).toEqual(3);
       expect(textNode.attr("some-attribute", "somevalue")).toEqual(textNode);
@@ -864,7 +864,7 @@ describe("jqLite", () => {
     });
 
     it("should do nothing when setting or getting on comment nodes", () => {
-      const comment = JQLite(window.document.createComment("some comment"));
+      const comment = JQLite(document.createComment("some comment"));
       expect(comment).toBeDefined();
       expect(comment[0].nodeType).toEqual(8);
       expect(comment.attr("some-attribute", "somevalue")).toEqual(comment);
@@ -931,7 +931,7 @@ describe("jqLite", () => {
 
     it("should return text only for element or text nodes", () => {
       expect(JQLite("<div>foo</div>").text()).toBe("foo");
-      expect(JQLite(window.document.createComment("foo")).text()).toBe("");
+      expect(JQLite(document.createComment("foo")).text()).toBe("");
     });
   });
 
@@ -1202,7 +1202,7 @@ describe("jqLite", () => {
       function browserMoveTrigger(from, to) {
         const fireEvent = function (type, element, relatedTarget) {
           let evnt;
-          evnt = window.document.createEvent("MouseEvents");
+          evnt = document.createEvent("MouseEvents");
 
           const originalPreventDefault = evnt.preventDefault;
 
@@ -1700,7 +1700,7 @@ describe("jqLite", () => {
       expect(root.html()).toEqual("text");
     });
     it("should append to document fragment", () => {
-      const root = JQLite(window.document.createDocumentFragment());
+      const root = JQLite(document.createDocumentFragment());
       expect(root.append("<p>foo</p>")).toBe(root);
       expect(root.children().length).toBe(1);
     });
@@ -1802,7 +1802,7 @@ describe("jqLite", () => {
 
     it("should return empty JQLite object when parent is a document fragment", () => {
       // this is quite unfortunate but jQuery 1.5.1 behaves this way
-      const fragment = window.document.createDocumentFragment();
+      const fragment = document.createDocumentFragment();
       const child = JQLite("<p>foo</p>");
 
       fragment.appendChild(child[0]);

package/src/shared/utils.js

@@ -357,12 +357,6 @@ export function forEach(obj, iterator, context) {
   return obj;
 }
 
-export function forEachSorted(obj, iterator, context) {
-  const keys = Object.keys(obj).sort();
-  keys.forEach((el) => iterator.call(context, obj[el], el));
-  return keys;
-}
-
 /**
  * when using forEach the params are value, key, but it is often useful to have key, value.
  * @param {function(string, *):any} iteratorFn
@@ -686,8 +680,8 @@ const cspCache = {};
 export function csp() {
   if (!isDefined(cspCache.rules)) {
     const ngCspElement =
-      window.document.querySelector("[ng-csp]") ||
-      window.document.querySelector("[data-ng-csp]");
+      document.querySelector("[ng-csp]") ||
+      document.querySelector("[data-ng-csp]");
 
     if (ngCspElement) {
       const ngCspAttribute =
@@ -721,8 +715,8 @@ export function csp() {
 
 /**
  * throw error if the name given is hasOwnProperty
- * @param  {String} name    the name to test
- * @param  {String} context the context in which the name is used, such as module or directive
+ * @param  {string} name    the name to test
+ * @param  {string} context the context in which the name is used, such as module or directive
  */
 export function assertNotHasOwnProperty(name, context) {
   if (name === "hasOwnProperty") {
@@ -1250,7 +1244,8 @@ export function mergeClasses(a, b) {
 
 /**
  * Converts all accepted directives format into proper directive name.
- * @param name Name to normalize
+ * @param {string} name Name to normalize
+ * @returns {string}
  */
 
 export function directiveNormalize(name) {