@angular-wave/angular.ts 0.0.8 → 0.0.9

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@angular-wave/angular.ts",
   "license": "MIT",
-  "version": "0.0.8",
+  "version": "0.0.9",
   "type": "module",
   "main": "dist/angular-ts.cjs.js",
   "module": "dist/angular-ts.esm.js",

package/rollup.config.js

@@ -15,7 +15,7 @@ export default [
     plugins: [resolve(), commonjs(), terser()],
   },
 
-  // CommonJS (for Node) and ES module (for bundlers) build.
+  // ES module (for bundlers) build.
   // (We could have three entries in the configuration array
   // instead of two, but it's quicker to generate multiple
   // builds from a single configuration where possible, using
@@ -24,10 +24,7 @@ export default [
   {
     input: 'src/index.js',
     external: ['ms'],
-    output: [
-      { file: pkg.main, format: 'cjs' },
-      { file: pkg.module, format: 'es' },
-    ],
+    output: { file: pkg.module, format: 'es' },
     plugins: [terser()],
   },
 ];

package/src/core/compile.js

@@ -37,11 +37,15 @@ import { PREFIX_REGEXP, ALIASED_ATTR } from "../constants";
 import { createEventDirective } from "../directive/events";
 import { CACHE, EXPANDO } from "./cache";
 
+/**
+ * Function that aggregates all linking fns for a compilation root (nodeList)
+ * @typedef {Function} CompositeLinkFn
+ */
+
 const $compileMinErr = minErr("$compile");
 
-function UNINITIALIZED_VALUE() {}
-const _UNINITIALIZED_VALUE = new UNINITIALIZED_VALUE();
-let config = { TTL: 10 };
+const _UNINITIALIZED_VALUE = new Object();
+let TTL = 10;
 
 /**
  * @ngdoc provider
@@ -54,7 +58,6 @@ $CompileProvider.$inject = ["$provide", "$$sanitizeUriProvider"];
 export function $CompileProvider($provide, $$sanitizeUriProvider) {
   const hasDirectives = {};
   const Suffix = "Directive";
-  const CLASS_DIRECTIVE_REGEXP = /(([\w-]+)(?::([^;]+))?;?)/;
   const ALL_OR_NOTHING_ATTRS = {
     ngSrc: true,
     ngSrcset: true,
@@ -209,7 +212,7 @@ export function $CompileProvider($provide, $$sanitizeUriProvider) {
    *    are the factories.
    * @param {Function|Array} directiveFactory An injectable directive factory function. See the
    *    {@link guide/directive directive guide} and the {@link $compile compile API} for more info.
-   * @returns {ng.$compileProvider} Self for chaining.
+   * @returns {ng.ICompileProvider} Self for chaining.
    */
   this.directive = function registerDirective(name, directiveFactory) {
     assertArg(name, "name");
@@ -252,7 +255,7 @@ export function $CompileProvider($provide, $$sanitizeUriProvider) {
       }
       hasDirectives[name].push(directiveFactory);
     } else {
-      forEach(name, reverseParams(registerDirective));
+      Object.entries(name).forEach(([k, v]) => registerDirective(k, v));
     }
     return this;
   };
@@ -427,7 +430,7 @@ export function $CompileProvider($provide, $$sanitizeUriProvider) {
    * the absolute url is prefixed with `'unsafe:'` string and only then is it written into the DOM.
    *
    * @param {RegExp=} regexp New regexp to trust urls with.
-   * @returns {RegExp|ng.$compileProvider} Current RegExp if called without value or self for
+   * @returns {RegExp|ng.ICompileProvider} Current RegExp if called without value or self for
    *    chaining otherwise.
    */
   this.aHrefSanitizationTrustedUrlList = function (regexp) {
@@ -455,7 +458,7 @@ export function $CompileProvider($provide, $$sanitizeUriProvider) {
    * the absolute url is prefixed with `'unsafe:'` string and only then is it written into the DOM.
    *
    * @param {RegExp=} regexp New regexp to trust urls with.
-   * @returns {RegExp|ng.$compileProvider} Current RegExp if called without value or self for
+   * @returns {RegExp|ng.ICompileProvider} Current RegExp if called without value or self for
    *    chaining otherwise.
    */
   this.imgSrcSanitizationTrustedUrlList = function (regexp) {
@@ -528,34 +531,6 @@ export function $CompileProvider($provide, $$sanitizeUriProvider) {
     return strictComponentBindingsEnabled;
   };
 
-  /**
-   * @ngdoc method
-   * @name $compileProvider#onChangesTtl
-   * @description
-   *
-   * Sets the number of times `$onChanges` hooks can trigger new changes before giving up and
-   * assuming that the model is unstable.
-   *
-   * The current default is 10 iterations.
-   *
-   * In complex applications it's possible that dependencies between `$onChanges` hooks and bindings will result
-   * in several iterations of calls to these hooks. However if an application needs more than the default 10
-   * iterations to stabilize then you should investigate what is causing the model to continuously change during
-   * the `$onChanges` hook execution.
-   *
-   * Increasing the TTL could have performance implications, so you should not change it without proper justification.
-   *
-   * @param {number} limit The number of `$onChanges` hook iterations.
-   * @returns {number|object} the current limit (or `this` if called as a setter for chaining)
-   */
-  this.onChangesTtl = function (value) {
-    if (arguments.length) {
-      config.TTL = value;
-      return this;
-    }
-    return config.TTL;
-  };
-
   /**
    * The security context of DOM Properties.
    * @private
@@ -686,13 +661,13 @@ export function $CompileProvider($provide, $$sanitizeUriProvider) {
       // This function is called in a $$postDigest to trigger all the onChanges hooks in a single digest
       function flushOnChangesQueue() {
         try {
-          if (!--config.TTL) {
+          if (!--TTL) {
             // We have hit the TTL limit so reset everything
             onChangesQueue = undefined;
             throw $compileMinErr(
               "infchng",
               "{0} $onChanges() iterations reached. Aborting!\n",
-              config.TTL,
+              TTL,
             );
           }
           // We must run this hook in an apply since the $$postDigest runs outside apply
@@ -708,7 +683,7 @@ export function $CompileProvider($provide, $$sanitizeUriProvider) {
             onChangesQueue = undefined;
           });
         } finally {
-          config.TTL++;
+          TTL++;
         }
       }
 
@@ -767,25 +742,20 @@ export function $CompileProvider($provide, $$sanitizeUriProvider) {
         return result;
       }
 
-      function Attributes(element, attributesToCopy) {
-        if (attributesToCopy) {
-          const keys = Object.keys(attributesToCopy);
-          let i;
-          let l;
-          let key;
-
-          for (i = 0, l = keys.length; i < l; i++) {
-            key = keys[i];
-            this[key] = attributesToCopy[key];
+      class Attributes {
+        constructor(element, attributesToCopy) {
+          if (attributesToCopy) {
+            const keys = Object.keys(attributesToCopy);
+            for (let i = 0, l = keys.length; i < l; i++) {
+              const key = keys[i];
+              this[key] = attributesToCopy[key];
+            }
+          } else {
+            this.$attr = {};
           }
-        } else {
-          this.$attr = {};
+          this.$$element = element;
         }
 
-        this.$$element = element;
-      }
-
-      Attributes.prototype = {
         /**
          * @ngdoc method
          * @name $compile.directive.Attributes#$normalize
@@ -801,7 +771,7 @@ export function $CompileProvider($provide, $$sanitizeUriProvider) {
          *
          * @param {string} name Name to normalize
          */
-        $normalize: directiveNormalize,
+        $normalize = directiveNormalize;
 
         /**
          * @ngdoc method
@@ -818,7 +788,7 @@ export function $CompileProvider($provide, $$sanitizeUriProvider) {
           if (classVal && classVal.length > 0) {
             $animate.addClass(this.$$element, classVal);
           }
-        },
+        }
 
         /**
          * @ngdoc method
@@ -835,7 +805,7 @@ export function $CompileProvider($provide, $$sanitizeUriProvider) {
           if (classVal && classVal.length > 0) {
             $animate.removeClass(this.$$element, classVal);
           }
-        },
+        }
 
         /**
          * @ngdoc method
@@ -859,7 +829,7 @@ export function $CompileProvider($provide, $$sanitizeUriProvider) {
           if (toRemove && toRemove.length) {
             $animate.removeClass(this.$$element, toRemove);
           }
-        },
+        }
 
         /**
          * Set a normalized attribute on the element in a way such that all directives
@@ -910,6 +880,7 @@ export function $CompileProvider($provide, $$sanitizeUriProvider) {
           if (writeAttr !== false) {
             if (value === null || isUndefined(value)) {
               this.$$element[0].removeAttribute(attrName);
+              //
             } else if (SIMPLE_ATTR_NAME.test(attrName)) {
               // jQuery skips special boolean attrs treatment in XML nodes for
               // historical reasons and hence AngularJS cannot freely call
@@ -937,9 +908,9 @@ export function $CompileProvider($provide, $$sanitizeUriProvider) {
               }
             });
           }
-        },
+        }
 
-        /**
+      /**
        * @ngdoc method
        * @name $compile.directive.Attributes#$observe
        * @kind function
@@ -959,28 +930,27 @@ export function $CompileProvider($provide, $$sanitizeUriProvider) {
        * @returns {function()} Returns a deregistration function for this observer.
        */
         $observe(key, fn) {
-          const attrs = this;
           const $$observers =
-            attrs.$$observers || (attrs.$$observers = createMap());
+            this.$$observers || (this.$$observers = createMap());
           const listeners = $$observers[key] || ($$observers[key] = []);
 
           listeners.push(fn);
           $rootScope.$evalAsync(() => {
             if (
               !listeners.$$inter &&
-              Object.prototype.hasOwnProperty.call(attrs, key) &&
-              !isUndefined(attrs[key])
+              Object.prototype.hasOwnProperty.call(this, key) &&
+              !isUndefined(this[key])
             ) {
               // no one registered attribute interpolation function, so lets call it manually
-              fn(attrs[key]);
+              fn(this[key]);
             }
           });
 
           return function () {
             arrayRemove(listeners, fn);
           };
-        },
-      };
+        }
+      }
 
       function setSpecialAttr(element, attrName, value) {
         // Attributes names that do not start with letters (such as `(click)`) cannot be set using `setAttribute`
@@ -995,15 +965,6 @@ export function $CompileProvider($provide, $$sanitizeUriProvider) {
         element.attributes.setNamedItem(attribute);
       }
 
-      function safeAddClass($element, className) {
-        try {
-          $element[0].classList.add(className);
-        } catch (e) {
-          // ignore, since it means that we are trying to set class on
-          // SVG element, where class name is read-only.
-        }
-      }
-
       const startSymbol = $interpolate.startSymbol();
       const endSymbol = $interpolate.endSymbol();
       const denormalizeTemplate =
@@ -1018,7 +979,7 @@ export function $CompileProvider($provide, $$sanitizeUriProvider) {
       const MULTI_ELEMENT_DIR_RE = /^(.+)Start$/;
 
       compile.$$addScopeInfo = debugInfoEnabled
-        ? function $$addScopeInfo($element, scope, isolated, noTemplate) {
+        ? ($element, scope, isolated, noTemplate) => {
             const dataName = isolated
               ? noTemplate
                 ? "$isolateScopeNoTemplate"
@@ -1028,19 +989,19 @@ export function $CompileProvider($provide, $$sanitizeUriProvider) {
           }
         : () => {};
 
-      compile.$$createComment = function (directiveName, comment) {
-        let content = "";
-        if (debugInfoEnabled) {
-          content = ` ${directiveName || ""}: `;
-          if (comment) content += `${comment} `;
-        }
-        return window.document.createComment(content);
-      };
-
       return compile;
 
       //= ===============================
 
+      /**
+       *
+       * @param {string|NodeList} $compileNodes
+       * @param {*} transcludeFn
+       * @param {*} maxPriority
+       * @param {*} ignoreDirective
+       * @param {*} previousCompileContext
+       * @returns
+       */
       function compile(
         $compileNodes,
         transcludeFn,
@@ -1051,8 +1012,13 @@ export function $CompileProvider($provide, $$sanitizeUriProvider) {
         if (!($compileNodes instanceof jqLite)) {
           // jquery always rewraps, whereas we need to preserve the original selector so that we can
           // modify it.
+
           $compileNodes = jqLite($compileNodes);
         }
+
+        /**
+         * @type {CompositeLinkFn}
+         */
         let compositeLinkFn = compileNodes(
           $compileNodes,
           transcludeFn,
@@ -1168,7 +1134,7 @@ export function $CompileProvider($provide, $$sanitizeUriProvider) {
        * function, which is the a linking function for the node.
        *
        * @param {NodeList} nodeList an array of nodes or NodeList to compile
-       * @param {function(angular.Scope, cloneAttachFn=)} transcludeFn A linking function, where the
+       * @param {function(ng.IScope, cloneAttachFn=)} transcludeFn A linking function, where the
        *        scope argument is auto-generated to the new child of the transcluded parent scope.
        * @param {Element=} $rootElement If the nodeList is the root of the compilation tree then
        *        the rootElement must be set the jqLite collection of the compile root. This is
@@ -1268,8 +1234,7 @@ export function $CompileProvider($provide, $$sanitizeUriProvider) {
           if (nodeLinkFnFound) {
             // copy nodeList so that if a nodeLinkFn removes or adds an element at this DOM level our
             // offsets don't get screwed up
-            const nodeListLength = nodeList.length;
-            stableNodeList = new Array(nodeListLength);
+            stableNodeList = new Array(nodeList.length);
 
             // create a sparse array by only copying the elements which have a linkFn
             for (i = 0; i < linkFns.length; i += 3) {
@@ -1378,7 +1343,7 @@ export function $CompileProvider($provide, $$sanitizeUriProvider) {
        * Looks for directives on the given node and adds them to the directive collection which is
        * sorted.
        *
-       * @param node Node to search.
+       * @param {Element} node Node to search.
        * @param directives An array to which the directives are added to. This array is sorted before
        *        the function returns.
        * @param attrs The shared attrs object which is used to populate the normalized attributes.
@@ -1393,9 +1358,7 @@ export function $CompileProvider($provide, $$sanitizeUriProvider) {
       ) {
         const { nodeType } = node;
         const attrsMap = attrs.$attr;
-        let match;
         let nodeName;
-        let className;
 
         switch (nodeType) {
           case Node.ELEMENT_NODE /* Element */:
@@ -1528,9 +1491,9 @@ export function $CompileProvider($provide, $$sanitizeUriProvider) {
       /**
        * Given a node with a directive-start it collects all of the siblings until it finds
        * directive-end.
-       * @param node
-       * @param attrStart
-       * @param attrEnd
+       * @param {Element} node
+       * @param {string} attrStart
+       * @param {string} attrEnd
        * @returns {*}
        */
       function groupScan(node, attrStart, attrEnd) {
@@ -1551,7 +1514,7 @@ export function $CompileProvider($provide, $$sanitizeUriProvider) {
               if (node.hasAttribute(attrEnd)) depth--;
             }
             nodes.push(node);
-            node = node.nextSibling;
+            node = /** @type {Element} */ (node.nextSibling);
           } while (depth > 0);
         } else {
           nodes.push(node);
@@ -1801,10 +1764,7 @@ export function $CompileProvider($provide, $$sanitizeUriProvider) {
               terminalPriority = directive.priority;
               $template = $compileNode;
               $compileNode = templateAttrs.$$element = jqLite(
-                compile.$$createComment(
-                  directiveName,
-                  templateAttrs[directiveName],
-                ),
+                document.createComment(""),
               );
               compileNode = $compileNode[0];
               replaceWith(jqCollection, sliceArgs($template), compileNode);
@@ -2528,8 +2488,6 @@ export function $CompileProvider($provide, $$sanitizeUriProvider) {
        *
        *   * `E`: element name
        *   * `A': attribute
-       *   * `C`: class
-       *   * `M`: comment
        * @returns {boolean} true if directive was added.
        */
       function addDirective(
@@ -2782,7 +2740,14 @@ export function $CompileProvider($provide, $$sanitizeUriProvider) {
                 );
 
                 // Copy in CSS classes from original node
-                safeAddClass(jqLite(linkNode), oldClasses);
+                try {
+                  if (oldClasses !== "") {
+                    linkNode.classList.add(oldClasses);
+                  }
+                } catch (e) {
+                  // ignore, since it means that we are trying to set class on
+                  // SVG element, where class name is read-only.
+                }
               }
               if (afterTemplateNodeLinkFn.transcludeOnThisElement) {
                 childBoundTranscludeFn = createBoundTranscludeFn(

package/src/directive/if.js

@@ -80,8 +80,7 @@ import { getBlockNodes } from "../jqLite";
  */
 export const ngIfDirective = [
   "$animate",
-  "$compile",
-  ($animate, $compile) => ({
+  ($animate) => ({
     multiElement: true,
     transclude: "element",
     priority: 600,
@@ -97,11 +96,7 @@ export const ngIfDirective = [
           if (!childScope) {
             $transclude((clone, newScope) => {
               childScope = newScope;
-              // eslint-disable-next-line no-plusplus, no-param-reassign
-              clone[clone.length++] = $compile.$$createComment(
-                "end ngIf",
-                $attr.ngIf,
-              );
+              clone[clone.length++] = document.createComment("");
               // Note: We only need the first/last node of the cloned nodes.
               // However, we need to keep the reference to the jqlite wrapper as it might be changed later
               // by a directive with templateUrl when its template arrives.