@angular-eslint/eslint-plugin 22.6.1-alpha.1 → 22.6.1-alpha.3

package/dist/index.d.ts

@@ -45,7 +45,7 @@ declare const _default: {
         "no-empty-lifecycle-method": import("@typescript-eslint/utils/ts-eslint").RuleModule<import("./rules/no-empty-lifecycle-method").MessageIds, [], import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener> & {
             name: string;
         };
-        "no-experimental": import("@typescript-eslint/utils/ts-eslint").RuleModule<"noExperimental", [], import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener> & {
+        "no-experimental": import("@typescript-eslint/utils/ts-eslint").RuleModule<"noExperimental", import("./rules/no-experimental").Options, import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener> & {
             name: string;
         };
         "no-forward-ref": import("@typescript-eslint/utils/ts-eslint").RuleModule<"noForwardRef", [], import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener> & {

package/dist/rules/no-experimental.d.ts

@@ -1,7 +1,11 @@
-export type Options = [];
+export type Options = [
+    {
+        readonly ignorePackages?: readonly string[];
+    }
+];
 export type MessageIds = 'noExperimental';
 export declare const RULE_NAME = "no-experimental";
-declare const _default: import("@typescript-eslint/utils/eslint-utils").RuleModule<"noExperimental", [], import("../utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/eslint-utils").RuleListener> & {
+declare const _default: import("@typescript-eslint/utils/eslint-utils").RuleModule<"noExperimental", Options, import("../utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/eslint-utils").RuleListener> & {
     name: string;
 };
 export default _default;

package/dist/rules/no-experimental.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"no-experimental.d.ts","sourceRoot":"","sources":["../../src/rules/no-experimental.ts"],"names":[],"mappings":"AASA,MAAM,MAAM,OAAO,GAAG,EAAE,CAAC;AACzB,MAAM,MAAM,UAAU,GAAG,gBAAgB,CAAC;AAC1C,eAAO,MAAM,SAAS,oBAAoB,CAAC;;;;AAE3C,wBAsCG;AAEH,eAAO,MAAM,mBAAmB;;CAE/B,CAAC"}
+{"version":3,"file":"no-experimental.d.ts","sourceRoot":"","sources":["../../src/rules/no-experimental.ts"],"names":[],"mappings":"AAUA,MAAM,MAAM,OAAO,GAAG;IACpB;QACE,QAAQ,CAAC,cAAc,CAAC,EAAE,SAAS,MAAM,EAAE,CAAC;KAC7C;CACF,CAAC;AACF,MAAM,MAAM,UAAU,GAAG,gBAAgB,CAAC;AAC1C,eAAO,MAAM,SAAS,oBAAoB,CAAC;;;;AA6E3C,wBA0DG;AAEH,eAAO,MAAM,mBAAmB;;CAE/B,CAAC"}

package/dist/rules/no-experimental.js

@@ -5,6 +5,52 @@ const create_eslint_rule_1 = require("../utils/create-eslint-rule");
 const eslint_utils_1 = require("@typescript-eslint/utils/eslint-utils");
 const jsdoc_1 = require("../utils/jsdoc");
 exports.RULE_NAME = 'no-experimental';
+const NODE_MODULES_SEGMENT = '/node_modules/';
+/**
+ * Returns the name of the npm package that owns the given file, based on the
+ * segment(s) after the last `node_modules` directory in its path, or
+ * `undefined` if the file is not inside `node_modules`.
+ *
+ * Using the last `node_modules` directory means that nested installs
+ * (`node_modules/a/node_modules/b/...`) and pnpm's layout
+ * (`node_modules/.pnpm/b@1.0.0/node_modules/b/...`) both resolve to `b`.
+ */
+function getOwningPackageName(fileName) {
+    const normalizedFileName = `/${fileName.replace(/\\/g, '/')}`;
+    const index = normalizedFileName.lastIndexOf(NODE_MODULES_SEGMENT);
+    if (index === -1) {
+        return undefined;
+    }
+    const [first, second] = normalizedFileName
+        .slice(index + NODE_MODULES_SEGMENT.length)
+        .split('/');
+    if (!first) {
+        return undefined;
+    }
+    if (first.startsWith('@')) {
+        return second ? `${first}/${second}` : undefined;
+    }
+    return first;
+}
+function isFileFromIgnoredPackage(fileName, ignorePackages) {
+    const packageName = getOwningPackageName(fileName);
+    return packageName !== undefined && ignorePackages.includes(packageName);
+}
+function shouldIgnoreDueToPackages(symbols, ignorePackages) {
+    if (ignorePackages.length === 0) {
+        return false;
+    }
+    const experimentalSymbols = symbols.filter((symbol) => symbol?.getJsDocTags().some((tag) => tag.name === 'experimental'));
+    return (experimentalSymbols.length > 0 &&
+        experimentalSymbols.every((symbol) => {
+            if (symbol === undefined) {
+                return false;
+            }
+            const declarations = symbol.getDeclarations() ?? [];
+            return (declarations.length > 0 &&
+                declarations.every((declaration) => isFileFromIgnoredPackage(declaration.getSourceFile().fileName, ignorePackages)));
+        }));
+}
 exports.default = (0, create_eslint_rule_1.createESLintRule)({
     name: exports.RULE_NAME,
     meta: {
@@ -12,13 +58,28 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
         docs: {
             description: `Disallow using code which is marked as experimental`,
         },
-        schema: [],
+        schema: [
+            {
+                type: 'object',
+                properties: {
+                    ignorePackages: {
+                        type: 'array',
+                        items: {
+                            type: 'string',
+                        },
+                        description: 'npm package names whose experimental APIs should not be reported. Each entry must be the name of the package that declares the experimental API, wherever it is installed (including nested `node_modules` and pnpm layouts). An API that one package re-exports from another is only ignored when the declaring package is listed, for example `@vitest/browser` (not `vitest`) for Vitest browser APIs imported from `vitest/browser`. Type-only packages such as `@types/foo` must be listed by their own name.',
+                        uniqueItems: true,
+                    },
+                },
+                additionalProperties: false,
+            },
+        ],
         messages: {
             noExperimental: '`{{name}}` is experimental',
         },
-        defaultOptions: [],
+        defaultOptions: [{ ignorePackages: [] }],
     },
-    create(context) {
+    create(context, [{ ignorePackages = [] }]) {
         const services = (0, eslint_utils_1.getParserServices)(context);
         const checker = services.program.getTypeChecker();
         return {
@@ -30,6 +91,9 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
                 if (!(0, jsdoc_1.hasJsDocTag)(symbols, 'experimental')) {
                     return;
                 }
+                if (shouldIgnoreDueToPackages(symbols, ignorePackages)) {
+                    return;
+                }
                 const { name } = node;
                 context.report({
                     node,

package/dist/rules/no-input-prefix.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"no-input-prefix.d.ts","sourceRoot":"","sources":["../../src/rules/no-input-prefix.ts"],"names":[],"mappings":"AAQA,MAAM,MAAM,OAAO,GAAG,CAAC;IAAE,QAAQ,CAAC,QAAQ,EAAE,SAAS,MAAM,EAAE,CAAA;CAAE,CAAC,CAAC;AACjE,MAAM,MAAM,UAAU,GAAG,eAAe,CAAC;AACzC,eAAO,MAAM,SAAS,oBAAoB,CAAC;;;;AAE3C,wBAwIG;AAWH,eAAO,MAAM,mBAAmB;;CAG/B,CAAC"}
+{"version":3,"file":"no-input-prefix.d.ts","sourceRoot":"","sources":["../../src/rules/no-input-prefix.ts"],"names":[],"mappings":"AAQA,MAAM,MAAM,OAAO,GAAG,CAAC;IAAE,QAAQ,CAAC,QAAQ,EAAE,SAAS,MAAM,EAAE,CAAA;CAAE,CAAC,CAAC;AACjE,MAAM,MAAM,UAAU,GAAG,eAAe,CAAC;AACzC,eAAO,MAAM,SAAS,oBAAoB,CAAC;;;;AAE3C,wBA4JG;AAWH,eAAO,MAAM,mBAAmB;;CAG/B,CAAC"}

package/dist/rules/no-input-prefix.js

@@ -90,6 +90,20 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
                     });
                 }
             },
+            [utils_1.Selectors.SIGNAL_INPUT_OR_MODEL_ALIAS](node) {
+                const aliasName = utils_1.ASTUtils.getRawText(node);
+                const hasDisallowedPrefix = prefixes.some((prefix) => isDisallowedPrefix(prefix, aliasName));
+                if (!hasDisallowedPrefix) {
+                    return;
+                }
+                context.report({
+                    node,
+                    messageId: 'noInputPrefix',
+                    data: {
+                        prefixes: (0, utils_1.toHumanReadableText)(prefixes),
+                    },
+                });
+            },
             [utils_1.Selectors.INPUTS_METADATA_PROPERTY_LITERAL](node) {
                 const [propertyName, aliasName] = utils_1.ASTUtils.getRawText(node)
                     .replace(/\s/g, '')

package/dist/rules/reactive-context-must-read-signal.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"reactive-context-must-read-signal.d.ts","sourceRoot":"","sources":["../../src/rules/reactive-context-must-read-signal.ts"],"names":[],"mappings":"AAAA,OAAO,EAEL,WAAW,EAGZ,MAAM,0BAA0B,CAAC;AAMlC,MAAM,MAAM,OAAO,GAAG;IACpB;QACE,QAAQ,CAAC,cAAc,CAAC,EAAE,OAAO,CAAC;KACnC;CACF,CAAC;AACF,MAAM,MAAM,UAAU,GAAG,gBAAgB,CAAC;AAC1C,eAAO,MAAM,SAAS,sCAAsC,CAAC;;;;AA8D7D,wBA2VG;AAEH,eAAO,MAAM,mBAAmB;;CAG/B,CAAC"}
+{"version":3,"file":"reactive-context-must-read-signal.d.ts","sourceRoot":"","sources":["../../src/rules/reactive-context-must-read-signal.ts"],"names":[],"mappings":"AAAA,OAAO,EAEL,WAAW,EAGZ,MAAM,0BAA0B,CAAC;AAMlC,MAAM,MAAM,OAAO,GAAG;IACpB;QACE,QAAQ,CAAC,cAAc,CAAC,EAAE,OAAO,CAAC;KACnC;CACF,CAAC;AACF,MAAM,MAAM,UAAU,GAAG,gBAAgB,CAAC;AAC1C,eAAO,MAAM,SAAS,sCAAsC,CAAC;;;;AA8D7D,wBAgWG;AAEH,eAAO,MAAM,mBAAmB;;CAG/B,CAAC"}

package/dist/rules/reactive-context-must-read-signal.js

@@ -186,6 +186,11 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
             }
             if (!symbol ||
                 !isDeclaredInDefaultLib(symbol) ||
+                // `fn.call()` and `fn.apply()` run `fn`, which can read a signal.
+                // Any other standard library `call`/`apply`, such as `Reflect.apply()`,
+                // also runs a function it is given.
+                symbol.name === 'call' ||
+                symbol.name === 'apply' ||
                 args.some(isOpaqueFunctionValue)) {
                 analysis.hasUnknown = true;
             }
@@ -351,5 +356,5 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
     },
 });
 exports.RULE_DOCS_EXTENSION = {
-    rationale: 'Reactive contexts like `computed()`, `linkedSignal()`, `effect()` and `afterRenderEffect()` re-run whenever a signal they read changes. If the relevant function never reads a signal, the context runs once and can never react to anything, so it adds overhead without providing reactivity. This is usually a mistake: either the developer forgot to call a signal (e.g. wrote `firstName` instead of `firstName()`), or the value is actually static and should be a plain constant, a `signal()`, or an `afterNextRender()` in the case of `afterRenderEffect()`. To avoid false positives, the rule only reports when everything the tracked function does is known not to read a signal. Calls into the TypeScript standard library (arrays, strings, `Math`, `JSON`, `console`, DOM APIs, etc.) are known to be safe; anything else keeps the rule silent, including a helper function, a service method, a getter, an unresolved symbol, and any Angular API such as `untracked()`. One known limitation: a standard library call that reaches user code through a protocol method, such as `toJSON()` in `JSON.stringify()` or `toString()` in a template literal, is still treated as safe, so a signal read inside such a method is not detected. For `resource()`/`rxResource()` only the `params` function defines the dependencies, and these are opt-in via the `checkResources` option.',
+    rationale: 'Reactive contexts like `computed()`, `linkedSignal()`, `effect()` and `afterRenderEffect()` re-run whenever a signal they read changes. If the relevant function never reads a signal, the context runs once and can never react to anything, so it adds overhead without providing reactivity. This is usually a mistake: either the developer forgot to call a signal (e.g. wrote `firstName` instead of `firstName()`), or the value is actually static and should be a plain constant, a `signal()`, or an `afterNextRender()` in the case of `afterRenderEffect()`. To avoid false positives, the rule only reports when everything the tracked function does is known not to read a signal. Calls into the TypeScript standard library (arrays, strings, `Math`, `JSON`, `console`, DOM APIs, etc.) are known to be safe, except `call()` and `apply()`, which run the function they are called on. Anything else keeps the rule silent, including a helper function, a service method, a getter, an unresolved symbol, and any Angular API such as `untracked()`. One known limitation: a standard library call that reaches user code through a protocol method, such as `toJSON()` in `JSON.stringify()` or `toString()` in a template literal, is still treated as safe, so a signal read inside such a method is not detected. For `resource()`/`rxResource()` only the `params` function defines the dependencies, and these are opt-in via the `checkResources` option.',
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@angular-eslint/eslint-plugin",
-  "version": "22.6.1-alpha.1",
+  "version": "22.6.1-alpha.3",
   "description": "ESLint plugin for Angular applications, following https://angular.dev/style-guide",
   "license": "MIT",
   "main": "dist/index.js",
@@ -19,12 +19,12 @@
     "LICENSE"
   ],
   "dependencies": {
-    "@angular-eslint/bundled-angular-compiler": "22.6.1-alpha.1",
-    "@angular-eslint/utils": "22.6.1-alpha.1",
+    "@angular-eslint/bundled-angular-compiler": "22.6.1-alpha.3",
+    "@angular-eslint/utils": "22.6.1-alpha.3",
     "ts-api-utils": "^2.1.0"
   },
   "devDependencies": {
-    "@angular-eslint/test-utils": "22.6.1-alpha.1"
+    "@angular-eslint/test-utils": "22.6.1-alpha.3"
   },
   "peerDependencies": {
     "@typescript-eslint/utils": "^8.0.0",