@angular-eslint/eslint-plugin 22.5.1-alpha.29 → 22.5.1-alpha.30

package/dist/rules/prefer-signal-model.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"prefer-signal-model.d.ts","sourceRoot":"","sources":["../../src/rules/prefer-signal-model.ts"],"names":[],"mappings":"AASA,OAAO,EAAkB,WAAW,EAAE,MAAM,0BAA0B,CAAC;AAIvE,KAAK,OAAO,GAAG;IACb;QACE,eAAe,EAAE,OAAO,CAAC;KAC1B;CACF,CAAC;AAMF,MAAM,MAAM,UAAU,GAAG,mBAAmB,CAAC;AAC7C,eAAO,MAAM,SAAS,wBAAwB,CAAC;;;;AA8B/C,wBAuKG;AAEH,eAAO,MAAM,mBAAmB;;CAG/B,CAAC"}
+{"version":3,"file":"prefer-signal-model.d.ts","sourceRoot":"","sources":["../../src/rules/prefer-signal-model.ts"],"names":[],"mappings":"AASA,OAAO,EAAkB,WAAW,EAAE,MAAM,0BAA0B,CAAC;AAIvE,KAAK,OAAO,GAAG;IACb;QACE,eAAe,EAAE,OAAO,CAAC;KAC1B;CACF,CAAC;AAMF,MAAM,MAAM,UAAU,GAAG,mBAAmB,CAAC;AAC7C,eAAO,MAAM,SAAS,wBAAwB,CAAC;;;;AA+C/C,wBAiMG;AAEH,eAAO,MAAM,mBAAmB;;CAG/B,CAAC"}

package/dist/rules/prefer-signal-model.js

@@ -12,6 +12,18 @@ const DEFAULT_OPTIONS = {
     useTypeChecking: false,
 };
 exports.RULE_NAME = 'prefer-signal-model';
+function getEmitCallee(reference) {
+    const { parent } = reference;
+    return parent?.type === utils_2.AST_NODE_TYPES.MemberExpression &&
+        parent.object === reference &&
+        !parent.computed &&
+        parent.property.type === utils_2.AST_NODE_TYPES.Identifier &&
+        parent.property.name === 'emit' &&
+        parent.parent?.type === utils_2.AST_NODE_TYPES.CallExpression &&
+        parent.parent.callee === parent
+        ? parent
+        : undefined;
+}
 function hasTransformOption(options) {
     return (options?.type === utils_2.AST_NODE_TYPES.ObjectExpression &&
         options.properties.some((property) => property.type === utils_2.AST_NODE_TYPES.Property &&
@@ -49,6 +61,7 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
         const { sourceCode } = context;
         const inputs = new Map();
         const outputs = new Map();
+        const thisReferences = new Map();
         let services;
         function getTypeServices() {
             return (services ??= utils_2.ESLintUtils.getParserServices(context));
@@ -114,32 +127,49 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
             "PropertyDefinition > CallExpression[callee.name='input']": createSignalCollector(inputs, { hasInitialValueArgument: true }),
             "PropertyDefinition > CallExpression[callee.object.name='input'][callee.property.name='required']": createSignalCollector(inputs, { hasInitialValueArgument: false }),
             "PropertyDefinition > CallExpression[callee.name='output']": createSignalCollector(outputs, { hasInitialValueArgument: false }),
+            'MemberExpression[object.type="ThisExpression"][computed=false][property.type="Identifier"]'(node) {
+                const { name } = node.property;
+                const references = thisReferences.get(name);
+                if (references) {
+                    references.push(node);
+                }
+                else {
+                    thisReferences.set(name, [node]);
+                }
+            },
             'ClassDeclaration:exit'() {
                 const twoWayBindings = [...inputs]
                     .map(([name, input]) => ({
+                    name,
                     input,
                     output: outputs.get(`${name}Change`),
                 }))
                     .filter((binding) => binding.output !== undefined &&
                     haveMergeableTypes(binding.input, binding.output));
-                for (const { input, output } of twoWayBindings) {
+                for (const { name, input, output } of twoWayBindings) {
+                    const emitCallees = (thisReferences.get(`${name}Change`) ?? []).map(getEmitCallee);
+                    const isRewritable = emitCallees.every(utils_1.isNotNullOrUndefined);
                     context.report({
                         node: input.property,
                         messageId: 'preferSignalModel',
-                        fix: (fixer) => [
-                            utils_1.RuleFixes.getImportAddFix({
-                                fixer,
-                                importName: 'model',
-                                moduleName: '@angular/core',
-                                node: input.property,
-                            }),
-                            fixer.replaceText(input.callee, 'model'),
-                            fixer.remove(output.property),
-                        ].filter(utils_1.isNotNullOrUndefined),
+                        fix: isRewritable
+                            ? (fixer) => [
+                                utils_1.RuleFixes.getImportAddFix({
+                                    fixer,
+                                    importName: 'model',
+                                    moduleName: '@angular/core',
+                                    node: input.property,
+                                }),
+                                fixer.replaceText(input.callee, 'model'),
+                                fixer.remove(output.property),
+                                ...emitCallees.map((callee) => fixer.replaceText(callee, `this.${name}.set`)),
+                            ].filter(utils_1.isNotNullOrUndefined)
+                            : undefined,
                     });
                 }
                 inputs.clear();
                 outputs.clear();
+                thisReferences.clear();
             },
         };
     },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@angular-eslint/eslint-plugin",
-  "version": "22.5.1-alpha.29",
+  "version": "22.5.1-alpha.30",
   "description": "ESLint plugin for Angular applications, following https://angular.dev/style-guide",
   "license": "MIT",
   "main": "dist/index.js",
@@ -19,12 +19,12 @@
     "LICENSE"
   ],
   "dependencies": {
-    "@angular-eslint/bundled-angular-compiler": "22.5.1-alpha.29",
-    "@angular-eslint/utils": "22.5.1-alpha.29",
+    "@angular-eslint/bundled-angular-compiler": "22.5.1-alpha.30",
+    "@angular-eslint/utils": "22.5.1-alpha.30",
     "ts-api-utils": "^2.1.0"
   },
   "devDependencies": {
-    "@angular-eslint/test-utils": "22.5.1-alpha.29"
+    "@angular-eslint/test-utils": "22.5.1-alpha.30"
   },
   "peerDependencies": {
     "@typescript-eslint/utils": "^8.0.0",