@angular-eslint/eslint-plugin 22.2.0 → 22.2.1-alpha.1

package/dist/rules/use-injectable-provided-in.d.ts

@@ -1,6 +1,9 @@
-export type Options = [{
-    readonly ignoreClassNamePattern?: string;
-}];
+export type Options = [
+    {
+        readonly ignoreClassNamePattern?: string;
+        readonly allowProvidedInNull?: boolean;
+    }
+];
 export type MessageIds = 'useInjectableProvidedIn' | 'suggestInjector';
 export declare const RULE_NAME = "use-injectable-provided-in";
 declare const _default: import("@typescript-eslint/utils/ts-eslint").RuleModule<MessageIds, Options, import("../utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener> & {

package/dist/rules/use-injectable-provided-in.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"use-injectable-provided-in.d.ts","sourceRoot":"","sources":["../../src/rules/use-injectable-provided-in.ts"],"names":[],"mappings":"AAIA,MAAM,MAAM,OAAO,GAAG,CAAC;IAAE,QAAQ,CAAC,sBAAsB,CAAC,EAAE,MAAM,CAAA;CAAE,CAAC,CAAC;AACrE,MAAM,MAAM,UAAU,GAAG,yBAAyB,GAAG,iBAAiB,CAAC;AACvE,eAAO,MAAM,SAAS,+BAA+B,CAAC;;;;AAGtD,wBA2DG;AAEH,eAAO,MAAM,mBAAmB;;CAE/B,CAAC"}
+{"version":3,"file":"use-injectable-provided-in.d.ts","sourceRoot":"","sources":["../../src/rules/use-injectable-provided-in.ts"],"names":[],"mappings":"AAIA,MAAM,MAAM,OAAO,GAAG;IACpB;QACE,QAAQ,CAAC,sBAAsB,CAAC,EAAE,MAAM,CAAC;QACzC,QAAQ,CAAC,mBAAmB,CAAC,EAAE,OAAO,CAAC;KACxC;CACF,CAAC;AACF,MAAM,MAAM,UAAU,GAAG,yBAAyB,GAAG,iBAAiB,CAAC;AACvE,eAAO,MAAM,SAAS,+BAA+B,CAAC;;;;AAMtD,wBAiEG;AAEH,eAAO,MAAM,mBAAmB;;CAE/B,CAAC"}

package/dist/rules/use-injectable-provided-in.js

@@ -5,6 +5,9 @@ const utils_1 = require("@angular-eslint/utils");
 const create_eslint_rule_1 = require("../utils/create-eslint-rule");
 exports.RULE_NAME = 'use-injectable-provided-in';
 const METADATA_PROPERTY_NAME = 'providedIn';
+const DEFAULT_OPTIONS = {
+    allowProvidedInNull: false,
+};
 exports.default = (0, create_eslint_rule_1.createESLintRule)({
     name: exports.RULE_NAME,
     meta: {
@@ -20,6 +23,10 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
                     ignoreClassNamePattern: {
                         type: 'string',
                     },
+                    allowProvidedInNull: {
+                        type: 'boolean',
+                        default: DEFAULT_OPTIONS.allowProvidedInNull,
+                    },
                 },
                 additionalProperties: false,
             },
@@ -29,15 +36,17 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
             suggestInjector: `Use \`${METADATA_PROPERTY_NAME}: '{{injector}}'\``,
         },
     },
-    defaultOptions: [{}],
-    create(context, [{ ignoreClassNamePattern }]) {
+    defaultOptions: [DEFAULT_OPTIONS],
+    create(context, [{ ignoreClassNamePattern, allowProvidedInNull }]) {
         const injectableClassDecorator = `ClassDeclaration:not([id.name=${ignoreClassNamePattern}]):not(:has(TSClassImplements:matches([expression.property.name='HttpInterceptor'], [expression.name='HttpInterceptor']))) > Decorator[expression.callee.name="Injectable"]`;
         const providedInMetadataProperty = utils_1.Selectors.metadataProperty(METADATA_PROPERTY_NAME);
         const withoutProvidedInDecorator = `${injectableClassDecorator}:matches([expression.arguments.length=0], [expression.arguments.0.type='ObjectExpression']:not(:has(${providedInMetadataProperty})))`;
-        const nullableProvidedInProperty = `${injectableClassDecorator} ${providedInMetadataProperty}:matches([value.type='Identifier'][value.name='undefined'], [value.type='Literal'][value.raw='null'])`;
+        const undefinedProvidedInProperty = `${injectableClassDecorator} ${providedInMetadataProperty}[value.type='Identifier'][value.name='undefined']`;
+        const nullProvidedInProperty = `${injectableClassDecorator} ${providedInMetadataProperty}[value.type='Literal'][value.raw='null']`;
         const selectors = [
             withoutProvidedInDecorator,
-            nullableProvidedInProperty,
+            undefinedProvidedInProperty,
+            ...(allowProvidedInNull ? [] : [nullProvidedInProperty]),
         ].join(',');
         return {
             [selectors](node) {
@@ -59,5 +68,5 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
     },
 });
 exports.RULE_DOCS_EXTENSION = {
-    rationale: `Using 'providedIn' in the @Injectable() decorator (like '@Injectable({ providedIn: "root" })') enables tree-shaking, which means Angular can remove the service from your production bundle if it's never actually used. Without 'providedIn', services must be registered in a module's providers array, and Angular must include them in the bundle even if they're unused. This can significantly increase bundle size. Additionally, 'providedIn' makes services easier to use (no need to add them to module providers) and makes circular dependencies less likely. The 'providedIn' syntax is the modern, recommended way to provide services.`,
+    rationale: `Using 'providedIn' in the @Injectable() decorator (like '@Injectable({ providedIn: "root" })') enables tree-shaking, which means Angular can remove the service from your production bundle if it's never actually used. Without 'providedIn', services must be registered in a module's providers array, and Angular must include them in the bundle even if they're unused. This can significantly increase bundle size. Additionally, 'providedIn' makes services easier to use (no need to add them to module providers) and makes circular dependencies less likely. The 'providedIn' syntax is the modern, recommended way to provide services. Angular treats 'providedIn: null' as equivalent to omitting the property, so it is flagged by default. Set 'allowProvidedInNull' to true if you need to permit this pattern.`,
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@angular-eslint/eslint-plugin",
-  "version": "22.2.0",
+  "version": "22.2.1-alpha.1",
   "description": "ESLint plugin for Angular applications, following https://angular.dev/style-guide",
   "license": "MIT",
   "main": "dist/index.js",
@@ -19,12 +19,12 @@
     "LICENSE"
   ],
   "dependencies": {
-    "ts-api-utils": "^2.1.0",
-    "@angular-eslint/bundled-angular-compiler": "22.2.0",
-    "@angular-eslint/utils": "22.2.0"
+    "@angular-eslint/bundled-angular-compiler": "22.2.1-alpha.1",
+    "@angular-eslint/utils": "22.2.1-alpha.1",
+    "ts-api-utils": "^2.1.0"
   },
   "devDependencies": {
-    "@angular-eslint/test-utils": "22.2.0"
+    "@angular-eslint/test-utils": "22.2.1-alpha.1"
   },
   "peerDependencies": {
     "@typescript-eslint/utils": "^8.0.0",