@angular-eslint/eslint-plugin 19.5.1-alpha.10 → 19.5.1-alpha.12

package/README.md

@@ -65,7 +65,7 @@ Please see https://github.com/angular-eslint/angular-eslint for full usage instr
 | [`no-pipe-impure`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/no-pipe-impure.md) | Disallows the declaration of impure pipes |  |  | :bulb: |
 | [`no-queries-metadata-property`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/no-queries-metadata-property.md) | Disallows usage of the `queries` metadata property. See more at https://angular.dev/style-guide#style-05-12. |  |  |  |
 | [`pipe-prefix`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/pipe-prefix.md) | Enforce consistent prefix for pipes. |  |  |  |
-| [`prefer-inject`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/prefer-inject.md) | Prefer using the inject() function over constructor parameter injection | :white_check_mark: |  |  |
+| [`prefer-inject`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/prefer-inject.md) | Prefer using the inject() function over constructor parameter injection |  |  |  |
 | [`prefer-on-push-component-change-detection`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/prefer-on-push-component-change-detection.md) | Ensures component's `changeDetection` is set to `ChangeDetectionStrategy.OnPush` |  |  | :bulb: |
 | [`prefer-output-emitter-ref`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/prefer-output-emitter-ref.md) | Use `OutputEmitterRef` instead of `@Output()` |  |  |  |
 | [`prefer-output-readonly`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/prefer-output-readonly.md) | Prefer to declare `@Output`, `OutputEmitterRef` and `OutputRef` as `readonly` since they are not supposed to be reassigned |  |  | :bulb: |

package/dist/configs/recommended.json

@@ -12,7 +12,6 @@
     "@angular-eslint/no-output-on-prefix": "error",
     "@angular-eslint/no-output-rename": "error",
     "@angular-eslint/no-outputs-metadata-property": "error",
-    "@angular-eslint/prefer-inject": "error",
     "@angular-eslint/prefer-standalone": "error",
     "@angular-eslint/use-pipe-transform-interface": "error",
     "@angular-eslint/use-lifecycle-interface": "warn"

package/dist/index.d.ts

@@ -62,7 +62,6 @@ declare const _default: {
                 "@angular-eslint/no-output-on-prefix": string;
                 "@angular-eslint/no-output-rename": string;
                 "@angular-eslint/no-outputs-metadata-property": string;
-                "@angular-eslint/prefer-inject": string;
                 "@angular-eslint/prefer-standalone": string;
                 "@angular-eslint/use-pipe-transform-interface": string;
                 "@angular-eslint/use-lifecycle-interface": string;

package/dist/index.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;AAkIA,kBAkDE"}
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;AAkIA,kBAkDE"}

package/dist/rules/prefer-inject.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"prefer-inject.d.ts","sourceRoot":"","sources":["../../src/rules/prefer-inject.ts"],"names":[],"mappings":"AAIA,MAAM,MAAM,OAAO,GAAG,EAAE,CAAC;AAEzB,MAAM,MAAM,UAAU,GAAG,cAAc,CAAC;AACxC,eAAO,MAAM,SAAS,kBAAkB,CAAC;;AAEzC,wBA8GG"}
+{"version":3,"file":"prefer-inject.d.ts","sourceRoot":"","sources":["../../src/rules/prefer-inject.ts"],"names":[],"mappings":"AAIA,MAAM,MAAM,OAAO,GAAG,EAAE,CAAC;AAEzB,MAAM,MAAM,UAAU,GAAG,cAAc,CAAC;AACxC,eAAO,MAAM,SAAS,kBAAkB,CAAC;;AAEzC,wBAiGG"}

package/dist/rules/prefer-inject.js

@@ -11,7 +11,6 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
         type: 'suggestion',
         docs: {
             description: 'Prefer using the inject() function over constructor parameter injection',
-            recommended: 'recommended',
         },
         schema: [],
         messages: {
@@ -68,19 +67,10 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
         }
         return {
             [`${utils_1.Selectors.decoratorDefinition(angularDecoratorsPattern)} > ClassBody > MethodDefinition[kind="constructor"]`](node) {
-                const params = node.value.params;
+                const params = node.value.params ?? [];
                 if (params.length === 0) {
                     return;
                 }
-                // ignore constructors that only call super() (no parameters to inject)
-                const body = node.value.body?.body ?? [];
-                const onlySuper = body.length === 1 &&
-                    body[0].type === utils_2.AST_NODE_TYPES.ExpressionStatement &&
-                    body[0].expression.type === utils_2.AST_NODE_TYPES.CallExpression &&
-                    body[0].expression.callee.type === utils_2.AST_NODE_TYPES.Super;
-                if (onlySuper && params.length === 0) {
-                    return;
-                }
                 for (const param of params) {
                     if (shouldReportParameter(param)) {
                         context.report({ node: param, messageId: 'preferInject' });

package/dist/rules/use-lifecycle-interface.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"use-lifecycle-interface.d.ts","sourceRoot":"","sources":["../../src/rules/use-lifecycle-interface.ts"],"names":[],"mappings":"AASA,MAAM,MAAM,OAAO,GAAG,EAAE,CAAC;AACzB,MAAM,MAAM,UAAU,GAAG,uBAAuB,CAAC;AACjD,eAAO,MAAM,SAAS,4BAA4B,CAAC;;AAGnD,wBAgEG"}
+{"version":3,"file":"use-lifecycle-interface.d.ts","sourceRoot":"","sources":["../../src/rules/use-lifecycle-interface.ts"],"names":[],"mappings":"AASA,MAAM,MAAM,OAAO,GAAG,EAAE,CAAC;AACzB,MAAM,MAAM,UAAU,GAAG,uBAAuB,CAAC;AACjD,eAAO,MAAM,SAAS,4BAA4B,CAAC;;AAGnD,wBAyEG"}

package/dist/rules/use-lifecycle-interface.js

@@ -24,9 +24,14 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
             ...utils_1.ASTUtils.ANGULAR_LIFECYCLE_METHODS,
         ]);
         return {
-            [`MethodDefinition[key.name=${angularLifecycleMethodsPattern}]`]({ key, parent: { parent }, }) {
+            [`MethodDefinition[key.name=${angularLifecycleMethodsPattern}]`](node) {
+                const { key, parent: { parent }, } = node;
                 if (!utils_1.ASTUtils.getAngularClassDecorator(parent))
                     return;
+                // Do not report the method if it has the override keyword because it implies the base class is responsible for the implementation
+                if (node.override) {
+                    return;
+                }
                 const declaredLifecycleInterfaces = utils_1.ASTUtils.getDeclaredAngularLifecycleInterfaces(parent);
                 const methodName = key
                     .name;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@angular-eslint/eslint-plugin",
-  "version": "19.5.1-alpha.10",
+  "version": "19.5.1-alpha.12",
   "description": "ESLint plugin for Angular applications, following https://angular.dev/style-guide",
   "license": "MIT",
   "main": "dist/index.js",
@@ -18,11 +18,11 @@
     "LICENSE"
   ],
   "dependencies": {
-    "@angular-eslint/bundled-angular-compiler": "19.5.1-alpha.10",
-    "@angular-eslint/utils": "19.5.1-alpha.10"
+    "@angular-eslint/bundled-angular-compiler": "19.5.1-alpha.12",
+    "@angular-eslint/utils": "19.5.1-alpha.12"
   },
   "devDependencies": {
-    "@angular-eslint/test-utils": "19.5.1-alpha.10"
+    "@angular-eslint/test-utils": "19.5.1-alpha.12"
   },
   "peerDependencies": {
     "@typescript-eslint/utils": "^7.11.0 || ^8.0.0",