@angular-eslint/eslint-plugin 19.0.0-alpha.5 → 19.0.0

package/README.md

@@ -66,7 +66,7 @@ Please see https://github.com/angular-eslint/angular-eslint for full usage instr
 | [`pipe-prefix`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/pipe-prefix.md) | Enforce consistent prefix for pipes. |  |  |  |
 | [`prefer-on-push-component-change-detection`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/prefer-on-push-component-change-detection.md) | Ensures component's `changeDetection` is set to `ChangeDetectionStrategy.OnPush` |  |  | :bulb: |
 | [`prefer-output-readonly`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/prefer-output-readonly.md) | Prefer to declare `@Output`, `OutputEmitterRef` and `OutputRef` as `readonly` since they are not supposed to be reassigned |  |  | :bulb: |
-| [`prefer-standalone`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/prefer-standalone.md) | Ensures component, directive and pipe `standalone` property is set to `true` in the component decorator | :white_check_mark: | :wrench: |  |
+| [`prefer-standalone`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/prefer-standalone.md) | Ensures Components, Directives and Pipes do not opt out of standalone | :white_check_mark: | :wrench: |  |
 | [`relative-url-prefix`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/relative-url-prefix.md) | The ./ and ../ prefix is standard syntax for relative URLs; don't depend on Angular's current ability to do without that prefix. See more at https://angular.dev/style-guide#style-05-04 |  |  |  |
 | [`require-localize-metadata`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/require-localize-metadata.md) | Ensures that $localize tagged messages contain helpful metadata to aid with translations. |  |  |  |
 | [`runtime-localize`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/runtime-localize.md) | Ensures that $localize tagged messages can use runtime-loaded translations. |  |  |  |

package/dist/rules/prefer-standalone.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"prefer-standalone.d.ts","sourceRoot":"","sources":["../../src/rules/prefer-standalone.ts"],"names":[],"mappings":"AASA,MAAM,MAAM,OAAO,GAAG,EAAE,CAAC;AAEzB,MAAM,MAAM,UAAU,GAAG,kBAAkB,CAAC;AAC5C,eAAO,MAAM,SAAS,sBAAsB,CAAC;;AAI7C,wBAkEG"}
+{"version":3,"file":"prefer-standalone.d.ts","sourceRoot":"","sources":["../../src/rules/prefer-standalone.ts"],"names":[],"mappings":"AAIA,MAAM,MAAM,OAAO,GAAG,EAAE,CAAC;AAEzB,MAAM,MAAM,UAAU,GAAG,kBAAkB,CAAC;AAC5C,eAAO,MAAM,SAAS,sBAAsB,CAAC;;AAE7C,wBA6DG"}

package/dist/rules/prefer-standalone.js

@@ -4,26 +4,25 @@ exports.RULE_NAME = void 0;
 const utils_1 = require("@angular-eslint/utils");
 const create_eslint_rule_1 = require("../utils/create-eslint-rule");
 exports.RULE_NAME = 'prefer-standalone';
-const METADATA_PROPERTY_NAME = 'standalone';
-const IS_STANDALONE = 'true';
 exports.default = (0, create_eslint_rule_1.createESLintRule)({
     name: exports.RULE_NAME,
     meta: {
         type: 'suggestion',
         docs: {
-            description: `Ensures component, directive and pipe \`${METADATA_PROPERTY_NAME}\` property is set to \`${IS_STANDALONE}\` in the component decorator`,
+            description: `Ensures Components, Directives and Pipes do not opt out of standalone`,
             recommended: 'recommended',
         },
         fixable: 'code',
         schema: [],
         messages: {
-            preferStandalone: `The {{type}} \`${METADATA_PROPERTY_NAME}\` property should be set to \`${IS_STANDALONE}\``,
+            preferStandalone: `Components, Directives and Pipes should not opt out of standalone`,
         },
     },
     defaultOptions: [],
     create(context) {
         const standaloneRuleFactory = (type) => (node) => {
-            const standalone = utils_1.ASTUtils.getDecoratorPropertyValue(node, METADATA_PROPERTY_NAME);
+            const standalone = utils_1.ASTUtils.getDecoratorPropertyValue(node, 'standalone');
+            // Leave the standalone property alone if it was set to true or not present
             if (!standalone ||
                 (utils_1.ASTUtils.isLiteral(standalone) && standalone.value === true)) {
                 return;
@@ -36,14 +35,15 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
                 messageId: 'preferStandalone',
                 data: { type },
                 fix: (fixer) => {
-                    if (standalone &&
-                        utils_1.ASTUtils.isLiteral(standalone) &&
-                        standalone.value !== true) {
-                        return [fixer.replaceText(standalone, IS_STANDALONE)].filter(utils_1.isNotNullOrUndefined);
+                    // Remove the standalone property altogether if it was set to false
+                    const tokenAfter = context.sourceCode.getTokenAfter(standalone.parent);
+                    // Remove the trailing comma, if present
+                    const removeStart = standalone.parent.range[0];
+                    let removeEnd = standalone.parent.range[1];
+                    if (tokenAfter && tokenAfter.value === ',') {
+                        removeEnd = tokenAfter.range[1];
                     }
-                    return [
-                        utils_1.RuleFixes.getDecoratorPropertyAddFix(node, fixer, `${METADATA_PROPERTY_NAME}: ${IS_STANDALONE}`),
-                    ].filter(utils_1.isNotNullOrUndefined);
+                    return fixer.removeRange([removeStart, removeEnd]);
                 },
             });
         };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@angular-eslint/eslint-plugin",
-  "version": "19.0.0-alpha.5",
+  "version": "19.0.0",
   "description": "ESLint plugin for Angular applications, following https://angular.dev/style-guide",
   "license": "MIT",
   "main": "dist/index.js",
@@ -18,11 +18,11 @@
     "LICENSE"
   ],
   "dependencies": {
-    "@angular-eslint/bundled-angular-compiler": "19.0.0-alpha.5",
-    "@angular-eslint/utils": "19.0.0-alpha.5"
+    "@angular-eslint/bundled-angular-compiler": "19.0.0",
+    "@angular-eslint/utils": "19.0.0"
   },
   "devDependencies": {
-    "@angular-eslint/test-utils": "19.0.0-alpha.5"
+    "@angular-eslint/test-utils": "19.0.0"
   },
   "peerDependencies": {
     "@typescript-eslint/utils": "^7.11.0 || ^8.0.0",

package/dist/rules/no-host-metadata-property.d.ts

@@ -1,8 +0,0 @@
-export type Options = [{
-    readonly allowStatic?: boolean;
-}];
-export type MessageIds = 'noHostMetadataProperty';
-export declare const RULE_NAME = "no-host-metadata-property";
-declare const _default: import("@typescript-eslint/utils/ts-eslint").RuleModule<"noHostMetadataProperty", Options, import("../utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
-export default _default;
-//# sourceMappingURL=no-host-metadata-property.d.ts.map

package/dist/rules/no-host-metadata-property.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"no-host-metadata-property.d.ts","sourceRoot":"","sources":["../../src/rules/no-host-metadata-property.ts"],"names":[],"mappings":"AAKA,MAAM,MAAM,OAAO,GAAG,CAAC;IAAE,QAAQ,CAAC,WAAW,CAAC,EAAE,OAAO,CAAA;CAAE,CAAC,CAAC;AAC3D,MAAM,MAAM,UAAU,GAAG,wBAAwB,CAAC;AAClD,eAAO,MAAM,SAAS,8BAA8B,CAAC;;AAIrD,wBA4CG"}

package/dist/rules/no-host-metadata-property.js

@@ -1,67 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.RULE_NAME = void 0;
-const utils_1 = require("@angular-eslint/utils");
-const utils_2 = require("@typescript-eslint/utils");
-const create_eslint_rule_1 = require("../utils/create-eslint-rule");
-exports.RULE_NAME = 'no-host-metadata-property';
-const DEFAULT_OPTIONS = { allowStatic: false };
-const METADATA_PROPERTY_NAME = 'host';
-exports.default = (0, create_eslint_rule_1.createESLintRule)({
-    name: exports.RULE_NAME,
-    meta: {
-        type: 'suggestion',
-        deprecated: true,
-        docs: {
-            description: `Disallows usage of the \`${METADATA_PROPERTY_NAME}\` metadata property. NOTE: This used to be recommended by the Angular Team, but now they recommend the exact opposite: https://github.com/angular/angular/issues/54284`,
-        },
-        schema: [
-            {
-                type: 'object',
-                properties: {
-                    allowStatic: {
-                        type: 'boolean',
-                        default: DEFAULT_OPTIONS.allowStatic,
-                    },
-                },
-                additionalProperties: false,
-            },
-        ],
-        messages: {
-            noHostMetadataProperty: `Use @${utils_1.ASTUtils.AngularInnerClassDecorators.HostBinding} or @${utils_1.ASTUtils.AngularInnerClassDecorators.HostListener} rather than the \`${METADATA_PROPERTY_NAME}\` metadata property`,
-        },
-    },
-    defaultOptions: [DEFAULT_OPTIONS],
-    create(context, [{ allowStatic }]) {
-        return {
-            [`${utils_1.Selectors.COMPONENT_OR_DIRECTIVE_CLASS_DECORATOR} Property[key.name="${METADATA_PROPERTY_NAME}"]`](node) {
-                const properties = allowStatic && utils_1.ASTUtils.isObjectExpression(node.value)
-                    ? node.value.properties.filter(isDynamic)
-                    : [node];
-                properties.forEach((property) => {
-                    context.report({
-                        node: property,
-                        messageId: 'noHostMetadataProperty',
-                    });
-                });
-            },
-        };
-    },
-});
-function startsWithLetter({ [0]: firstLetter }) {
-    return firstLetter.toLowerCase() !== firstLetter.toUpperCase();
-}
-function isEmptyStringValue(property) {
-    return (utils_1.ASTUtils.isStringLiteral(property.value) && property.value.value === '');
-}
-function isStatic(property) {
-    return (!property.computed &&
-        (utils_2.ASTUtils.isIdentifier(property.key) ||
-            (utils_1.ASTUtils.isStringLiteral(property.key) &&
-                startsWithLetter(property.key.value))));
-}
-function isDynamic(property) {
-    return (utils_1.ASTUtils.isProperty(property) &&
-        !isStatic(property) &&
-        !isEmptyStringValue(property));
-}

package/dist/rules/prefer-standalone-component.d.ts

@@ -1,6 +0,0 @@
-export type Options = [];
-export type MessageIds = 'preferStandaloneComponent';
-export declare const RULE_NAME = "prefer-standalone-component";
-declare const _default: import("@typescript-eslint/utils/ts-eslint").RuleModule<"preferStandaloneComponent", [], import("../utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
-export default _default;
-//# sourceMappingURL=prefer-standalone-component.d.ts.map

package/dist/rules/prefer-standalone-component.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"prefer-standalone-component.d.ts","sourceRoot":"","sources":["../../src/rules/prefer-standalone-component.ts"],"names":[],"mappings":"AASA,MAAM,MAAM,OAAO,GAAG,EAAE,CAAC;AACzB,MAAM,MAAM,UAAU,GAAG,2BAA2B,CAAC;AACrD,eAAO,MAAM,SAAS,gCAAgC,CAAC;;AAIvD,wBA0DG"}

package/dist/rules/prefer-standalone-component.js

@@ -1,59 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.RULE_NAME = void 0;
-const utils_1 = require("@angular-eslint/utils");
-const create_eslint_rule_1 = require("../utils/create-eslint-rule");
-exports.RULE_NAME = 'prefer-standalone-component';
-const METADATA_PROPERTY_NAME = 'standalone';
-const IS_STANDALONE = 'true';
-exports.default = (0, create_eslint_rule_1.createESLintRule)({
-    name: exports.RULE_NAME,
-    meta: {
-        type: 'suggestion',
-        docs: {
-            description: `Ensures component \`${METADATA_PROPERTY_NAME}\` property is set to \`${IS_STANDALONE}\` in the component decorator`,
-        },
-        deprecated: true,
-        replacedBy: ['prefer-standalone'],
-        fixable: 'code',
-        schema: [],
-        messages: {
-            preferStandaloneComponent: `The component \`${METADATA_PROPERTY_NAME}\` property should be set to \`${IS_STANDALONE}\``,
-        },
-    },
-    defaultOptions: [],
-    create(context) {
-        return {
-            [utils_1.Selectors.COMPONENT_CLASS_DECORATOR](node) {
-                const standalone = utils_1.ASTUtils.getDecoratorPropertyValue(node, METADATA_PROPERTY_NAME);
-                if (standalone &&
-                    utils_1.ASTUtils.isLiteral(standalone) &&
-                    standalone.value === true) {
-                    return;
-                }
-                context.report({
-                    node: nodeToReport(node),
-                    messageId: 'preferStandaloneComponent',
-                    fix: (fixer) => {
-                        if (standalone &&
-                            utils_1.ASTUtils.isLiteral(standalone) &&
-                            standalone.value !== true) {
-                            return [fixer.replaceText(standalone, IS_STANDALONE)].filter(utils_1.isNotNullOrUndefined);
-                        }
-                        return [
-                            utils_1.RuleFixes.getDecoratorPropertyAddFix(node, fixer, `${METADATA_PROPERTY_NAME}: ${IS_STANDALONE}`),
-                        ].filter(utils_1.isNotNullOrUndefined);
-                    },
-                });
-            },
-        };
-    },
-});
-function nodeToReport(node) {
-    if (!utils_1.ASTUtils.isProperty(node)) {
-        return node;
-    }
-    return utils_1.ASTUtils.isMemberExpression(node.value)
-        ? node.value.property
-        : node.value;
-}

package/dist/rules/sort-ngmodule-metadata-arrays.d.ts

@@ -1,10 +0,0 @@
-export type Options = [
-    {
-        readonly locale: string;
-    }
-];
-export type MessageIds = 'sortNgmoduleMetadataArrays';
-export declare const RULE_NAME = "sort-ngmodule-metadata-arrays";
-declare const _default: import("@typescript-eslint/utils/ts-eslint").RuleModule<"sortNgmoduleMetadataArrays", Options, import("../utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
-export default _default;
-//# sourceMappingURL=sort-ngmodule-metadata-arrays.d.ts.map

package/dist/rules/sort-ngmodule-metadata-arrays.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"sort-ngmodule-metadata-arrays.d.ts","sourceRoot":"","sources":["../../src/rules/sort-ngmodule-metadata-arrays.ts"],"names":[],"mappings":"AAKA,MAAM,MAAM,OAAO,GAAG;IACpB;QACE,QAAQ,CAAC,MAAM,EAAE,MAAM,CAAC;KACzB;CACF,CAAC;AACF,MAAM,MAAM,UAAU,GAAG,4BAA4B,CAAC;AACtD,eAAO,MAAM,SAAS,kCAAkC,CAAC;;AAGzD,wBA2DG"}

package/dist/rules/sort-ngmodule-metadata-arrays.js

@@ -1,63 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.RULE_NAME = void 0;
-const utils_1 = require("@angular-eslint/utils");
-const utils_2 = require("@typescript-eslint/utils");
-const create_eslint_rule_1 = require("../utils/create-eslint-rule");
-exports.RULE_NAME = 'sort-ngmodule-metadata-arrays';
-const DEFAULT_LOCALE = 'en-US';
-exports.default = (0, create_eslint_rule_1.createESLintRule)({
-    name: exports.RULE_NAME,
-    meta: {
-        type: 'suggestion',
-        deprecated: true,
-        docs: {
-            description: 'Ensures ASC alphabetical order for `NgModule` metadata arrays for easy visual scanning',
-        },
-        fixable: 'code',
-        schema: [
-            {
-                type: 'object',
-                properties: {
-                    locale: {
-                        type: 'string',
-                        description: 'A string with a BCP 47 language tag.',
-                        default: DEFAULT_LOCALE,
-                    },
-                },
-                additionalProperties: false,
-            },
-        ],
-        messages: {
-            sortNgmoduleMetadataArrays: '`NgModule` metadata arrays should be sorted in ASC alphabetical order',
-        },
-    },
-    defaultOptions: [
-        {
-            locale: DEFAULT_LOCALE,
-        },
-    ],
-    create(context, [{ locale }]) {
-        return {
-            [`${utils_1.Selectors.MODULE_CLASS_DECORATOR} Property[key.name!="deps"] > ArrayExpression`]({ elements, }) {
-                const unorderedNodes = elements
-                    .filter(utils_2.ASTUtils.isIdentifier)
-                    .map((current, index, list) => [current, list[index + 1]])
-                    .find(([current, next]) => {
-                    return next && current.name.localeCompare(next.name, locale) === 1;
-                });
-                if (!unorderedNodes)
-                    return;
-                const [unorderedNode, nextNode] = unorderedNodes;
-                context.report({
-                    node: nextNode,
-                    messageId: 'sortNgmoduleMetadataArrays',
-                    fix: (fixer) => [
-                        fixer.replaceText(unorderedNode, nextNode.name),
-                        fixer.replaceText(nextNode, unorderedNode.name),
-                    ],
-                });
-            },
-        };
-    },
-});