npm - @angular-eslint/eslint-plugin - Versions diffs - 18.4.3 → 18.4.4-alpha.0 - Mend

@angular-eslint/eslint-plugin 18.4.3 → 18.4.4-alpha.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (21) hide show

package/README.md +1 -11
package/dist/configs/all.json +0 -3
package/dist/configs/recommended.json +1 -0
package/dist/index.d.ts +1 -6
package/dist/index.d.ts.map +1 -1
package/dist/index.js +0 -6
package/dist/rules/prefer-signals.d.ts +15 -0
package/dist/rules/prefer-signals.d.ts.map +1 -0
package/dist/rules/prefer-signals.js +168 -0
package/dist/rules/prefer-standalone.d.ts.map +1 -1
package/dist/rules/prefer-standalone.js +15 -15
package/package.json +4 -4
package/dist/rules/no-host-metadata-property.d.ts +0 -8
package/dist/rules/no-host-metadata-property.d.ts.map +0 -1
package/dist/rules/no-host-metadata-property.js +0 -67
package/dist/rules/prefer-standalone-component.d.ts +0 -6
package/dist/rules/prefer-standalone-component.d.ts.map +0 -1
package/dist/rules/prefer-standalone-component.js +0 -59
package/dist/rules/sort-ngmodule-metadata-arrays.d.ts +0 -10
package/dist/rules/sort-ngmodule-metadata-arrays.d.ts.map +0 -1
package/dist/rules/sort-ngmodule-metadata-arrays.js +0 -63

package/README.md CHANGED Viewed

@@ -66,7 +66,7 @@ Please see https://github.com/angular-eslint/angular-eslint for full usage instr
 | [`pipe-prefix`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/pipe-prefix.md) | Enforce consistent prefix for pipes. |  |  |  |
 | [`prefer-on-push-component-change-detection`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/prefer-on-push-component-change-detection.md) | Ensures component's `changeDetection` is set to `ChangeDetectionStrategy.OnPush` |  |  | :bulb: |
 | [`prefer-output-readonly`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/prefer-output-readonly.md) | Prefer to declare `@Output`, `OutputEmitterRef` and `OutputRef` as `readonly` since they are not supposed to be reassigned |  |  | :bulb: |
-| [`prefer-standalone`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/prefer-standalone.md) | Ensures component, directive and pipe `standalone` property is set to `true` in the component decorator |  | :wrench: |  |
+| [`prefer-standalone`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/prefer-standalone.md) | Ensures Components, Directives and Pipes do not opt out of standalone | :white_check_mark: | :wrench: |  |
 | [`relative-url-prefix`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/relative-url-prefix.md) | The ./ and ../ prefix is standard syntax for relative URLs; don't depend on Angular's current ability to do without that prefix. See more at https://angular.dev/style-guide#style-05-04 |  |  |  |
 | [`require-localize-metadata`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/require-localize-metadata.md) | Ensures that $localize tagged messages contain helpful metadata to aid with translations. |  |  |  |
 | [`runtime-localize`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/runtime-localize.md) | Ensures that $localize tagged messages can use runtime-loaded translations. |  |  |  |
@@ -85,14 +85,4 @@ Please see https://github.com/angular-eslint/angular-eslint for full usage instr
 <!-- begin deprecated rule list -->
-### Deprecated
-<!-- prettier-ignore-start -->
-| Rule | Replaced by |
-| --- | --- |
-| [`no-host-metadata-property`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/no-host-metadata-property.md) |  |
-| [`prefer-standalone-component`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/prefer-standalone-component.md) | [`prefer-standalone`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/prefer-standalone.md) |
-| [`sort-ngmodule-metadata-arrays`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/sort-ngmodule-metadata-arrays.md) |  |
-<!-- prettier-ignore-end -->
 <!-- end deprecated rule list -->

package/dist/configs/all.json CHANGED Viewed

@@ -16,7 +16,6 @@
     "@angular-eslint/no-duplicates-in-metadata-arrays": "error",
     "@angular-eslint/no-empty-lifecycle-method": "error",
     "@angular-eslint/no-forward-ref": "error",
-    "@angular-eslint/no-host-metadata-property": "error",
     "@angular-eslint/no-input-prefix": "error",
     "@angular-eslint/no-input-rename": "error",
     "@angular-eslint/no-inputs-metadata-property": "error",
@@ -31,12 +30,10 @@
     "@angular-eslint/prefer-on-push-component-change-detection": "error",
     "@angular-eslint/prefer-output-readonly": "error",
     "@angular-eslint/prefer-standalone": "error",
-    "@angular-eslint/prefer-standalone-component": "error",
     "@angular-eslint/relative-url-prefix": "error",
     "@angular-eslint/require-localize-metadata": "error",
     "@angular-eslint/runtime-localize": "error",
     "@angular-eslint/sort-lifecycle-methods": "error",
-    "@angular-eslint/sort-ngmodule-metadata-arrays": "error",
     "@angular-eslint/use-component-selector": "error",
     "@angular-eslint/use-component-view-encapsulation": "error",
     "@angular-eslint/use-injectable-provided-in": "error",

package/dist/configs/recommended.json CHANGED Viewed

@@ -12,6 +12,7 @@
     "@angular-eslint/no-output-on-prefix": "error",
     "@angular-eslint/no-output-rename": "error",
     "@angular-eslint/no-outputs-metadata-property": "error",
+    "@angular-eslint/prefer-standalone": "error",
     "@angular-eslint/use-pipe-transform-interface": "error",
     "@angular-eslint/use-lifecycle-interface": "warn"
   }

package/dist/index.d.ts CHANGED Viewed

@@ -18,7 +18,6 @@ declare const _default: {
                 "@angular-eslint/no-duplicates-in-metadata-arrays": string;
                 "@angular-eslint/no-empty-lifecycle-method": string;
                 "@angular-eslint/no-forward-ref": string;
-                "@angular-eslint/no-host-metadata-property": string;
                 "@angular-eslint/no-input-prefix": string;
                 "@angular-eslint/no-input-rename": string;
                 "@angular-eslint/no-inputs-metadata-property": string;
@@ -33,12 +32,10 @@ declare const _default: {
                 "@angular-eslint/prefer-on-push-component-change-detection": string;
                 "@angular-eslint/prefer-output-readonly": string;
                 "@angular-eslint/prefer-standalone": string;
-                "@angular-eslint/prefer-standalone-component": string;
                 "@angular-eslint/relative-url-prefix": string;
                 "@angular-eslint/require-localize-metadata": string;
                 "@angular-eslint/runtime-localize": string;
                 "@angular-eslint/sort-lifecycle-methods": string;
-                "@angular-eslint/sort-ngmodule-metadata-arrays": string;
                 "@angular-eslint/use-component-selector": string;
                 "@angular-eslint/use-component-view-encapsulation": string;
                 "@angular-eslint/use-injectable-provided-in": string;
@@ -60,6 +57,7 @@ declare const _default: {
                 "@angular-eslint/no-output-on-prefix": string;
                 "@angular-eslint/no-output-rename": string;
                 "@angular-eslint/no-outputs-metadata-property": string;
+                "@angular-eslint/prefer-standalone": string;
                 "@angular-eslint/use-pipe-transform-interface": string;
                 "@angular-eslint/use-lifecycle-interface": string;
             };
@@ -80,7 +78,6 @@ declare const _default: {
         "no-duplicates-in-metadata-arrays": import("@typescript-eslint/utils/ts-eslint").RuleModule<"noDuplicatesInMetadataArrays", [], import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
         "no-empty-lifecycle-method": import("@typescript-eslint/utils/ts-eslint").RuleModule<import("./rules/no-empty-lifecycle-method").MessageIds, [], import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
         "no-forward-ref": import("@typescript-eslint/utils/ts-eslint").RuleModule<"noForwardRef", [], import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
-        "no-host-metadata-property": import("@typescript-eslint/utils/ts-eslint").RuleModule<"noHostMetadataProperty", import("./rules/no-host-metadata-property").Options, import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
         "no-input-prefix": import("@typescript-eslint/utils/ts-eslint").RuleModule<"noInputPrefix", import("./rules/no-input-prefix").Options, import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
         "no-input-rename": import("@typescript-eslint/utils/ts-eslint").RuleModule<import("./rules/no-input-rename").MessageIds, import("./rules/no-input-rename").Options, import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
         "no-inputs-metadata-property": import("@typescript-eslint/utils/ts-eslint").RuleModule<"noInputsMetadataProperty", [], import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
@@ -94,13 +91,11 @@ declare const _default: {
         "pipe-prefix": import("@typescript-eslint/utils/ts-eslint").RuleModule<"pipePrefix", import("./rules/pipe-prefix").Options, import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
         "prefer-on-push-component-change-detection": import("@typescript-eslint/utils/ts-eslint").RuleModule<import("./rules/prefer-on-push-component-change-detection").MessageIds, [], import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
         "prefer-standalone": import("@typescript-eslint/utils/ts-eslint").RuleModule<"preferStandalone", [], import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
-        "prefer-standalone-component": import("@typescript-eslint/utils/ts-eslint").RuleModule<"preferStandaloneComponent", [], import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
         "prefer-output-readonly": import("@typescript-eslint/utils/ts-eslint").RuleModule<import("./rules/prefer-output-readonly").MessageIds, [], import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
         "relative-url-prefix": import("@typescript-eslint/utils/ts-eslint").RuleModule<"relativeUrlPrefix", [], import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
         "require-localize-metadata": import("@typescript-eslint/utils/ts-eslint").RuleModule<import("./rules/require-localize-metadata").MessageIds, import("./rules/require-localize-metadata").Options, import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
         "runtime-localize": import("@typescript-eslint/utils/ts-eslint").RuleModule<"runtimeLocalize", [], import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
         "sort-lifecycle-methods": import("@typescript-eslint/utils/ts-eslint").RuleModule<"lifecycleMethodsNotSorted", [], import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
-        "sort-ngmodule-metadata-arrays": import("@typescript-eslint/utils/ts-eslint").RuleModule<"sortNgmoduleMetadataArrays", import("./rules/sort-ngmodule-metadata-arrays").Options, import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
         "use-component-selector": import("@typescript-eslint/utils/ts-eslint").RuleModule<"useComponentSelector", [], import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
         "use-component-view-encapsulation": import("@typescript-eslint/utils/ts-eslint").RuleModule<import("./rules/use-component-view-encapsulation").MessageIds, [], import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
         "use-injectable-provided-in": import("@typescript-eslint/utils/ts-eslint").RuleModule<import("./rules/use-injectable-provided-in").MessageIds, import("./rules/use-injectable-provided-in").Options, import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;

package/dist/index.d.ts.map CHANGED Viewed

	@@ -1 +1 @@
1	- {"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":"~~;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;AA4HA~~,~~kBAgDE~~"}
1	+ {"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;AAmHA,kBA6CE"}

package/dist/index.js CHANGED Viewed

@@ -40,7 +40,6 @@ const no_attribute_decorator_1 = __importStar(require("./rules/no-attribute-deco
 const no_conflicting_lifecycle_1 = __importStar(require("./rules/no-conflicting-lifecycle"));
 const no_empty_lifecycle_method_1 = __importStar(require("./rules/no-empty-lifecycle-method"));
 const no_forward_ref_1 = __importStar(require("./rules/no-forward-ref"));
-const no_host_metadata_property_1 = __importStar(require("./rules/no-host-metadata-property"));
 const no_input_prefix_1 = __importStar(require("./rules/no-input-prefix"));
 const no_input_rename_1 = __importStar(require("./rules/no-input-rename"));
 const no_inputs_metadata_property_1 = __importStar(require("./rules/no-inputs-metadata-property"));
@@ -55,12 +54,10 @@ const pipe_prefix_1 = __importStar(require("./rules/pipe-prefix"));
 const prefer_on_push_component_change_detection_1 = __importStar(require("./rules/prefer-on-push-component-change-detection"));
 const prefer_output_readonly_1 = __importStar(require("./rules/prefer-output-readonly"));
 const prefer_standalone_1 = __importStar(require("./rules/prefer-standalone"));
-const prefer_standalone_component_1 = __importStar(require("./rules/prefer-standalone-component"));
 const relative_url_prefix_1 = __importStar(require("./rules/relative-url-prefix"));
 const require_localize_metadata_1 = __importStar(require("./rules/require-localize-metadata"));
 const runtime_localize_1 = __importStar(require("./rules/runtime-localize"));
 const sort_lifecycle_methods_1 = __importStar(require("./rules/sort-lifecycle-methods"));
-const sort_ngmodule_metadata_arrays_1 = __importStar(require("./rules/sort-ngmodule-metadata-arrays"));
 const use_component_selector_1 = __importStar(require("./rules/use-component-selector"));
 const use_component_view_encapsulation_1 = __importStar(require("./rules/use-component-view-encapsulation"));
 const use_injectable_provided_in_1 = __importStar(require("./rules/use-injectable-provided-in"));
@@ -87,7 +84,6 @@ module.exports = {
         [no_duplicates_in_metadata_arrays_1.RULE_NAME]: no_duplicates_in_metadata_arrays_1.default,
         [no_empty_lifecycle_method_1.RULE_NAME]: no_empty_lifecycle_method_1.default,
         [no_forward_ref_1.RULE_NAME]: no_forward_ref_1.default,
-        [no_host_metadata_property_1.RULE_NAME]: no_host_metadata_property_1.default,
         [no_input_prefix_1.RULE_NAME]: no_input_prefix_1.default,
         [no_input_rename_1.RULE_NAME]: no_input_rename_1.default,
         [no_inputs_metadata_property_1.RULE_NAME]: no_inputs_metadata_property_1.default,
@@ -101,13 +97,11 @@ module.exports = {
         [pipe_prefix_1.RULE_NAME]: pipe_prefix_1.default,
         [prefer_on_push_component_change_detection_1.RULE_NAME]: prefer_on_push_component_change_detection_1.default,
         [prefer_standalone_1.RULE_NAME]: prefer_standalone_1.default,
-        [prefer_standalone_component_1.RULE_NAME]: prefer_standalone_component_1.default,
         [prefer_output_readonly_1.RULE_NAME]: prefer_output_readonly_1.default,
         [relative_url_prefix_1.RULE_NAME]: relative_url_prefix_1.default,
         [require_localize_metadata_1.RULE_NAME]: require_localize_metadata_1.default,
         [runtime_localize_1.RULE_NAME]: runtime_localize_1.default,
         [sort_lifecycle_methods_1.RULE_NAME]: sort_lifecycle_methods_1.default,
-        [sort_ngmodule_metadata_arrays_1.RULE_NAME]: sort_ngmodule_metadata_arrays_1.default,
         [use_component_selector_1.RULE_NAME]: use_component_selector_1.default,
         [use_component_view_encapsulation_1.RULE_NAME]: use_component_view_encapsulation_1.default,
         [use_injectable_provided_in_1.RULE_NAME]: use_injectable_provided_in_1.default,

package/dist/rules/prefer-signals.d.ts ADDED Viewed

@@ -0,0 +1,15 @@
+import { ESLintUtils } from '@typescript-eslint/utils';
+type Options = [
+    {
+        preferReadonlySignalProperties: boolean;
+        preferInputSignals: boolean;
+        preferQuerySignals: boolean;
+        useTypeChecking: boolean;
+        additionalSignalCreationFunctions: string[];
+    }
+];
+export type MessageIds = 'preferInputSignals' | 'preferQuerySignals' | 'preferReadonlySignalProperties' | 'suggestAddReadonlyModifier';
+export declare const RULE_NAME = "prefer-signals";
+declare const _default: ESLintUtils.RuleModule<MessageIds, Options, import("../utils/create-eslint-rule").RuleDocs, ESLintUtils.RuleListener>;
+export default _default;
+//# sourceMappingURL=prefer-signals.d.ts.map

package/dist/rules/prefer-signals.d.ts.map ADDED Viewed

@@ -0,0 +1 @@

+ {"version":3,"file":"prefer-signals.d.ts","sourceRoot":"","sources":["../../src/rules/prefer-signals.ts"],"names":[],"mappings":"AAKA,OAAO,EAAkB,WAAW,EAAE,MAAM,0BAA0B,CAAC;AAGvE,KAAK,OAAO,GAAG;IACb;QACE,8BAA8B,EAAE,OAAO,CAAC;QACxC,kBAAkB,EAAE,OAAO,CAAC;QAC5B,kBAAkB,EAAE,OAAO,CAAC;QAC5B,eAAe,EAAE,OAAO,CAAC;QACzB,iCAAiC,EAAE,MAAM,EAAE,CAAC;KAC7C;CACF,CAAC;AA4BF,MAAM,MAAM,UAAU,GAClB,oBAAoB,GACpB,oBAAoB,GACpB,gCAAgC,GAChC,4BAA4B,CAAC;AACjC,eAAO,MAAM,SAAS,mBAAmB,CAAC;;AAE1C,wBA6KG"}

package/dist/rules/prefer-signals.js ADDED Viewed

@@ -0,0 +1,168 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.RULE_NAME = void 0;
+const utils_1 = require("@angular-eslint/utils");
+const utils_2 = require("@typescript-eslint/utils");
+const create_eslint_rule_1 = require("../utils/create-eslint-rule");
+const DEFAULT_OPTIONS = {
+    preferReadonlySignalProperties: true,
+    preferInputSignals: true,
+    preferQuerySignals: true,
+    useTypeChecking: false,
+    additionalSignalCreationFunctions: [],
+};
+const KNOWN_SIGNAL_TYPES = new Set([
+    'InputSignal',
+    'ModelSignal',
+    'Signal',
+    'WritableSignal',
+]);
+const KNOWN_SIGNAL_CREATION_FUNCTIONS = new Set([
+    'computed',
+    'contentChild',
+    'contentChildren',
+    'input',
+    'model',
+    'signal',
+    'toSignal',
+    'viewChild',
+    'viewChildren',
+]);
+exports.RULE_NAME = 'prefer-signals';
+exports.default = (0, create_eslint_rule_1.createESLintRule)({
+    name: exports.RULE_NAME,
+    meta: {
+        type: 'suggestion',
+        docs: {
+            description: 'Use readonly signals instead of `@Input()`, `@ViewChild()` and other legacy decorators',
+            recommended: 'recommended',
+        },
+        hasSuggestions: true,
+        schema: [
+            {
+                type: 'object',
+                properties: {
+                    preferReadonlySignalProperties: {
+                        type: 'boolean',
+                        default: DEFAULT_OPTIONS.preferReadonlySignalProperties,
+                    },
+                    preferInputSignals: {
+                        type: 'boolean',
+                        default: DEFAULT_OPTIONS.preferInputSignals,
+                    },
+                    preferQuerySignals: {
+                        type: 'boolean',
+                        default: DEFAULT_OPTIONS.preferQuerySignals,
+                    },
+                    useTypeChecking: {
+                        type: 'boolean',
+                        default: DEFAULT_OPTIONS.useTypeChecking,
+                    },
+                    additionalSignalCreationFunctions: {
+                        type: 'array',
+                        items: { type: 'string' },
+                        default: DEFAULT_OPTIONS.additionalSignalCreationFunctions,
+                    },
+                },
+                additionalProperties: false,
+            },
+        ],
+        messages: {
+            preferInputSignals: 'Use `InputSignal`s (e.g. via `input()`) for Component input properties rather than the legacy `@Input()` decorator',
+            preferQuerySignals: 'Use the `{{function}}` function instead of the `{{decorator}}` decorator',
+            preferReadonlySignalProperties: 'Properties declared using signals should be marked as `readonly` since they should not be reassigned',
+            suggestAddReadonlyModifier: 'Add `readonly` modifier',
+        },
+    },
+    defaultOptions: [{ ...DEFAULT_OPTIONS }],
+    create(context, [{ preferReadonlySignalProperties = DEFAULT_OPTIONS.preferReadonlySignalProperties, preferInputSignals = DEFAULT_OPTIONS.preferInputSignals, preferQuerySignals = DEFAULT_OPTIONS.preferQuerySignals, additionalSignalCreationFunctions = DEFAULT_OPTIONS.additionalSignalCreationFunctions, useTypeChecking = DEFAULT_OPTIONS.useTypeChecking, },]) {
+        let services;
+        const listener = {};
+        if (preferReadonlySignalProperties) {
+            listener[`PropertyDefinition:not([readonly=true])`] = (node) => {
+                let shouldBeReadonly = false;
+                if (node.typeAnnotation) {
+                    // Use the type annotation to determine
+                    // whether the property is a signal.
+                    if (node.typeAnnotation.typeAnnotation.type ===
+                        utils_2.AST_NODE_TYPES.TSTypeReference) {
+                        const type = node.typeAnnotation.typeAnnotation;
+                        if (type.typeArguments &&
+                            type.typeName.type === utils_2.AST_NODE_TYPES.Identifier &&
+                            KNOWN_SIGNAL_TYPES.has(type.typeName.name)) {
+                            shouldBeReadonly = true;
+                        }
+                    }
+                }
+                else {
+                    // There is no type annotation, so try to
+                    // use the value assigned to the property
+                    // to determine whether it would be a signal.
+                    if (node.value?.type === utils_2.AST_NODE_TYPES.CallExpression) {
+                        let callee = node.value.callee;
+                        // Some signal-creating functions have a `.required`
+                        // member. For example, `input.required()`.
+                        if (callee.type === utils_2.AST_NODE_TYPES.MemberExpression) {
+                            if (callee.property.type === utils_2.AST_NODE_TYPES.Identifier &&
+                                callee.property.name !== 'required') {
+                                return;
+                            }
+                            callee = callee.object;
+                        }
+                        if (callee.type === utils_2.AST_NODE_TYPES.Identifier &&
+                            (KNOWN_SIGNAL_CREATION_FUNCTIONS.has(callee.name) ||
+                                additionalSignalCreationFunctions.includes(callee.name))) {
+                            shouldBeReadonly = true;
+                        }
+                    }
+                    if (!shouldBeReadonly && useTypeChecking && node.value) {
+                        services ??= utils_2.ESLintUtils.getParserServices(context);
+                        const name = services
+                            .getTypeAtLocation(node.value)
+                            .getSymbol()?.name;
+                        shouldBeReadonly =
+                            name !== undefined && KNOWN_SIGNAL_TYPES.has(name);
+                    }
+                }
+                if (shouldBeReadonly) {
+                    context.report({
+                        node: node.key,
+                        messageId: 'preferReadonlySignalProperties',
+                        suggest: [
+                            {
+                                messageId: 'suggestAddReadonlyModifier',
+                                fix: (fixer) => fixer.insertTextBefore(node.key, 'readonly '),
+                            },
+                        ],
+                    });
+                }
+            };
+        }
+        if (preferInputSignals) {
+            listener[utils_1.Selectors.INPUT_DECORATOR] = (node) => {
+                context.report({
+                    node,
+                    messageId: 'preferInputSignals',
+                });
+            };
+        }
+        if (preferQuerySignals) {
+            listener['Decorator[expression.callee.name=/^(ContentChild|ContentChildren|ViewChild|ViewChildren)$/]'] = (node) => {
+                if (node.expression.type === utils_2.AST_NODE_TYPES.CallExpression &&
+                    node.expression.callee.type === utils_2.AST_NODE_TYPES.Identifier) {
+                    const decoratorName = node.expression.callee.name;
+                    context.report({
+                        node,
+                        messageId: 'preferQuerySignals',
+                        data: {
+                            function: decoratorName.slice(0, 1).toLowerCase() +
+                                decoratorName.slice(1),
+                            decorator: decoratorName,
+                        },
+                    });
+                }
+            };
+        }
+        return listener;
+    },
+});

package/dist/rules/prefer-standalone.d.ts.map CHANGED Viewed

	@@ -1 +1 @@
1	- {"version":3,"file":"prefer-standalone.d.ts","sourceRoot":"","sources":["../../src/rules/prefer-standalone.ts"],"names":[],"mappings":"~~AASA~~,MAAM,MAAM,OAAO,GAAG,EAAE,CAAC;AAEzB,MAAM,MAAM,UAAU,GAAG,kBAAkB,CAAC;AAC5C,eAAO,MAAM,SAAS,sBAAsB,CAAC;;~~AAI7C~~,~~wBAkEG~~"}
1	+ {"version":3,"file":"prefer-standalone.d.ts","sourceRoot":"","sources":["../../src/rules/prefer-standalone.ts"],"names":[],"mappings":"AAIA,MAAM,MAAM,OAAO,GAAG,EAAE,CAAC;AAEzB,MAAM,MAAM,UAAU,GAAG,kBAAkB,CAAC;AAC5C,eAAO,MAAM,SAAS,sBAAsB,CAAC;;AAE7C,wBA6DG"}

package/dist/rules/prefer-standalone.js CHANGED Viewed

@@ -4,28 +4,27 @@ exports.RULE_NAME = void 0;
 const utils_1 = require("@angular-eslint/utils");
 const create_eslint_rule_1 = require("../utils/create-eslint-rule");
 exports.RULE_NAME = 'prefer-standalone';
-const METADATA_PROPERTY_NAME = 'standalone';
-const IS_STANDALONE = 'true';
 exports.default = (0, create_eslint_rule_1.createESLintRule)({
     name: exports.RULE_NAME,
     meta: {
         type: 'suggestion',
         docs: {
-            description: `Ensures component, directive and pipe \`${METADATA_PROPERTY_NAME}\` property is set to \`${IS_STANDALONE}\` in the component decorator`,
+            description: `Ensures Components, Directives and Pipes do not opt out of standalone`,
+            recommended: 'recommended',
         },
         fixable: 'code',
         schema: [],
         messages: {
-            preferStandalone: `The {{type}} \`${METADATA_PROPERTY_NAME}\` property should be set to \`${IS_STANDALONE}\``,
+            preferStandalone: `Components, Directives and Pipes should not opt out of standalone`,
         },
     },
     defaultOptions: [],
     create(context) {
         const standaloneRuleFactory = (type) => (node) => {
-            const standalone = utils_1.ASTUtils.getDecoratorPropertyValue(node, METADATA_PROPERTY_NAME);
-            if (standalone &&
-                utils_1.ASTUtils.isLiteral(standalone) &&
-                standalone.value === true) {
+            const standalone = utils_1.ASTUtils.getDecoratorPropertyValue(node, 'standalone');
+            // Leave the standalone property alone if it was set to true or not present
+            if (!standalone ||
+                (utils_1.ASTUtils.isLiteral(standalone) && standalone.value === true)) {
                 return;
             }
             if (!utils_1.ASTUtils.getDecoratorArgument(node)) {
@@ -36,14 +35,15 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
                 messageId: 'preferStandalone',
                 data: { type },
                 fix: (fixer) => {
-                    if (standalone &&
-                        utils_1.ASTUtils.isLiteral(standalone) &&
-                        standalone.value !== true) {
-                        return [fixer.replaceText(standalone, IS_STANDALONE)].filter(utils_1.isNotNullOrUndefined);
+                    // Remove the standalone property altogether if it was set to false
+                    const tokenAfter = context.sourceCode.getTokenAfter(standalone.parent);
+                    // Remove the trailing comma, if present
+                    const removeStart = standalone.parent.range[0];
+                    let removeEnd = standalone.parent.range[1];
+                    if (tokenAfter && tokenAfter.value === ',') {
+                        removeEnd = tokenAfter.range[1];
                     }
-                    return [
-                        utils_1.RuleFixes.getDecoratorPropertyAddFix(node, fixer, `${METADATA_PROPERTY_NAME}: ${IS_STANDALONE}`),
-                    ].filter(utils_1.isNotNullOrUndefined);
+                    return fixer.removeRange([removeStart, removeEnd]);
                 },
             });
         };

package/package.json CHANGED Viewed

@@ -1,6 +1,6 @@
 {
   "name": "@angular-eslint/eslint-plugin",
-  "version": "18.4.3",
+  "version": "18.4.4-alpha.0",
   "description": "ESLint plugin for Angular applications, following https://angular.dev/style-guide",
   "license": "MIT",
   "main": "dist/index.js",
@@ -18,11 +18,11 @@
     "LICENSE"
   ],
   "dependencies": {
-    "@angular-eslint/bundled-angular-compiler": "18.4.3",
-    "@angular-eslint/utils": "18.4.3"
+    "@angular-eslint/utils": "18.4.4-alpha.0",
+    "@angular-eslint/bundled-angular-compiler": "18.4.4-alpha.0"
   },
   "devDependencies": {
-    "@angular-eslint/test-utils": "18.4.3"
+    "@angular-eslint/test-utils": "18.4.4-alpha.0"
   },
   "peerDependencies": {
     "@typescript-eslint/utils": "^7.11.0 || ^8.0.0",

package/dist/rules/no-host-metadata-property.d.ts DELETED Viewed

@@ -1,8 +0,0 @@
-export type Options = [{
-    readonly allowStatic?: boolean;
-}];
-export type MessageIds = 'noHostMetadataProperty';
-export declare const RULE_NAME = "no-host-metadata-property";
-declare const _default: import("@typescript-eslint/utils/ts-eslint").RuleModule<"noHostMetadataProperty", Options, import("../utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
-export default _default;
-//# sourceMappingURL=no-host-metadata-property.d.ts.map

package/dist/rules/no-host-metadata-property.d.ts.map DELETED Viewed

	@@ -1 +0,0 @@
1	- {"version":3,"file":"no-host-metadata-property.d.ts","sourceRoot":"","sources":["../../src/rules/no-host-metadata-property.ts"],"names":[],"mappings":"AAKA,MAAM,MAAM,OAAO,GAAG,CAAC;IAAE,QAAQ,CAAC,WAAW,CAAC,EAAE,OAAO,CAAA;CAAE,CAAC,CAAC;AAC3D,MAAM,MAAM,UAAU,GAAG,wBAAwB,CAAC;AAClD,eAAO,MAAM,SAAS,8BAA8B,CAAC;;AAIrD,wBA4CG"}

package/dist/rules/no-host-metadata-property.js DELETED Viewed

@@ -1,67 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.RULE_NAME = void 0;
-const utils_1 = require("@angular-eslint/utils");
-const utils_2 = require("@typescript-eslint/utils");
-const create_eslint_rule_1 = require("../utils/create-eslint-rule");
-exports.RULE_NAME = 'no-host-metadata-property';
-const DEFAULT_OPTIONS = { allowStatic: false };
-const METADATA_PROPERTY_NAME = 'host';
-exports.default = (0, create_eslint_rule_1.createESLintRule)({
-    name: exports.RULE_NAME,
-    meta: {
-        type: 'suggestion',
-        deprecated: true,
-        docs: {
-            description: `Disallows usage of the \`${METADATA_PROPERTY_NAME}\` metadata property. NOTE: This used to be recommended by the Angular Team, but now they recommend the exact opposite: https://github.com/angular/angular/issues/54284`,
-        },
-        schema: [
-            {
-                type: 'object',
-                properties: {
-                    allowStatic: {
-                        type: 'boolean',
-                        default: DEFAULT_OPTIONS.allowStatic,
-                    },
-                },
-                additionalProperties: false,
-            },
-        ],
-        messages: {
-            noHostMetadataProperty: `Use @${utils_1.ASTUtils.AngularInnerClassDecorators.HostBinding} or @${utils_1.ASTUtils.AngularInnerClassDecorators.HostListener} rather than the \`${METADATA_PROPERTY_NAME}\` metadata property`,
-        },
-    },
-    defaultOptions: [DEFAULT_OPTIONS],
-    create(context, [{ allowStatic }]) {
-        return {
-            [`${utils_1.Selectors.COMPONENT_OR_DIRECTIVE_CLASS_DECORATOR} Property[key.name="${METADATA_PROPERTY_NAME}"]`](node) {
-                const properties = allowStatic && utils_1.ASTUtils.isObjectExpression(node.value)
-                    ? node.value.properties.filter(isDynamic)
-                    : [node];
-                properties.forEach((property) => {
-                    context.report({
-                        node: property,
-                        messageId: 'noHostMetadataProperty',
-                    });
-                });
-            },
-        };
-    },
-});
-function startsWithLetter({ [0]: firstLetter }) {
-    return firstLetter.toLowerCase() !== firstLetter.toUpperCase();
-}
-function isEmptyStringValue(property) {
-    return (utils_1.ASTUtils.isStringLiteral(property.value) && property.value.value === '');
-}
-function isStatic(property) {
-    return (!property.computed &&
-        (utils_2.ASTUtils.isIdentifier(property.key) ||
-            (utils_1.ASTUtils.isStringLiteral(property.key) &&
-                startsWithLetter(property.key.value))));
-}
-function isDynamic(property) {
-    return (utils_1.ASTUtils.isProperty(property) &&
-        !isStatic(property) &&
-        !isEmptyStringValue(property));
-}

package/dist/rules/prefer-standalone-component.d.ts DELETED Viewed

@@ -1,6 +0,0 @@
-export type Options = [];
-export type MessageIds = 'preferStandaloneComponent';
-export declare const RULE_NAME = "prefer-standalone-component";
-declare const _default: import("@typescript-eslint/utils/ts-eslint").RuleModule<"preferStandaloneComponent", [], import("../utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
-export default _default;
-//# sourceMappingURL=prefer-standalone-component.d.ts.map

package/dist/rules/prefer-standalone-component.d.ts.map DELETED Viewed

	@@ -1 +0,0 @@
1	- {"version":3,"file":"prefer-standalone-component.d.ts","sourceRoot":"","sources":["../../src/rules/prefer-standalone-component.ts"],"names":[],"mappings":"AASA,MAAM,MAAM,OAAO,GAAG,EAAE,CAAC;AACzB,MAAM,MAAM,UAAU,GAAG,2BAA2B,CAAC;AACrD,eAAO,MAAM,SAAS,gCAAgC,CAAC;;AAIvD,wBA0DG"}

package/dist/rules/prefer-standalone-component.js DELETED Viewed

@@ -1,59 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.RULE_NAME = void 0;
-const utils_1 = require("@angular-eslint/utils");
-const create_eslint_rule_1 = require("../utils/create-eslint-rule");
-exports.RULE_NAME = 'prefer-standalone-component';
-const METADATA_PROPERTY_NAME = 'standalone';
-const IS_STANDALONE = 'true';
-exports.default = (0, create_eslint_rule_1.createESLintRule)({
-    name: exports.RULE_NAME,
-    meta: {
-        type: 'suggestion',
-        docs: {
-            description: `Ensures component \`${METADATA_PROPERTY_NAME}\` property is set to \`${IS_STANDALONE}\` in the component decorator`,
-        },
-        deprecated: true,
-        replacedBy: ['prefer-standalone'],
-        fixable: 'code',
-        schema: [],
-        messages: {
-            preferStandaloneComponent: `The component \`${METADATA_PROPERTY_NAME}\` property should be set to \`${IS_STANDALONE}\``,
-        },
-    },
-    defaultOptions: [],
-    create(context) {
-        return {
-            [utils_1.Selectors.COMPONENT_CLASS_DECORATOR](node) {
-                const standalone = utils_1.ASTUtils.getDecoratorPropertyValue(node, METADATA_PROPERTY_NAME);
-                if (standalone &&
-                    utils_1.ASTUtils.isLiteral(standalone) &&
-                    standalone.value === true) {
-                    return;
-                }
-                context.report({
-                    node: nodeToReport(node),
-                    messageId: 'preferStandaloneComponent',
-                    fix: (fixer) => {
-                        if (standalone &&
-                            utils_1.ASTUtils.isLiteral(standalone) &&
-                            standalone.value !== true) {
-                            return [fixer.replaceText(standalone, IS_STANDALONE)].filter(utils_1.isNotNullOrUndefined);
-                        }
-                        return [
-                            utils_1.RuleFixes.getDecoratorPropertyAddFix(node, fixer, `${METADATA_PROPERTY_NAME}: ${IS_STANDALONE}`),
-                        ].filter(utils_1.isNotNullOrUndefined);
-                    },
-                });
-            },
-        };
-    },
-});
-function nodeToReport(node) {
-    if (!utils_1.ASTUtils.isProperty(node)) {
-        return node;
-    }
-    return utils_1.ASTUtils.isMemberExpression(node.value)
-        ? node.value.property
-        : node.value;
-}

package/dist/rules/sort-ngmodule-metadata-arrays.d.ts DELETED Viewed

@@ -1,10 +0,0 @@
-export type Options = [
-    {
-        readonly locale: string;
-    }
-];
-export type MessageIds = 'sortNgmoduleMetadataArrays';
-export declare const RULE_NAME = "sort-ngmodule-metadata-arrays";
-declare const _default: import("@typescript-eslint/utils/ts-eslint").RuleModule<"sortNgmoduleMetadataArrays", Options, import("../utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
-export default _default;
-//# sourceMappingURL=sort-ngmodule-metadata-arrays.d.ts.map

package/dist/rules/sort-ngmodule-metadata-arrays.d.ts.map DELETED Viewed

	@@ -1 +0,0 @@
1	- {"version":3,"file":"sort-ngmodule-metadata-arrays.d.ts","sourceRoot":"","sources":["../../src/rules/sort-ngmodule-metadata-arrays.ts"],"names":[],"mappings":"AAKA,MAAM,MAAM,OAAO,GAAG;IACpB;QACE,QAAQ,CAAC,MAAM,EAAE,MAAM,CAAC;KACzB;CACF,CAAC;AACF,MAAM,MAAM,UAAU,GAAG,4BAA4B,CAAC;AACtD,eAAO,MAAM,SAAS,kCAAkC,CAAC;;AAGzD,wBA2DG"}

package/dist/rules/sort-ngmodule-metadata-arrays.js DELETED Viewed

@@ -1,63 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.RULE_NAME = void 0;
-const utils_1 = require("@angular-eslint/utils");
-const utils_2 = require("@typescript-eslint/utils");
-const create_eslint_rule_1 = require("../utils/create-eslint-rule");
-exports.RULE_NAME = 'sort-ngmodule-metadata-arrays';
-const DEFAULT_LOCALE = 'en-US';
-exports.default = (0, create_eslint_rule_1.createESLintRule)({
-    name: exports.RULE_NAME,
-    meta: {
-        type: 'suggestion',
-        deprecated: true,
-        docs: {
-            description: 'Ensures ASC alphabetical order for `NgModule` metadata arrays for easy visual scanning',
-        },
-        fixable: 'code',
-        schema: [
-            {
-                type: 'object',
-                properties: {
-                    locale: {
-                        type: 'string',
-                        description: 'A string with a BCP 47 language tag.',
-                        default: DEFAULT_LOCALE,
-                    },
-                },
-                additionalProperties: false,
-            },
-        ],
-        messages: {
-            sortNgmoduleMetadataArrays: '`NgModule` metadata arrays should be sorted in ASC alphabetical order',
-        },
-    },
-    defaultOptions: [
-        {
-            locale: DEFAULT_LOCALE,
-        },
-    ],
-    create(context, [{ locale }]) {
-        return {
-            [`${utils_1.Selectors.MODULE_CLASS_DECORATOR} Property[key.name!="deps"] > ArrayExpression`]({ elements, }) {
-                const unorderedNodes = elements
-                    .filter(utils_2.ASTUtils.isIdentifier)
-                    .map((current, index, list) => [current, list[index + 1]])
-                    .find(([current, next]) => {
-                    return next && current.name.localeCompare(next.name, locale) === 1;
-                });
-                if (!unorderedNodes)
-                    return;
-                const [unorderedNode, nextNode] = unorderedNodes;
-                context.report({
-                    node: nextNode,
-                    messageId: 'sortNgmoduleMetadataArrays',
-                    fix: (fixer) => [
-                        fixer.replaceText(unorderedNode, nextNode.name),
-                        fixer.replaceText(nextNode, unorderedNode.name),
-                    ],
-                });
-            },
-        };
-    },
-});