@angular-eslint/eslint-plugin 17.3.1-alpha.12 → 17.3.1-alpha.14

package/README.md

@@ -48,6 +48,7 @@
 | [`directive-class-suffix`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/directive-class-suffix.md) | Classes decorated with @Directive must have suffix "Directive" (or custom) in their name. See more at https://angular.io/styleguide#style-02-03 | :white_check_mark: |  |  |
 | [`directive-selector`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/directive-selector.md) | Directive selectors should follow given naming rules. See more at https://angular.io/guide/styleguide#style-02-06 and https://angular.io/guide/styleguide#style-02-08. |  |  |  |
 | [`no-conflicting-lifecycle`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/no-conflicting-lifecycle.md) | Ensures that directives not implement conflicting lifecycle interfaces. |  |  |  |
+| [`no-duplicates-in-metadata-arrays`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/no-duplicates-in-metadata-arrays.md) | Ensures that metadata arrays do not contain duplicate entries. |  |  |  |
 | [`no-empty-lifecycle-method`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/no-empty-lifecycle-method.md) | Disallows declaring empty lifecycle methods | :white_check_mark: |  | :bulb: |
 | [`no-forward-ref`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/no-forward-ref.md) | Disallows usage of `forwardRef` references for DI |  |  |  |
 | [`no-host-metadata-property`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/no-host-metadata-property.md) | Disallows usage of the `host` metadata property. See more at https://angular.io/styleguide#style-06-03 | :white_check_mark: |  |  |
@@ -67,7 +68,6 @@
 | [`prefer-standalone`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/prefer-standalone.md) | Ensures component, directive and pipe `standalone` property is set to `true` in the component decorator |  | :wrench: |  |
 | [`relative-url-prefix`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/relative-url-prefix.md) | The ./ and ../ prefix is standard syntax for relative URLs; don't depend on Angular's current ability to do without that prefix. See more at https://angular.io/styleguide#style-05-04 |  |  |  |
 | [`require-localize-metadata`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/require-localize-metadata.md) | Ensures that $localize tagged messages contain helpful metadata to aid with translations. |  |  |  |
-| [`sort-ngmodule-metadata-arrays`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/sort-ngmodule-metadata-arrays.md) | Ensures ASC alphabetical order for `NgModule` metadata arrays for easy visual scanning |  | :wrench: |  |
 | [`use-component-selector`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/use-component-selector.md) | Component selector must be declared |  |  |  |
 | [`use-component-view-encapsulation`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/use-component-view-encapsulation.md) | Disallows using `ViewEncapsulation.None` |  |  | :bulb: |
 | [`use-injectable-provided-in`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/use-injectable-provided-in.md) | Using the `providedIn` property makes `Injectables` tree-shakable |  |  | :bulb: |
@@ -89,6 +89,7 @@
 | Rule | Replaced by |
 | --- | --- |
 | [`prefer-standalone-component`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/prefer-standalone-component.md) | [`prefer-standalone`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/prefer-standalone.md) |
+| [`sort-ngmodule-metadata-arrays`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/sort-ngmodule-metadata-arrays.md) |  |
 <!-- prettier-ignore-end -->
 
 <!-- end deprecated rule list -->

package/dist/configs/all.json

@@ -13,6 +13,7 @@
     "@angular-eslint/no-async-lifecycle-method": "error",
     "@angular-eslint/no-attribute-decorator": "error",
     "@angular-eslint/no-conflicting-lifecycle": "error",
+    "@angular-eslint/no-duplicates-in-metadata-arrays": "error",
     "@angular-eslint/no-empty-lifecycle-method": "error",
     "@angular-eslint/no-forward-ref": "error",
     "@angular-eslint/no-host-metadata-property": "error",

package/dist/index.d.ts

@@ -15,6 +15,7 @@ declare const _default: {
                 "@angular-eslint/no-async-lifecycle-method": string;
                 "@angular-eslint/no-attribute-decorator": string;
                 "@angular-eslint/no-conflicting-lifecycle": string;
+                "@angular-eslint/no-duplicates-in-metadata-arrays": string;
                 "@angular-eslint/no-empty-lifecycle-method": string;
                 "@angular-eslint/no-forward-ref": string;
                 "@angular-eslint/no-host-metadata-property": string;
@@ -84,6 +85,7 @@ declare const _default: {
         "no-async-lifecycle-method": import("@typescript-eslint/utils/ts-eslint").RuleModule<"noAsyncLifecycleMethod", [], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
         "no-attribute-decorator": import("@typescript-eslint/utils/ts-eslint").RuleModule<"noAttributeDecorator", [], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
         "no-conflicting-lifecycle": import("@typescript-eslint/utils/ts-eslint").RuleModule<import("./rules/no-conflicting-lifecycle").MessageIds, [], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+        "no-duplicates-in-metadata-arrays": import("@typescript-eslint/utils/ts-eslint").RuleModule<"noDuplicatesInMetadataArrays", [], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
         "no-empty-lifecycle-method": import("@typescript-eslint/utils/ts-eslint").RuleModule<import("./rules/no-empty-lifecycle-method").MessageIds, [], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
         "no-forward-ref": import("@typescript-eslint/utils/ts-eslint").RuleModule<"noForwardRef", [], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
         "no-host-metadata-property": import("@typescript-eslint/utils/ts-eslint").RuleModule<"noHostMetadataProperty", [{

package/dist/index.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;AAsHA,kBA8CE"}
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;AAyHA,kBA+CE"}

package/dist/index.js

@@ -65,6 +65,7 @@ const use_component_view_encapsulation_1 = __importStar(require("./rules/use-com
 const use_injectable_provided_in_1 = __importStar(require("./rules/use-injectable-provided-in"));
 const use_lifecycle_interface_1 = __importStar(require("./rules/use-lifecycle-interface"));
 const use_pipe_transform_interface_1 = __importStar(require("./rules/use-pipe-transform-interface"));
+const no_duplicates_in_metadata_arrays_1 = __importStar(require("./rules/no-duplicates-in-metadata-arrays"));
 module.exports = {
     configs: {
         all: all_json_1.default,
@@ -82,6 +83,7 @@ module.exports = {
         [no_async_lifecycle_method_1.RULE_NAME]: no_async_lifecycle_method_1.default,
         [no_attribute_decorator_1.RULE_NAME]: no_attribute_decorator_1.default,
         [no_conflicting_lifecycle_1.RULE_NAME]: no_conflicting_lifecycle_1.default,
+        [no_duplicates_in_metadata_arrays_1.RULE_NAME]: no_duplicates_in_metadata_arrays_1.default,
         [no_empty_lifecycle_method_1.RULE_NAME]: no_empty_lifecycle_method_1.default,
         [no_forward_ref_1.RULE_NAME]: no_forward_ref_1.default,
         [no_host_metadata_property_1.RULE_NAME]: no_host_metadata_property_1.default,

package/dist/rules/no-duplicates-in-metadata-arrays.d.ts

@@ -0,0 +1,5 @@
+export type MessageIds = 'noDuplicatesInMetadataArrays';
+export declare const RULE_NAME = "no-duplicates-in-metadata-arrays";
+declare const _default: import("@typescript-eslint/utils/ts-eslint").RuleModule<"noDuplicatesInMetadataArrays", [], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+export default _default;
+//# sourceMappingURL=no-duplicates-in-metadata-arrays.d.ts.map

package/dist/rules/no-duplicates-in-metadata-arrays.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"no-duplicates-in-metadata-arrays.d.ts","sourceRoot":"","sources":["../../src/rules/no-duplicates-in-metadata-arrays.ts"],"names":[],"mappings":"AAMA,MAAM,MAAM,UAAU,GAAG,8BAA8B,CAAC;AACxD,eAAO,MAAM,SAAS,qCAAqC,CAAC;;AAE5D,wBA4CG"}

package/dist/rules/no-duplicates-in-metadata-arrays.js

@@ -0,0 +1,64 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.RULE_NAME = void 0;
+const utils_1 = require("@angular-eslint/utils");
+const create_eslint_rule_1 = require("../utils/create-eslint-rule");
+const utils_2 = require("@typescript-eslint/utils");
+exports.RULE_NAME = 'no-duplicates-in-metadata-arrays';
+exports.default = (0, create_eslint_rule_1.createESLintRule)({
+    name: exports.RULE_NAME,
+    meta: {
+        type: 'suggestion',
+        docs: {
+            description: 'Ensures that metadata arrays do not contain duplicate entries.',
+        },
+        schema: [],
+        messages: {
+            noDuplicatesInMetadataArrays: 'Entry is duplicated in metadata array',
+        },
+    },
+    defaultOptions: [],
+    create(context) {
+        const selectors = [
+            // https://angular.io/api/core/NgModule
+            `${utils_1.Selectors.MODULE_CLASS_DECORATOR} Property[key.name=${(0, utils_1.toPattern)([
+                'providers',
+                'declarations',
+                'imports',
+                'exports',
+            ])}] > ArrayExpression`,
+            // https://angular.io/api/core/Component
+            `${utils_1.Selectors.COMPONENT_CLASS_DECORATOR} Property[key.name=${(0, utils_1.toPattern)([
+                'imports',
+            ])}] > ArrayExpression`,
+            // https://angular.io/api/core/Directive
+            `${utils_1.Selectors.DIRECTIVE_CLASS_DECORATOR} Property[key.name=${(0, utils_1.toPattern)([
+                'providers',
+            ])}] > ArrayExpression`,
+        ].join(',');
+        return {
+            [selectors]({ elements }) {
+                getDuplicateItems(elements).forEach((duplicateImport) => {
+                    context.report({
+                        node: duplicateImport,
+                        messageId: 'noDuplicatesInMetadataArrays',
+                    });
+                });
+            },
+        };
+    },
+});
+function getDuplicateItems(elements) {
+    const items = elements.filter(utils_2.ASTUtils.isIdentifier);
+    const uniqueItemNames = new Set();
+    const duplicateItems = [];
+    items.forEach((item) => {
+        if (uniqueItemNames.has(item.name)) {
+            duplicateItems.push(item);
+        }
+        else {
+            uniqueItemNames.add(item.name);
+        }
+    });
+    return duplicateItems;
+}

package/dist/rules/sort-ngmodule-metadata-arrays.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"sort-ngmodule-metadata-arrays.d.ts","sourceRoot":"","sources":["../../src/rules/sort-ngmodule-metadata-arrays.ts"],"names":[],"mappings":"AAKA,KAAK,OAAO,GAAG;IACb;QACE,QAAQ,CAAC,MAAM,EAAE,MAAM,CAAC;KACzB;CACF,CAAC;AACF,MAAM,MAAM,UAAU,GAAG,4BAA4B,CAAC;AACtD,eAAO,MAAM,SAAS,kCAAkC,CAAC;;AAGzD,wBA0DG"}
+{"version":3,"file":"sort-ngmodule-metadata-arrays.d.ts","sourceRoot":"","sources":["../../src/rules/sort-ngmodule-metadata-arrays.ts"],"names":[],"mappings":"AAKA,KAAK,OAAO,GAAG;IACb;QACE,QAAQ,CAAC,MAAM,EAAE,MAAM,CAAC;KACzB;CACF,CAAC;AACF,MAAM,MAAM,UAAU,GAAG,4BAA4B,CAAC;AACtD,eAAO,MAAM,SAAS,kCAAkC,CAAC;;AAGzD,wBA2DG"}

package/dist/rules/sort-ngmodule-metadata-arrays.js

@@ -10,6 +10,7 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
     name: exports.RULE_NAME,
     meta: {
         type: 'suggestion',
+        deprecated: true,
         docs: {
             description: 'Ensures ASC alphabetical order for `NgModule` metadata arrays for easy visual scanning',
         },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@angular-eslint/eslint-plugin",
-  "version": "17.3.1-alpha.12",
+  "version": "17.3.1-alpha.14",
   "description": "ESLint plugin for Angular applications, following angular.io/styleguide",
   "license": "MIT",
   "main": "dist/index.js",
@@ -18,9 +18,9 @@
     "LICENSE"
   ],
   "dependencies": {
-    "@angular-eslint/bundled-angular-compiler": "17.3.1-alpha.12",
-    "@angular-eslint/utils": "17.3.1-alpha.12",
-    "@typescript-eslint/utils": "7.7.0"
+    "@angular-eslint/bundled-angular-compiler": "17.3.1-alpha.14",
+    "@angular-eslint/utils": "17.3.1-alpha.14",
+    "@typescript-eslint/utils": "7.8.0"
   },
   "peerDependencies": {
     "eslint": "^7.20.0 || ^8.0.0",