@angular-eslint/eslint-plugin 17.1.2-alpha.5 → 17.1.2-alpha.7

package/README.md

@@ -20,6 +20,7 @@
 | Rule | Description | :white_check_mark: | :wrench: | :bulb: |
 | --- | --- | --- | --- | --- |
 | [`contextual-lifecycle`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/contextual-lifecycle.md) | Ensures that lifecycle methods are used in a correct context | :white_check_mark: |  |  |
+| [`no-async-lifecycle-method`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/no-async-lifecycle-method.md) | Angular Lifecycle methods should not be async. Angular does not wait for async lifecycle but the code incorrectly suggests it does. |  |  |  |
 | [`no-attribute-decorator`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/no-attribute-decorator.md) | The @Attribute decorator is used to obtain a single value for an attribute. This is a much less common use-case than getting a stream of values (using @Input), so often the @Attribute decorator is mistakenly used when @Input was what was intended. This rule disallows usage of @Attribute decorator altogether in order to prevent these mistakes. |  |  |  |
 | [`sort-lifecycle-methods`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/docs/rules/sort-lifecycle-methods.md) | Ensures that lifecycle methods are declared in order of execution |  |  |  |
 <!-- prettier-ignore-end -->

package/dist/configs/all.json

@@ -9,6 +9,7 @@
     "@angular-eslint/contextual-lifecycle": "error",
     "@angular-eslint/directive-class-suffix": "error",
     "@angular-eslint/directive-selector": "error",
+    "@angular-eslint/no-async-lifecycle-method": "error",
     "@angular-eslint/no-attribute-decorator": "error",
     "@angular-eslint/no-conflicting-lifecycle": "error",
     "@angular-eslint/no-empty-lifecycle-method": "error",

package/dist/index.js

@@ -34,6 +34,7 @@ const contextual_decorator_1 = __importStar(require("./rules/contextual-decorato
 const contextual_lifecycle_1 = __importStar(require("./rules/contextual-lifecycle"));
 const directive_class_suffix_1 = __importStar(require("./rules/directive-class-suffix"));
 const directive_selector_1 = __importStar(require("./rules/directive-selector"));
+const no_async_lifecycle_method_1 = __importStar(require("./rules/no-async-lifecycle-method"));
 const no_attribute_decorator_1 = __importStar(require("./rules/no-attribute-decorator"));
 const no_conflicting_lifecycle_1 = __importStar(require("./rules/no-conflicting-lifecycle"));
 const no_empty_lifecycle_method_1 = __importStar(require("./rules/no-empty-lifecycle-method"));
@@ -75,6 +76,7 @@ module.exports = {
         [contextual_lifecycle_1.RULE_NAME]: contextual_lifecycle_1.default,
         [directive_class_suffix_1.RULE_NAME]: directive_class_suffix_1.default,
         [directive_selector_1.RULE_NAME]: directive_selector_1.default,
+        [no_async_lifecycle_method_1.RULE_NAME]: no_async_lifecycle_method_1.default,
         [no_attribute_decorator_1.RULE_NAME]: no_attribute_decorator_1.default,
         [no_conflicting_lifecycle_1.RULE_NAME]: no_conflicting_lifecycle_1.default,
         [no_empty_lifecycle_method_1.RULE_NAME]: no_empty_lifecycle_method_1.default,

package/dist/rules/no-async-lifecycle-method.js

@@ -0,0 +1,42 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.RULE_NAME = void 0;
+const utils_1 = require("@angular-eslint/utils");
+const create_eslint_rule_1 = require("../utils/create-eslint-rule");
+exports.RULE_NAME = 'no-async-lifecycle-method';
+exports.default = (0, create_eslint_rule_1.createESLintRule)({
+    name: exports.RULE_NAME,
+    meta: {
+        type: 'problem',
+        docs: {
+            description: `Angular Lifecycle methods should not be async. Angular does not wait for async lifecycle but the code incorrectly suggests it does.`,
+        },
+        schema: [],
+        messages: {
+            noAsyncLifecycleMethod: 'Angular Lifecycle method should not be async',
+        },
+    },
+    defaultOptions: [],
+    create(context) {
+        const angularDecoratorsPattern = (0, utils_1.toPattern)([
+            'Component',
+            'Directive',
+            'Injectable',
+            'NgModule',
+            'Pipe',
+        ]);
+        const angularLifecycleMethodsPattern = (0, utils_1.toPattern)([
+            ...utils_1.ASTUtils.ANGULAR_LIFECYCLE_METHODS,
+        ]);
+        return {
+            [`${utils_1.Selectors.decoratorDefinition(angularDecoratorsPattern)} > ClassBody > MethodDefinition[key.name=${angularLifecycleMethodsPattern}]`](node) {
+                if (node.value.async === true) {
+                    context.report({
+                        node: node.key,
+                        messageId: 'noAsyncLifecycleMethod',
+                    });
+                }
+            },
+        };
+    },
+});

package/dist/rules/no-empty-lifecycle-method.js

@@ -22,11 +22,18 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
     defaultOptions: [],
     create(context) {
         const sourceCode = context.getSourceCode();
+        const angularDecoratorsPattern = (0, utils_1.toPattern)([
+            'Component',
+            'Directive',
+            'Injectable',
+            'NgModule',
+            'Pipe',
+        ]);
         const angularLifecycleMethodsPattern = (0, utils_1.toPattern)([
             ...utils_1.ASTUtils.ANGULAR_LIFECYCLE_METHODS,
         ]);
         return {
-            [`ClassDeclaration:has(Decorator[expression.callee.name=/^(Component|Directive|Injectable|NgModule|Pipe)$/]) > ClassBody > ${utils_1.Selectors.methodDefinition(angularLifecycleMethodsPattern)}[value.body.body.length=0]`](node) {
+            [`${utils_1.Selectors.decoratorDefinition(angularDecoratorsPattern)} > ClassBody > ${utils_1.Selectors.methodDefinition(angularLifecycleMethodsPattern)}[value.body.body.length=0]`](node) {
                 context.report({
                     node,
                     messageId: 'noEmptyLifecycleMethod',

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@angular-eslint/eslint-plugin",
-  "version": "17.1.2-alpha.5",
+  "version": "17.1.2-alpha.7",
   "description": "ESLint plugin for Angular applications, following angular.io/styleguide",
   "license": "MIT",
   "main": "dist/index.js",
@@ -17,8 +17,8 @@
     "LICENSE"
   ],
   "dependencies": {
-    "@angular-eslint/utils": "17.1.2-alpha.5",
-    "@typescript-eslint/utils": "6.13.1"
+    "@angular-eslint/utils": "17.1.2-alpha.7",
+    "@typescript-eslint/utils": "6.18.0"
   },
   "peerDependencies": {
     "eslint": "^7.20.0 || ^8.0.0",