@angular-eslint/eslint-plugin-template 22.3.1-alpha.1 → 22.3.1-alpha.3

package/dist/rules/button-has-type.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"button-has-type.d.ts","sourceRoot":"","sources":["../../src/rules/button-has-type.ts"],"names":[],"mappings":"AAWA,MAAM,MAAM,OAAO,GAAG;IACpB;QACE,QAAQ,CAAC,oBAAoB,CAAC,EAAE,MAAM,EAAE,CAAC;KAC1C;CACF,CAAC;AACF,MAAM,MAAM,UAAU,GAAG,aAAa,GAAG,aAAa,CAAC;AACvD,eAAO,MAAM,SAAS,oBAAoB,CAAC;AAI3C,eAAO,MAAM,qBAAqB,SAAS,CAAC;;;;AAW5C,wBA2DG;AAEH,eAAO,MAAM,mBAAmB;;CAG/B,CAAC"}
+{"version":3,"file":"button-has-type.d.ts","sourceRoot":"","sources":["../../src/rules/button-has-type.ts"],"names":[],"mappings":"AAYA,MAAM,MAAM,OAAO,GAAG;IACpB;QACE,QAAQ,CAAC,oBAAoB,CAAC,EAAE,MAAM,EAAE,CAAC;KAC1C;CACF,CAAC;AACF,MAAM,MAAM,UAAU,GAAG,aAAa,GAAG,aAAa,CAAC;AACvD,eAAO,MAAM,SAAS,oBAAoB,CAAC;AAI3C,eAAO,MAAM,qBAAqB,SAAS,CAAC;;;;AAW5C,wBA+DG;AAEH,eAAO,MAAM,mBAAmB;;CAG/B,CAAC"}

package/dist/rules/button-has-type.js

@@ -4,6 +4,7 @@ exports.RULE_DOCS_EXTENSION = exports.INVALID_TYPE_DATA_KEY = exports.RULE_NAME
 const bundled_angular_compiler_1 = require("@angular-eslint/bundled-angular-compiler");
 const utils_1 = require("@angular-eslint/utils");
 const create_eslint_rule_1 = require("../utils/create-eslint-rule");
+const has_ignored_directive_1 = require("../utils/has-ignored-directive");
 exports.RULE_NAME = 'button-has-type';
 const DEFAULT_OPTIONS = {
     ignoreWithDirectives: [],
@@ -27,6 +28,7 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
                         type: 'array',
                         items: { type: 'string' },
                         uniqueItems: true,
+                        description: 'Directive names that, when present on the element, cause it to be ignored. Entries wrapped in slashes, e.g. `/^tui/`, are treated as regular expressions.',
                         default: DEFAULT_OPTIONS.ignoreWithDirectives,
                     },
                 },
@@ -41,10 +43,11 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
     },
     create(context, [{ ignoreWithDirectives }]) {
         const parserServices = (0, utils_1.getTemplateParserServices)(context);
+        const hasIgnoredDirective = (0, has_ignored_directive_1.createIgnoredDirectiveMatcher)(ignoreWithDirectives);
         return {
             [`Element[name=/^(button)$/i]`](element) {
                 if (!isTypeAttributePresentInElement(element)) {
-                    if (!isIgnored(ignoreWithDirectives, element)) {
+                    if (!hasIgnoredDirective(element)) {
                         context.report({
                             loc: parserServices.convertNodeSourceSpanToLoc(element.sourceSpan),
                             messageId: 'missingType',
@@ -71,21 +74,6 @@ exports.RULE_DOCS_EXTENSION = {
 function isTypeAttributePresentInElement({ inputs, attributes, }) {
     return [...inputs, ...attributes].some(({ name }) => name === TYPE_ATTRIBUTE_NAME);
 }
-function isIgnored(ignoreWithDirectives, { inputs, attributes }) {
-    if (ignoreWithDirectives && ignoreWithDirectives.length > 0) {
-        for (const input of inputs) {
-            if (ignoreWithDirectives.includes(input.name)) {
-                return true;
-            }
-        }
-        for (const attribute of attributes) {
-            if (ignoreWithDirectives.includes(attribute.name)) {
-                return true;
-            }
-        }
-    }
-    return false;
-}
 function getInvalidButtonTypeIfPresent(element) {
     const invalidTextAttribute = element.attributes.find(({ name, value }) => name === TYPE_ATTRIBUTE_NAME && !VALID_BUTTON_TYPES.includes(value));
     if (invalidTextAttribute) {

package/dist/rules/click-events-have-key-events.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"click-events-have-key-events.d.ts","sourceRoot":"","sources":["../../src/rules/click-events-have-key-events.ts"],"names":[],"mappings":"AAaA,MAAM,MAAM,OAAO,GAAG;IACpB;QACE,QAAQ,CAAC,oBAAoB,CAAC,EAAE,MAAM,EAAE,CAAC;QACzC,QAAQ,CAAC,cAAc,CAAC,EAAE,OAAO,CAAC;QAClC,QAAQ,CAAC,eAAe,CAAC,EAAE,MAAM,EAAE,CAAC;KACrC;CACF,CAAC;AACF,MAAM,MAAM,UAAU,GAClB,0BAA0B,GAC1B,wBAAwB,GACxB,+BAA+B,CAAC;AACpC,eAAO,MAAM,SAAS,iCAAiC,CAAC;;;;AASxD,wBA+HG;AAyCH,eAAO,MAAM,mBAAmB;;CAG/B,CAAC"}
+{"version":3,"file":"click-events-have-key-events.d.ts","sourceRoot":"","sources":["../../src/rules/click-events-have-key-events.ts"],"names":[],"mappings":"AAcA,MAAM,MAAM,OAAO,GAAG;IACpB;QACE,QAAQ,CAAC,oBAAoB,CAAC,EAAE,MAAM,EAAE,CAAC;QACzC,QAAQ,CAAC,cAAc,CAAC,EAAE,OAAO,CAAC;QAClC,QAAQ,CAAC,eAAe,CAAC,EAAE,MAAM,EAAE,CAAC;KACrC;CACF,CAAC;AACF,MAAM,MAAM,UAAU,GAClB,0BAA0B,GAC1B,wBAAwB,GACxB,+BAA+B,CAAC;AACpC,eAAO,MAAM,SAAS,iCAAiC,CAAC;;;;AASxD,wBAmIG;AAqBH,eAAO,MAAM,mBAAmB;;CAG/B,CAAC"}

package/dist/rules/click-events-have-key-events.js

@@ -3,6 +3,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.RULE_DOCS_EXTENSION = exports.RULE_NAME = void 0;
 const utils_1 = require("@angular-eslint/utils");
 const create_eslint_rule_1 = require("../utils/create-eslint-rule");
+const has_ignored_directive_1 = require("../utils/has-ignored-directive");
 const get_dom_elements_1 = require("../utils/get-dom-elements");
 const is_hidden_from_screen_reader_1 = require("../utils/is-hidden-from-screen-reader");
 const is_interactive_element_1 = require("../utils/is-interactive-element");
@@ -30,6 +31,7 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
                         type: 'array',
                         items: { type: 'string' },
                         uniqueItems: true,
+                        description: 'Directive names that, when present on the element, cause it to be ignored. Entries wrapped in slashes, e.g. `/^tui/`, are treated as regular expressions.',
                         default: DEFAULT_OPTIONS.ignoreWithDirectives,
                     },
                     requireKeyCode: {
@@ -57,12 +59,13 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
     },
     create(context, [{ ignoreWithDirectives, requireKeyCode, allowedKeyCodes }]) {
         const normalizedAllowedKeyCodes = (allowedKeyCodes ?? []).map((keyCode) => keyCode.toLowerCase());
+        const hasIgnoredDirective = (0, has_ignored_directive_1.createIgnoredDirectiveMatcher)(ignoreWithDirectives);
         return {
             Element(node) {
                 if (!(0, get_dom_elements_1.getDomElements)().has(node.name.toLowerCase())) {
                     return;
                 }
-                if (isIgnored(ignoreWithDirectives, node) ||
+                if (hasIgnoredDirective(node) ||
                     (0, is_presentation_role_1.isPresentationRole)(node) ||
                     (0, is_hidden_from_screen_reader_1.isHiddenFromScreenReader)(node) ||
                     (0, is_interactive_element_1.isInherentlyInteractiveElement)(node)) {
@@ -139,21 +142,6 @@ function getKeyCode({ name }) {
     const keyCode = segments[segments.length - 1].toLowerCase();
     return keyCode.length > 0 ? keyCode : undefined;
 }
-function isIgnored(ignoreWithDirectives, { inputs, attributes }) {
-    if (ignoreWithDirectives && ignoreWithDirectives.length > 0) {
-        for (const input of inputs) {
-            if (ignoreWithDirectives.includes(input.name)) {
-                return true;
-            }
-        }
-        for (const attribute of attributes) {
-            if (ignoreWithDirectives.includes(attribute.name)) {
-                return true;
-            }
-        }
-    }
-    return false;
-}
 exports.RULE_DOCS_EXTENSION = {
     rationale: 'Elements with click handlers must also be operable via keyboard for users who cannot use a mouse. This includes users with motor disabilities, users of assistive technologies, and keyboard-only users. While native interactive elements like buttons and links are keyboard-accessible by default (activated by Enter or Space keys), non-interactive elements with click handlers (like divs or spans) are not. For such elements, you must add keyboard event handlers (keyup, keydown, or keypress) that perform the same action as the click handler. Alternatively, use a semantic button element which handles this automatically. This is a WCAG Level A requirement for keyboard accessibility.',
 };

package/dist/rules/prefer-self-closing-tags.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"prefer-self-closing-tags.d.ts","sourceRoot":"","sources":["../../src/rules/prefer-self-closing-tags.ts"],"names":[],"mappings":"AAUA,MAAM,MAAM,OAAO,GAAG,EAAE,CAAC;AACzB,MAAM,MAAM,UAAU,GAAG,uBAAuB,CAAC;AACjD,eAAO,MAAM,SAAS,6BAA6B,CAAC;;;;AAEpD,wBA+JG;AAuCH,eAAO,MAAM,mBAAmB;;CAG/B,CAAC"}
+{"version":3,"file":"prefer-self-closing-tags.d.ts","sourceRoot":"","sources":["../../src/rules/prefer-self-closing-tags.ts"],"names":[],"mappings":"AAUA,MAAM,MAAM,OAAO,GAAG,EAAE,CAAC;AACzB,MAAM,MAAM,UAAU,GAAG,uBAAuB,CAAC;AACjD,eAAO,MAAM,SAAS,6BAA6B,CAAC;;;;AAEpD,wBA+JG;AAoDH,eAAO,MAAM,mBAAmB;;CAG/B,CAAC"}

package/dist/rules/prefer-self-closing-tags.js

@@ -34,7 +34,7 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
                 }
                 else {
                     // Ignore native elements.
-                    if ('name' in node && (0, get_dom_elements_1.getDomElements)().has(node.name.toLowerCase())) {
+                    if ('name' in node && isNativeElement(node.name)) {
                         return;
                     }
                     processElementOrTemplateNode(node);
@@ -135,6 +135,16 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
         }
     },
 });
+function isNativeElement(name) {
+    const lowerCaseName = name.toLowerCase();
+    // The Angular compiler namespaces the children of `<svg>` and `<math>`
+    // (e.g. `:svg:use` and `:math:mi`). These are foreign elements that are
+    // native to the browser, and self-closing some of them (such as `<title />`)
+    // produces a template that Angular cannot parse.
+    return (lowerCaseName.startsWith(':svg:') ||
+        lowerCaseName.startsWith(':math:') ||
+        (0, get_dom_elements_1.getDomElements)().has(lowerCaseName));
+}
 function isContentNode(node) {
     return 'name' in node && node.name.toLowerCase() === 'ng-content';
 }

package/dist/utils/has-ignored-directive.d.ts

@@ -0,0 +1,11 @@
+import type { TmplAstElement } from '@angular-eslint/bundled-angular-compiler';
+/**
+ * Compiles an `ignoreWithDirectives` option into a predicate that reports
+ * whether an element carries one of the ignored directives.
+ *
+ * Entries wrapped in slashes, e.g. `/^tui/`, are treated as regular
+ * expressions (an optional flags suffix is supported, e.g. `/^tui/i`).
+ * All other entries are matched exactly against the directive name.
+ */
+export declare function createIgnoredDirectiveMatcher(ignoreWithDirectives: readonly string[] | undefined): (element: TmplAstElement) => boolean;
+//# sourceMappingURL=has-ignored-directive.d.ts.map

package/dist/utils/has-ignored-directive.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"has-ignored-directive.d.ts","sourceRoot":"","sources":["../../src/utils/has-ignored-directive.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,0CAA0C,CAAC;AAM/E;;;;;;;GAOG;AACH,wBAAgB,6BAA6B,CAC3C,oBAAoB,EAAE,SAAS,MAAM,EAAE,GAAG,SAAS,GAClD,CAAC,OAAO,EAAE,cAAc,KAAK,OAAO,CAsBtC"}

package/dist/utils/has-ignored-directive.js

@@ -0,0 +1,28 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.createIgnoredDirectiveMatcher = createIgnoredDirectiveMatcher;
+const REGEX_LITERAL_PATTERN = /^\/(.+)\/([a-z]*)$/;
+/**
+ * Compiles an `ignoreWithDirectives` option into a predicate that reports
+ * whether an element carries one of the ignored directives.
+ *
+ * Entries wrapped in slashes, e.g. `/^tui/`, are treated as regular
+ * expressions (an optional flags suffix is supported, e.g. `/^tui/i`).
+ * All other entries are matched exactly against the directive name.
+ */
+function createIgnoredDirectiveMatcher(ignoreWithDirectives) {
+    if (!ignoreWithDirectives || ignoreWithDirectives.length === 0) {
+        return () => false;
+    }
+    const matchers = ignoreWithDirectives.map((entry) => {
+        const regexLiteral = REGEX_LITERAL_PATTERN.exec(entry);
+        if (regexLiteral) {
+            const pattern = new RegExp(regexLiteral[1], regexLiteral[2]);
+            return (name) => pattern.test(name);
+        }
+        return (name) => name === entry;
+    });
+    const isIgnoredName = (name) => matchers.some((matcher) => matcher(name));
+    return ({ inputs, attributes }) => inputs.some(({ name }) => isIgnoredName(name)) ||
+        attributes.some(({ name }) => isIgnoredName(name));
+}

package/dist/utils/literal-primitive.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"literal-primitive.d.ts","sourceRoot":"","sources":["../../src/utils/literal-primitive.ts"],"names":[],"mappings":"AAAA,OAAO,EACL,GAAG,EACH,gBAAgB,EACjB,MAAM,0CAA0C,CAAC;AAElD,MAAM,MAAM,KAAK,GAAG,GAAG,GAAG,GAAG,GAAG,GAAG,CAAC;AAEpC,wBAAgB,kBAAkB,CAAC,IAAI,EAAE,GAAG,GAAG,IAAI,IAAI,gBAAgB,CAEtE;AAED,wBAAgB,wBAAwB,CACtC,IAAI,EAAE,GAAG,GACR,IAAI,IAAI,IAAI,CAAC,gBAAgB,EAAE,OAAO,CAAC,GAAG;IAAE,KAAK,EAAE,MAAM,CAAA;CAAE,CAE7D;AAED,wBAAgB,8BAA8B,CAC5C,IAAI,EAAE,gBAAgB,EACtB,KAAK,EAAE,KAAK,GACX,MAAM,CAIR"}
+{"version":3,"file":"literal-primitive.d.ts","sourceRoot":"","sources":["../../src/utils/literal-primitive.ts"],"names":[],"mappings":"AAAA,OAAO,EACL,GAAG,EACH,gBAAgB,EACjB,MAAM,0CAA0C,CAAC;AAElD,MAAM,MAAM,KAAK,GAAG,GAAG,GAAG,GAAG,GAAG,GAAG,CAAC;AAEpC,wBAAgB,kBAAkB,CAAC,IAAI,EAAE,GAAG,GAAG,IAAI,IAAI,gBAAgB,CAStE;AAED,wBAAgB,wBAAwB,CACtC,IAAI,EAAE,GAAG,GACR,IAAI,IAAI,IAAI,CAAC,gBAAgB,EAAE,OAAO,CAAC,GAAG;IAAE,KAAK,EAAE,MAAM,CAAA;CAAE,CAE7D;AAED,wBAAgB,8BAA8B,CAC5C,IAAI,EAAE,gBAAgB,EACtB,KAAK,EAAE,KAAK,GACX,MAAM,CAIR"}

package/dist/utils/literal-primitive.js

@@ -5,7 +5,12 @@ exports.isStringLiteralPrimitive = isStringLiteralPrimitive;
 exports.getLiteralPrimitiveStringValue = getLiteralPrimitiveStringValue;
 const bundled_angular_compiler_1 = require("@angular-eslint/bundled-angular-compiler");
 function isLiteralPrimitive(node) {
-    return node instanceof bundled_angular_compiler_1.LiteralPrimitive;
+    // The template parser stamps `type` from `constructor.name`. `instanceof`
+    // fails when more than one copy of `@angular-eslint/bundled-angular-compiler`
+    // is installed (version mismatches, Yarn `hoistingLimits`, etc.).
+    return (!!node &&
+        (node.type === 'LiteralPrimitive' ||
+            node instanceof bundled_angular_compiler_1.LiteralPrimitive));
 }
 function isStringLiteralPrimitive(node) {
     return isLiteralPrimitive(node) && typeof node.value === 'string';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@angular-eslint/eslint-plugin-template",
-  "version": "22.3.1-alpha.1",
+  "version": "22.3.1-alpha.3",
   "description": "ESLint plugin for Angular Templates",
   "license": "MIT",
   "main": "dist/index.js",
@@ -19,17 +19,17 @@
     "LICENSE"
   ],
   "dependencies": {
-    "@angular-eslint/bundled-angular-compiler": "22.3.1-alpha.1",
-    "@angular-eslint/utils": "22.3.1-alpha.1",
+    "@angular-eslint/bundled-angular-compiler": "22.3.1-alpha.3",
+    "@angular-eslint/utils": "22.3.1-alpha.3",
     "aria-query": "5.3.2",
     "axobject-query": "4.1.0"
   },
   "devDependencies": {
-    "@angular-eslint/test-utils": "22.3.1-alpha.1",
+    "@angular-eslint/test-utils": "22.3.1-alpha.3",
     "@types/aria-query": "5.0.4"
   },
   "peerDependencies": {
-    "@angular-eslint/template-parser": "22.3.1-alpha.1",
+    "@angular-eslint/template-parser": "22.3.1-alpha.3",
     "@typescript-eslint/types": "^8.0.0",
     "@typescript-eslint/utils": "^8.0.0",
     "eslint": "^9.0.0 || ^10.0.0",