@angular-eslint/eslint-plugin-template 19.2.2-alpha.2 → 19.2.2-alpha.3

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/dist/index.d.ts CHANGED
@@ -86,7 +86,7 @@ declare const _default: {
86
86
  "alt-text": import("@typescript-eslint/utils/ts-eslint").RuleModule<"altText", [], import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
87
87
  "attributes-order": import("@typescript-eslint/utils/ts-eslint").RuleModule<"attributesOrder", import("./rules/attributes-order").Options, import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
88
88
  "banana-in-box": import("@typescript-eslint/utils/ts-eslint").RuleModule<"bananaInBox", [], import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
89
- "button-has-type": import("@typescript-eslint/utils/ts-eslint").RuleModule<import("./rules/button-has-type").MessageIds, [], import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
89
+ "button-has-type": import("@typescript-eslint/utils/ts-eslint").RuleModule<import("./rules/button-has-type").MessageIds, import("./rules/button-has-type").Options, import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
90
90
  "click-events-have-key-events": import("@typescript-eslint/utils/ts-eslint").RuleModule<"clickEventsHaveKeyEvents", [], import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
91
91
  "conditional-complexity": import("@typescript-eslint/utils/ts-eslint").RuleModule<"conditionalComplexity", import("./rules/conditional-complexity").Options, import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
92
92
  "cyclomatic-complexity": import("@typescript-eslint/utils/ts-eslint").RuleModule<"cyclomaticComplexity", import("./rules/cyclomatic-complexity").Options, import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
@@ -1,7 +1,11 @@
1
- export type Options = [];
1
+ export type Options = [
2
+ {
3
+ readonly ignoreWithDirectives?: string[];
4
+ }
5
+ ];
2
6
  export type MessageIds = 'invalidType' | 'missingType';
3
7
  export declare const RULE_NAME = "button-has-type";
4
8
  export declare const INVALID_TYPE_DATA_KEY = "type";
5
- declare const _default: import("@typescript-eslint/utils/ts-eslint").RuleModule<MessageIds, [], import("../utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
9
+ declare const _default: import("@typescript-eslint/utils/ts-eslint").RuleModule<MessageIds, Options, import("../utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
6
10
  export default _default;
7
11
  //# sourceMappingURL=button-has-type.d.ts.map
@@ -1 +1 @@
1
- {"version":3,"file":"button-has-type.d.ts","sourceRoot":"","sources":["../../src/rules/button-has-type.ts"],"names":[],"mappings":"AAWA,MAAM,MAAM,OAAO,GAAG,EAAE,CAAC;AACzB,MAAM,MAAM,UAAU,GAAG,aAAa,GAAG,aAAa,CAAC;AACvD,eAAO,MAAM,SAAS,oBAAoB,CAAC;AAE3C,eAAO,MAAM,qBAAqB,SAAS,CAAC;;AAW5C,wBAyCG"}
1
+ {"version":3,"file":"button-has-type.d.ts","sourceRoot":"","sources":["../../src/rules/button-has-type.ts"],"names":[],"mappings":"AAWA,MAAM,MAAM,OAAO,GAAG;IACpB;QACE,QAAQ,CAAC,oBAAoB,CAAC,EAAE,MAAM,EAAE,CAAC;KAC1C;CACF,CAAC;AACF,MAAM,MAAM,UAAU,GAAG,aAAa,GAAG,aAAa,CAAC;AACvD,eAAO,MAAM,SAAS,oBAAoB,CAAC;AAI3C,eAAO,MAAM,qBAAqB,SAAS,CAAC;;AAW5C,wBA4DG"}
@@ -5,6 +5,9 @@ const bundled_angular_compiler_1 = require("@angular-eslint/bundled-angular-comp
5
5
  const utils_1 = require("@angular-eslint/utils");
6
6
  const create_eslint_rule_1 = require("../utils/create-eslint-rule");
7
7
  exports.RULE_NAME = 'button-has-type';
8
+ const DEFAULT_OPTIONS = {
9
+ ignoreWithDirectives: [],
10
+ };
8
11
  exports.INVALID_TYPE_DATA_KEY = 'type';
9
12
  // https://www.w3.org/TR/html401/interact/forms.html#adef-type-BUTTON
10
13
  const VALID_BUTTON_TYPES = ['button', 'submit', 'reset'];
@@ -16,22 +19,37 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
16
19
  docs: {
17
20
  description: 'Ensures that a button has a valid type specified',
18
21
  },
19
- schema: [],
22
+ schema: [
23
+ {
24
+ type: 'object',
25
+ properties: {
26
+ ignoreWithDirectives: {
27
+ type: 'array',
28
+ items: { type: 'string' },
29
+ uniqueItems: true,
30
+ default: DEFAULT_OPTIONS.ignoreWithDirectives,
31
+ },
32
+ },
33
+ additionalProperties: false,
34
+ },
35
+ ],
20
36
  messages: {
21
37
  missingType: 'Type for <button> is missing',
22
38
  invalidType: `"{{${exports.INVALID_TYPE_DATA_KEY}}}" can not be used as a type for <button>`,
23
39
  },
24
40
  },
25
- defaultOptions: [],
26
- create(context) {
41
+ defaultOptions: [{}],
42
+ create(context, [{ ignoreWithDirectives }]) {
27
43
  const parserServices = (0, utils_1.getTemplateParserServices)(context);
28
44
  return {
29
45
  [`Element$1[name=button]`](element) {
30
46
  if (!isTypeAttributePresentInElement(element)) {
31
- context.report({
32
- loc: parserServices.convertNodeSourceSpanToLoc(element.sourceSpan),
33
- messageId: 'missingType',
34
- });
47
+ if (!isIgnored(ignoreWithDirectives, element)) {
48
+ context.report({
49
+ loc: parserServices.convertNodeSourceSpanToLoc(element.sourceSpan),
50
+ messageId: 'missingType',
51
+ });
52
+ }
35
53
  }
36
54
  const invalidTypeInfo = getInvalidButtonTypeIfPresent(element);
37
55
  if (invalidTypeInfo != null) {
@@ -50,6 +68,21 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
50
68
  function isTypeAttributePresentInElement({ inputs, attributes, }) {
51
69
  return [...inputs, ...attributes].some(({ name }) => name === TYPE_ATTRIBUTE_NAME);
52
70
  }
71
+ function isIgnored(ignoreWithDirectives, { inputs, attributes }) {
72
+ if (ignoreWithDirectives && ignoreWithDirectives.length > 0) {
73
+ for (const input of inputs) {
74
+ if (ignoreWithDirectives.includes(input.name)) {
75
+ return true;
76
+ }
77
+ }
78
+ for (const attribute of attributes) {
79
+ if (ignoreWithDirectives.includes(attribute.name)) {
80
+ return true;
81
+ }
82
+ }
83
+ }
84
+ return false;
85
+ }
53
86
  function getInvalidButtonTypeIfPresent(element) {
54
87
  const invalidTextAttribute = element.attributes.find(({ name, value }) => name === TYPE_ATTRIBUTE_NAME && !VALID_BUTTON_TYPES.includes(value));
55
88
  if (invalidTextAttribute) {
@@ -395,5 +395,5 @@ function isTagAllowed(allowedTags, node) {
395
395
  }
396
396
  // `customId` could be `undefined` in case of non-`Message`.
397
397
  function getI18nCustomId(i18n) {
398
- return i18n.customId;
398
+ return i18n?.customId;
399
399
  }
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@angular-eslint/eslint-plugin-template",
3
- "version": "19.2.2-alpha.2",
3
+ "version": "19.2.2-alpha.3",
4
4
  "description": "ESLint plugin for Angular Templates",
5
5
  "license": "MIT",
6
6
  "main": "dist/index.js",
@@ -20,13 +20,13 @@
20
20
  "dependencies": {
21
21
  "aria-query": "5.3.2",
22
22
  "axobject-query": "4.1.0",
23
- "@angular-eslint/bundled-angular-compiler": "19.2.2-alpha.2",
24
- "@angular-eslint/utils": "19.2.2-alpha.2"
23
+ "@angular-eslint/bundled-angular-compiler": "19.2.2-alpha.3",
24
+ "@angular-eslint/utils": "19.2.2-alpha.3"
25
25
  },
26
26
  "devDependencies": {
27
27
  "@types/aria-query": "5.0.4",
28
- "@angular-eslint/test-utils": "19.2.2-alpha.2",
29
- "@angular-eslint/template-parser": "19.2.2-alpha.2"
28
+ "@angular-eslint/template-parser": "19.2.2-alpha.3",
29
+ "@angular-eslint/test-utils": "19.2.2-alpha.3"
30
30
  },
31
31
  "peerDependencies": {
32
32
  "@typescript-eslint/types": "^7.11.0 || ^8.0.0",