@angular-eslint/eslint-plugin-template 19.0.3-alpha.8 → 19.1.0

package/README.md

@@ -87,6 +87,7 @@ Please see https://github.com/angular-eslint/angular-eslint for full usage instr
 | --- | --- | --- | --- | --- | --- |
 | [`attributes-order`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin-template/docs/rules/attributes-order.md) | Ensures that HTML attributes and Angular bindings are sorted based on an expected order |  | :wrench: |  |  |
 | [`prefer-self-closing-tags`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin-template/docs/rules/prefer-self-closing-tags.md) | Ensures that self-closing tags are used for elements with a closing tag but no content. |  | :wrench: |  |  |
+| [`prefer-static-string-properties`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin-template/docs/rules/prefer-static-string-properties.md) | Ensures that static string values use property assignment instead of property binding. |  | :wrench: |  |  |
 <!-- prettier-ignore-end -->
 
 <!-- end layout rule list -->

package/dist/configs/all.json

@@ -27,6 +27,7 @@
     "@angular-eslint/template/prefer-control-flow": "error",
     "@angular-eslint/template/prefer-ngsrc": "error",
     "@angular-eslint/template/prefer-self-closing-tags": "error",
+    "@angular-eslint/template/prefer-static-string-properties": "error",
     "@angular-eslint/template/role-has-required-aria": "error",
     "@angular-eslint/template/table-scope": "error",
     "@angular-eslint/template/use-track-by-function": "error",

package/dist/index.d.ts

@@ -29,6 +29,7 @@ declare const _default: {
                 "@angular-eslint/template/prefer-control-flow": string;
                 "@angular-eslint/template/prefer-ngsrc": string;
                 "@angular-eslint/template/prefer-self-closing-tags": string;
+                "@angular-eslint/template/prefer-static-string-properties": string;
                 "@angular-eslint/template/role-has-required-aria": string;
                 "@angular-eslint/template/table-scope": string;
                 "@angular-eslint/template/use-track-by-function": string;
@@ -106,6 +107,7 @@ declare const _default: {
         "no-positive-tabindex": import("@typescript-eslint/utils/ts-eslint").RuleModule<import("./rules/no-positive-tabindex").MessageIds, [], import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
         "prefer-control-flow": import("@typescript-eslint/utils/ts-eslint").RuleModule<"preferControlFlow", [], import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
         "prefer-self-closing-tags": import("@typescript-eslint/utils/ts-eslint").RuleModule<"preferSelfClosingTags", [], import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+        "prefer-static-string-properties": import("@typescript-eslint/utils/ts-eslint").RuleModule<"preferStaticStringProperties", [], import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
         "prefer-ngsrc": import("@typescript-eslint/utils/ts-eslint").RuleModule<import("./rules/prefer-ngsrc").MessageIds, [], import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
         "role-has-required-aria": import("@typescript-eslint/utils/ts-eslint").RuleModule<import("./rules/role-has-required-aria").MessageIds, [], import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
         "table-scope": import("@typescript-eslint/utils/ts-eslint").RuleModule<"tableScope", [], import("./utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;

package/dist/index.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;AAmFA,kBAuCE"}
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;AAsFA,kBAwCE"}

package/dist/index.js

@@ -55,6 +55,7 @@ const no_positive_tabindex_1 = __importStar(require("./rules/no-positive-tabinde
 const prefer_ngsrc_1 = __importStar(require("./rules/prefer-ngsrc"));
 const prefer_control_flow_1 = __importStar(require("./rules/prefer-control-flow"));
 const prefer_self_closing_tags_1 = __importStar(require("./rules/prefer-self-closing-tags"));
+const prefer_static_string_properties_1 = __importStar(require("./rules/prefer-static-string-properties"));
 const role_has_required_aria_1 = __importStar(require("./rules/role-has-required-aria"));
 const table_scope_1 = __importStar(require("./rules/table-scope"));
 const use_track_by_function_1 = __importStar(require("./rules/use-track-by-function"));
@@ -92,6 +93,7 @@ module.exports = {
         [no_positive_tabindex_1.RULE_NAME]: no_positive_tabindex_1.default,
         [prefer_control_flow_1.RULE_NAME]: prefer_control_flow_1.default,
         [prefer_self_closing_tags_1.RULE_NAME]: prefer_self_closing_tags_1.default,
+        [prefer_static_string_properties_1.RULE_NAME]: prefer_static_string_properties_1.default,
         [prefer_ngsrc_1.RULE_NAME]: prefer_ngsrc_1.default,
         [role_has_required_aria_1.RULE_NAME]: role_has_required_aria_1.default,
         [table_scope_1.RULE_NAME]: table_scope_1.default,

package/dist/rules/attributes-order.js

@@ -211,7 +211,8 @@ function toTemplateReferenceVariableOrderType(reference) {
     };
 }
 function isImplicitTemplate(node) {
-    return isTmplAstTemplate(node) && node.tagName !== 'ng-template';
+    return (isTmplAstTemplate(node) &&
+        (node.tagName === null || !/^(:svg:)?ng-template$/.test(node.tagName)));
 }
 function extractTemplateAttrs(node) {
     if (isTmplAstTemplate(node)) {

package/dist/rules/prefer-self-closing-tags.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"prefer-self-closing-tags.d.ts","sourceRoot":"","sources":["../../src/rules/prefer-self-closing-tags.ts"],"names":[],"mappings":"AAUA,MAAM,MAAM,OAAO,GAAG,EAAE,CAAC;AACzB,MAAM,MAAM,UAAU,GAAG,uBAAuB,CAAC;AACjD,eAAO,MAAM,SAAS,6BAA6B,CAAC;;AAEpD,wBAkIG"}
+{"version":3,"file":"prefer-self-closing-tags.d.ts","sourceRoot":"","sources":["../../src/rules/prefer-self-closing-tags.ts"],"names":[],"mappings":"AAUA,MAAM,MAAM,OAAO,GAAG,EAAE,CAAC;AACzB,MAAM,MAAM,UAAU,GAAG,uBAAuB,CAAC;AACjD,eAAO,MAAM,SAAS,6BAA6B,CAAC;;AAEpD,wBAuIG"}

package/dist/rules/prefer-self-closing-tags.js

@@ -1,6 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.RULE_NAME = void 0;
+const bundled_angular_compiler_1 = require("@angular-eslint/bundled-angular-compiler");
 const utils_1 = require("@angular-eslint/utils");
 const create_eslint_rule_1 = require("../utils/create-eslint-rule");
 const get_dom_elements_1 = require("../utils/get-dom-elements");
@@ -44,10 +45,16 @@ exports.default = (0, create_eslint_rule_1.createESLintRule)({
             const { children, startSourceSpan, endSourceSpan } = node;
             const noContent = !children.length ||
                 children.every((node) => {
-                    const text = node.value;
-                    // If the node has no value, or only whitespace,
-                    // we can consider it empty.
-                    return (typeof text === 'string' && text.replace(/\n/g, '').trim() === '');
+                    // If the node is only whitespace, we can consider it empty.
+                    // We need to look at the text from the source code, rather
+                    // than the `TmplAstText.value` property. The `value` property
+                    // contains the HTML-decoded value, so if the raw text contains
+                    // ` `, that is decoded to a space, but we don't want to
+                    // treat that as empty text.
+                    return (node instanceof bundled_angular_compiler_1.TmplAstText &&
+                        context.sourceCode.text
+                            .slice(node.sourceSpan.start.offset, node.sourceSpan.end.offset)
+                            .trim() === '');
                 });
             const noCloseTag = !endSourceSpan ||
                 (startSourceSpan.start.offset === endSourceSpan.start.offset &&

package/dist/rules/prefer-static-string-properties.d.ts

@@ -0,0 +1,6 @@
+export type Options = [];
+export type MessageIds = 'preferStaticStringProperties';
+export declare const RULE_NAME = "prefer-static-string-properties";
+declare const _default: import("@typescript-eslint/utils/ts-eslint").RuleModule<"preferStaticStringProperties", [], import("../utils/create-eslint-rule").RuleDocs, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+export default _default;
+//# sourceMappingURL=prefer-static-string-properties.d.ts.map

package/dist/rules/prefer-static-string-properties.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"prefer-static-string-properties.d.ts","sourceRoot":"","sources":["../../src/rules/prefer-static-string-properties.ts"],"names":[],"mappings":"AAQA,MAAM,MAAM,OAAO,GAAG,EAAE,CAAC;AACzB,MAAM,MAAM,UAAU,GAAG,8BAA8B,CAAC;AACxD,eAAO,MAAM,SAAS,oCAAoC,CAAC;;AAE3D,wBA6CG"}

package/dist/rules/prefer-static-string-properties.js

@@ -0,0 +1,44 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.RULE_NAME = void 0;
+const bundled_angular_compiler_1 = require("@angular-eslint/bundled-angular-compiler");
+const utils_1 = require("@angular-eslint/utils");
+const create_eslint_rule_1 = require("../utils/create-eslint-rule");
+exports.RULE_NAME = 'prefer-static-string-properties';
+exports.default = (0, create_eslint_rule_1.createESLintRule)({
+    name: exports.RULE_NAME,
+    meta: {
+        type: 'layout',
+        docs: {
+            description: 'Ensures that static string values use property assignment instead of property binding.',
+        },
+        fixable: 'code',
+        schema: [],
+        messages: {
+            preferStaticStringProperties: 'Using a property is more efficient than binding a static string.',
+        },
+    },
+    defaultOptions: [],
+    create(context) {
+        const parserServices = (0, utils_1.getTemplateParserServices)(context);
+        return {
+            BoundAttribute({ name, sourceSpan, value }) {
+                if (value instanceof bundled_angular_compiler_1.ASTWithSource &&
+                    value.ast instanceof bundled_angular_compiler_1.LiteralPrimitive &&
+                    typeof value.ast.value === 'string') {
+                    // If the string literal is quoted with a double quote,
+                    // then the property binding must be using single quotes
+                    // to quote the value, and we should keep using single
+                    // quotes when we convert it to a property assignment.
+                    const quote = value.source?.trimStart().at(0) === '"' ? "'" : '"';
+                    const literal = value.ast.value;
+                    context.report({
+                        loc: parserServices.convertNodeSourceSpanToLoc(sourceSpan),
+                        messageId: 'preferStaticStringProperties',
+                        fix: (fixer) => fixer.replaceTextRange([sourceSpan.start.offset, sourceSpan.end.offset], `${name}=${quote}${literal}${quote}`),
+                    });
+                }
+            },
+        };
+    },
+});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@angular-eslint/eslint-plugin-template",
-  "version": "19.0.3-alpha.8",
+  "version": "19.1.0",
   "description": "ESLint plugin for Angular Templates",
   "license": "MIT",
   "main": "dist/index.js",
@@ -20,13 +20,13 @@
   "dependencies": {
     "aria-query": "5.3.2",
     "axobject-query": "4.1.0",
-    "@angular-eslint/bundled-angular-compiler": "19.0.3-alpha.8",
-    "@angular-eslint/utils": "19.0.3-alpha.8"
+    "@angular-eslint/utils": "19.1.0",
+    "@angular-eslint/bundled-angular-compiler": "19.1.0"
   },
   "devDependencies": {
     "@types/aria-query": "5.0.4",
-    "@angular-eslint/test-utils": "19.0.3-alpha.8",
-    "@angular-eslint/template-parser": "19.0.3-alpha.8"
+    "@angular-eslint/test-utils": "19.1.0",
+    "@angular-eslint/template-parser": "19.1.0"
   },
   "peerDependencies": {
     "@typescript-eslint/types": "^7.11.0 || ^8.0.0",