@angular-eslint/eslint-plugin-template 17.0.2-alpha.3 → 17.0.2-alpha.4

package/README.md

@@ -59,6 +59,7 @@
 | [`no-interpolation-in-attributes`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin-template/docs/rules/no-interpolation-in-attributes.md) | Ensures that property-binding is used instead of interpolation in attributes. |  |  |  |  |
 | [`no-negated-async`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin-template/docs/rules/no-negated-async.md) | Ensures that async pipe results, as well as values used with the async pipe, are not negated | :white_check_mark: |  | :bulb: |  |
 | [`no-positive-tabindex`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin-template/docs/rules/no-positive-tabindex.md) | Ensures that the `tabindex` attribute is not positive |  |  | :bulb: |  |
+| [`prefer-control-flow`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin-template/docs/rules/prefer-control-flow.md) | Ensures that the built-in control flow is used. |  |  |  |  |
 | [`prefer-ngsrc`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin-template/docs/rules/prefer-ngsrc.md) | Ensures ngSrc is used instead of src for img elements |  |  |  |  |
 | [`role-has-required-aria`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin-template/docs/rules/role-has-required-aria.md) | [Accessibility] Ensures elements with ARIA roles have all required properties for that role. |  |  | :bulb: | :accessibility: |
 | [`table-scope`](https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin-template/docs/rules/table-scope.md) | [Accessibility] Ensures that the `scope` attribute is only used on the `<th>` element |  | :wrench: |  | :accessibility: |

package/dist/configs/all.json

@@ -24,6 +24,7 @@
     "@angular-eslint/template/no-interpolation-in-attributes": "error",
     "@angular-eslint/template/no-negated-async": "error",
     "@angular-eslint/template/no-positive-tabindex": "error",
+    "@angular-eslint/template/prefer-control-flow": "error",
     "@angular-eslint/template/prefer-ngsrc": "error",
     "@angular-eslint/template/prefer-self-closing-tags": "error",
     "@angular-eslint/template/role-has-required-aria": "error",

package/dist/index.js

@@ -53,6 +53,7 @@ const no_interpolation_in_attributes_1 = __importStar(require("./rules/no-interp
 const no_negated_async_1 = __importStar(require("./rules/no-negated-async"));
 const no_positive_tabindex_1 = __importStar(require("./rules/no-positive-tabindex"));
 const prefer_ngsrc_1 = __importStar(require("./rules/prefer-ngsrc"));
+const prefer_control_flow_1 = __importStar(require("./rules/prefer-control-flow"));
 const prefer_self_closing_tags_1 = __importStar(require("./rules/prefer-self-closing-tags"));
 const role_has_required_aria_1 = __importStar(require("./rules/role-has-required-aria"));
 const table_scope_1 = __importStar(require("./rules/table-scope"));
@@ -89,6 +90,7 @@ module.exports = {
         [no_interpolation_in_attributes_1.RULE_NAME]: no_interpolation_in_attributes_1.default,
         [no_negated_async_1.RULE_NAME]: no_negated_async_1.default,
         [no_positive_tabindex_1.RULE_NAME]: no_positive_tabindex_1.default,
+        [prefer_control_flow_1.RULE_NAME]: prefer_control_flow_1.default,
         [prefer_self_closing_tags_1.RULE_NAME]: prefer_self_closing_tags_1.default,
         [prefer_ngsrc_1.RULE_NAME]: prefer_ngsrc_1.default,
         [role_has_required_aria_1.RULE_NAME]: role_has_required_aria_1.default,

package/dist/rules/prefer-control-flow.js

@@ -0,0 +1,39 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.RULE_NAME = exports.MESSAGE_ID = void 0;
+const create_eslint_rule_1 = require("../utils/create-eslint-rule");
+const utils_1 = require("@angular-eslint/utils");
+exports.MESSAGE_ID = 'preferControlFlow';
+exports.RULE_NAME = 'prefer-control-flow';
+exports.default = (0, create_eslint_rule_1.createESLintRule)({
+    name: exports.RULE_NAME,
+    meta: {
+        type: 'suggestion',
+        docs: {
+            description: 'Ensures that the built-in control flow is used.',
+        },
+        schema: [],
+        messages: {
+            [exports.MESSAGE_ID]: 'Use built-in control flow instead of directive {{name}}.',
+        },
+    },
+    defaultOptions: [],
+    create(context) {
+        const parserServices = (0, utils_1.getTemplateParserServices)(context);
+        return {
+            'BoundAttribute[name=/^ngFor|ngIf|ngSwitch$/]'({ sourceSpan, name, }) {
+                // For these names, the parent ngIf or ngFor already throws an error
+                const redundantNames = ['ngIfElse', 'ngIfThen', 'ngForTrackBy'];
+                if (redundantNames.includes(name)) {
+                    return;
+                }
+                const loc = parserServices.convertNodeSourceSpanToLoc(sourceSpan);
+                context.report({
+                    messageId: exports.MESSAGE_ID,
+                    loc,
+                    data: { name },
+                });
+            },
+        };
+    },
+});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@angular-eslint/eslint-plugin-template",
-  "version": "17.0.2-alpha.3",
+  "version": "17.0.2-alpha.4",
   "description": "ESLint plugin for Angular Templates",
   "license": "MIT",
   "main": "dist/index.js",
@@ -17,8 +17,8 @@
     "LICENSE"
   ],
   "dependencies": {
-    "@angular-eslint/bundled-angular-compiler": "17.0.2-alpha.3",
-    "@angular-eslint/utils": "17.0.2-alpha.3",
+    "@angular-eslint/bundled-angular-compiler": "17.0.2-alpha.4",
+    "@angular-eslint/utils": "17.0.2-alpha.4",
     "@typescript-eslint/type-utils": "6.10.0",
     "@typescript-eslint/utils": "6.10.0",
     "aria-query": "5.3.0",