@angular-devkit/build-angular 17.0.5 → 17.1.0-next.0

package/package.json

@@ -1,27 +1,27 @@
 {
   "name": "@angular-devkit/build-angular",
-  "version": "17.0.5",
+  "version": "17.1.0-next.0",
   "description": "Angular Webpack Build Facade",
   "main": "src/index.js",
   "typings": "src/index.d.ts",
   "builders": "builders.json",
   "dependencies": {
     "@ampproject/remapping": "2.2.1",
-    "@angular-devkit/architect": "0.1700.5",
-    "@angular-devkit/build-webpack": "0.1700.5",
-    "@angular-devkit/core": "17.0.5",
-    "@babel/core": "7.23.2",
-    "@babel/generator": "7.23.0",
+    "@angular-devkit/architect": "0.1701.0-next.0",
+    "@angular-devkit/build-webpack": "0.1701.0-next.0",
+    "@angular-devkit/core": "17.1.0-next.0",
+    "@babel/core": "7.23.5",
+    "@babel/generator": "7.23.5",
     "@babel/helper-annotate-as-pure": "7.22.5",
     "@babel/helper-split-export-declaration": "7.22.6",
-    "@babel/plugin-transform-async-generator-functions": "7.23.2",
-    "@babel/plugin-transform-async-to-generator": "7.22.5",
-    "@babel/plugin-transform-runtime": "7.23.2",
-    "@babel/preset-env": "7.23.2",
-    "@babel/runtime": "7.23.2",
+    "@babel/plugin-transform-async-generator-functions": "7.23.4",
+    "@babel/plugin-transform-async-to-generator": "7.23.3",
+    "@babel/plugin-transform-runtime": "7.23.4",
+    "@babel/preset-env": "7.23.5",
+    "@babel/runtime": "7.23.5",
     "@discoveryjs/json-ext": "0.5.7",
-    "@ngtools/webpack": "17.0.5",
-    "@vitejs/plugin-basic-ssl": "1.0.1",
+    "@ngtools/webpack": "17.1.0-next.0",
+    "@vitejs/plugin-basic-ssl": "1.0.2",
     "ansi-colors": "4.1.3",
     "autoprefixer": "10.4.16",
     "babel-loader": "9.1.3",
@@ -32,11 +32,11 @@
     "copy-webpack-plugin": "11.0.0",
     "critters": "0.0.20",
     "css-loader": "6.8.1",
-    "esbuild-wasm": "0.19.5",
-    "fast-glob": "3.3.1",
+    "esbuild-wasm": "0.19.8",
+    "fast-glob": "3.3.2",
     "https-proxy-agent": "7.0.2",
     "http-proxy-middleware": "2.0.6",
-    "inquirer": "9.2.11",
+    "inquirer": "9.2.12",
     "jsonc-parser": "3.2.0",
     "karma-source-map-support": "1.4.0",
     "less": "4.2.0",
@@ -50,7 +50,7 @@
     "ora": "5.4.1",
     "parse5-html-rewriting-stream": "7.0.0",
     "picomatch": "3.0.1",
-    "piscina": "4.1.0",
+    "piscina": "4.2.0",
     "postcss": "8.4.31",
     "postcss-loader": "7.3.3",
     "resolve-url-loader": "5.0.0",
@@ -64,8 +64,8 @@
     "text-table": "0.2.0",
     "tree-kill": "1.2.2",
     "tslib": "2.6.2",
-    "undici": "5.27.2",
-    "vite": "4.5.0",
+    "undici": "5.28.1",
+    "vite": "5.0.4",
     "webpack": "5.89.0",
     "webpack-dev-middleware": "6.1.1",
     "webpack-dev-server": "4.15.1",
@@ -73,20 +73,20 @@
     "webpack-subresource-integrity": "5.1.0"
   },
   "optionalDependencies": {
-    "esbuild": "0.19.5"
+    "esbuild": "0.19.8"
   },
   "peerDependencies": {
-    "@angular/compiler-cli": "^17.0.0",
-    "@angular/localize": "^17.0.0",
-    "@angular/platform-server": "^17.0.0",
-    "@angular/service-worker": "^17.0.0",
+    "@angular/compiler-cli": "^17.0.0 || ^17.1.0-next.0",
+    "@angular/localize": "^17.0.0 || ^17.1.0-next.0",
+    "@angular/platform-server": "^17.0.0 || ^17.1.0-next.0",
+    "@angular/service-worker": "^17.0.0 || ^17.1.0-next.0",
     "jest": "^29.5.0",
     "jest-environment-jsdom": "^29.5.0",
     "karma": "^6.3.0",
-    "ng-packagr": "^17.0.0",
+    "ng-packagr": "^17.0.0 || ^17.1.0-next.0",
     "protractor": "^7.0.0",
     "tailwindcss": "^2.0.0 || ^3.0.0",
-    "typescript": ">=5.2 <5.3"
+    "typescript": ">=5.2 <5.4"
   },
   "peerDependenciesMeta": {
     "@angular/localize": {

package/src/builders/app-shell/index.js

@@ -104,8 +104,6 @@ async function _renderUniversal(options, context, browserResult, serverResult, s
         }
     }
     finally {
-        // Workaround piscina bug where a worker thread will be recreated after destroy to meet the minimum.
-        renderWorker.options.minThreads = 0;
         await renderWorker.destroy();
     }
     return browserResult;
@@ -134,6 +132,8 @@ async function _appShellBuilder(options, context) {
     const browserOptions = (await context.getTargetOptions(browserTarget));
     const optimization = (0, utils_1.normalizeOptimization)(browserOptions.optimization);
     optimization.styles.inlineCritical = false;
+    // Webpack based builders do not have the `removeSpecialComments` option.
+    delete optimization.styles.removeSpecialComments;
     const browserTargetRun = await context.scheduleTarget(browserTarget, {
         watch: false,
         serviceWorker: false,

package/src/builders/application/options.d.ts

@@ -127,5 +127,6 @@ export declare function normalizeOptions(context: BuilderContext, projectName: s
     budgets: import("./schema").Budget[] | undefined;
     publicPath: string | undefined;
     plugins: Plugin[] | undefined;
+    loaderExtensions: Record<string, "binary" | "file" | "text"> | undefined;
 }>;
 export {};

package/src/builders/application/options.js

@@ -88,6 +88,19 @@ async function normalizeOptions(context, projectName, options, plugins) {
             fileReplacements[node_path_1.default.join(workspaceRoot, replacement.replace)] = fileReplaceWith;
         }
     }
+    let loaderExtensions;
+    if (options.loader) {
+        for (const [extension, value] of Object.entries(options.loader)) {
+            if (extension[0] !== '.' || /\.[cm]?[jt]sx?$/.test(extension)) {
+                continue;
+            }
+            if (value !== 'text' && value !== 'binary' && value !== 'file' && value !== 'empty') {
+                continue;
+            }
+            loaderExtensions ??= {};
+            loaderExtensions[extension] = value;
+        }
+    }
     const globalStyles = [];
     if (options.styles?.length) {
         const { entryPoints: stylesheetEntrypoints, noInjectNames } = (0, helpers_1.normalizeGlobalStyles)(options.styles || []);
@@ -213,6 +226,7 @@ async function normalizeOptions(context, projectName, options, plugins) {
         budgets: budgets?.length ? budgets : undefined,
         publicPath: deployUrl ? deployUrl : undefined,
         plugins: plugins?.length ? plugins : undefined,
+        loaderExtensions,
     };
 }
 exports.normalizeOptions = normalizeOptions;

package/src/builders/application/schema.d.ts

@@ -3,7 +3,8 @@
  */
 export interface Schema {
     /**
-     * A list of CommonJS packages that are allowed to be used without a build time warning.
+     * A list of CommonJS or AMD packages that are allowed to be used without a build time
+     * warning. Use `'*'` to allow all.
      */
     allowedCommonJsDependencies?: string[];
     /**
@@ -69,6 +70,15 @@ export interface Schema {
      * The stylesheet language to use for the application's inline component styles.
      */
     inlineStyleLanguage?: InlineStyleLanguage;
+    /**
+     * Defines the type of loader to use with a specified file extension when used with a
+     * JavaScript `import`. `text` inlines the content as a string; `binary` inlines the content
+     * as a Uint8Array; `file` emits the file and provides the runtime location of the file;
+     * `empty` considers the content to be empty and not include it in bundles.
+     */
+    loader?: {
+        [key: string]: any;
+    };
     /**
      * Translate the bundles in one or more locales.
      */
@@ -344,6 +354,11 @@ export interface StylesClass {
      * identifiers and minimizing values.
      */
     minify?: boolean;
+    /**
+     * Remove comments in global CSS that contains '@license' or '@preserve' or that starts with
+     * '//!' or '/*!'.
+     */
+    removeSpecialComments?: boolean;
 }
 /**
  * Define the output filename cache-busting hashing mode.

package/src/builders/application/schema.json

@@ -162,6 +162,11 @@
                       "type": "boolean",
                       "description": "Extract and inline critical CSS definitions to improve first paint time.",
                       "default": true
+                    },
+                    "removeSpecialComments": {
+                      "type": "boolean",
+                      "description": "Remove comments in global CSS that contains '@license' or '@preserve' or that starts with '//!' or '/*!'.",
+                      "default": true
                     }
                   },
                   "additionalProperties": false
@@ -199,6 +204,13 @@
         }
       ]
     },
+    "loader": {
+      "description": "Defines the type of loader to use with a specified file extension when used with a JavaScript `import`. `text` inlines the content as a string; `binary` inlines the content as a Uint8Array; `file` emits the file and provides the runtime location of the file; `empty` considers the content to be empty and not include it in bundles.",
+      "type": "object",
+      "patternProperties": {
+        "^\\.\\S+$": { "enum": ["text", "binary", "file", "empty"] }
+      }
+    },
     "fileReplacements": {
       "description": "Replace compilation source files with other compilation source files in the build.",
       "type": "array",
@@ -406,7 +418,7 @@
       "enum": ["none", "anonymous", "use-credentials"]
     },
     "allowedCommonJsDependencies": {
-      "description": "A list of CommonJS packages that are allowed to be used without a build time warning.",
+      "description": "A list of CommonJS or AMD packages that are allowed to be used without a build time warning. Use `'*'` to allow all.",
       "type": "array",
       "items": {
         "type": "string"

package/src/builders/browser/schema.d.ts

@@ -3,7 +3,8 @@
  */
 export interface Schema {
     /**
-     * A list of CommonJS packages that are allowed to be used without a build time warning.
+     * A list of CommonJS or AMD packages that are allowed to be used without a build time
+     * warning. Use `'*'` to allow all.
      */
     allowedCommonJsDependencies?: string[];
     /**

package/src/builders/browser/schema.json

@@ -417,7 +417,7 @@
       "enum": ["none", "anonymous", "use-credentials"]
     },
     "allowedCommonJsDependencies": {
-      "description": "A list of CommonJS packages that are allowed to be used without a build time warning.",
+      "description": "A list of CommonJS or AMD packages that are allowed to be used without a build time warning. Use `'*'` to allow all.",
       "type": "array",
       "items": {
         "type": "string"

package/src/builders/browser-esbuild/schema.d.ts

@@ -3,7 +3,8 @@
  */
 export interface Schema {
     /**
-     * A list of CommonJS packages that are allowed to be used without a build time warning.
+     * A list of CommonJS or AMD packages that are allowed to be used without a build time
+     * warning. Use `'*'` to allow all.
      */
     allowedCommonJsDependencies?: string[];
     /**

package/src/builders/browser-esbuild/schema.json

@@ -429,7 +429,7 @@
       "enum": ["none", "anonymous", "use-credentials"]
     },
     "allowedCommonJsDependencies": {
-      "description": "A list of CommonJS packages that are allowed to be used without a build time warning.",
+      "description": "A list of CommonJS or AMD packages that are allowed to be used without a build time warning. Use `'*'` to allow all.",
       "type": "array",
       "items": {
         "type": "string"

package/src/builders/dev-server/builder.d.ts

@@ -6,6 +6,8 @@
  * found in the LICENSE file at https://angular.io/license
  */
 /// <reference types="node" />
+/// <reference types="@types/node/http" />
+/// <reference types="@types/node/ts4.8/http" />
 import type { BuilderContext } from '@angular-devkit/architect';
 import type { Plugin } from 'esbuild';
 import type http from 'node:http';

package/src/builders/dev-server/vite-server.d.ts

@@ -7,7 +7,7 @@
  */
 import type { BuilderContext } from '@angular-devkit/architect';
 import type { Plugin } from 'esbuild';
-import type { Connect, InlineConfig } from 'vite';
+import type { Connect, DepOptimizationConfig, InlineConfig } from 'vite';
 import { ExternalResultMetadata } from '../../tools/esbuild/bundler-execution-result';
 import { JavaScriptTransformer } from '../../tools/esbuild/javascript-transformer';
 import type { NormalizedDevServerOptions } from './options';
@@ -25,5 +25,6 @@ export declare function serveWithVite(serverOptions: NormalizedDevServerOptions,
     middleware?: Connect.NextHandleFunction[];
     buildPlugins?: Plugin[];
 }): AsyncIterableIterator<DevServerBuilderOutput>;
-export declare function setupServer(serverOptions: NormalizedDevServerOptions, outputFiles: Map<string, OutputFileRecord>, assets: Map<string, string>, preserveSymlinks: boolean | undefined, externalMetadata: ExternalResultMetadata, ssr: boolean, prebundleTransformer: JavaScriptTransformer, target: string[], extensionMiddleware?: Connect.NextHandleFunction[], indexHtmlTransformer?: (content: string) => Promise<string>, thirdPartySourcemaps?: boolean): Promise<InlineConfig>;
+export declare function setupServer(serverOptions: NormalizedDevServerOptions, outputFiles: Map<string, OutputFileRecord>, assets: Map<string, string>, preserveSymlinks: boolean | undefined, externalMetadata: ExternalResultMetadata, ssr: boolean, prebundleTransformer: JavaScriptTransformer, target: string[], prebundleLoaderExtensions: EsbuildLoaderOption | undefined, extensionMiddleware?: Connect.NextHandleFunction[], indexHtmlTransformer?: (content: string) => Promise<string>, thirdPartySourcemaps?: boolean): Promise<InlineConfig>;
+type EsbuildLoaderOption = Exclude<DepOptimizationConfig['esbuildOptions'], undefined>['loader'];
 export {};

package/src/builders/dev-server/vite-server.js

@@ -45,6 +45,7 @@ const rxjs_esm_resolution_plugin_1 = require("../../tools/esbuild/rxjs-esm-resol
 const utils_1 = require("../../tools/esbuild/utils");
 const i18n_locale_plugin_1 = require("../../tools/vite/i18n-locale-plugin");
 const utils_2 = require("../../utils");
+const load_esm_1 = require("../../utils/load-esm");
 const render_page_1 = require("../../utils/server-rendering/render-page");
 const supported_browsers_1 = require("../../utils/supported-browsers");
 const webpack_browser_config_1 = require("../../utils/webpack-browser-config");
@@ -99,7 +100,7 @@ async function* serveWithVite(serverOptions, builderName, context, transformers,
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
     const htmlIndexPath = (0, webpack_browser_config_1.getIndexOutputFile)(browserOptions.index);
     // dynamically import Vite for ESM compatibility
-    const { createServer, normalizePath } = await Promise.resolve().then(() => __importStar(require('vite')));
+    const { createServer, normalizePath } = await (0, load_esm_1.loadEsmModule)('vite');
     let server;
     let serverUrl;
     let hadError = false;
@@ -176,6 +177,10 @@ async function* serveWithVite(serverOptions, builderName, context, transformers,
             externalMetadata.implicitBrowser.sort();
         }
         if (server) {
+            // Update fs allow list to include any new assets from the build option.
+            server.config.server.fs.allow = [
+                ...new Set(...server.config.server.fs.allow, ...assetFiles.values()),
+            ];
             handleUpdate(normalizePath, generatedFiles, server, serverOptions, context.logger);
         }
         else {
@@ -188,7 +193,7 @@ async function* serveWithVite(serverOptions, builderName, context, transformers,
             const browsers = (0, supported_browsers_1.getSupportedBrowsers)(projectRoot, context.logger);
             const target = (0, utils_1.transformSupportedBrowsersToTargets)(browsers);
             // Setup server and start listening
-            const serverConfiguration = await setupServer(serverOptions, generatedFiles, assetFiles, browserOptions.preserveSymlinks, externalMetadata, !!browserOptions.ssr, prebundleTransformer, target, extensions?.middleware, transformers?.indexHtml, thirdPartySourcemaps);
+            const serverConfiguration = await setupServer(serverOptions, generatedFiles, assetFiles, browserOptions.preserveSymlinks, externalMetadata, !!browserOptions.ssr, prebundleTransformer, target, browserOptions.loader, extensions?.middleware, transformers?.indexHtml, thirdPartySourcemaps);
             server = await createServer(serverConfiguration);
             await server.listen();
             if (serverConfiguration.ssr?.optimizeDeps?.disabled === false) {
@@ -208,6 +213,21 @@ async function* serveWithVite(serverOptions, builderName, context, transformers,
             }
             // log connection information
             server.printUrls();
+            server.bindCLIShortcuts({
+                print: true,
+                customShortcuts: [
+                    {
+                        key: 'r',
+                        description: 'force reload browser',
+                        action(server) {
+                            server.ws.send({
+                                type: 'full-reload',
+                                path: '*',
+                            });
+                        },
+                    },
+                ],
+            });
         }
         // TODO: adjust output typings to reflect both development servers
         yield {
@@ -307,20 +327,21 @@ function analyzeResultFiles(normalizePath, htmlIndexPath, resultFiles, generated
     }
 }
 // eslint-disable-next-line max-lines-per-function
-async function setupServer(serverOptions, outputFiles, assets, preserveSymlinks, externalMetadata, ssr, prebundleTransformer, target, extensionMiddleware, indexHtmlTransformer, thirdPartySourcemaps = false) {
+async function setupServer(serverOptions, outputFiles, assets, preserveSymlinks, externalMetadata, ssr, prebundleTransformer, target, prebundleLoaderExtensions, extensionMiddleware, indexHtmlTransformer, thirdPartySourcemaps = false) {
     const proxy = await (0, load_proxy_config_1.loadProxyConfiguration)(serverOptions.workspaceRoot, serverOptions.proxyConfig, true);
     // dynamically import Vite for ESM compatibility
-    const { normalizePath } = await Promise.resolve().then(() => __importStar(require('vite')));
+    const { normalizePath } = await (0, load_esm_1.loadEsmModule)('vite');
     // Path will not exist on disk and only used to provide separate path for Vite requests
     const virtualProjectRoot = normalizePath((0, node_path_1.join)(serverOptions.workspaceRoot, `.angular/vite-root`, serverOptions.buildTarget.project));
     const serverExplicitExternal = [
         ...(await Promise.resolve().then(() => __importStar(require('node:module')))).builtinModules,
         ...externalMetadata.explicit,
     ];
+    const cacheDir = (0, node_path_1.join)(serverOptions.cacheOptions.path, 'vite');
     const configuration = {
         configFile: false,
         envFile: false,
-        cacheDir: (0, node_path_1.join)(serverOptions.cacheOptions.path, 'vite'),
+        cacheDir,
         root: virtualProjectRoot,
         publicDir: false,
         esbuild: false,
@@ -342,9 +363,14 @@ async function setupServer(serverOptions, outputFiles, assets, preserveSymlinks,
             open: serverOptions.open,
             headers: serverOptions.headers,
             proxy,
-            // Currently does not appear to be a way to disable file watching directly so ignore all files
-            watch: {
-                ignored: ['**/*'],
+            // File watching is handled by the build directly. `null` disables file watching for Vite.
+            watch: null,
+            fs: {
+                // Ensure cache directory, node modules, and all assets are accessible by the client.
+                // The first two are required for Vite to function in prebundling mode (the default) and to load
+                // the Vite client-side code for browser reloading. These would be available by default but when
+                // the `allow` option is explicitly configured, they must be included manually.
+                allow: [cacheDir, (0, node_path_1.join)(serverOptions.workspaceRoot, 'node_modules'), ...assets.values()],
             },
             // This is needed when `externalDependencies` is used to prevent Vite load errors.
             // NOTE: If Vite adds direct support for externals, this can be removed.
@@ -367,7 +393,7 @@ async function setupServer(serverOptions, outputFiles, assets, preserveSymlinks,
                  * - Breaks RxJs (Unless it is added as external). See: https://github.com/angular/angular-cli/issues/26235
                  */
                 // Only enable with caching since it causes prebundle dependencies to be cached
-                disabled: true,
+                disabled: true, // !serverOptions.cacheOptions.enabled,
                 // Exclude any explicitly defined dependencies (currently build defined externals and node.js built-ins)
                 exclude: serverExplicitExternal,
                 // Include all implict dependencies from the external packages internal option
@@ -375,6 +401,7 @@ async function setupServer(serverOptions, outputFiles, assets, preserveSymlinks,
                 ssr: true,
                 prebundleTransformer,
                 target,
+                loader: prebundleLoaderExtensions,
                 thirdPartySourcemaps,
             }),
         },
@@ -573,6 +600,7 @@ async function setupServer(serverOptions, outputFiles, assets, preserveSymlinks,
             ssr: false,
             prebundleTransformer,
             target,
+            loader: prebundleLoaderExtensions,
             thirdPartySourcemaps,
         }),
     };
@@ -619,7 +647,7 @@ function pathnameWithoutBasePath(url, basePath) {
         ? pathname.slice(basePath.length - 1)
         : pathname;
 }
-function getDepOptimizationConfig({ disabled, exclude, include, target, prebundleTransformer, ssr, thirdPartySourcemaps, }) {
+function getDepOptimizationConfig({ disabled, exclude, include, target, prebundleTransformer, ssr, loader, thirdPartySourcemaps, }) {
     const plugins = [
         {
             name: `angular-vite-optimize-deps${ssr ? '-ssr' : ''}${thirdPartySourcemaps ? '-vendor-sourcemap' : ''}`,
@@ -649,6 +677,7 @@ function getDepOptimizationConfig({ disabled, exclude, include, target, prebundl
             target,
             supported: (0, utils_1.getFeatureSupport)(target),
             plugins,
+            loader,
         },
     };
 }

package/src/builders/jest/index.js

@@ -78,7 +78,7 @@ exports.default = (0, architect_1.createBuilder)(async (schema, context) => {
         aot: false,
         index: false,
         outputHashing: schema_1.OutputHashing.None,
-        outExtension: 'mjs',
+        outExtension: 'mjs', // Force native ESM.
         optimization: false,
         sourceMap: {
             scripts: true,

package/src/builders/jest/test-files.js

@@ -25,7 +25,7 @@ async function findTestFiles(options, workspaceRoot, glob = fast_glob_1.default)
     const globOptions = {
         cwd: workspaceRoot,
         ignore: ['node_modules/**'].concat(options.exclude),
-        braceExpansion: false,
+        braceExpansion: false, // Do not expand `a{b,c}` to `ab,ac`.
         extglob: false, // Disable "extglob" patterns.
     };
     const included = await Promise.all(options.include.map((pattern) => glob(pattern, globOptions)));

package/src/builders/prerender/index.js

@@ -191,8 +191,6 @@ async function _renderUniversal(options, context, browserResult, serverResult, b
         }
     }
     finally {
-        // Workaround piscina bug where a worker thread will be recreated after destroy to meet the minimum.
-        worker.options.minThreads = 0;
         void worker.destroy();
     }
     return browserResult;

package/src/builders/ssr-dev-server/utils.d.ts

@@ -5,6 +5,8 @@
  * Use of this source code is governed by an MIT-style license that can be
  * found in the LICENSE file at https://angular.io/license
  */
+/// <reference types="@types/node/child_process" />
+/// <reference types="@types/node/ts4.8/child_process" />
 import { SpawnOptions } from 'child_process';
 import { Observable } from 'rxjs';
 export declare function getAvailablePort(): Promise<number>;

package/src/tools/babel/plugins/adjust-static-class-members.d.ts

@@ -5,6 +5,8 @@
  * Use of this source code is governed by an MIT-style license that can be
  * found in the LICENSE file at https://angular.io/license
  */
+/// <reference path="../../../../../../../../../../packages/angular_devkit/build_angular/src/babel-bazel.d.ts" />
+/// <reference types="@angular/compiler-cli/private/babel" />
 import { PluginObj } from '@babel/core';
 /**
  * Provides one or more keywords that if found within the content of a source file indicate

package/src/tools/babel/plugins/adjust-typescript-enums.d.ts

@@ -5,6 +5,8 @@
  * Use of this source code is governed by an MIT-style license that can be
  * found in the LICENSE file at https://angular.io/license
  */
+/// <reference path="../../../../../../../../../../packages/angular_devkit/build_angular/src/babel-bazel.d.ts" />
+/// <reference types="@angular/compiler-cli/private/babel" />
 import { PluginObj } from '@babel/core';
 /**
  * Provides one or more keywords that if found within the content of a source file indicate

package/src/tools/babel/plugins/elide-angular-metadata.d.ts

@@ -5,6 +5,8 @@
  * Use of this source code is governed by an MIT-style license that can be
  * found in the LICENSE file at https://angular.io/license
  */
+/// <reference path="../../../../../../../../../../packages/angular_devkit/build_angular/src/babel-bazel.d.ts" />
+/// <reference types="@angular/compiler-cli/private/babel" />
 import { PluginObj } from '@babel/core';
 /**
  * Provides one or more keywords that if found within the content of a source file indicate

package/src/tools/babel/plugins/pure-toplevel-functions.d.ts

@@ -5,6 +5,8 @@
  * Use of this source code is governed by an MIT-style license that can be
  * found in the LICENSE file at https://angular.io/license
  */
+/// <reference path="../../../../../../../../../../packages/angular_devkit/build_angular/src/babel-bazel.d.ts" />
+/// <reference types="@angular/compiler-cli/private/babel" />
 import { PluginObj } from '@babel/core';
 /**
  * A babel plugin factory function for adding the PURE annotation to top-level new and call expressions.

package/src/tools/babel/presets/application.js

@@ -70,7 +70,7 @@ function createI18nPlugins(locale, translation, missingTranslationBehavior, diag
 }
 function createNgtscLogger(reporter) {
     return {
-        level: 1,
+        level: 1, // Info level
         debug(...args) { },
         info(...args) {
             reporter?.('info', args.join());

package/src/tools/esbuild/angular/compilation/parallel-compilation.js

@@ -116,8 +116,6 @@ class ParallelCompilation extends angular_compilation_1.AngularCompilation {
         return this.#worker.run(files, { name: 'update' });
     }
     close() {
-        // Workaround piscina bug where a worker thread will be recreated after destroy to meet the minimum.
-        this.#worker.options.minThreads = 0;
         return this.#worker.destroy();
     }
 }

package/src/tools/esbuild/angular/compilation/parallel-worker.d.ts

@@ -6,6 +6,8 @@
  * found in the LICENSE file at https://angular.io/license
  */
 /// <reference types="node" />
+/// <reference types="@types/node/worker_threads" />
+/// <reference types="@types/node/ts4.8/worker_threads" />
 import type { PartialMessage } from 'esbuild';
 import { type MessagePort } from 'node:worker_threads';
 export interface InitRequest {

package/src/tools/esbuild/application-code-bundle.js

@@ -221,7 +221,7 @@ function createServerPolyfillBundleOptions(options, target, sourceFileCache) {
 }
 exports.createServerPolyfillBundleOptions = createServerPolyfillBundleOptions;
 function getEsBuildCommonOptions(options) {
-    const { workspaceRoot, outExtension, optimizationOptions, sourcemapOptions, tsconfig, externalDependencies, outputNames, preserveSymlinks, jit, } = options;
+    const { workspaceRoot, outExtension, optimizationOptions, sourcemapOptions, tsconfig, externalDependencies, outputNames, preserveSymlinks, jit, loaderExtensions, } = options;
     // Ensure unique hashes for i18n translation changes when using post-process inlining.
     // This hash value is added as a footer to each file and ensures that the output file names (with hashes)
     // change when translation files have changed. If this is not done the post processed files may have
@@ -262,6 +262,7 @@ function getEsBuildCommonOptions(options) {
             ...(optimizationOptions.scripts ? { 'ngDevMode': 'false' } : undefined),
             'ngJitMode': jit ? 'true' : 'false',
         },
+        loader: loaderExtensions,
         footer,
         publicPath: options.publicPath,
     };

package/src/tools/esbuild/commonjs-checker.d.ts

@@ -15,7 +15,7 @@ import type { Metafile, PartialMessage } from 'esbuild';
  *
  * If any allowed dependencies are provided via the `allowedCommonJsDependencies`
  * parameter, both the direct import and any deep imports will be ignored and no
- * diagnostic will be generated.
+ * diagnostic will be generated. Use `'*'` as entry to skip the check.
  *
  * If a module has been issued a diagnostic message, then all descendant modules
  * will not be checked. This prevents a potential massive amount of inactionable

package/src/tools/esbuild/commonjs-checker.js

@@ -17,7 +17,7 @@ exports.checkCommonJSModules = void 0;
  *
  * If any allowed dependencies are provided via the `allowedCommonJsDependencies`
  * parameter, both the direct import and any deep imports will be ignored and no
- * diagnostic will be generated.
+ * diagnostic will be generated. Use `'*'` as entry to skip the check.
  *
  * If a module has been issued a diagnostic message, then all descendant modules
  * will not be checked. This prevents a potential massive amount of inactionable
@@ -30,6 +30,9 @@ exports.checkCommonJSModules = void 0;
 function checkCommonJSModules(metafile, allowedCommonJsDependencies) {
     const messages = [];
     const allowedRequests = new Set(allowedCommonJsDependencies);
+    if (allowedRequests.has('*')) {
+        return messages;
+    }
     // Ignore Angular locale definitions which are currently UMD
     allowedRequests.add('@angular/common/locales');
     // Ignore zone.js due to it currently being built with a UMD like structure.

package/src/tools/esbuild/global-styles.js

@@ -47,7 +47,11 @@ function createGlobalStylesBundleOptions(options, target, initial) {
             tailwindConfiguration,
             publicPath: options.publicPath,
         }, loadCache);
-        buildOptions.legalComments = options.extractLicenses ? 'none' : 'eof';
+        // Keep special CSS comments `/*! comment */` in place when `removeSpecialComments` is disabled.
+        // These comments are special for a number of CSS tools such as Critters and PurgeCSS.
+        buildOptions.legalComments = optimizationOptions.styles?.removeSpecialComments
+            ? 'none'
+            : 'inline';
         buildOptions.entryPoints = entryPoints;
         buildOptions.plugins.unshift((0, virtual_module_plugin_1.createVirtualModulePlugin)({
             namespace,

package/src/tools/esbuild/i18n-inliner.js

@@ -143,8 +143,6 @@ class I18nInliner {
      * @returns A void promise that resolves when closing is complete.
      */
     close() {
-        // Workaround piscina bug where a worker thread will be recreated after destroy to meet the minimum.
-        this.#workerPool.options.minThreads = 0;
         return this.#workerPool.destroy();
     }
 }

package/src/tools/esbuild/index-html-generator.js

@@ -109,7 +109,7 @@ async function generateIndexHtml(initialFiles, outputFiles, buildOptions, lang)
     }
     const { InlineCriticalCssProcessor } = await Promise.resolve().then(() => __importStar(require('../../utils/index-file/inline-critical-css')));
     const inlineCriticalCssProcessor = new InlineCriticalCssProcessor({
-        minify: false,
+        minify: false, // CSS has already been minified during the build.
         readAsset,
     });
     const { content, errors, warnings } = await inlineCriticalCssProcessor.process(contentWithoutCriticalCssInlined, {

package/src/tools/esbuild/javascript-transformer.js

@@ -105,8 +105,6 @@ class JavaScriptTransformer {
     async close() {
         this.#pendingfileResults?.clear();
         if (this.#workerPool) {
-            // Workaround piscina bug where a worker thread will be recreated after destroy to meet the minimum.
-            this.#workerPool.options.minThreads = 0;
             try {
                 await this.#workerPool.destroy();
             }

package/src/tools/esbuild/watcher.js

@@ -9,6 +9,7 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.createWatcher = exports.ChangedFiles = void 0;
 const chokidar_1 = require("chokidar");
+const node_path_1 = require("node:path");
 class ChangedFiles {
     added = new Set();
     modified = new Set();
@@ -37,19 +38,64 @@ function createWatcher(options) {
     const nextQueue = [];
     let currentChanges;
     let nextWaitTimeout;
-    watcher.on('all', (event, path) => {
+    /**
+     * We group the current events in a map as on Windows with certain IDE a file contents change can trigger multiple events.
+     *
+     * Example:
+     * rename | 'C:/../src/app/app.component.css'
+     * rename | 'C:/../src/app/app.component.css'
+     * change | 'C:/../src/app/app.component.css'
+     *
+     */
+    let currentEvents;
+    /**
+     * Using `watcher.on('all')` does not capture some of events fired when using Visual studio and this does not happen all the time,
+     * but only after a file has been changed 3 or more times.
+     *
+     * Also, some IDEs such as Visual Studio (not VS Code) will fire a rename event instead of unlink when a file is renamed or changed.
+     *
+     * Example:
+     * ```
+     * watcher.on('raw')
+     * Change 1
+     * rename | 'C:/../src/app/app.component.css'
+     * rename | 'C:/../src/app/app.component.css'
+     * change | 'C:/../src/app/app.component.css'
+     *
+     * Change 2
+     * rename | 'C:/../src/app/app.component.css'
+     * rename | 'C:/../src/app/app.component.css'
+     * change | 'C:/../src/app/app.component.css'
+     *
+     * Change 3
+     * rename | 'C:/../src/app/app.component.css'
+     * rename | 'C:/../src/app/app.component.css'
+     * change | 'C:/../src/app/app.component.css'
+     *
+     * watcher.on('all')
+     * Change 1
+     * change | 'C:\\..\\src\\app\\app.component.css'
+     *
+     * Change 2
+     * unlink | 'C:\\..\\src\\app\\app.component.css'
+     *
+     * Change 3
+     * ... (Nothing)
+     * ```
+     */
+    watcher.on('raw', (event, path, { watchedPath }) => {
         switch (event) {
             case 'add':
-                currentChanges ??= new ChangedFiles();
-                currentChanges.added.add(path);
-                break;
             case 'change':
-                currentChanges ??= new ChangedFiles();
-                currentChanges.modified.add(path);
-                break;
+            // When using Visual Studio the rename event is fired before a change event when the contents of the file changed
+            // or instead of `unlink` when the file has been renamed.
             case 'unlink':
-                currentChanges ??= new ChangedFiles();
-                currentChanges.removed.add(path);
+            case 'rename':
+                // When polling is enabled `watchedPath` can be undefined.
+                // `path` is always normalized unlike `watchedPath`.
+                const changedPath = watchedPath ? (0, node_path_1.normalize)(watchedPath) : path;
+                currentEvents ??= new Map();
+                currentEvents.set(changedPath, event);
                 break;
             default:
                 return;
@@ -59,10 +105,25 @@ function createWatcher(options) {
             nextWaitTimeout = setTimeout(() => {
                 nextWaitTimeout = undefined;
                 const next = nextQueue.shift();
-                if (next) {
-                    const value = currentChanges;
-                    currentChanges = undefined;
-                    next(value);
+                if (next && currentEvents) {
+                    const events = currentEvents;
+                    currentEvents = undefined;
+                    const currentChanges = new ChangedFiles();
+                    for (const [path, event] of events) {
+                        switch (event) {
+                            case 'add':
+                                currentChanges.added.add(path);
+                                break;
+                            case 'change':
+                                currentChanges.modified.add(path);
+                                break;
+                            case 'unlink':
+                            case 'rename':
+                                currentChanges.removed.add(path);
+                                break;
+                        }
+                    }
+                    next(currentChanges);
                 }
             }, 250);
             nextWaitTimeout?.unref();

package/src/tools/webpack/configs/common.js

@@ -270,7 +270,7 @@ async function getCommonConfig(wco) {
         externals: externalDependencies,
         output: {
             uniqueName: projectName,
-            hashFunction: 'xxhash64',
+            hashFunction: 'xxhash64', // todo: remove in webpack 6. This is part of `futureDefaults`.
             clean: buildOptions.deleteOutputPath ?? true,
             path: path.resolve(root, buildOptions.outputPath),
             publicPath: buildOptions.deployUrl ?? '',

package/src/tools/webpack/plugins/common-js-usage-warn-plugin.d.ts

@@ -7,7 +7,7 @@
  */
 import { Compiler } from 'webpack';
 export interface CommonJsUsageWarnPluginOptions {
-    /** A list of CommonJS packages that are allowed to be used without a warning. */
+    /** A list of CommonJS or AMD packages that are allowed to be used without a warning. Use `'*'` to allow all. */
     allowedDependencies?: string[];
 }
 export declare class CommonJsUsageWarnPlugin {

package/src/tools/webpack/plugins/common-js-usage-warn-plugin.js

@@ -24,6 +24,9 @@ class CommonJsUsageWarnPlugin {
         this.allowedDependencies = new Set(this.options.allowedDependencies);
     }
     apply(compiler) {
+        if (this.allowedDependencies.has('*')) {
+            return;
+        }
         compiler.hooks.compilation.tap('CommonJsUsageWarnPlugin', (compilation) => {
             compilation.hooks.finishModules.tap('CommonJsUsageWarnPlugin', (modules) => {
                 const mainEntry = compilation.entries.get('main');

package/src/tools/webpack/plugins/javascript-optimizer-plugin.js

@@ -156,8 +156,6 @@ class JavaScriptOptimizerPlugin {
                     await Promise.all(tasks);
                 }
                 finally {
-                    // Workaround piscina bug where a worker thread will be recreated after destroy to meet the minimum.
-                    workerPool.options.minThreads = 0;
                     void workerPool.destroy();
                 }
                 logger.timeEnd('optimize js assets');

package/src/tools/webpack/utils/helpers.js

@@ -240,16 +240,16 @@ function assetPatterns(root, assets) {
 exports.assetPatterns = assetPatterns;
 function getStatsOptions(verbose = false) {
     const webpackOutputOptions = {
-        all: false,
+        all: false, // Fallback value for stats options when an option is not defined. It has precedence over local webpack defaults.
         colors: true,
-        hash: true,
-        timings: true,
-        chunks: true,
-        builtAt: true,
+        hash: true, // required by custom stat output
+        timings: true, // required by custom stat output
+        chunks: true, // required by custom stat output
+        builtAt: true, // required by custom stat output
         warnings: true,
         errors: true,
-        assets: true,
-        cachedAssets: true,
+        assets: true, // required by custom stat output
+        cachedAssets: true, // required for bundle size calculators
         // Needed for markAsyncChunksNonInitial.
         ids: true,
         entrypoints: true,

package/src/utils/action-executor.js

@@ -52,8 +52,6 @@ class BundleActionExecutor {
     }
     stop() {
         if (this.workerPool) {
-            // Workaround piscina bug where a worker thread will be recreated after destroy to meet the minimum.
-            this.workerPool.options.minThreads = 0;
             void this.workerPool.destroy();
         }
     }

package/src/utils/environment-options.js

@@ -82,6 +82,4 @@ exports.useLegacySass = (() => {
 const debugPerfVariable = process.env['NG_BUILD_DEBUG_PERF'];
 exports.debugPerformance = isPresent(debugPerfVariable) && isEnabled(debugPerfVariable);
 const watchRootVariable = process.env['NG_BUILD_WATCH_ROOT'];
-exports.shouldWatchRoot = process.platform === 'win32'
-    ? !isPresent(watchRootVariable) || !isDisabled(watchRootVariable)
-    : isPresent(watchRootVariable) && isEnabled(watchRootVariable);
+exports.shouldWatchRoot = isPresent(watchRootVariable) && isEnabled(watchRootVariable);

package/src/utils/normalize-optimization.d.ts

@@ -5,7 +5,7 @@
  * Use of this source code is governed by an MIT-style license that can be
  * found in the LICENSE file at https://angular.io/license
  */
-import { FontsClass, OptimizationClass, OptimizationUnion, StylesClass } from '../builders/browser/schema';
+import { FontsClass, OptimizationClass, OptimizationUnion, StylesClass } from '../builders/application/schema';
 export type NormalizedOptimizationOptions = Required<Omit<OptimizationClass, 'fonts' | 'styles'>> & {
     fonts: FontsClass;
     styles: StylesClass;

package/src/utils/normalize-optimization.js

@@ -10,13 +10,15 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.normalizeOptimization = void 0;
 function normalizeOptimization(optimization = true) {
     if (typeof optimization === 'object') {
+        const styleOptimization = !!optimization.styles;
         return {
             scripts: !!optimization.scripts,
             styles: typeof optimization.styles === 'object'
                 ? optimization.styles
                 : {
-                    minify: !!optimization.styles,
-                    inlineCritical: !!optimization.styles,
+                    minify: styleOptimization,
+                    removeSpecialComments: styleOptimization,
+                    inlineCritical: styleOptimization,
                 },
             fonts: typeof optimization.fonts === 'object'
                 ? optimization.fonts
@@ -30,6 +32,7 @@ function normalizeOptimization(optimization = true) {
         styles: {
             minify: optimization,
             inlineCritical: optimization,
+            removeSpecialComments: optimization,
         },
         fonts: {
             inline: optimization,

package/src/utils/server-rendering/esm-in-memory-loader/node-18-utils.js

@@ -25,7 +25,7 @@ exports.callInitializeIfNeeded = callInitializeIfNeeded;
 function getESMLoaderArgs() {
     if (isNode18()) {
         return [
-            '--no-warnings',
+            '--no-warnings', // Suppress `ExperimentalWarning: Custom ESM Loaders is an experimental feature...`.
             '--loader',
             (0, node_url_1.pathToFileURL)((0, node_path_1.join)(__dirname, 'loader-hooks.js')).href, // Loader cannot be an absolute path on Windows.
         ];

package/src/utils/server-rendering/prerender.js

@@ -124,8 +124,6 @@ async function renderPages(sourcemap, allRoutes, maxThreads, workspaceRoot, outp
         await Promise.all(renderingPromises);
     }
     finally {
-        // Workaround piscina bug where a worker thread will be recreated after destroy to meet the minimum.
-        renderWorker.options.minThreads = 0;
         void renderWorker.destroy();
     }
     return {
@@ -169,8 +167,6 @@ async function getAllRoutes(workspaceRoot, outputFilesForWorker, assetFilesForWo
     const { routes: extractedRoutes, warnings } = await renderWorker
         .run({})
         .finally(() => {
-        // Workaround piscina bug where a worker thread will be recreated after destroy to meet the minimum.
-        renderWorker.options.minThreads = 0;
         void renderWorker.destroy();
     });
     for (const route of extractedRoutes) {

package/src/utils/server-rendering/render-page.js

@@ -82,7 +82,7 @@ async function renderPage({ route, serverContext, document, inlineCriticalCss, o
     if (inlineCriticalCss) {
         const { InlineCriticalCssProcessor } = await Promise.resolve().then(() => __importStar(require('../../utils/index-file/inline-critical-css')));
         const inlineCriticalCssProcessor = new InlineCriticalCssProcessor({
-            minify: false,
+            minify: false, // CSS has already been minified during the build.
             readAsset: async (filePath) => {
                 filePath = (0, node_path_1.basename)(filePath);
                 const content = outputFiles[filePath];

package/src/utils/service-worker.d.ts

@@ -5,6 +5,8 @@
  * Use of this source code is governed by an MIT-style license that can be
  * found in the LICENSE file at https://angular.io/license
  */
+/// <reference types="@types/node/fs" />
+/// <reference types="@types/node/ts4.8/fs" />
 import type { Config, Filesystem } from '@angular/service-worker/config';
 import { promises as fsPromises } from 'node:fs';
 import { BuildOutputFile } from '../tools/esbuild/bundler-context';