@angular-devkit/build-angular 17.0.0-rc.4 → 17.0.0-rc.5

package/package.json

@@ -1,15 +1,15 @@
 {
   "name": "@angular-devkit/build-angular",
-  "version": "17.0.0-rc.4",
+  "version": "17.0.0-rc.5",
   "description": "Angular Webpack Build Facade",
   "main": "src/index.js",
   "typings": "src/index.d.ts",
   "builders": "builders.json",
   "dependencies": {
     "@ampproject/remapping": "2.2.1",
-    "@angular-devkit/architect": "0.1700.0-rc.4",
-    "@angular-devkit/build-webpack": "0.1700.0-rc.4",
-    "@angular-devkit/core": "17.0.0-rc.4",
+    "@angular-devkit/architect": "0.1700.0-rc.5",
+    "@angular-devkit/build-webpack": "0.1700.0-rc.5",
+    "@angular-devkit/core": "17.0.0-rc.5",
     "@babel/core": "7.23.2",
     "@babel/generator": "7.23.0",
     "@babel/helper-annotate-as-pure": "7.22.5",
@@ -20,7 +20,7 @@
     "@babel/preset-env": "7.23.2",
     "@babel/runtime": "7.23.2",
     "@discoveryjs/json-ext": "0.5.7",
-    "@ngtools/webpack": "17.0.0-rc.4",
+    "@ngtools/webpack": "17.0.0-rc.5",
     "@vitejs/plugin-basic-ssl": "1.0.1",
     "ansi-colors": "4.1.3",
     "autoprefixer": "10.4.16",

package/src/builders/karma/find-tests-plugin.js

@@ -89,18 +89,26 @@ async function findTests(include, exclude, workspaceRoot, projectSourceRoot) {
     return [...new Set(files.flat())];
 }
 const normalizePath = (path) => path.replace(/\\/g, '/');
+const removeLeadingSlash = (pattern) => {
+    if (pattern.charAt(0) === '/') {
+        return pattern.substring(1);
+    }
+    return pattern;
+};
+const removeRelativeRoot = (path, root) => {
+    if (path.startsWith(root)) {
+        return path.substring(root.length);
+    }
+    return path;
+};
 async function findMatchingTests(pattern, ignore, workspaceRoot, projectSourceRoot) {
     // normalize pattern, glob lib only accepts forward slashes
     let normalizedPattern = normalizePath(pattern);
-    if (normalizedPattern.charAt(0) === '/') {
-        normalizedPattern = normalizedPattern.substring(1);
-    }
+    normalizedPattern = removeLeadingSlash(normalizedPattern);
     const relativeProjectRoot = normalizePath((0, path_1.relative)(workspaceRoot, projectSourceRoot) + '/');
     // remove relativeProjectRoot to support relative paths from root
     // such paths are easy to get when running scripts via IDEs
-    if (normalizedPattern.startsWith(relativeProjectRoot)) {
-        normalizedPattern = normalizedPattern.substring(relativeProjectRoot.length);
-    }
+    normalizedPattern = removeRelativeRoot(normalizedPattern, relativeProjectRoot);
     // special logic when pattern does not look like a glob
     if (!(0, fast_glob_1.isDynamicPattern)(normalizedPattern)) {
         if (await isDirectory((0, path_1.join)(projectSourceRoot, normalizedPattern))) {
@@ -116,10 +124,12 @@ async function findMatchingTests(pattern, ignore, workspaceRoot, projectSourceRo
             }
         }
     }
+    // normalize the patterns in the ignore list
+    const normalizedIgnorePatternList = ignore.map((pattern) => removeRelativeRoot(removeLeadingSlash(normalizePath(pattern)), relativeProjectRoot));
     return (0, fast_glob_1.default)(normalizedPattern, {
         cwd: projectSourceRoot,
         absolute: true,
-        ignore: ['**/node_modules/**', ...ignore],
+        ignore: ['**/node_modules/**', ...normalizedIgnorePatternList],
     });
 }
 async function isDirectory(path) {

package/src/tools/esbuild/angular/compiler-plugin.js

@@ -203,6 +203,7 @@ function createCompilerPlugin(pluginOptions, styleOptions) {
                 }
                 if (compilation instanceof compilation_1.NoopCompilation) {
                     await sharedTSCompilationState.waitUntilReady;
+                    hasCompilationErrors = false;
                     return result;
                 }
                 const diagnostics = await compilation.diagnoseFiles();