@andypai/agent-kanban 0.6.1 → 0.6.3

package/src/__tests__/linear-provider-sync.test.ts

@@ -41,6 +41,7 @@ function linearIssue(
       nodes: Array<{ id: string }>
       pageInfo?: { hasNextPage: boolean; endCursor: string | null }
     }
+    team: { id: string } | null
   }> = {},
 ) {
   return {
@@ -88,17 +89,27 @@ describe('LinearProvider sync', () => {
       }
 
       if (body.query.includes('query Users')) {
-        return new Response(JSON.stringify({ data: { users: { nodes: [] } } }), {
-          status: 200,
-          headers: { 'content-type': 'application/json' },
-        })
+        return new Response(
+          JSON.stringify({
+            data: { users: { nodes: [], pageInfo: { hasNextPage: false, endCursor: null } } },
+          }),
+          {
+            status: 200,
+            headers: { 'content-type': 'application/json' },
+          },
+        )
       }
 
       if (body.query.includes('query Projects')) {
-        return new Response(JSON.stringify({ data: { projects: { nodes: [] } } }), {
-          status: 200,
-          headers: { 'content-type': 'application/json' },
-        })
+        return new Response(
+          JSON.stringify({
+            data: { projects: { nodes: [], pageInfo: { hasNextPage: false, endCursor: null } } },
+          }),
+          {
+            status: 200,
+            headers: { 'content-type': 'application/json' },
+          },
+        )
       }
 
       if (body.query.includes('query Issues')) {
@@ -209,6 +220,324 @@ describe('LinearProvider sync', () => {
     expect(created.labels).toEqual(['garage-smoke', 'garage-owner-local'])
   })
 
+  test('paginates users and projects across multiple pages', async () => {
+    let userPages = 0
+    let projectPages = 0
+    const seenUserAfter: Array<string | null> = []
+    const seenProjectAfter: Array<string | null> = []
+
+    globalThis.fetch = (async (_input: string | URL | Request, init?: RequestInit) => {
+      const body = JSON.parse(String(init?.body)) as {
+        query: string
+        variables: Record<string, unknown>
+      }
+
+      if (body.query.includes('query TeamSnapshot')) {
+        return new Response(
+          JSON.stringify({
+            data: {
+              team: {
+                id: 'team-1',
+                key: 'R2P',
+                name: 'R2pi',
+                states: { nodes: [{ id: 'state-1', name: 'Todo', position: 0 }] },
+              },
+            },
+          }),
+          { status: 200, headers: { 'content-type': 'application/json' } },
+        )
+      }
+
+      if (body.query.includes('query Users')) {
+        userPages += 1
+        const after = (body.variables.after as string | null) ?? null
+        seenUserAfter.push(after)
+        const page = after
+          ? {
+              nodes: [{ id: 'u2', displayName: 'User Two', active: true }],
+              hasNextPage: false,
+              endCursor: null,
+            }
+          : {
+              nodes: [{ id: 'u1', displayName: 'User One', active: true }],
+              hasNextPage: true,
+              endCursor: 'cursor-u1',
+            }
+        return new Response(
+          JSON.stringify({
+            data: {
+              users: {
+                nodes: page.nodes,
+                pageInfo: { hasNextPage: page.hasNextPage, endCursor: page.endCursor },
+              },
+            },
+          }),
+          { status: 200, headers: { 'content-type': 'application/json' } },
+        )
+      }
+
+      if (body.query.includes('query Projects')) {
+        projectPages += 1
+        const after = (body.variables.after as string | null) ?? null
+        seenProjectAfter.push(after)
+        const page = after
+          ? { nodes: [{ id: 'p2', name: 'Project Two' }], hasNextPage: false, endCursor: null }
+          : {
+              nodes: [{ id: 'p1', name: 'Project One' }],
+              hasNextPage: true,
+              endCursor: 'cursor-p1',
+            }
+        return new Response(
+          JSON.stringify({
+            data: {
+              projects: {
+                nodes: page.nodes,
+                pageInfo: { hasNextPage: page.hasNextPage, endCursor: page.endCursor },
+              },
+            },
+          }),
+          { status: 200, headers: { 'content-type': 'application/json' } },
+        )
+      }
+
+      if (body.query.includes('query Issues')) {
+        return new Response(
+          JSON.stringify({
+            data: { issues: { nodes: [], pageInfo: { hasNextPage: false, endCursor: null } } },
+          }),
+          { status: 200, headers: { 'content-type': 'application/json' } },
+        )
+      }
+
+      return new Response(`Unexpected query: ${body.query}`, { status: 500 })
+    }) as unknown as typeof fetch
+
+    const provider = new LinearProvider(db, 'R2P', 'lin_api_test')
+    await provider.getBoard()
+
+    expect(userPages).toBe(2)
+    expect(seenUserAfter).toEqual([null, 'cursor-u1'])
+    expect(projectPages).toBe(2)
+    expect(seenProjectAfter).toEqual([null, 'cursor-p1'])
+  })
+
+  test('createTask rejects an unknown assignee instead of silently dropping it', async () => {
+    replaceStates(db, [{ id: 'state-1', name: 'Todo', position: 0 }])
+    saveSyncMeta(db, {
+      team: { id: 'team-1', key: 'R2P', name: 'R2pi' },
+      lastSyncAt: new Date().toISOString(),
+      lastIssueUpdatedAt: '2026-01-02T00:00:00Z',
+    })
+
+    globalThis.fetch = (async (_input: string | URL | Request, init?: RequestInit) => {
+      const body = JSON.parse(String(init?.body)) as { query: string }
+      // The assignee resolver should throw before any CreateIssue mutation runs.
+      return new Response(`Unexpected query: ${body.query}`, { status: 500 })
+    }) as unknown as typeof fetch
+
+    const provider = new LinearProvider(db, 'R2P', 'lin_api_test')
+    await expect(
+      provider.createTask({ title: 'Hello', assignee: 'Ghost User' }),
+    ).rejects.toMatchObject({ code: 'PROVIDER_UPSTREAM_ERROR' })
+  })
+
+  test('updateTask rejects an unknown assignee instead of clearing the field', async () => {
+    replaceStates(db, [{ id: 'state-1', name: 'Todo', position: 0 }])
+    upsertIssues(db, [
+      {
+        id: 'issue-1',
+        identifier: 'R2P-1',
+        title: 'Linear task',
+        assigneeId: 'user-1',
+        assigneeName: 'Real Person',
+        stateId: 'state-1',
+        stateName: 'Todo',
+        statePosition: 0,
+        commentCount: 0,
+        createdAt: '2026-01-01T00:00:00Z',
+        updatedAt: '2026-01-01T00:00:00Z',
+      },
+    ])
+    saveSyncMeta(db, {
+      team: { id: 'team-1', key: 'R2P', name: 'R2pi' },
+      lastSyncAt: new Date().toISOString(),
+      lastIssueUpdatedAt: '2026-01-02T00:00:00Z',
+    })
+
+    globalThis.fetch = (async (_input: string | URL | Request, init?: RequestInit) => {
+      const body = JSON.parse(String(init?.body)) as { query: string }
+      // The resolver should throw before any UpdateIssue mutation runs.
+      return new Response(`Unexpected query: ${body.query}`, { status: 500 })
+    }) as unknown as typeof fetch
+
+    const provider = new LinearProvider(db, 'R2P', 'lin_api_test')
+    await expect(provider.updateTask('R2P-1', { assignee: 'Ghost User' })).rejects.toMatchObject({
+      code: 'PROVIDER_UPSTREAM_ERROR',
+    })
+  })
+
+  test('updateTask clears the assignee when given an empty string', async () => {
+    replaceStates(db, [{ id: 'state-1', name: 'Todo', position: 0 }])
+    upsertIssues(db, [
+      {
+        id: 'issue-1',
+        identifier: 'R2P-1',
+        title: 'Linear task',
+        assigneeId: 'user-1',
+        assigneeName: 'Real Person',
+        stateId: 'state-1',
+        stateName: 'Todo',
+        statePosition: 0,
+        commentCount: 0,
+        createdAt: '2026-01-01T00:00:00Z',
+        updatedAt: '2026-01-01T00:00:00Z',
+      },
+    ])
+    saveSyncMeta(db, {
+      team: { id: 'team-1', key: 'R2P', name: 'R2pi' },
+      lastSyncAt: new Date().toISOString(),
+      lastFullSyncAt: new Date().toISOString(),
+      lastIssueUpdatedAt: '2026-01-02T00:00:00Z',
+    })
+
+    const updateInputs: Array<Record<string, unknown>> = []
+    globalThis.fetch = (async (_input: string | URL | Request, init?: RequestInit) => {
+      const body = JSON.parse(String(init?.body)) as {
+        query: string
+        variables: { input?: Record<string, unknown> }
+      }
+
+      if (body.query.includes('mutation UpdateIssue')) {
+        updateInputs.push(body.variables.input ?? {})
+        return new Response(JSON.stringify({ data: { issueUpdate: { success: true } } }), {
+          status: 200,
+          headers: { 'content-type': 'application/json' },
+        })
+      }
+
+      if (body.query.includes('query TeamSnapshot')) {
+        return new Response(
+          JSON.stringify({
+            data: {
+              team: {
+                id: 'team-1',
+                key: 'R2P',
+                name: 'R2pi',
+                states: { nodes: [{ id: 'state-1', name: 'Todo', position: 0 }] },
+              },
+            },
+          }),
+          { status: 200, headers: { 'content-type': 'application/json' } },
+        )
+      }
+      if (body.query.includes('query Users')) {
+        return new Response(
+          JSON.stringify({
+            data: { users: { nodes: [], pageInfo: { hasNextPage: false, endCursor: null } } },
+          }),
+          {
+            status: 200,
+            headers: { 'content-type': 'application/json' },
+          },
+        )
+      }
+      if (body.query.includes('query Projects')) {
+        return new Response(
+          JSON.stringify({
+            data: { projects: { nodes: [], pageInfo: { hasNextPage: false, endCursor: null } } },
+          }),
+          {
+            status: 200,
+            headers: { 'content-type': 'application/json' },
+          },
+        )
+      }
+      if (body.query.includes('query Issues')) {
+        return new Response(
+          JSON.stringify({
+            data: {
+              issues: {
+                nodes: [linearIssue()],
+                pageInfo: { hasNextPage: false, endCursor: null },
+              },
+            },
+          }),
+          { status: 200, headers: { 'content-type': 'application/json' } },
+        )
+      }
+      if (body.query.includes('query IssueById')) {
+        return new Response(JSON.stringify({ data: { issue: linearIssue({ assignee: null }) } }), {
+          status: 200,
+          headers: { 'content-type': 'application/json' },
+        })
+      }
+      if (body.query.includes('query IssueHistory')) {
+        return new Response(
+          JSON.stringify({
+            data: {
+              issue: { history: { nodes: [], pageInfo: { hasNextPage: false, endCursor: null } } },
+            },
+          }),
+          { status: 200, headers: { 'content-type': 'application/json' } },
+        )
+      }
+      return new Response(`Unexpected query: ${body.query}`, { status: 500 })
+    }) as unknown as typeof fetch
+
+    const provider = new LinearProvider(db, 'R2P', 'lin_api_test')
+    await provider.updateTask('R2P-1', { assignee: '' })
+
+    expect(updateInputs).toHaveLength(1)
+    expect(updateInputs[0]).toHaveProperty('assigneeId', null)
+  })
+
+  test('updateTask drops the cached row when the hydrated issue left the team', async () => {
+    replaceStates(db, [{ id: 'state-1', name: 'Todo', position: 0 }])
+    upsertIssues(db, [
+      {
+        id: 'issue-1',
+        identifier: 'R2P-1',
+        title: 'Linear task',
+        stateId: 'state-1',
+        stateName: 'Todo',
+        statePosition: 0,
+        commentCount: 0,
+        createdAt: '2026-01-01T00:00:00Z',
+        updatedAt: '2026-01-01T00:00:00Z',
+      },
+    ])
+    saveSyncMeta(db, {
+      team: { id: 'team-1', key: 'R2P', name: 'R2pi' },
+      lastSyncAt: new Date().toISOString(),
+      lastFullSyncAt: new Date().toISOString(),
+      lastIssueUpdatedAt: '2026-01-02T00:00:00Z',
+    })
+
+    globalThis.fetch = (async (_input: string | URL | Request, init?: RequestInit) => {
+      const body = JSON.parse(String(init?.body)) as { query: string }
+      if (body.query.includes('mutation UpdateIssue')) {
+        return new Response(JSON.stringify({ data: { issueUpdate: { success: true } } }), {
+          status: 200,
+          headers: { 'content-type': 'application/json' },
+        })
+      }
+      if (body.query.includes('query IssueById')) {
+        // Upstream reports the issue now belongs to a different team.
+        return new Response(
+          JSON.stringify({ data: { issue: linearIssue({ team: { id: 'team-2' } }) } }),
+          { status: 200, headers: { 'content-type': 'application/json' } },
+        )
+      }
+      return new Response(`Unexpected query: ${body.query}`, { status: 500 })
+    }) as unknown as typeof fetch
+
+    const provider = new LinearProvider(db, 'R2P', 'lin_api_test')
+    await expect(provider.updateTask('R2P-1', { title: 'Renamed' })).rejects.toMatchObject({
+      code: 'TASK_NOT_FOUND',
+    })
+    expect(getCachedTasks(db)).toHaveLength(0)
+  })
+
   test('periodic full sync prunes cached issues missing from upstream', async () => {
     replaceStates(db, [{ id: 'state-1', name: 'Todo', position: 0 }])
     upsertIssues(db, [
@@ -265,17 +594,27 @@ describe('LinearProvider sync', () => {
       }
 
       if (body.query.includes('query Users')) {
-        return new Response(JSON.stringify({ data: { users: { nodes: [] } } }), {
-          status: 200,
-          headers: { 'content-type': 'application/json' },
-        })
+        return new Response(
+          JSON.stringify({
+            data: { users: { nodes: [], pageInfo: { hasNextPage: false, endCursor: null } } },
+          }),
+          {
+            status: 200,
+            headers: { 'content-type': 'application/json' },
+          },
+        )
       }
 
       if (body.query.includes('query Projects')) {
-        return new Response(JSON.stringify({ data: { projects: { nodes: [] } } }), {
-          status: 200,
-          headers: { 'content-type': 'application/json' },
-        })
+        return new Response(
+          JSON.stringify({
+            data: { projects: { nodes: [], pageInfo: { hasNextPage: false, endCursor: null } } },
+          }),
+          {
+            status: 200,
+            headers: { 'content-type': 'application/json' },
+          },
+        )
       }
 
       if (body.query.includes('query Issues')) {
@@ -327,6 +666,114 @@ describe('LinearProvider sync', () => {
     expect(loadSyncMeta(db).lastFullSyncAt).not.toBeNull()
   })
 
+  test('counts comments beyond the inline first page instead of capping at the page length', async () => {
+    saveSyncMeta(db, {
+      team: { id: 'team-1', key: 'R2P', name: 'R2pi' },
+      lastSyncAt: '2026-01-01T00:00:00Z',
+      lastFullSyncAt: '2026-01-01T00:00:00Z',
+      lastIssueUpdatedAt: '2026-01-01T00:00:00Z',
+    })
+
+    let commentCountQueries = 0
+    globalThis.fetch = (async (_input: string | URL | Request, init?: RequestInit) => {
+      const body = JSON.parse(String(init?.body)) as {
+        query: string
+        variables: Record<string, unknown>
+      }
+
+      if (body.query.includes('query TeamSnapshot')) {
+        return new Response(
+          JSON.stringify({
+            data: {
+              team: {
+                id: 'team-1',
+                key: 'R2P',
+                name: 'R2pi',
+                states: { nodes: [{ id: 'state-1', name: 'Todo', position: 0 }] },
+              },
+            },
+          }),
+          { status: 200, headers: { 'content-type': 'application/json' } },
+        )
+      }
+      if (body.query.includes('query Users')) {
+        return new Response(
+          JSON.stringify({
+            data: { users: { nodes: [], pageInfo: { hasNextPage: false, endCursor: null } } },
+          }),
+          { status: 200, headers: { 'content-type': 'application/json' } },
+        )
+      }
+      if (body.query.includes('query Projects')) {
+        return new Response(
+          JSON.stringify({
+            data: { projects: { nodes: [], pageInfo: { hasNextPage: false, endCursor: null } } },
+          }),
+          { status: 200, headers: { 'content-type': 'application/json' } },
+        )
+      }
+      if (body.query.includes('query IssueCommentCount')) {
+        commentCountQueries += 1
+        // Second comment page: three more comments, no further pages.
+        return new Response(
+          JSON.stringify({
+            data: {
+              issue: {
+                comments: {
+                  nodes: [{ id: 'c3' }, { id: 'c4' }, { id: 'c5' }],
+                  pageInfo: { hasNextPage: false, endCursor: null },
+                },
+              },
+            },
+          }),
+          { status: 200, headers: { 'content-type': 'application/json' } },
+        )
+      }
+      if (body.query.includes('query Issues')) {
+        return new Response(
+          JSON.stringify({
+            data: {
+              issues: {
+                nodes: [
+                  linearIssue({
+                    comments: {
+                      nodes: [{ id: 'c1' }, { id: 'c2' }],
+                      pageInfo: { hasNextPage: true, endCursor: 'comment-cursor-1' },
+                    },
+                  }),
+                ],
+                pageInfo: { hasNextPage: false, endCursor: null },
+              },
+            },
+          }),
+          { status: 200, headers: { 'content-type': 'application/json' } },
+        )
+      }
+      if (body.query.includes('query IssueHistory')) {
+        return new Response(
+          JSON.stringify({
+            data: {
+              issue: { history: { nodes: [], pageInfo: { hasNextPage: false, endCursor: null } } },
+            },
+          }),
+          { status: 200, headers: { 'content-type': 'application/json' } },
+        )
+      }
+      return new Response(`Unexpected query: ${body.query}`, { status: 500 })
+    }) as unknown as typeof fetch
+
+    const originalDateNow = Date.now
+    Date.now = () => Date.parse('2026-01-01T00:06:00Z')
+    try {
+      const provider = new LinearProvider(db, 'R2P', 'lin_api_test')
+      const task = await provider.getTask('R2P-1')
+      expect(task.comment_count).toBe(5)
+      expect(commentCountQueries).toBe(1)
+    } finally {
+      Date.now = originalDateNow
+    }
+  })
+
   test('polling keeps upstream comment counts instead of resetting them to zero', async () => {
     upsertIssues(db, [
       {
@@ -370,17 +817,27 @@ describe('LinearProvider sync', () => {
       }
 
       if (body.query.includes('query Users')) {
-        return new Response(JSON.stringify({ data: { users: { nodes: [] } } }), {
-          status: 200,
-          headers: { 'content-type': 'application/json' },
-        })
+        return new Response(
+          JSON.stringify({
+            data: { users: { nodes: [], pageInfo: { hasNextPage: false, endCursor: null } } },
+          }),
+          {
+            status: 200,
+            headers: { 'content-type': 'application/json' },
+          },
+        )
       }
 
       if (body.query.includes('query Projects')) {
-        return new Response(JSON.stringify({ data: { projects: { nodes: [] } } }), {
-          status: 200,
-          headers: { 'content-type': 'application/json' },
-        })
+        return new Response(
+          JSON.stringify({
+            data: { projects: { nodes: [], pageInfo: { hasNextPage: false, endCursor: null } } },
+          }),
+          {
+            status: 200,
+            headers: { 'content-type': 'application/json' },
+          },
+        )
       }
 
       if (body.query.includes('query Issues')) {
@@ -468,17 +925,27 @@ describe('LinearProvider sync', () => {
       }
 
       if (body.query.includes('query Users')) {
-        return new Response(JSON.stringify({ data: { users: { nodes: [] } } }), {
-          status: 200,
-          headers: { 'content-type': 'application/json' },
-        })
+        return new Response(
+          JSON.stringify({
+            data: { users: { nodes: [], pageInfo: { hasNextPage: false, endCursor: null } } },
+          }),
+          {
+            status: 200,
+            headers: { 'content-type': 'application/json' },
+          },
+        )
       }
 
       if (body.query.includes('query Projects')) {
-        return new Response(JSON.stringify({ data: { projects: { nodes: [] } } }), {
-          status: 200,
-          headers: { 'content-type': 'application/json' },
-        })
+        return new Response(
+          JSON.stringify({
+            data: { projects: { nodes: [], pageInfo: { hasNextPage: false, endCursor: null } } },
+          }),
+          {
+            status: 200,
+            headers: { 'content-type': 'application/json' },
+          },
+        )
       }
 
       if (body.query.includes('query Issues')) {
@@ -546,17 +1013,27 @@ describe('LinearProvider sync', () => {
       }
 
       if (body.query.includes('query Users')) {
-        return new Response(JSON.stringify({ data: { users: { nodes: [] } } }), {
-          status: 200,
-          headers: { 'content-type': 'application/json' },
-        })
+        return new Response(
+          JSON.stringify({
+            data: { users: { nodes: [], pageInfo: { hasNextPage: false, endCursor: null } } },
+          }),
+          {
+            status: 200,
+            headers: { 'content-type': 'application/json' },
+          },
+        )
       }
 
       if (body.query.includes('query Projects')) {
-        return new Response(JSON.stringify({ data: { projects: { nodes: [] } } }), {
-          status: 200,
-          headers: { 'content-type': 'application/json' },
-        })
+        return new Response(
+          JSON.stringify({
+            data: { projects: { nodes: [], pageInfo: { hasNextPage: false, endCursor: null } } },
+          }),
+          {
+            status: 200,
+            headers: { 'content-type': 'application/json' },
+          },
+        )
       }
 
       if (body.query.includes('query Issues')) {

package/src/__tests__/mcp-core.test.ts

@@ -115,6 +115,60 @@ describe('createTrackerCore', () => {
     expect(seenCommentBody === 'visible comment').toBe(true)
   })
 
+  test('filters board tasks via policy and reports the visible task count', async () => {
+    const visible = addTask(db, 'visible task')
+    addTask(db, 'hidden task')
+    const hookResults: Array<{ tool: string; result?: Record<string, unknown> }> = []
+
+    const core = createTrackerCore<TestScope>({
+      provider,
+      policy: {
+        canReadTicket() {},
+        canPostComment() {},
+        canUpdateComment() {},
+        canMoveTicket() {},
+        filterTask(_scope, task) {
+          return task.title.startsWith('visible')
+        },
+      },
+      hooks: {
+        onToolResult(event) {
+          hookResults.push({ tool: event.tool, result: event.result })
+        },
+      },
+    })
+
+    const board = await core.handlers.getBoard({ scope: { actor: 'agent' } })
+    const tasks = board.columns.flatMap((column) => column.tasks)
+
+    expect(tasks.map((task) => task.id)).toEqual([visible.id])
+    expect(hookResults).toEqual([{ tool: 'getBoard', result: { taskCount: 1 } }])
+  })
+
+  test('denies board reads when canReadBoard throws', async () => {
+    addTask(db, 'Core task')
+    const core = createTrackerCore<TestScope>({
+      provider,
+      policy: {
+        canReadTicket() {},
+        canPostComment() {},
+        canUpdateComment() {},
+        canMoveTicket() {},
+        canReadBoard() {
+          throw new TrackerMcpError({
+            code: 'policy_denied',
+            publicMessage: 'forbidden_board',
+          })
+        },
+      },
+    })
+
+    await expect(core.handlers.getBoard({ scope: { actor: 'agent' } })).rejects.toMatchObject({
+      code: 'policy_denied',
+      publicMessage: 'forbidden_board',
+    })
+  })
+
   test('normalizes policy denials into TrackerMcpError and reports them through hooks', async () => {
     const task = addTask(db, 'Core task')
     const toolErrors: Array<{ tool: string; code: string; message?: string }> = []