@andrian.yablonskyy/thub-coordinator 1.0.5 → 1.0.7

package/package.json

@@ -1,8 +1,11 @@
 {
   "name": "@andrian.yablonskyy/thub-coordinator",
-  "version": "1.0.5",
+  "version": "1.0.7",
   "description": "TestHub Coordinator — job queue, resource registry, scheduler, heartbeat monitor, log/artifact store and web dashboard",
   "main": "src/server.js",
+  "engines": {
+    "node": ">=20"
+  },
   "bin": {
     "thub-admin": "./bin/thub-admin.js",
     "thub-coordinator": "./src/server.js"
@@ -11,7 +14,7 @@
     "start": "node src/server.js",
     "dev": "node --watch src/server.js",
     "test": "node --test test/*.test.js",
-    "postinstall": "node scripts/install-default-config.js && node scripts/install-systemd-unit.js",
+    "postinstall": "node scripts/ensure-native-deps.js && node scripts/install-default-config.js && node scripts/install-systemd-unit.js",
     "lint": "eslint .",
     "lint:fix": "eslint . --fix"
   },

package/scripts/ensure-native-deps.js

@@ -0,0 +1,85 @@
+/**
+ * @file        scripts/ensure-native-deps.js
+ * @description npm postinstall: makes sure better-sqlite3's native addon loads under the Node.js
+ *              running this install, rebuilding it in place if not
+ *
+ * @author      Andrian Yablonskyy
+ * @copyright   Copyright (c) 2026 Andrian Yablonskyy. All rights reserved.
+ *
+ * This file is part of TestHub and is proprietary and confidential.
+ * Unauthorized copying, modification, distribution, or use of this file,
+ * via any medium, is strictly prohibited without prior written permission
+ * from AdSystem.PRO.
+ */
+
+'use strict';
+
+const path = require('node:path'),
+  { execFileSync, spawnSync } = require('node:child_process'),
+  { isGlobalInstall } = require('./install-target'),
+
+  PKG_DIR = path.join(__dirname, '..');
+
+// Checked in a child process: once a mismatched addon has been dlopen'ed,
+// this process keeps the old image mapped, so an in-process retry after
+// the rebuild would still see the stale one.
+function loads(){
+  const res = spawnSync(process.execPath, ['-e', 'new (require(\'better-sqlite3\'))(\':memory:\').close()'], {
+    cwd: PKG_DIR,
+    encoding: 'utf8'
+  });
+  if (res.status === 0){
+    return true;
+  }
+  if (/ERR_DLOPEN_FAILED|NODE_MODULE_VERSION/.test(res.stderr)){
+    return false;
+  }
+  throw new Error(res.stderr.trim().split('\n').find((l) => /Error/.test(l)) || `exit ${res.status}`);
+}
+
+// Runs better-sqlite3's own install script (prebuild-install, falling back
+// to node-gyp) in its own directory. Not `npm rebuild`: under `npm i -g`
+// this script inherits npm_config_global=true, which points a nested
+// `npm rebuild` at the global prefix instead of this package, where it
+// "succeeds" without touching the addon at all.
+function rebuild(){
+  const dir = path.dirname(require.resolve('better-sqlite3/package.json', { paths: [PKG_DIR] })),
+    npmCli = process.env.npm_execpath,
+    [cmd, args] = npmCli ? [process.execPath, [npmCli]] : ['npm', []];
+  execFileSync(cmd, [...args, 'run-script', 'install'], {
+    cwd: dir,
+    stdio: 'inherit',
+    env: { ...process.env, npm_config_global: 'false' }
+  });
+}
+
+// Re-running `npm i -g` for an already-installed version after a Node
+// major upgrade leaves unchanged dependencies alone — including
+// better-sqlite3's addon, still built for the old Node ABI — so the server
+// then dies with NODE_MODULE_VERSION mismatch at startup. Rebuild it here
+// with the same node/npm that's running this install. Best-effort: never
+// fails the install itself.
+function main(){
+  if (!isGlobalInstall()){
+    return;
+  }
+  try {
+    if (loads()){
+      return;
+    }
+    console.log(`thub-coordinator: rebuilding better-sqlite3 for Node.js ${process.version} (ABI ${process.versions.modules})`);
+    rebuild();
+    if (!loads()){
+      throw new Error('still fails to load after rebuild');
+    }
+    console.log('thub-coordinator: better-sqlite3 rebuilt');
+  }
+  catch (err){
+    console.warn(
+      `thub-coordinator: better-sqlite3 doesn't load under ${process.execPath} (${process.version}): ${err.message}\n` +
+        `Rebuild it manually: cd ${PKG_DIR} && sudo env "PATH=$PATH" npm rebuild better-sqlite3`
+    );
+  }
+}
+
+main();

package/scripts/install-default-config.js

@@ -1,7 +1,7 @@
 /**
  * @file        scripts/install-default-config.js
  * @description npm postinstall: on a real global install, creates the Coordinator's directory layout
- *              (~/.config/thub, ~/var/lib/thub and its artifacts/avatars/work subdirs) and, if it
+ *              (~/.config/thub, ~/.thub and its artifacts/avatars/work subdirs) and, if it
  *              doesn't already exist, ~/.config/thub/coordinator.json with every default option and
  *              a freshly generated sessionSecret (README §12, §13)
  *
@@ -26,7 +26,7 @@ const fs = require('node:fs'),
 // can be changed — not a copy of the bundled config.json (which uses a
 // relative dataDir and a fixed sessionSecret for zero-setup `npm run
 // coordinator` in the monorepo). What differs from DEFAULTS:
-//   - dataDir: home-anchored (~/var/lib/thub), not cwd-relative — a real
+//   - dataDir: home-anchored (~/.thub), not cwd-relative — a real
 //     install shouldn't get a different data directory depending on which
 //     directory thub-coordinator happened to be launched from.
 //   - sessionSecret: freshly random per install, never the shared
@@ -51,7 +51,7 @@ function chownToUser(p, user){
 }
 
 // Creates `dir` and chowns every directory this call created along the
-// way (e.g. ~/.config, ~/var, ~/var/lib when they didn't exist yet),
+// way (e.g. ~/.config, ~/.thub when they didn't exist yet),
 // plus `dir` itself.
 function mkdirOwned(dir, user){
   const firstCreated = fs.mkdirSync(dir, { recursive: true });

package/scripts/install-target.js

@@ -52,14 +52,14 @@ function resolveTargetUser(){
 }
 
 // Default layout (README §13): config under ~/.config/thub, runtime data
-// (SQLite DB, uploaded artifacts, avatars, work files) under ~/var/lib/thub.
+// (SQLite DB, uploaded artifacts, avatars, work files) under ~/.thub.
 // An existing coordinator.json's own dataDir wins over the default, so a
 // re-install prepares (and the systemd unit allows writes to) the
 // directory the Coordinator will really use.
 function targetPaths(user){
   const configDir = path.join(user.home, '.config', 'thub'),
     configPath = path.join(configDir, 'coordinator.json'),
-    defaultDataDir = path.join(user.home, 'var', 'lib', 'thub'),
+    defaultDataDir = path.join(user.home, '.thub'),
     dataDir = configuredDataDir(configPath) || defaultDataDir;
   return {
     configDir,

package/src/db/index.js

@@ -18,7 +18,7 @@ const fs = require('node:fs'),
   Database = require('better-sqlite3');
 
 function openDb(dbPath){
-  const db = new Database(dbPath);
+  const db = openDatabase(dbPath);
   db.pragma('journal_mode = WAL');
   db.pragma('synchronous = NORMAL');
   db.pragma('foreign_keys = ON');
@@ -26,6 +26,32 @@ function openDb(dbPath){
   return db;
 }
 
+// better-sqlite3 is a native addon built for one Node.js ABI at install
+// time; after a Node major upgrade it must be rebuilt. Without this, the
+// only hint is a raw NODE_MODULE_VERSION mismatch from deep in bindings.js.
+// The rebuild command keeps the caller's PATH under sudo, since sudo's own
+// secure_path often finds a different (older) node than the user's shell
+// does — rebuilding with that one just reproduces the same mismatch.
+function openDatabase(dbPath){
+  try {
+    return new Database(dbPath);
+  }
+  catch (err){
+    if (err.code === 'ERR_DLOPEN_FAILED'){
+      const builtFor = err.message.match(/NODE_MODULE_VERSION (\d+)/)?.[1],
+        pkgDir = path.join(__dirname, '..', '..');
+      throw new Error(
+        `better-sqlite3 was built for a different Node.js ABI (${builtFor || 'unknown'}) than this one: ` +
+          `${process.version}, ABI ${process.versions.modules}, at ${process.execPath}.\n` +
+          `Rebuild it with this same node: cd ${pkgDir} && sudo env "PATH=$PATH" npm rebuild better-sqlite3\n` +
+          'If `sudo node -v` and `node -v` differ, sudo was using another Node.js for earlier installs.',
+        { cause: err }
+      );
+    }
+    throw err;
+  }
+}
+
 function migrate(db){
   db.exec(`
     CREATE TABLE IF NOT EXISTS schema_migrations (