@andares/pi-toolkits 0.9.1 → 0.9.2

package/README.md

@@ -106,6 +106,8 @@ Enter with `/ask` (press it again to exit). Meant for the case where you only wa
 - `/ask-perm allow allow allow ask` — positional form (`in-read in-write out-read out-write`), enables immediately without a dialog. Missing arguments fall back to the defaults. This is the form autostart uses.
 - `/ask-perm` again — turns it off.
 
+Repeating the argument form with the modes already in force is a **no-op**: no second "ON" notice and no loss of the session grants collected so far. Changing any mode notifies and clears those grants, because they were made under the old policy.
+
 **Defaults**: in-project read/write allowed, outside read allowed, outside write asks.
 
 | Scope | reads | writes / exec |
@@ -307,6 +309,8 @@ No file = feature disabled, zero overhead, silently skipped.
 
 The global list runs first, so a project can override an earlier setting (for example a later `/ask-perm` with different arguments). Use the global file only when you want the same commands in every project; per-project files remain the recommended default.
 
+An **identical command line** declared by both sources runs once: a duplicate is skipped for that replay, so a global `/ask-perm ...` copied into a project does not run (or announce itself) twice. Different commands still both run, which is what keeps a project override working.
+
 **When it runs**:
 
 | session_start reason | Replayed | Why |

package/README.zh-CN.md

@@ -106,6 +106,8 @@ pi -e ./src/index.ts
 - `/ask-perm allow allow allow ask` —— 位置参数形式(`in-read in-write out-read out-write`),不弹窗直接开启;没给全的参数回落到默认值。这也是 autostart 使用的形式
 - 再输入一次 `/ask-perm` —— 关闭
 
+参数形式重复执行、且四项模式与当前一致时是**空操作**:不会再出一条「ON」提示,也不会清掉已经攒下的会话授权。只有模式真的变了才会提示并清空授权——那些授权是按旧策略给的。
+
 **默认值**:项目内读/写全放行,项目外读放行,项目外写询问。
 
 | 作用域 | 读 | 写 / 执行 |
@@ -307,6 +309,8 @@ run = [
 
 全局列表先执行,项目列表后执行,因此项目可以覆盖此前的设置(例如后面再执行一条不同参数的 `/ask-perm`)。只有希望所有项目都用同一套命令时才用全局文件;仍然建议以项目级配置为主。
 
+**完全相同的命令行**若同时出现在两个来源,一次重放里只执行一次:重复项跳过,所以把全局的 `/ask-perm ...` 复制到项目里不会再跑一遍、也不会再提示一遍。不同的命令仍然各跑一次——这正是「项目覆盖全局」得以成立的原因。
+
 **执行时机**:
 
 | session_start reason | 是否重放 | 原因 |

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@andares/pi-toolkits",
-  "version": "0.9.1",
+  "version": "0.9.2",
   "description": "Integrated toolkit extension for pi — ask mode (read-only Q&A), session-scoped permission checks, model favorites, prompt stash, third-party code review, session autostart, and a dedicated compaction model",
   "type": "module",
   "license": "MIT",

package/src/features/autostart/autostart.test.ts

@@ -418,6 +418,29 @@ describe("registerAutostart", () => {
 		expect(h.notifications[0]?.type).toBe("warning");
 	});
 
+	it("runs an identical command only once across sources", async () => {
+		const h = await harness(
+			"[command]\nrun = [\"/ask on\"]",
+			false,
+			"[command]\nrun = [\"/ask on\"]",
+		);
+		await h.start("startup");
+		expect(h.sent.map((entry) => entry.command)).toEqual(["/ask on"]);
+	});
+
+	it("still runs different commands from both sources", async () => {
+		const h = await harness(
+			"[command]\nrun = [\"/ask on\", \"/add-dir ../p\"]",
+			false,
+			"[command]\nrun = [\"/ask on\"]",
+		);
+		await h.start("startup");
+		expect(h.sent.map((entry) => entry.command)).toEqual([
+			"/ask on",
+			"/add-dir ../p",
+		]);
+	});
+
 	it("keeps running the project config when the global one is absent", async () => {
 		const h = await harness('[command]\nrun = ["/ask on"]', false, null);
 		await h.start("startup");

package/src/features/autostart/index.ts

@@ -163,6 +163,13 @@ export function registerAutostart(
 				),
 		);
 
+		// The same line may be declared by both sources (global defaults plus a
+		// project copy). Running an identical command twice in one replay is
+		// never meaningful — a repeated `/ask-perm` would re-notify, and a
+		// repeated `/add-dir` is pure noise — so identical text runs once.
+		// Different commands still both run, which keeps the project's override.
+		const dispatched = new Set<string>();
+
 		for (const source of sources) {
 			const commands = await readCommands(ctx, source);
 			if (commands === undefined || commands.length === 0) continue;
@@ -184,6 +191,8 @@ export function registerAutostart(
 					);
 					continue;
 				}
+				if (dispatched.has(command)) continue;
+				dispatched.add(command);
 				// One failing command must not cancel the rest of the list.
 				try {
 					await pi.sendUserMessage(command, { expandPromptTemplates: true });

package/src/features/permission/index.test.ts

@@ -269,15 +269,30 @@ describe("/ask-perm", () => {
 		expect(await h.evaluate(customEvent("mcp"))).toBeUndefined();
 	});
 
-	it("clears session grants when the mode is reconfigured", async () => {
+	it("is idempotent: repeating the same command notifies once and keeps grants", async () => {
 		const h = makeHarness();
 		await h.command("allow allow allow ask");
+		expect(h.notes).toHaveLength(1);
+
 		asAsk(await h.evaluate(bashEvent("rm -rf /tmp/outside/x"))).request.apply(
 			"allow-session",
 		);
+		await h.command("allow allow allow ask");
+		expect(h.notes).toHaveLength(1);
+		// The grant collected before the repeat is still in force.
 		expect(await h.evaluate(bashEvent("rm -rf /tmp/outside/y"))).toBeUndefined();
+	});
 
+	it("notifies and clears session grants when the modes actually change", async () => {
+		const h = makeHarness();
 		await h.command("allow allow allow ask");
+		asAsk(await h.evaluate(bashEvent("rm -rf /tmp/outside/x"))).request.apply(
+			"allow-session",
+		);
+		expect(await h.evaluate(bashEvent("rm -rf /tmp/outside/y"))).toBeUndefined();
+
+		await h.command("ask allow allow ask");
+		expect(h.notes).toHaveLength(2);
 		expect(asAsk(await h.evaluate(bashEvent("rm -rf /tmp/outside/y"))).kind).toBe("ask");
 	});
 });

package/src/features/permission/index.ts

@@ -31,6 +31,7 @@ import {
 import {
 	formatModes,
 	parsePermissionArgs,
+	sameModes,
 	shortMode,
 } from "./modes.js";
 import { openPermissionPanel } from "./panel.js";
@@ -253,9 +254,16 @@ export function registerPermission(pi: ExtensionAPI, gates: GateHub): void {
 					ctx.ui.notify(`ask-perm: ${parsed.error}`, "error");
 					return;
 				}
+				// Idempotent: the same command may arrive twice in one session start
+				// (both autostart sources declaring it, a duplicated config line, …).
+				// Re-applying an unchanged policy is a no-op — no second "ON" notice,
+				// and no loss of the session grants collected so far.
+				if (enabled && sameModes(modes, parsed.modes)) return;
+
+				const changed = !sameModes(modes, parsed.modes);
 				modes = parsed.modes;
-				// A new policy invalidates grants made under the old one.
-				rules.clear();
+				// A changed policy invalidates grants made under the old one.
+				if (changed) rules.clear();
 				enabled = true;
 				syncStatus(ctx);
 				ctx.ui.notify(
@@ -284,7 +292,9 @@ export function registerPermission(pi: ExtensionAPI, gates: GateHub): void {
 				);
 				return;
 			}
+			// The panel only opens while off, so this always transitions on.
 			modes = chosen;
+			rules.clear();
 			enabled = true;
 			syncStatus(ctx);
 			ctx.ui.notify(

package/src/features/permission/modes.ts

@@ -80,3 +80,13 @@ export function shortMode(mode: TriMode | "allow"): string {
 			return "D";
 	}
 }
+
+/** Structural equality for the four modes. */
+export function sameModes(a: PermissionModes, b: PermissionModes): boolean {
+	return (
+		a.inRead === b.inRead &&
+		a.inWrite === b.inWrite &&
+		a.outRead === b.outRead &&
+		a.outWrite === b.outWrite
+	);
+}