@andares/pi-toolkits 0.3.0 → 0.3.1

package/README.md

@@ -36,7 +36,7 @@ pi -e ./src/index.ts
 - `/ask` → footer 出现灰色 `ask` 状态,`write`/`edit` 被硬禁用
 - `/model`(或 `ctrl+l`)→ 选择器顶部出现收藏提示行
 - 输入框内按 `ctrl+alt+y` → 当前提示词被暂存并清空输入框
-- 完成一个开发任务后输入 `third-review` → 切换到评审模型执行查+修
+- 完成一个开发任务后输入 `/third-review` → 切换到评审模型执行查+修
 
 ---
 
@@ -63,7 +63,7 @@ pi -e ./src/index.ts
 | 🛡️ **ask** 只读咨询模式 | `/ask` | 进入只读问答模式,`write`/`edit` 硬禁用,`bash` 只读沙箱 |
 | ⭐ **favorites** 模型收藏 | `/model` 内 `ctrl+F` / `ctrl+J` | 收藏常用模型(加粗亮黄标记),`ctrl+p` 仅在收藏间循环 |
 | 📥 **stash** 提示词暂存 | `ctrl+alt+y` | 一段提示词的暂存槽,按键交换 / 连按两次暂存并清空输入框 |
-| 🔎 **review** 第三方代码评审 | `third-review` / `/third-review` | 召唤配置的评审模型,对刚完成的任务做查+修,重点检查「本轮需求实现 / 是否有遗漏 / 是否有错误」 |
+| 🔎 **review** 第三方代码评审 | `/third-review` | 召唤配置的评审模型,对刚完成的任务做查+修,重点检查「本轮需求实现 / 是否有遗漏 / 是否有错误」 |
 
 ---
 
@@ -144,7 +144,9 @@ pi -e ./src/index.ts
 
 <a name="review"></a>
 
-开发任务完成后,输入 `third-review`(或 `third review`、`/third-review`)召唤**另一个模型**以第三方身份,对刚完成的代码做「查 + 修」:评审模型拥有**完整工具权限**,确认的问题直接改,不是只读审计。评审回合留在当前会话记录里,评审完成后**会话保持评审模型**(不自动切回)。
+开发任务完成后,输入 `/third-review` 指令召唤**另一个模型**以第三方身份,对刚完成的代码做「查 + 修」:评审模型拥有**完整工具权限**,确认的问题直接改,不是只读审计。评审回合留在当前会话记录里,评审完成后**会话保持评审模型**(不自动切回)。
+
+> **仅指令触发**:只有 `/third-review` 能发起评审。聊天中直接输入 `third-review` 不会触发(作为普通消息发给模型),避免误发。
 
 **评审提示词重点检查三点**(逐项给出结论):
 
@@ -152,6 +154,8 @@ pi -e ./src/index.ts
 2. **是否有遗漏** —— 功能点、边界情况、异常处理、兼容性、测试等
 3. **是否有错误** —— 逻辑错误、潜在 bug、类型/编译错误、安全与性能隐患等
 
+**范围强约束** —— 评审仅限**当前本轮修改内容**,避免扩大范围;本轮改动范围内确认的问题才直接修复,范围外的历史遗留/无关问题只记录提示、不动手改。
+
 **评审模型配置**(`<agent-dir>/pi-toolkits-review.json`,默认 `~/.pi/agent/`):
 
 ```json

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@andares/pi-toolkits",
-  "version": "0.3.0",
+  "version": "0.3.1",
   "description": "Integrated toolkit extension for pi — currently provides ask mode (read-only Q&A); more features to come",
   "type": "module",
   "license": "MIT",

package/src/features/review/index.ts

@@ -6,10 +6,9 @@
  * (full tool access — this is check AND fix, not a read-only audit), runs a
  * review turn, and the session then stays on that model (no auto-restore).
  *
- * Trigger paths (both share createReviewRunner()):
- *  - bare message: typing exactly "third-review" / "third review" in the
- *    input box (pi.on("input") interception, swallowed with "handled")
- *  - slash command: /third-review
+ * Trigger: the /third-review slash command. (Bare-message keyword matching
+ * was deliberately removed — a plain "third-review" message goes to the
+ * model as ordinary text, so an accidental send can never start a review.)
  *
  * Review-model config lives in `<agent-dir>/pi-toolkits-review.json`
  * ("provider/id", see store.ts). When no model is configured, or the
@@ -28,7 +27,7 @@ import type {
 } from "@earendil-works/pi-coding-agent";
 import type { Api, Model } from "@earendil-works/pi-ai";
 import { REVIEW_STATUS_KEY } from "./constants.js";
-import { REVIEW_PROMPT, isReviewTrigger } from "./prompt.js";
+import { REVIEW_PROMPT } from "./prompt.js";
 import { getReviewStore, modelKey, type ReviewStore } from "./store.js";
 
 /** Resolve the configured review model against the available model list. */
@@ -154,33 +153,9 @@ export function createReviewRunner(
 export function registerReview(pi: ExtensionAPI): void {
 	const runReview = createReviewRunner(pi);
 
-	// Bare-message trigger: "third-review" / "third review" in the input box.
-	// Extension-injected messages are ignored so the runner's own prompts
-	// never re-trigger this path.
-	pi.on("input", (event, ctx) => {
-		if (event.source === "extension") {
-			return { action: "continue" };
-		}
-		if (isReviewTrigger(event.text)) {
-			// Fire-and-forget: the runner uses the live ctx proxy, so it is safe
-			// after this handler returns. A session switch mid-dialog can make
-			// the context assert-inactive; swallow that instead of leaking an
-			// unhandled rejection (a fresh extension instance owns the new
-			// session anyway).
-			void runReview(ctx).catch((error) => {
-				// pi-lens-ignore: no-console-except-error,console-statement, — deliberate degradation log
-				console.warn(
-					"[pi-toolkits/review] third-review aborted:",
-					error instanceof Error ? error.message : String(error),
-				);
-			});
-			return { action: "handled" };
-		}
-		return { action: "continue" };
-	});
-
-	// Slash-command trigger (pi resolves commands before the input event, so
-	// the two paths never double-fire).
+	// Slash-command trigger — the only entry point (bare-message keyword
+	// matching was removed to avoid accidental triggers). The handler awaits
+	// the runner, which may block on the model picker and the review turn.
 	pi.registerCommand("third-review", {
 		description:
 			"Summon the configured review model to review the just-completed work (check + fix)",

package/src/features/review/prompt.ts

@@ -8,20 +8,10 @@
  * under review.
  *
  * The three focus points the user asked for (本轮需求实现 / 是否有遗漏 /
- * 是否有错误) are spelled out verbatim in the prompt.
+ * 是否有错误) are spelled out verbatim in the prompt, together with a hard
+ * scope constraint: the review must stay within this round's changes.
  */
 
-/** Trigger words for the bare-message form of the third-review command. */
-export const TRIGGER_WORDS: ReadonlySet<string> = new Set([
-	"third-review",
-	"third review",
-]);
-
-/** Whether the input text is exactly a third-review trigger (case/space-insensitive). */
-export function isReviewTrigger(text: string): boolean {
-	return TRIGGER_WORDS.has(text.trim().toLowerCase());
-}
-
 export const REVIEW_PROMPT = `请以第三方代码评审的身份，对本次会话中刚完成的开发任务进行 Review。
 
 本轮需求、开发过程和代码改动都在当前会话上下文中，请结合上下文，并用 read/grep 等工具实际检查仓库代码，不要凭空猜测。
@@ -31,6 +21,10 @@ export const REVIEW_PROMPT = `请以第三方代码评审的身份，对本次
 2. 是否有遗漏：需求中是否有遗漏的功能点、边界情况、异常处理、兼容性、测试等？
 3. 是否有错误：代码中是否存在逻辑错误、潜在 bug、类型/编译错误、安全与性能隐患等？
 
+范围强约束：
+- 本次 Review 仅限当前本轮修改内容（本轮需求对应的代码改动），避免扩大范围；
+- 本轮改动范围内确认的问题才直接修复；范围外的问题（历史遗留、无关代码）只记录提示，不要动手修改。
+
 要求：
 - 对确认的问题直接修复（write/edit），并简要说明改了什么、为什么改；
 - 无法确认或不宜直接改的问题，列出：位置（文件/行）、问题描述、建议方案；

package/src/features/review/review.test.ts

@@ -2,7 +2,6 @@
  * review feature — unit tests.
  *
  * Covers the logic behind the third-review command:
- *  - trigger words (isReviewTrigger): exact bare-message match only
  *  - store: set/get persistence round-trip + corrupted-file fallback
  *  - modelKey / resolveConfiguredModel: provider/id resolution, incl. ids
  *    that themselves contain "/" (e.g. openrouter/openai/gpt-5)
@@ -37,7 +36,7 @@ import {
 	pickReviewModel,
 	resolveConfiguredModel,
 } from "./index.js";
-import { REVIEW_PROMPT, isReviewTrigger } from "./prompt.js";
+import { REVIEW_PROMPT } from "./prompt.js";
 import {
 	ReviewStore,
 	getReviewStore,
@@ -121,26 +120,6 @@ function fakePi(switched = true) {
 	return { pi, setModel, sendUserMessage };
 }
 
-// ─── trigger words ─────────────────────────────────────────────
-
-describe("isReviewTrigger", () => {
-	it("matches the bare trigger words case/space-insensitively", () => {
-		expect(isReviewTrigger("third-review")).toBe(true);
-		expect(isReviewTrigger("  Third-Review  ")).toBe(true);
-		expect(isReviewTrigger("third review")).toBe(true);
-		expect(isReviewTrigger("THIRD REVIEW")).toBe(true);
-	});
-
-	it("rejects non-trigger text (no prefix/suffix matching)", () => {
-		expect(isReviewTrigger("third-review now")).toBe(false);
-		expect(isReviewTrigger("third_review")).toBe(false);
-		expect(isReviewTrigger("thirdreview")).toBe(false);
-		expect(isReviewTrigger("/third-review")).toBe(false);
-		expect(isReviewTrigger("")).toBe(false);
-		expect(isReviewTrigger("review the code please")).toBe(false);
-	});
-});
-
 // ─── model key & resolution ────────────────────────────────────
 
 describe("modelKey", () => {