@anchrd/intel-api 0.32.0 → 0.33.0

package/dist/nodes/nodes.js

@@ -120,16 +120,17 @@ async function boardFor(deps, actor, parent) {
         return null;
     return (await deps.boardOfTask?.(actor, parent.id)) ?? null;
 }
-function refuseArchivedParent(childKind, parent) {
-    // ⚠️ Tasks only, and the narrowness is deliberate. The same hole exists for a folder — archive an
-    // empty one, file a document in it, purge — but it is OLDER than this ticket and fixing it here
-    // would change the behaviour of the whole tree out of a board ticket, with no test outside
-    // `boards.int.ts` covering it. It is #679, which also asks what such data already exists.
+function refuseArchivedParent(parent) {
+    // ⚠️ EVERY kind, not just tasks (#679). It was narrowed to tasks in #677 because widening it out
+    // of a board ticket would have changed the whole tree with no test outside `boards.int.ts`; the
+    // hole it left is older than that ticket and is what this one closes.
     //
-    // ⚠️ A reference without its number is not a reference: the review of #677 searched for this
-    // ticket and could not find it, because this comment did not name it.
-    if (childKind !== "task")
-        return;
+    // ⚠️ **This asks the DIRECT parent only, and the hole one level up stays open** (#733). Archiving a
+    // folder that still holds something live is allowed for every kind but `task`, so `Aussen`
+    // archived over a live `Innen` still takes anything filed under `Innen` when it is purged:
+    // `inspectPurgeTree` walks the whole subtree and `purge` checks `archived_at` on the root alone.
+    // Closing that needs a decision (refuse the archive, cascade it, refuse the purge, or name the
+    // live nodes in the preview) and #733 carries it with the count of what already exists.
     if (parent === null || parent.archivedAt === null)
         return;
     throw new IntelError(409, "parent_archived", `This ${parent.kind} is archived, so nothing new can be filed under it. Restore it first.`);
@@ -597,7 +598,7 @@ export function createNodes(deps) {
             // reason — a task lives on a board — and saying "restore the folder first" would send the
             // reader to do something that changes nothing: restored, the folder still cannot hold a task.
             refuseWrongParent(input.kind, destinationParent, { destination: destinationBoard });
-            refuseArchivedParent(input.kind, destinationParent);
+            refuseArchivedParent(destinationParent);
             const timestamp = deps.now().toISOString();
             const created = await deps.repository.insertNode({
                 node: {
@@ -983,7 +984,7 @@ export function createNodes(deps) {
                     destination: destinationBoard,
                     current: currentBoard,
                 });
-                refuseArchivedParent(current.kind, parent);
+                refuseArchivedParent(parent);
             }
             const updatedAt = deps.now().toISOString();
             const updated = await deps.repository.updateNode({

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@anchrd/intel-api",
-  "version": "0.32.0",
+  "version": "0.33.0",
   "type": "module",
   "license": "UNLICENSED",
   "repository": {