@anatolykoptev/krolik-cli 0.15.1 → 0.16.0

package/dist/bin/cli.js

@@ -58,7 +58,7 @@ var KROLIK_VERSION, TEMPLATE_VERSION;
 var init_version = __esm({
   "src/version.ts"() {
     init_esm_shims();
-    KROLIK_VERSION = "0.15.1";
+    KROLIK_VERSION = "0.16.0";
     TEMPLATE_VERSION = "6.1.0";
   }
 });
@@ -20779,6 +20779,53 @@ var init_context4 = __esm({
 });
 
 // src/commands/fix/fixers/console/analyzer.ts
+function isErrorHandlingContext(lines, lineIndex) {
+  const startIdx = Math.max(0, lineIndex - 5);
+  const endIdx = Math.min(lines.length - 1, lineIndex + 2);
+  for (let i = startIdx; i <= endIdx; i++) {
+    const line = lines[i] ?? "";
+    for (const pattern of ERROR_CONTEXT_PATTERNS) {
+      if (pattern.test(line)) {
+        return true;
+      }
+    }
+  }
+  return false;
+}
+function isStructuredLogging(line) {
+  return STRUCTURED_LOGGING_PATTERNS.some((pattern) => pattern.test(line));
+}
+function classifyConsole(method, lines, lineIndex) {
+  const isDebugMethod = DEBUG_METHODS.includes(method);
+  const isErrorMethod = ERROR_METHODS.includes(method);
+  const inErrorContext = isErrorHandlingContext(lines, lineIndex);
+  if (isErrorMethod && inErrorContext) {
+    return {
+      severity: "info",
+      shouldFix: false,
+      reason: "Error logging in error handler - likely intentional"
+    };
+  }
+  if (isDebugMethod) {
+    return {
+      severity: "warning",
+      shouldFix: true,
+      reason: "Debug statement should be removed before production"
+    };
+  }
+  if (isErrorMethod) {
+    return {
+      severity: "info",
+      shouldFix: true,
+      reason: "Consider using structured logging instead"
+    };
+  }
+  return {
+    severity: "warning",
+    shouldFix: true,
+    reason: "Remove console statement before production"
+  };
+}
 function analyzeConsole(content, file) {
   const issues = [];
   const lines = content.split("\n");
@@ -20786,33 +20833,76 @@ function analyzeConsole(content, file) {
     const line = lines[i] ?? "";
     const trimmed = line.trim();
     if (trimmed.startsWith("//") || trimmed.startsWith("*")) continue;
+    if (isStructuredLogging(line)) continue;
     CONSOLE_PATTERN.lastIndex = 0;
     let match;
     while ((match = CONSOLE_PATTERN.exec(line)) !== null) {
       if (isInsideLineComment(line, match.index)) continue;
       if (isInsideStringLine(line, match.index)) continue;
       const method = match[1] ?? "log";
-      issues.push({
+      const classification = classifyConsole(method, lines, i);
+      const issue = {
         file,
         line: i + 1,
-        severity: "warning",
+        severity: classification.severity,
         category: "lint",
-        message: `Unexpected console statement: console.${method}`,
-        suggestion: "Remove console statement before production",
-        snippet: trimmed.slice(0, 60),
-        fixerId: "console"
-      });
+        message: `console.${method}: ${classification.reason}`,
+        suggestion: classification.shouldFix ? "Remove or replace with structured logging" : "Review if this logging is necessary",
+        snippet: trimmed.slice(0, 60)
+      };
+      if (classification.shouldFix) {
+        issue.fixerId = "console";
+      }
+      issues.push(issue);
     }
   }
   return issues;
 }
-var CONSOLE_METHODS, CONSOLE_PATTERN;
+var DEBUG_METHODS, ERROR_METHODS, ERROR_CONTEXT_PATTERNS, STRUCTURED_LOGGING_PATTERNS, CONSOLE_PATTERN;
 var init_analyzer2 = __esm({
   "src/commands/fix/fixers/console/analyzer.ts"() {
     init_esm_shims();
     init_swc();
-    CONSOLE_METHODS = ["log", "warn", "error", "info", "debug", "trace", "dir", "table"];
-    CONSOLE_PATTERN = new RegExp(`console\\.(${CONSOLE_METHODS.join("|")})\\s*\\(`, "g");
+    DEBUG_METHODS = ["log", "debug", "trace", "dir", "table", "info", "count", "time", "timeEnd"];
+    ERROR_METHODS = ["error", "warn"];
+    ERROR_CONTEXT_PATTERNS = [
+      /\bcatch\s*\(/i,
+      // catch block
+      /\.catch\s*\(/i,
+      // promise catch
+      /\bonError\b/i,
+      // error callback
+      /\bonReject\b/i,
+      // rejection handler
+      /\berror\s*[=:]/i,
+      // error variable assignment
+      /\bhandleError\b/i,
+      // error handler function
+      /\bif\s*\(\s*error\b/i,
+      // error check
+      /\bif\s*\(\s*err\b/i,
+      // err check
+      /throw\s+/i
+      // near throw statement
+    ];
+    STRUCTURED_LOGGING_PATTERNS = [
+      /\blogger\./i,
+      // logger.info, logger.error
+      /\blog\./i,
+      // log.info, log.error
+      /(?<!console\.)\bdebug\(/i,
+      // debug() from debug package (not console.debug)
+      /\bwinston\b/i,
+      // winston logger
+      /\bpino\b/i,
+      // pino logger
+      /\bbunyan\b/i
+      // bunyan logger
+    ];
+    CONSOLE_PATTERN = new RegExp(
+      `console\\.(${[...DEBUG_METHODS, ...ERROR_METHODS].join("|")})\\s*\\(`,
+      "g"
+    );
   }
 });
 
@@ -24766,6 +24856,27 @@ var init_long_functions = __esm({
     };
   }
 });
+function suggestConstantName(value, lineContent) {
+  const knownName = NUMBER_NAME_SUGGESTIONS.get(value);
+  if (knownName) return knownName;
+  for (const { pattern, nameTemplate } of CONTEXT_PATTERNS) {
+    if (pattern.test(lineContent)) {
+      return nameTemplate(value);
+    }
+  }
+  if (value >= 1e3 && value % 1e3 === 0) {
+    const seconds = value / 1e3;
+    if (seconds < 60) return `${seconds}_SECONDS_MS`;
+    if (seconds < 3600) return `${Math.round(seconds / 60)}_MINUTES_MS`;
+    return `${Math.round(seconds / 3600)}_HOURS_MS`;
+  }
+  if (value >= 1024 && value % 1024 === 0) {
+    const kb = value / 1024;
+    if (kb < 1024) return `${kb}_KB`;
+    return `${Math.round(kb / 1024)}_MB`;
+  }
+  return `CONST_${value}`;
+}
 function analyzeMagicNumbersAST(content, file) {
   if (file.includes(".config.") || file.includes(".test.") || file.includes(".spec.") || file.endsWith(".d.ts")) {
     return [];
@@ -24789,13 +24900,14 @@ function analyzeMagicNumbersAST(content, file) {
         if (shouldSkipNumber(value)) continue;
         if (isInAllowedContext2(literal)) continue;
         const lineContent = lines[line - 1] ?? "";
+        const suggestedName = suggestConstantName(value, lineContent);
         issues.push({
           file,
           line,
           severity: "warning",
           category: "hardcoded",
           message: `Hardcoded number: ${value}`,
-          suggestion: "Extract to a named constant",
+          suggestion: `Extract to constant: const ${suggestedName} = ${value}`,
           snippet: lineContent.trim().slice(0, 60),
           fixerId: "magic-numbers"
         });
@@ -24892,13 +25004,14 @@ function analyzeMagicNumbersFallback(content, file) {
     while ((match = MAGIC_NUMBER_PATTERN.exec(codeOnly)) !== null) {
       const num = parseInt(match[1] ?? "0", 10);
       if (shouldSkipNumber(num)) continue;
+      const suggestedName = suggestConstantName(num, line);
       issues.push({
         file,
         line: i + 1,
         severity: "warning",
         category: "hardcoded",
         message: `Hardcoded number: ${num}`,
-        suggestion: "Extract to a named constant",
+        suggestion: `Extract to constant: const ${suggestedName} = ${num}`,
         snippet: trimmed.slice(0, 60),
         fixerId: "magic-numbers"
       });
@@ -24906,7 +25019,7 @@ function analyzeMagicNumbersFallback(content, file) {
   }
   return issues;
 }
-var ALLOWED_NUMBERS, HTTP_STATUS_CODES2, PORT_NUMBERS, TIME_CONSTANTS;
+var ALLOWED_NUMBERS, HTTP_STATUS_CODES2, PORT_NUMBERS, TIME_CONSTANTS, NUMBER_NAME_SUGGESTIONS, CONTEXT_PATTERNS;
 var init_ast_analyzer4 = __esm({
   "src/commands/fix/fixers/magic-numbers/ast-analyzer.ts"() {
     init_esm_shims();
@@ -24944,6 +25057,75 @@ var init_ast_analyzer4 = __esm({
       864e5
       // 1 day
     ]);
+    NUMBER_NAME_SUGGESTIONS = /* @__PURE__ */ new Map([
+      // Time (milliseconds)
+      [500, "HALF_SECOND_MS"],
+      [1e3, "ONE_SECOND_MS"],
+      [1500, "ONE_AND_HALF_SECONDS_MS"],
+      [2e3, "TWO_SECONDS_MS"],
+      [3e3, "THREE_SECONDS_MS"],
+      [5e3, "FIVE_SECONDS_MS"],
+      [1e4, "TEN_SECONDS_MS"],
+      [15e3, "FIFTEEN_SECONDS_MS"],
+      [3e4, "THIRTY_SECONDS_MS"],
+      [6e4, "ONE_MINUTE_MS"],
+      [12e4, "TWO_MINUTES_MS"],
+      [3e5, "FIVE_MINUTES_MS"],
+      [6e5, "TEN_MINUTES_MS"],
+      [9e5, "FIFTEEN_MINUTES_MS"],
+      [18e5, "THIRTY_MINUTES_MS"],
+      [36e5, "ONE_HOUR_MS"],
+      [72e5, "TWO_HOURS_MS"],
+      [864e5, "ONE_DAY_MS"],
+      [6048e5, "ONE_WEEK_MS"],
+      // Time (seconds)
+      [60, "ONE_MINUTE_SECS"],
+      [120, "TWO_MINUTES_SECS"],
+      [300, "FIVE_MINUTES_SECS"],
+      [600, "TEN_MINUTES_SECS"],
+      [3600, "ONE_HOUR_SECS"],
+      [86400, "ONE_DAY_SECS"],
+      // File sizes
+      [1024, "ONE_KB"],
+      [1048576, "ONE_MB"],
+      [1073741824, "ONE_GB"],
+      [5242880, "FIVE_MB"],
+      [10485760, "TEN_MB"],
+      [52428800, "FIFTY_MB"],
+      [104857600, "HUNDRED_MB"],
+      // Pagination / limits
+      [10, "DEFAULT_PAGE_SIZE"],
+      [20, "DEFAULT_PAGE_SIZE"],
+      [25, "DEFAULT_PAGE_SIZE"],
+      [50, "DEFAULT_PAGE_SIZE"],
+      [100, "DEFAULT_LIMIT"],
+      // Retry / timeout
+      [3, "MAX_RETRIES"],
+      [5, "MAX_RETRIES"],
+      // Animation / UI
+      [150, "ANIMATION_DURATION_MS"],
+      [200, "ANIMATION_DURATION_MS"],
+      [250, "ANIMATION_DURATION_MS"],
+      [300, "ANIMATION_DURATION_MS"],
+      [350, "ANIMATION_DURATION_MS"],
+      [400, "ANIMATION_DURATION_MS"],
+      [500, "ANIMATION_DURATION_MS"]
+    ]);
+    CONTEXT_PATTERNS = [
+      // setTimeout/setInterval
+      { pattern: /setTimeout|setInterval|delay|sleep/, nameTemplate: (v) => `DELAY_${v}MS` },
+      // Width/height
+      { pattern: /width|height|size/i, nameTemplate: (v) => `SIZE_${v}PX` },
+      // Padding/margin
+      { pattern: /padding|margin|gap|spacing/i, nameTemplate: (v) => `SPACING_${v}` },
+      // Max/min
+      { pattern: /max|maximum/i, nameTemplate: (v) => `MAX_${v}` },
+      { pattern: /min|minimum/i, nameTemplate: (v) => `MIN_${v}` },
+      // Threshold/limit
+      { pattern: /threshold|limit/i, nameTemplate: (v) => `THRESHOLD_${v}` },
+      // Percentage
+      { pattern: /percent|opacity|alpha/i, nameTemplate: (v) => `PERCENT_${v}` }
+    ];
   }
 });
 function fixMagicNumberAST(issue, content) {
@@ -27042,7 +27224,7 @@ function analyzeContentSignals(filePath, content) {
   const exportsJSX = matchesAnyPattern(fileContent, JSX_PATTERNS);
   const usesReactHooks = matchesAnyPattern(fileContent, REACT_HOOK_PATTERNS);
   const exportsValidationSchema = matchesAnyPattern(fileContent, SCHEMA_PATTERNS);
-  const createsReactContext = matchesAnyPattern(fileContent, CONTEXT_PATTERNS);
+  const createsReactContext = matchesAnyPattern(fileContent, CONTEXT_PATTERNS2);
   const hasAsyncOperations = matchesAnyPattern(fileContent, ASYNC_PATTERNS);
   const hasPureIndicators = matchesAnyPattern(fileContent, PURE_FUNCTION_INDICATORS);
   const hasSideEffects = matchesAnyPattern(fileContent, SIDE_EFFECT_PATTERNS);
@@ -27094,7 +27276,7 @@ function detectContentType(signals) {
   }
   return null;
 }
-var SCORES, REACT_HOOK_PATTERNS, JSX_PATTERNS, SCHEMA_PATTERNS, CONTEXT_PATTERNS, PURE_FUNCTION_INDICATORS, SIDE_EFFECT_PATTERNS, ASYNC_PATTERNS;
+var SCORES, REACT_HOOK_PATTERNS, JSX_PATTERNS, SCHEMA_PATTERNS, CONTEXT_PATTERNS2, PURE_FUNCTION_INDICATORS, SIDE_EFFECT_PATTERNS, ASYNC_PATTERNS;
 var init_content = __esm({
   "src/lib/@discovery/reusables/signals/content.ts"() {
     init_esm_shims();
@@ -27163,7 +27345,7 @@ var init_content = __esm({
       /export\s+(?:const|type)\s+\w*Schema/
       // export const/type XxxSchema
     ];
-    CONTEXT_PATTERNS = [
+    CONTEXT_PATTERNS2 = [
       /createContext\s*\(/,
       // React.createContext
       /React\.createContext\s*\(/,