@amsterdamdatalabs/enact-extensions 0.1.42 → 0.1.48

package/dist/validate/run.js

@@ -0,0 +1,60 @@
+import { execSync } from "node:child_process";
+import { existsSync, readFileSync } from "node:fs";
+import { join } from "node:path";
+import { checkHookEvents, checkPluginBundleComponentPathsFromCanonical, validatePluginBundleFromCanonical, } from "./index.js";
+/**
+ * Run the full canonical-bundle validation suite against a plugin.
+ *
+ * This is the programmatic entry point for `enact-extensions validate`. It is
+ * pure (no console output) and returns a structured report. The CLI wrapper in
+ * `scripts/lib/run-validate.mjs` is responsible for human-readable formatting.
+ *
+ * Checks performed:
+ *   1. Manifest schema validation per requested platform via in-memory
+ *      derivation from `.agents/plugin.json`.
+ *   2. Component path existence (skills, commands, hooks, mcpServers, apps).
+ *   3. Hook event allowlist (events must be supported across all hook-capable
+ *      surfaces).
+ *   4. Optional plugin-level `validate` command execution.
+ */
+export function runBundleValidation(pluginRoot, options = {}) {
+    const { platforms, pluginValidate = false } = options;
+    const manifestReport = validatePluginBundleFromCanonical(pluginRoot, platforms);
+    const componentPathWarnings = checkPluginBundleComponentPathsFromCanonical(pluginRoot);
+    const hookEventErrors = checkHookEvents(pluginRoot);
+    // Run the plugin's declared validate command when present and requested.
+    let pluginValidateOk = true;
+    let pluginValidateCommand;
+    const manifestPath = join(pluginRoot, ".agents", "plugin.json");
+    if (pluginValidate && existsSync(manifestPath)) {
+        let manifest;
+        try {
+            manifest = JSON.parse(readFileSync(manifestPath, "utf8"));
+        }
+        catch {
+            // malformed manifest — schema checks above will have already flagged it
+        }
+        const validateCmd = typeof manifest?.validate === "string" ? manifest.validate : undefined;
+        if (validateCmd && validateCmd.trim().length > 0) {
+            pluginValidateCommand = validateCmd.trim();
+            try {
+                execSync(pluginValidateCommand, { cwd: pluginRoot, stdio: "inherit" });
+                pluginValidateOk = true;
+            }
+            catch {
+                pluginValidateOk = false;
+            }
+        }
+    }
+    const ok = manifestReport.ok && componentPathWarnings.length === 0 && hookEventErrors.length === 0 && pluginValidateOk;
+    return {
+        pluginRoot,
+        manifestReport,
+        componentPathWarnings,
+        hookEventErrors,
+        pluginValidateOk,
+        pluginValidateCommand,
+        ok,
+    };
+}
+//# sourceMappingURL=run.js.map

package/dist/validate/run.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"run.js","sourceRoot":"","sources":["../../src/validate/run.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,MAAM,oBAAoB,CAAC;AAC9C,OAAO,EAAE,UAAU,EAAE,YAAY,EAAE,MAAM,SAAS,CAAC;AACnD,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAC;AAGjC,OAAO,EACL,eAAe,EACf,4CAA4C,EAC5C,iCAAiC,GAClC,MAAM,YAAY,CAAC;AAwBpB;;;;;;;;;;;;;;GAcG;AACH,MAAM,UAAU,mBAAmB,CAAC,UAAkB,EAAE,OAAO,GAA4B,EAAE;IAC3F,MAAM,EAAE,SAAS,EAAE,cAAc,GAAG,KAAK,EAAE,GAAG,OAAO,CAAC;IAEtD,MAAM,cAAc,GAAG,iCAAiC,CAAC,UAAU,EAAE,SAAS,CAAC,CAAC;IAChF,MAAM,qBAAqB,GAAG,4CAA4C,CAAC,UAAU,CAAC,CAAC;IACvF,MAAM,eAAe,GAAG,eAAe,CAAC,UAAU,CAAC,CAAC;IAEpD,yEAAyE;IACzE,IAAI,gBAAgB,GAAG,IAAI,CAAC;IAC5B,IAAI,qBAAyC,CAAC;IAC9C,MAAM,YAAY,GAAG,IAAI,CAAC,UAAU,EAAE,SAAS,EAAE,aAAa,CAAC,CAAC;IAChE,IAAI,cAAc,IAAI,UAAU,CAAC,YAAY,CAAC,EAAE,CAAC;QAC/C,IAAI,QAA6C,CAAC;QAClD,IAAI,CAAC;YACH,QAAQ,GAAG,IAAI,CAAC,KAAK,CAAC,YAAY,CAAC,YAAY,EAAE,MAAM,CAAC,CAA4B,CAAC;QACvF,CAAC;QAAC,MAAM,CAAC;YACP,wEAAwE;QAC1E,CAAC;QACD,MAAM,WAAW,GAAG,OAAO,QAAQ,EAAE,QAAQ,KAAK,QAAQ,CAAC,CAAC,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAC,CAAC,SAAS,CAAC;QAC3F,IAAI,WAAW,IAAI,WAAW,CAAC,IAAI,EAAE,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACjD,qBAAqB,GAAG,WAAW,CAAC,IAAI,EAAE,CAAC;YAC3C,IAAI,CAAC;gBACH,QAAQ,CAAC,qBAAqB,EAAE,EAAE,GAAG,EAAE,UAAU,EAAE,KAAK,EAAE,SAAS,EAAE,CAAC,CAAC;gBACvE,gBAAgB,GAAG,IAAI,CAAC;YAC1B,CAAC;YAAC,MAAM,CAAC;gBACP,gBAAgB,GAAG,KAAK,CAAC;YAC3B,CAAC;QACH,CAAC;IACH,CAAC;IAED,MAAM,EAAE,GACN,cAAc,CAAC,EAAE,IAAI,qBAAqB,CAAC,MAAM,KAAK,CAAC,IAAI,eAAe,CAAC,MAAM,KAAK,CAAC,IAAI,gBAAgB,CAAC;IAE9G,OAAO;QACL,UAAU;QACV,cAAc;QACd,qBAAqB;QACrB,eAAe;QACf,gBAAgB;QAChB,qBAAqB;QACrB,EAAE;KACH,CAAC;AACJ,CAAC"}

package/extensions/enact-loop/.agents/plugin.json

@@ -1,7 +1,7 @@
 {
   "name": "enact-loop",
-  "version": "0.1.0",
-  "description": "Generic contract-runner state machine. Drives declared stages (mechanical and judgment) to closure; judgment gates are graded by independent agents on a different vendor/model.",
+  "version": "0.3.0",
+  "description": "Generic contract-runner state machine with interactive Executor, mechanical, StageVerifier, and LoopGrader stages.",
   "author": {
     "name": "amsterdamdatalabs"
   },
@@ -13,13 +13,15 @@
     "loop",
     "contract-runner",
     "verification",
-    "independent-grading"
+    "stage-verification",
+    "loop-grading"
   ],
   "targets": [
     "claude",
     "codex",
     "cursor",
-    "enact"
+    "enact",
+    "kimi"
   ],
   "skills": "./skills/",
   "hooks": "./hooks/hooks.json",
@@ -27,16 +29,18 @@
   "mcpServers": "./.mcp.json",
   "interface": {
     "displayName": "Enact Loop",
-    "shortDescription": "Contract-runner loop with independent judgment grading.",
-    "longDescription": "Runs any declared contract (ordered stages: mechanical and judgment) to closure. The Stop boulder refuses to exit until every required stage passes. Judgment stages are graded by independent agents on a different model — no self-grading. Mechanical stages are engine-run via loop_grade (exit code 0 = pass).",
+    "shortDescription": "Generic Stage runner with interactive Executor work, mechanical checks, and distinct judgment roles.",
+    "longDescription": "Runs any declared Stage graph to closure. The Stop hook refuses to exit until every required Stage passes. Interactive Executor Stages use an immutable input packet and pass-only evidence; mechanical Stages run a declared command; StageVerifier handles lightweight current-plus-predecessor review; LoopGrader handles final whole-loop completeness.",
     "developerName": "enact-loop",
     "category": "Developer Tools",
     "capabilities": [
       "contract-runner state machine",
-      "independent judgment grading",
+      "interactive Executor stages",
+      "StageVerifier judgment",
+      "LoopGrader judgment",
       "stop boulder enforcement",
       "session auto-resume",
-      "engine-run mechanical grading",
+      "engine-run mechanical stages",
       "loop lifecycle MCP tools"
     ]
   },

package/extensions/enact-loop/scripts/validate.mjs

@@ -4,6 +4,7 @@ import { join } from "node:path";
 
 const root = process.cwd();
 const failures = [];
+const retiredMechanicalTool = /\bloop_grade\b/;
 
 function fail(message) {
   failures.push(message);
@@ -61,6 +62,13 @@ if (manifest) {
   for (const target of ["claude", "codex", "cursor", "enact"]) {
     assertArrayIncludes(manifest.targets, target, "manifest.targets");
   }
+  const interfaceText = JSON.stringify(manifest.interface ?? {});
+  if (!/StageVerifier/.test(interfaceText) || !/LoopGrader/.test(interfaceText)) {
+    fail("manifest.interface must name both StageVerifier and LoopGrader");
+  }
+  if (retiredMechanicalTool.test(interfaceText)) {
+    fail("manifest.interface must use loop_stage_run for mechanical Stages");
+  }
 }
 
 const mcp = readJson(".mcp.json");
@@ -81,6 +89,10 @@ if (mcp) {
 
 const hooks = readJson("hooks/hooks.json");
 if (hooks) {
+  const hookEvents = Object.keys(hooks.hooks ?? {}).sort();
+  if (hookEvents.join("|") !== "SessionStart|Stop") {
+    fail("enact-loop hooks must own only SessionStart and Stop");
+  }
   const sessionStart = findCommandHook(hooks.hooks?.SessionStart, "enact-loop hook session-start");
   if (!sessionStart) {
     fail('hooks.SessionStart must run "enact-loop hook session-start"');
@@ -108,8 +120,55 @@ if (!existsSync(join(root, skillPath))) {
   if (!/^name:\s*enact-loop\s*$/m.test(skill)) {
     fail(`${skillPath} frontmatter must declare name: enact-loop`);
   }
-  if (!/loop_grader_dispatch/.test(skill) || !/loop_grader_verdict/.test(skill)) {
-    fail(`${skillPath} must document independent judgment grading tools`);
+  for (const tool of [
+    "loop_executor_stage_input",
+    "loop_executor_stage_complete",
+    "loop_stage_run",
+    "loop_stage_verifier_dispatch",
+    "loop_stage_verifier_register_session",
+    "loop_stage_verifier_observation_record",
+    "loop_stage_verifier_report_spawn_failure",
+    "loop_stage_verifier_verdict",
+    "loop_grader_dispatch",
+    "loop_grader_register_session",
+    "loop_grader_observation_record",
+    "loop_grader_report_spawn_failure",
+    "loop_grader_verdict",
+  ]) {
+    if (!skill.includes(tool)) fail(`${skillPath} must document ${tool}`);
+  }
+  if (retiredMechanicalTool.test(skill)) {
+    fail(`${skillPath} must use loop_stage_run for mechanical Stages`);
+  }
+  if (!/StageVerifier/.test(skill) || !/LoopGrader/.test(skill)) {
+    fail(`${skillPath} must preserve the distinct StageVerifier and LoopGrader contracts`);
+  }
+
+  const contractReference = readFileSync(join(root, "skills/enact-loop/references/loop-contract.md"), "utf8");
+  for (const cli of [
+    "enact-loop stage-verifier observation-record --file <json>",
+    "enact-loop stage-verifier verdict --file <json>",
+    "enact-loop loop-grader observation-record --file <json>",
+    "enact-loop loop-grader verdict --file <json>",
+  ]) {
+    if (!contractReference.includes(cli)) fail(`loop contract reference must document ${cli}`);
+  }
+  if (retiredMechanicalTool.test(contractReference)) {
+    fail("loop contract reference must use loop_stage_run for mechanical Stages");
+  }
+  for (const executorContractToken of [
+    "type: executor",
+    "loop_executor_stage_input({ stageId })",
+    "{ stageInput, identity, inputFingerprint, executorContinuationId, prompt: { text, sha256 } }",
+    "loop_executor_stage_complete",
+    "inputFingerprint",
+    "executorContinuationId",
+    "evidenceRefs",
+    "outputDigest",
+  ]) {
+    if (!contractReference.includes(executorContractToken)) {
+      fail(`loop contract reference must document ${executorContractToken}`);
+    }
   }
 }
 
@@ -142,6 +201,29 @@ if (!existsSync(join(root, budgetSkillPath))) {
   }
 }
 
+const domainSpecificVocabulary = /Factory|AzDO|Azure|WorkItem|Feature Brief|Planning Notes|\bWIP\b|pull request|CI failure|worktree|repository edits|implementation evidence|coding|software/i;
+if (manifest) {
+  const {
+    factory: _provisioningMetadata,
+    repository: _hostingMetadata,
+    ...functionalManifest
+  } = manifest;
+  if (domainSpecificVocabulary.test(JSON.stringify(functionalManifest))) {
+    fail(".agents/plugin.json violates the domain-neutral Loop boundary");
+  }
+}
+for (const relativePath of [
+  "skills/enact-loop/SKILL.md",
+  "skills/enact-loop/references/loop-contract.md",
+  "skills/loop-budget/SKILL.md",
+  "skills/loop-intake/SKILL.md",
+]) {
+  const content = readFileSync(join(root, relativePath), "utf8");
+  if (domainSpecificVocabulary.test(content)) {
+    fail(`${relativePath} violates the domain-neutral Loop boundary`);
+  }
+}
+
 if (failures.length > 0) {
   for (const failure of failures) {
     console.error(`[enact-loop validate] ${failure}`);