@ampsec/platform-client 40.0.0 → 40.2.0

package/build/src/services/settings.service.js

@@ -7,113 +7,113 @@ exports.AmpSettingsMap = exports.AmpSettingsService = void 0;
 const lodash_1 = __importDefault(require("lodash"));
 class AmpSettingsService {
     constructor(rest, targetApi = 'api') {
+        this.getSettingsMap = async (tid) => {
+            const res = await this.rest.call({
+                url: `/${this.targetApi}/v1/settings`,
+                method: 'GET',
+                params: { tid },
+            });
+            const page = res.data;
+            const settings = page.data;
+            const rawSettingsMap = AmpSettingsService.formatSettingMap(settings, true);
+            return new AmpSettingsMap(rawSettingsMap, settings);
+        };
+        this.create = async (key, value, tid, cid) => {
+            const page = await this.rest.call({
+                url: `/${this.targetApi}/v1/settings`,
+                method: 'POST',
+                data: {
+                    tid,
+                    cid,
+                    key,
+                    value,
+                },
+            });
+            const settings = page.data;
+            return settings[0];
+        };
+        this.update = async (id, entity) => {
+            const page = await this.rest.call({
+                url: `/${this.targetApi}/v1/settings/${id}`,
+                method: 'PUT',
+                data: entity,
+            });
+            const settings = page.data;
+            return settings[0];
+        };
+        this.delete = async (id) => {
+            const page = await this.rest.call({
+                url: `/${this.targetApi}/v1/settings/${id}`,
+                method: 'DELETE',
+            });
+            const settings = page.data;
+            return settings[0];
+        };
         this.rest = rest;
         this.targetApi = targetApi;
     }
-    async getSettingsMap(tid) {
-        const res = await this.rest.call({
-            url: `/${this.targetApi}/v1/settings`,
-            method: 'GET',
-            params: { tid },
-        });
-        const page = res.data;
-        const settings = page.data;
-        const rawSettingsMap = AmpSettingsService.formatSettingMap(settings, true);
-        return new AmpSettingsMap(rawSettingsMap, settings);
-    }
-    async create(key, value, tid, cid) {
-        const page = await this.rest.call({
-            url: `/${this.targetApi}/v1/settings`,
-            method: 'POST',
-            data: {
-                tid,
-                cid,
-                key,
-                value,
-            },
-        });
-        const settings = page.data;
-        return settings[0];
-    }
-    async update(id, entity) {
-        const page = await this.rest.call({
-            url: `/${this.targetApi}/v1/settings/${id}`,
-            method: 'PUT',
-            data: entity,
-        });
-        const settings = page.data;
-        return settings[0];
-    }
-    async delete(id) {
-        const page = await this.rest.call({
-            url: `/${this.targetApi}/v1/settings/${id}`,
-            method: 'DELETE',
-        });
-        const settings = page.data;
-        return settings[0];
-    }
-    static formatSettingMap(settings, valuesOnly = true) {
-        const rawSettingsMap = {
-            tenantSettings: {},
-            connectorSettings: {},
-        };
-        settings.forEach(setting => {
-            if (setting.cid) {
-                if (!rawSettingsMap.connectorSettings[setting.cid]) {
-                    rawSettingsMap.connectorSettings[setting.cid] = {};
-                }
-                rawSettingsMap.connectorSettings[setting.cid][setting.key] = valuesOnly ? setting.value : setting;
-            }
-            else {
-                rawSettingsMap.tenantSettings[setting.key] = valuesOnly ? setting.value : setting;
-            }
-        });
-        return rawSettingsMap;
-    }
 }
 exports.AmpSettingsService = AmpSettingsService;
+AmpSettingsService.formatSettingMap = (settings, valuesOnly = true) => {
+    const rawSettingsMap = {
+        tenantSettings: {},
+        connectorSettings: {},
+    };
+    settings.forEach(setting => {
+        if (setting.cid) {
+            if (!rawSettingsMap.connectorSettings[setting.cid]) {
+                rawSettingsMap.connectorSettings[setting.cid] = {};
+            }
+            rawSettingsMap.connectorSettings[setting.cid][setting.key] = valuesOnly ? setting.value : setting;
+        }
+        else {
+            rawSettingsMap.tenantSettings[setting.key] = valuesOnly ? setting.value : setting;
+        }
+    });
+    return rawSettingsMap;
+};
 class AmpSettingsMap {
     constructor(settings, rawSettingsList) {
         this.rawSettingsList = new Array();
-        this.settings = settings;
-        this.rawSettingsList = rawSettingsList;
-    }
-    getGlobalSetting(key) {
-        const tenantVal = this.settings.tenantSettings[key.id];
-        if (tenantVal) {
-            return tenantVal;
-        }
-        return key.defaultValue;
-    }
-    getConnectorSetting(cid, key) {
-        const tenantVal = this.settings.tenantSettings[key.id];
-        const connectorMap = this.settings.connectorSettings[cid];
-        if (connectorMap) {
-            const connectorVal = connectorMap[key.id];
-            if (connectorVal) {
-                return connectorVal;
+        this.getGlobalSetting = (key) => {
+            const tenantVal = this.settings.tenantSettings[key.id];
+            if (tenantVal) {
+                return tenantVal;
             }
-        }
-        if (tenantVal) {
-            return tenantVal;
-        }
-        return key.defaultValue;
-    }
-    getConnectorSettings(cid) {
-        if (!this.settings.connectorSettings[cid]) {
-            return undefined;
-        }
-        return lodash_1.default.clone(this.settings.connectorSettings[cid]);
-    }
-    getRawMap() {
-        return AmpSettingsService.formatSettingMap(this.rawSettingsList, false);
-    }
-    static asKey(key, defaultValue) {
-        return {
-            id: key,
-            defaultValue,
+            return key.defaultValue;
         };
+        this.getConnectorSetting = (cid, key) => {
+            const tenantVal = this.settings.tenantSettings[key.id];
+            const connectorMap = this.settings.connectorSettings[cid];
+            if (connectorMap) {
+                const connectorVal = connectorMap[key.id];
+                if (connectorVal) {
+                    return connectorVal;
+                }
+            }
+            if (tenantVal) {
+                return tenantVal;
+            }
+            return key.defaultValue;
+        };
+        this.getConnectorSettings = (cid) => {
+            if (!this.settings.connectorSettings[cid]) {
+                return undefined;
+            }
+            return lodash_1.default.clone(this.settings.connectorSettings[cid]);
+        };
+        this.getRawMap = () => {
+            return AmpSettingsService.formatSettingMap(this.rawSettingsList, false);
+        };
+        this.settings = settings;
+        this.rawSettingsList = rawSettingsList;
     }
 }
 exports.AmpSettingsMap = AmpSettingsMap;
+AmpSettingsMap.asKey = (key, defaultValue) => {
+    return {
+        id: key,
+        defaultValue,
+    };
+};
 //# sourceMappingURL=settings.service.js.map

package/build/src/services/settings.service.js.map

@@ -1 +1 @@
-{"version":3,"file":"settings.service.js","sourceRoot":"","sources":["../../../src/services/settings.service.ts"],"names":[],"mappings":";;;;;;AAAA,oDAAuB;AAoBvB,MAAa,kBAAkB;IAG7B,YAAY,IAAgB,EAAE,YAAuB,KAAK;QACxD,IAAI,CAAC,IAAI,GAAG,IAAI,CAAC;QACjB,IAAI,CAAC,SAAS,GAAG,SAAS,CAAC;IAC7B,CAAC;IAED,KAAK,CAAC,cAAc,CAAC,GAAY;QAC/B,MAAM,GAAG,GAAG,MAAM,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC;YAC/B,GAAG,EAAE,IAAI,IAAI,CAAC,SAAS,cAAc;YACrC,MAAM,EAAE,KAAK;YACb,MAAM,EAAE,EAAC,GAAG,EAAC;SACd,CAAC,CAAC;QACH,MAAM,IAAI,GAAG,GAAG,CAAC,IAA2B,CAAC;QAC7C,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAI,CAAC;QAC3B,MAAM,cAAc,GAAsB,kBAAkB,CAAC,gBAAgB,CAAC,QAAQ,EAAE,IAAI,CAAC,CAAC;QAC9F,OAAO,IAAI,cAAc,CAAC,cAAc,EAAE,QAAQ,CAAC,CAAC;IACtD,CAAC;IAED,KAAK,CAAC,MAAM,CAAI,GAA2B,EAAE,KAAQ,EAAE,GAAW,EAAE,GAAY;QAC9E,MAAM,IAAI,GAAG,MAAM,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC;YAChC,GAAG,EAAE,IAAI,IAAI,CAAC,SAAS,cAAc;YACrC,MAAM,EAAE,MAAM;YACd,IAAI,EAAE;gBACJ,GAAG;gBACH,GAAG;gBACH,GAAG;gBACH,KAAK;aACN;SACF,CAAC,CAAC;QACH,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAuB,CAAC;QAC9C,OAAO,QAAQ,CAAC,CAAC,CAAC,CAAC;IACrB,CAAC;IAED,KAAK,CAAC,MAAM,CAAC,EAAU,EAAE,MAA2B;QAClD,MAAM,IAAI,GAAG,MAAM,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC;YAChC,GAAG,EAAE,IAAI,IAAI,CAAC,SAAS,gBAAgB,EAAE,EAAE;YAC3C,MAAM,EAAE,KAAK;YACb,IAAI,EAAE,MAAM;SACb,CAAC,CAAC;QACH,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAuB,CAAC;QAC9C,OAAO,QAAQ,CAAC,CAAC,CAAC,CAAC;IACrB,CAAC;IAED,KAAK,CAAC,MAAM,CAAC,EAAU;QACrB,MAAM,IAAI,GAAG,MAAM,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC;YAChC,GAAG,EAAE,IAAI,IAAI,CAAC,SAAS,gBAAgB,EAAE,EAAE;YAC3C,MAAM,EAAE,QAAQ;SACjB,CAAC,CAAC;QACH,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAuB,CAAC;QAC9C,OAAO,QAAQ,CAAC,CAAC,CAAC,CAAC;IACrB,CAAC;IAED,MAAM,CAAC,gBAAgB,CAAC,QAAyB,EAAE,UAAU,GAAG,IAAI;QAClE,MAAM,cAAc,GAAsB;YACxC,cAAc,EAAE,EAAE;YAClB,iBAAiB,EAAE,EAAE;SACtB,CAAC;QACF,QAAQ,CAAC,OAAO,CAAC,OAAO,CAAC,EAAE;YACzB,IAAI,OAAO,CAAC,GAAG,EAAE;gBACf,IAAI,CAAC,cAAc,CAAC,iBAAiB,CAAC,OAAO,CAAC,GAAG,CAAC,EAAE;oBAClD,cAAc,CAAC,iBAAiB,CAAC,OAAO,CAAC,GAAG,CAAC,GAAG,EAAE,CAAC;iBACpD;gBACD,cAAc,CAAC,iBAAiB,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,OAAO,CAAC,GAAG,CAAC,GAAG,UAAU,CAAC,CAAC,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC,CAAC,OAAO,CAAC;aACnG;iBAAM;gBACL,cAAc,CAAC,cAAc,CAAC,OAAO,CAAC,GAAG,CAAC,GAAG,UAAU,CAAC,CAAC,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC,CAAC,OAAO,CAAC;aACnF;QACH,CAAC,CAAC,CAAC;QACH,OAAO,cAAc,CAAC;IACxB,CAAC;CACF;AAvED,gDAuEC;AAED,MAAa,cAAc;IAIzB,YAAY,QAA2B,EAAE,eAAgC;QAFxD,oBAAe,GAAG,IAAI,KAAK,EAAiB,CAAC;QAG5D,IAAI,CAAC,QAAQ,GAAG,QAAQ,CAAC;QACzB,IAAI,CAAC,eAAe,GAAG,eAAe,CAAC;IACzC,CAAC;IAED,gBAAgB,CAAI,GAA2B;QAC7C,MAAM,SAAS,GAAG,IAAI,CAAC,QAAQ,CAAC,cAAc,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;QACvD,IAAI,SAAS,EAAE;YACb,OAAO,SAAc,CAAC;SACvB;QACD,OAAO,GAAG,CAAC,YAAY,CAAC;IAC1B,CAAC;IAED,mBAAmB,CAAI,GAAW,EAAE,GAA2B;QAC7D,MAAM,SAAS,GAAG,IAAI,CAAC,QAAQ,CAAC,cAAc,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;QACvD,MAAM,YAAY,GAAG,IAAI,CAAC,QAAQ,CAAC,iBAAiB,CAAC,GAAG,CAAC,CAAC;QAC1D,IAAI,YAAY,EAAE;YAChB,MAAM,YAAY,GAAG,YAAY,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;YAC1C,IAAI,YAAY,EAAE;gBAChB,OAAO,YAAiB,CAAC;aAC1B;SACF;QACD,IAAI,SAAS,EAAE;YACb,OAAO,SAAc,CAAC;SACvB;QACD,OAAO,GAAG,CAAC,YAAY,CAAC;IAC1B,CAAC;IAED,oBAAoB,CAAC,GAAW;QAC9B,IAAI,CAAC,IAAI,CAAC,QAAQ,CAAC,iBAAiB,CAAC,GAAG,CAAC,EAAE;YACzC,OAAO,SAAS,CAAC;SAClB;QACD,OAAO,gBAAC,CAAC,KAAK,CAAC,IAAI,CAAC,QAAQ,CAAC,iBAAiB,CAAC,GAAG,CAAC,CAAC,CAAC;IACvD,CAAC;IAED,SAAS;QACP,OAAO,kBAAkB,CAAC,gBAAgB,CAAC,IAAI,CAAC,eAAe,EAAE,KAAK,CAAC,CAAC;IAC1E,CAAC;IAED,MAAM,CAAC,KAAK,CAAI,GAAkB,EAAE,YAAe;QACjD,OAAO;YACL,EAAE,EAAE,GAAG;YACP,YAAY;SACb,CAAC;IACJ,CAAC;CACF;AAjDD,wCAiDC"}
+{"version":3,"file":"settings.service.js","sourceRoot":"","sources":["../../../src/services/settings.service.ts"],"names":[],"mappings":";;;;;;AAAA,oDAAuB;AAoBvB,MAAa,kBAAkB;IAG7B,YAAY,IAAgB,EAAE,YAAuB,KAAK;QAK1D,mBAAc,GAAG,KAAK,EAAE,GAAY,EAA2B,EAAE;YAC/D,MAAM,GAAG,GAAG,MAAM,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC;gBAC/B,GAAG,EAAE,IAAI,IAAI,CAAC,SAAS,cAAc;gBACrC,MAAM,EAAE,KAAK;gBACb,MAAM,EAAE,EAAC,GAAG,EAAC;aACd,CAAC,CAAC;YACH,MAAM,IAAI,GAAG,GAAG,CAAC,IAA2B,CAAC;YAC7C,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAI,CAAC;YAC3B,MAAM,cAAc,GAAsB,kBAAkB,CAAC,gBAAgB,CAAC,QAAQ,EAAE,IAAI,CAAC,CAAC;YAC9F,OAAO,IAAI,cAAc,CAAC,cAAc,EAAE,QAAQ,CAAC,CAAC;QACtD,CAAC,CAAC;QAEF,WAAM,GAAG,KAAK,EAAK,GAA2B,EAAE,KAAQ,EAAE,GAAW,EAAE,GAAY,EAA0B,EAAE;YAC7G,MAAM,IAAI,GAAG,MAAM,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC;gBAChC,GAAG,EAAE,IAAI,IAAI,CAAC,SAAS,cAAc;gBACrC,MAAM,EAAE,MAAM;gBACd,IAAI,EAAE;oBACJ,GAAG;oBACH,GAAG;oBACH,GAAG;oBACH,KAAK;iBACN;aACF,CAAC,CAAC;YACH,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAuB,CAAC;YAC9C,OAAO,QAAQ,CAAC,CAAC,CAAC,CAAC;QACrB,CAAC,CAAC;QAEF,WAAM,GAAG,KAAK,EAAE,EAAU,EAAE,MAA2B,EAA0B,EAAE;YACjF,MAAM,IAAI,GAAG,MAAM,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC;gBAChC,GAAG,EAAE,IAAI,IAAI,CAAC,SAAS,gBAAgB,EAAE,EAAE;gBAC3C,MAAM,EAAE,KAAK;gBACb,IAAI,EAAE,MAAM;aACb,CAAC,CAAC;YACH,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAuB,CAAC;YAC9C,OAAO,QAAQ,CAAC,CAAC,CAAC,CAAC;QACrB,CAAC,CAAC;QAEF,WAAM,GAAG,KAAK,EAAE,EAAU,EAA0B,EAAE;YACpD,MAAM,IAAI,GAAG,MAAM,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC;gBAChC,GAAG,EAAE,IAAI,IAAI,CAAC,SAAS,gBAAgB,EAAE,EAAE;gBAC3C,MAAM,EAAE,QAAQ;aACjB,CAAC,CAAC;YACH,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAuB,CAAC;YAC9C,OAAO,QAAQ,CAAC,CAAC,CAAC,CAAC;QACrB,CAAC,CAAC;QAhDA,IAAI,CAAC,IAAI,GAAG,IAAI,CAAC;QACjB,IAAI,CAAC,SAAS,GAAG,SAAS,CAAC;IAC7B,CAAC;;AANH,gDAuEC;AAjBQ,mCAAgB,GAAG,CAAC,QAAyB,EAAE,UAAU,GAAG,IAAI,EAAqB,EAAE;IAC5F,MAAM,cAAc,GAAsB;QACxC,cAAc,EAAE,EAAE;QAClB,iBAAiB,EAAE,EAAE;KACtB,CAAC;IACF,QAAQ,CAAC,OAAO,CAAC,OAAO,CAAC,EAAE;QACzB,IAAI,OAAO,CAAC,GAAG,EAAE;YACf,IAAI,CAAC,cAAc,CAAC,iBAAiB,CAAC,OAAO,CAAC,GAAG,CAAC,EAAE;gBAClD,cAAc,CAAC,iBAAiB,CAAC,OAAO,CAAC,GAAG,CAAC,GAAG,EAAE,CAAC;aACpD;YACD,cAAc,CAAC,iBAAiB,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,OAAO,CAAC,GAAG,CAAC,GAAG,UAAU,CAAC,CAAC,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC,CAAC,OAAO,CAAC;SACnG;aAAM;YACL,cAAc,CAAC,cAAc,CAAC,OAAO,CAAC,GAAG,CAAC,GAAG,UAAU,CAAC,CAAC,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC,CAAC,OAAO,CAAC;SACnF;IACH,CAAC,CAAC,CAAC;IACH,OAAO,cAAc,CAAC;AACxB,CAAC,AAhBsB,CAgBrB;AAGJ,MAAa,cAAc;IAIzB,YAAY,QAA2B,EAAE,eAAgC;QAFxD,oBAAe,GAAG,IAAI,KAAK,EAAiB,CAAC;QAO9D,qBAAgB,GAAG,CAAI,GAA2B,EAAK,EAAE;YACvD,MAAM,SAAS,GAAG,IAAI,CAAC,QAAQ,CAAC,cAAc,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;YACvD,IAAI,SAAS,EAAE;gBACb,OAAO,SAAc,CAAC;aACvB;YACD,OAAO,GAAG,CAAC,YAAY,CAAC;QAC1B,CAAC,CAAC;QAEF,wBAAmB,GAAG,CAAI,GAAW,EAAE,GAA2B,EAAK,EAAE;YACvE,MAAM,SAAS,GAAG,IAAI,CAAC,QAAQ,CAAC,cAAc,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;YACvD,MAAM,YAAY,GAAG,IAAI,CAAC,QAAQ,CAAC,iBAAiB,CAAC,GAAG,CAAC,CAAC;YAC1D,IAAI,YAAY,EAAE;gBAChB,MAAM,YAAY,GAAG,YAAY,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;gBAC1C,IAAI,YAAY,EAAE;oBAChB,OAAO,YAAiB,CAAC;iBAC1B;aACF;YACD,IAAI,SAAS,EAAE;gBACb,OAAO,SAAc,CAAC;aACvB;YACD,OAAO,GAAG,CAAC,YAAY,CAAC;QAC1B,CAAC,CAAC;QAEF,yBAAoB,GAAG,CAAC,GAAW,EAAiC,EAAE;YACpE,IAAI,CAAC,IAAI,CAAC,QAAQ,CAAC,iBAAiB,CAAC,GAAG,CAAC,EAAE;gBACzC,OAAO,SAAS,CAAC;aAClB;YACD,OAAO,gBAAC,CAAC,KAAK,CAAC,IAAI,CAAC,QAAQ,CAAC,iBAAiB,CAAC,GAAG,CAAC,CAAC,CAAC;QACvD,CAAC,CAAC;QAEF,cAAS,GAAG,GAAsB,EAAE;YAClC,OAAO,kBAAkB,CAAC,gBAAgB,CAAC,IAAI,CAAC,eAAe,EAAE,KAAK,CAAC,CAAC;QAC1E,CAAC,CAAC;QApCA,IAAI,CAAC,QAAQ,GAAG,QAAQ,CAAC;QACzB,IAAI,CAAC,eAAe,GAAG,eAAe,CAAC;IACzC,CAAC;;AAPH,wCAiDC;AANQ,oBAAK,GAAG,CAAI,GAAkB,EAAE,YAAe,EAA0B,EAAE;IAChF,OAAO;QACL,EAAE,EAAE,GAAG;QACP,YAAY;KACb,CAAC;AACJ,CAAC,AALW,CAKV"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ampsec/platform-client",
-  "version": "40.0.0",
+  "version": "40.2.0",
   "description": "",
   "main": "build/src/index.js",
   "runkitExampleFilename": "example/main.js",

package/src/dto/enums/finding.status.ts

@@ -1,6 +1,31 @@
+/**
+ * Enum for FindingStatus
+ *
+ * |                       | OPEN                 | CLOSED |
+ * | :-------------------- | :------------------- | :----- |
+ * | Included in score     | OPEN + ACCEPTED_RISK | N/A    |
+ * | Not included in score | FALSE_POSITIVE       | CLOSED |
+ *
+ * - OPEN
+ *    - Included in Score
+ *       - OPEN
+ *       - ACCEPTED_RISK
+ *    - Not included in Score
+ *      - PENDING_VERIFICATION
+ *      - FALSE_POSITIVE
+ * - CLOSED
+ */
+
 /* eslint-disable no-unused-vars */
 export enum FindingStatus {
+  /** OPEN + INCLUDED in score */
   OPEN = 'OPEN',
-  CLOSED = 'CLOSED',
+  /** OPEN + INCLUDED in score */
   PENDING_VERIFICATION = 'PENDING_VERIFICATION',
+  /** OPEN + INCLUDED in score */
+  ACCEPTED_RISK = 'ACCEPTED_RISK',
+  /** CLOSED + IGNORED from score */
+  CLOSED = 'CLOSED',
+  /** CLOSED + IGNORED from score */
+  FALSE_POSITIVE = 'CLOSED_FALSE_POSITIVE',
 }

package/src/services/AmpApi.ts

@@ -4,7 +4,6 @@ import {
   AssetDto,
   ConnectorDto,
   ConnectorUpsertDto,
-  FindingDto,
   NotificationDto,
   ProviderDto,
   ReportResultDto,
@@ -24,6 +23,7 @@ import {DefaultEnumService, EnumService} from './rest/EnumService';
 import {AmpSettingsService} from './settings.service';
 import {AgentIdentityService} from './rest/AgentIdentityService';
 import {ConnectorInstallService} from './rest/ConnectorInstallService';
+import {FindingsService} from './findings.service';
 
 export type AmpApiOptions = AmpRestClientOptions;
 
@@ -44,7 +44,7 @@ export class AmpApi {
   readonly asset: AmpDataService<AssetDto>;
   readonly connectors: AmpEntityService<ConnectorUpsertDto, ConnectorDto>;
   readonly enums: EnumService;
-  readonly findings: AmpDataService<FindingDto>;
+  readonly findings: FindingsService;
   readonly identity: AgentIdentityService;
   readonly install: ConnectorInstallService;
   readonly notifications: AmpDataService<NotificationDto>;
@@ -63,7 +63,7 @@ export class AmpApi {
     this.asset = new AmpDataServiceImpl<AssetDto>(rest, KIND.ASSETS);
     this.connectors = new AmpEntityServiceImpl<ConnectorUpsertDto, ConnectorDto>(rest, KIND.CONNECTORS);
     this.enums = new DefaultEnumService(rest);
-    this.findings = new AmpDataServiceImpl<FindingDto>(rest, KIND.FINDINGS);
+    this.findings = new FindingsService(rest);
     this.identity = new AgentIdentityService(rest);
     this.install = new ConnectorInstallService(rest);
     this.notifications = new AmpDataServiceImpl<NotificationDto>(rest, KIND.NOTIFICATIONS);

package/src/services/EngageApi.ts

@@ -38,13 +38,13 @@ export class EngageApi {
   readonly settings: AmpSettingsService;
 
   constructor(rest: RestClient) {
-    this.connectors = new AmpEntityServiceImpl<ConnectorUpsertDto, ConnectorDto>(rest, KIND.CONNECTORS, TARGET_API_ENGAGE); // TODO: add /eng endpoint... needed?
+    this.connectors = new AmpEntityServiceImpl<ConnectorUpsertDto, ConnectorDto>(rest, KIND.CONNECTORS, TARGET_API_ENGAGE);
     this.findings = new AmpPatchDataServiceImpl<FindingsStatusPatchDto, FindingDto>(rest, KIND.FINDINGS, TARGET_API_ENGAGE);
     this.identity = new UserIdentityService(rest);
-    this.notifications = new AmpDataServiceImpl<NotificationDto>(rest, KIND.NOTIFICATIONS, TARGET_API_ENGAGE); // TODO: add /eng endpoint
+    this.notifications = new AmpDataServiceImpl<NotificationDto>(rest, KIND.NOTIFICATIONS, TARGET_API_ENGAGE);
     this.providers = new AmpDataServiceImpl<ProviderDto>(rest, KIND.PROVIDERS, TARGET_API_AGENT);
     this.reports = new AmpReportServiceImpl(rest);
-    this.settings = new AmpSettingsService(rest); // TODO: add /eng endpoint
+    this.settings = new AmpSettingsService(rest); // TODO: confirm it is not needed. Currently returns NOT_IMPLEMENTED error code
   }
 
   static instance(options: EngageApiOptions): EngageApi {

package/src/services/data.service.ts

@@ -29,7 +29,7 @@ export class AmpDataServiceImpl<ReadT extends BaseDto> implements AmpDataService
     this.targetApi = targetApi;
   }
 
-  protected async call<T>(req: RestRequest, errorHandler: ErrorHandler<T>): Promise<T> {
+  protected call = async <T>(req: RestRequest, errorHandler: ErrorHandler<T>): Promise<T> => {
     try {
       const res = await this.rest.call(req);
       return res.data as T;
@@ -39,9 +39,9 @@ export class AmpDataServiceImpl<ReadT extends BaseDto> implements AmpDataService
       }
       return errorHandler(error);
     }
-  }
+  };
 
-  protected async getPage(req: RestRequest): Promise<Page<ReadT>> {
+  protected getPage = async (req: RestRequest): Promise<Page<ReadT>> => {
     return this.call(req, (error: unknown) => {
       const message = error instanceof Error ? error.message : 'Unknown error';
       return {
@@ -51,22 +51,22 @@ export class AmpDataServiceImpl<ReadT extends BaseDto> implements AmpDataService
         hints: {},
       };
     });
-  }
+  };
 
-  list(filter: FilterCriteria): Promise<Page<ReadT>> {
+  list = (filter: FilterCriteria): Promise<Page<ReadT>> => {
     return this.getPage({
       url: `/${this.targetApi}/v1/${this.kind}`,
       method: 'GET',
       params: filter,
     });
-  }
+  };
 
-  getById(id: string): Promise<Page<ReadT>> {
+  getById = (id: string): Promise<Page<ReadT>> => {
     return this.getPage({
       url: `/${this.targetApi}/v1/${this.kind}/${id}`,
       method: 'GET',
     });
-  }
+  };
 }
 
 export class AmpPatchDataServiceImpl<WriteT extends BaseUpsertDto, ReadT extends BaseDto> extends AmpDataServiceImpl<ReadT> implements AmpPatchDataService<WriteT, ReadT> {
@@ -74,7 +74,7 @@ export class AmpPatchDataServiceImpl<WriteT extends BaseUpsertDto, ReadT extends
     super(rest, kind, targetApi);
   }
 
-  patch(model: WriteT | WriteT[], options: DataServiceCallOptions): Promise<Page<ReadT>> {
+  patch = (model: WriteT | WriteT[], options: DataServiceCallOptions): Promise<Page<ReadT>> => {
     const url = _.isArray(model) ? `/${this.targetApi}/v1/${this.kind}` : `/${this.targetApi}/v1/${this.kind}/${model.id}`;
     return this.getPage({
       url,
@@ -82,5 +82,5 @@ export class AmpPatchDataServiceImpl<WriteT extends BaseUpsertDto, ReadT extends
       params: options.params as QueryMap,
       data: model,
     });
-  }
+  };
 }

package/src/services/entity.service.ts

@@ -38,16 +38,16 @@ export class AmpEntityServiceImpl<WriteT extends BaseUpsertDto, ReadT extends Ba
     super(rest, kind, targetApi);
   }
 
-  create(model: WriteT | WriteT[], options?: EntityCallOptions): Promise<Page<ReadT>> {
+  create = (model: WriteT | WriteT[], options?: EntityCallOptions): Promise<Page<ReadT>> => {
     return this.getPage({
       url: `/${this.targetApi}/v1/${this.kind}`,
       method: 'POST',
       params: options?.params as QueryMap,
       data: model,
     });
-  }
+  };
 
-  update(model: WriteT | WriteT[], options?: EntityCallOptions): Promise<Page<ReadT>> {
+  update = (model: WriteT | WriteT[], options?: EntityCallOptions): Promise<Page<ReadT>> => {
     const url = _.isArray(model) ? `/${this.targetApi}/v1/${this.kind}` : `/${this.targetApi}/v1/${this.kind}/${model.id}`;
     return this.getPage({
       url,
@@ -55,9 +55,9 @@ export class AmpEntityServiceImpl<WriteT extends BaseUpsertDto, ReadT extends Ba
       params: options?.params as QueryMap,
       data: model,
     });
-  }
+  };
 
-  async delete(id: string, options?: EntityCallOptions): Promise<Page<ReadT>> {
+  delete = async (id: string, options?: EntityCallOptions): Promise<Page<ReadT>> => {
     const res = await this.getById(id);
     if (res.data.length === 1) {
       const req: RestRequest = {
@@ -76,7 +76,7 @@ export class AmpEntityServiceImpl<WriteT extends BaseUpsertDto, ReadT extends Ba
       }
     }
     return res;
-  }
+  };
 }
 
 const extIdMapErrorHandler: ErrorHandler<ExtKeyMap> = (error: unknown) => {
@@ -93,7 +93,7 @@ export class AmpGlobalEntityServiceImpl<WriteT extends BaseUpsertDto, ReadT exte
   constructor(rest: RestClient, kind: string, targetApi: TargetApi = TARGET_API_AGENT) {
     super(rest, kind, targetApi);
   }
-  getLookupIds(tid: string, options?: EntityCallOptions): Promise<ExtKeyMap> {
+  getLookupIds = (tid: string, options?: EntityCallOptions): Promise<ExtKeyMap> => {
     const req: RestRequest = {
       url: `/${this.targetApi}/v1/${this.kind}/ext_key_map`,
       method: 'GET',
@@ -103,7 +103,7 @@ export class AmpGlobalEntityServiceImpl<WriteT extends BaseUpsertDto, ReadT exte
       },
     };
     return this.call(req, extIdMapErrorHandler);
-  }
+  };
 }
 
 export class AmpSaaSEntityServiceImpl<WriteT extends BaseUpsertDto, ReadT extends BaseDto>
@@ -113,7 +113,7 @@ export class AmpSaaSEntityServiceImpl<WriteT extends BaseUpsertDto, ReadT extend
   constructor(rest: RestClient, kind: string, targetApi: TargetApi = TARGET_API_AGENT) {
     super(rest, kind, targetApi);
   }
-  getLookupIds(cid: string, options?: EntityCallOptions): Promise<ExtKeyMap> {
+  getLookupIds = (cid: string, options?: EntityCallOptions): Promise<ExtKeyMap> => {
     const req: RestRequest = {
       url: `/${this.targetApi}/v1/${this.kind}/ext_key_map`,
       method: 'GET',
@@ -123,5 +123,5 @@ export class AmpSaaSEntityServiceImpl<WriteT extends BaseUpsertDto, ReadT extend
       },
     };
     return this.call(req, extIdMapErrorHandler);
-  }
+  };
 }

package/src/services/findings.service.ts

@@ -0,0 +1,24 @@
+import _ from 'lodash';
+import {FindingDto, FindingStatus, Page} from '../dto';
+import {AmpDataServiceImpl} from './data.service';
+import {RestClient} from './rest';
+import {KIND} from './constants';
+
+export interface FindingPatchDto {
+  status: FindingStatus;
+}
+
+export class FindingsService extends AmpDataServiceImpl<FindingDto> {
+  constructor(rest: RestClient) {
+    super(rest, KIND.FINDINGS);
+  }
+
+  patch(id: string, values: FindingPatchDto | FindingPatchDto[]): Promise<Page<FindingDto>> {
+    const url = _.isArray(values) ? `/${this.targetApi}/v1/${this.kind}` : `/${this.targetApi}/v1/${this.kind}/${id}`;
+    return this.getPage({
+      url,
+      method: 'PATCH',
+      data: values,
+    });
+  }
+}

package/src/services/index.ts

@@ -4,5 +4,6 @@ export * from './AmpSdk';
 export * from './constants';
 export * from './data.service';
 export * from './entity.service';
+export * from './findings.service';
 export * from './rest';
 export * from './settings.service';

package/src/services/reports.service.ts

@@ -15,7 +15,7 @@ export class AmpReportServiceImpl implements AmpReportService {
     this.rest = rest;
   }
 
-  async getMetrics(reportId: string, filter?: FilterCriteria | undefined): Promise<Page<ReportResultDto>> {
+  getMetrics = async (reportId: string, filter?: FilterCriteria | undefined): Promise<Page<ReportResultDto>> => {
     filter = filter ?? {};
     filter.limit = filter.limit ?? 1; // pull latest result by default
     try {
@@ -37,7 +37,7 @@ export class AmpReportServiceImpl implements AmpReportService {
         hints: {},
       };
     }
-  }
+  };
 
   /**
    *
@@ -46,11 +46,11 @@ export class AmpReportServiceImpl implements AmpReportService {
    * @param filter
    * @returns
    */
-  async getMetricsTrend(reportId: string, filter?: FilterCriteria): Promise<Page<ReportResultDto>> {
+  getMetricsTrend = async (reportId: string, filter?: FilterCriteria): Promise<Page<ReportResultDto>> => {
     // I am breaking this out into a separate method so that we can extend typing later
     // and add buckets/aggregations to the args
     filter = filter ?? {};
     filter.limit = filter.limit ?? DEFAULT_TREND_WINDOW_MONTHS;
     return this.getMetrics(reportId, filter);
-  }
+  };
 }

package/src/services/rest/AgentIdentityService.ts

@@ -10,7 +10,7 @@ export class AgentIdentityService {
   constructor(rest: RestClient) {
     this.rest = rest;
   }
-  async exchangeToken(targetTenantId: string): Promise<TokenResponse> {
+  exchangeToken = async (targetTenantId: string): Promise<TokenResponse> => {
     const res = await this.rest.call({
       url: '/api/v1/auth/token/exchange',
       method: 'GET',
@@ -19,13 +19,13 @@ export class AgentIdentityService {
       },
     });
     return res.data as TokenResponse;
-  }
+  };
 
-  async me(): Promise<AgentDto> {
+  me = async (): Promise<AgentDto> => {
     const res = await this.rest.call({
-      url: '/api/v1/me',
+      url: '/me',
       method: 'GET',
     });
     return res.data as AgentDto;
-  }
+  };
 }

package/src/services/rest/ConnectorInstallService.ts

@@ -7,7 +7,7 @@ export class ConnectorInstallService {
     this.rest = rest;
   }
 
-  async getInstallToken(cid: string): Promise<string> {
+  getInstallToken = async (cid: string): Promise<string> => {
     const res = await this.rest.call({
       url: '/install/oauth/token',
       method: 'POST',
@@ -15,9 +15,9 @@ export class ConnectorInstallService {
     });
     const token = (res.data as {token: string}).token;
     return token;
-  }
+  };
 
-  buildInstallOAuthUrl(apiBaseUrl: string, token: string, redirectUrl: string): string {
+  buildInstallOAuthUrl = (apiBaseUrl: string, token: string, redirectUrl: string): string => {
     return `${apiBaseUrl}/install/oauth?token=${token}&redirect=${encodeURIComponent(redirectUrl)}`;
-  }
+  };
 }

package/src/services/rest/EnumService.ts

@@ -23,14 +23,14 @@ class DefaultEnumCollection implements EnumCollection {
     this.kind = kind;
     this.targetApi = targetApi;
   }
-  async list(filter?: FilterCriteria): Promise<Page<EnumDto>> {
+  list = async (filter?: FilterCriteria): Promise<Page<EnumDto>> => {
     const res = await this.rest.call({
       url: `/${this.targetApi}/v1/enum/${this.kind}`,
       method: 'GET',
       params: filter,
     });
     return res.data as Page<EnumDto>;
-  }
+  };
 }
 
 export class DefaultEnumService implements EnumService {

package/src/services/rest/RestClient.ts

@@ -68,7 +68,7 @@ export class DefaultRestClient {
     this.retryStrategy = options.retryStrategy ?? noopRestRetryStrategy;
     this.rateLimitStrategy = options.rateLimitStrategy ?? noopRestClientRateLimitStrategy;
   }
-  async call(request: RestRequest): Promise<RestResponse> {
+  call = async (request: RestRequest): Promise<RestResponse> => {
     const req = _.merge(request);
     try {
       await this.rateLimitStrategy.reserve(req);
@@ -92,7 +92,7 @@ export class DefaultRestClient {
       }
       throw err;
     }
-  }
+  };
 }
 
 export const getAmpRestClient = (options: AmpRestClientOptions): RestClient => {

package/src/services/rest/UserIdentityService.ts

@@ -10,11 +10,11 @@ export class UserIdentityService {
   constructor(rest: RestClient) {
     this.rest = rest;
   }
-  async me(): Promise<AmpJwtToken> {
+  me = async (): Promise<AmpJwtToken> => {
     const res = await this.rest.call({
-      url: '/eng/v1/me',
+      url: '/me',
       method: 'GET',
     });
     return res.data as AmpJwtToken;
-  }
+  };
 }

package/src/services/rest/rateLimit.rest.ts

@@ -6,7 +6,7 @@ export interface RestClientRateLimitStrategy {
 
 export const noopRestClientRateLimitStrategy: RestClientRateLimitStrategy = {
   // eslint-disable-next-line @typescript-eslint/no-unused-vars
-  reserve(_req: RestRequest): Promise<void> {
+  reserve: (_req: RestRequest): Promise<void> => {
     return Promise.resolve();
   },
 };
@@ -22,10 +22,10 @@ export class StaticRestClientRateLimitStrategy implements RestClientRateLimitStr
     this.lastRequest = 0;
   }
   // eslint-disable-next-line @typescript-eslint/no-unused-vars
-  async reserve(_req: RestRequest): Promise<void> {
+  reserve = async (_req: RestRequest): Promise<void> => {
     while (Date.now() - this.lastRequest < this.delay) {
       await sleep(this.delay);
     }
     this.lastRequest = Date.now();
-  }
+  };
 }

package/src/services/rest/retry.rest.ts

@@ -8,7 +8,7 @@ export interface RestClientRetryStrategy {
 }
 
 export const noopRestRetryStrategy: RestClientRetryStrategy = {
-  onError(req: RestRequest, err: AxiosError): Promise<RestResponse> {
+  onError: (req: RestRequest, err: AxiosError): Promise<RestResponse> => {
     const axiosError = err as AxiosError;
     const res: RestResponse = {
       status: axiosError.response?.status ?? 500,