@amplytools/react-native-amply-sdk 0.1.4 → 0.1.5

package/android/build.gradle

@@ -15,7 +15,7 @@ buildscript {
 apply plugin: 'com.android.library'
 apply plugin: 'org.jetbrains.kotlin.android'
 
-def amplySdkVersion = project.findProperty('amplySdkVersion') ?: System.getenv('AMPLY_SDK_VERSION') ?: '0.1.10'
+def amplySdkVersion = project.findProperty('amplySdkVersion') ?: System.getenv('AMPLY_SDK_VERSION') ?: '0.1.12'
 group = 'tools.amply'
 version = amplySdkVersion
 

package/android/src/main/java/tools/amply/sdk/reactnative/AmplyModule.kt

@@ -203,7 +203,8 @@ class AmplyModule(reactContext: ReactApplicationContext) :
   private fun ensureLogEventCollection() {
     if (logEventsJob == null) {
       logEventsJob = scope.launch {
-        client.logEvents.collectLatest { event ->
+        // Use collect (not collectLatest) to ensure all replayed logs are emitted
+        client.logEvents.collect { event ->
           emitOnSystemEvent(event.toWritableMap())
         }
       }

package/android/src/main/java/tools/amply/sdk/reactnative/core/DefaultAmplyClient.kt

@@ -56,7 +56,7 @@ class DefaultAmplyClient(
   override val systemEvents: SharedFlow<EventEnvelope> = _systemEvents.asSharedFlow()
 
   private val _logEvents = MutableSharedFlow<EventEnvelope>(
-    replay = 0,
+    replay = 64,  // Replay buffer to capture init logs before JS collection starts
     extraBufferCapacity = 64,
   )
   override val logEvents: SharedFlow<EventEnvelope> = _logEvents.asSharedFlow()
@@ -70,21 +70,19 @@ class DefaultAmplyClient(
           "AmplyReactNative",
           "Initializing Amply with appId=${options.appId} apiKeyPublic=${options.apiKeyPublic.takeIf { it.isNotEmpty() } ?: "<empty>"}"
         )
-        val instance = withContext(Dispatchers.Default) {
-          Amply(config, application)
-        }
 
-        // Set log level from config
+        // Set log level and listener BEFORE creating instance so initialization logs are captured
         val effectiveLogLevel = options.getEffectiveLogLevel()
-        instance.setLogLevel(effectiveLogLevel.toString())
+        tools.amply.sdk.logging.Logger.setLevel(effectiveLogLevel.toString())
+        android.util.Log.i("AmplyReactNative", "Pre-init log level set to: $effectiveLogLevel")
 
-        // Set up log listener to emit logs to JS
-        instance.setLogListener(object : LogListener {
+        // Set up log listener BEFORE instance creation to capture all init logs
+        tools.amply.sdk.logging.Logger.setListener(object : LogListener {
           override fun onLog(entry: LogEntry) {
             val envelope = EventEnvelope(
               id = null,
               name = "DebugLog",
-              type = "system",
+              type = "log",
               timestamp = entry.timestamp,
               properties = buildMap {
                 put("level", entry.level.toString())
@@ -102,6 +100,10 @@ class DefaultAmplyClient(
           }
         })
 
+        val instance = withContext(Dispatchers.Default) {
+          Amply(config, application)
+        }
+
         ensureSystemEventsListener(instance)
         amplyInstance = instance
         createdInstance = true

package/ios/AmplyReactNative.podspec

@@ -1,6 +1,6 @@
 Pod::Spec.new do |s|
   s.name         = 'AmplyReactNative'
-  s.version      = '0.1.0-alpha.0'
+  s.version      = '0.1.0-alpha.1'
   s.summary      = 'React Native bridge for Amply SDK'
   s.homepage     = 'https://github.com/amply/amply-react-native'
   s.license      = { :type => 'MIT' }
@@ -16,7 +16,7 @@ Pod::Spec.new do |s|
   s.dependency 'React-RCTFabric'
 
   # Amply KMP SDK from CocoaPods
-  s.dependency 'AmplySDK', '~> 0.1.10'
+  s.dependency 'AmplySDK', '~> 0.1.12'
 
   s.libraries = 'c++'
   s.pod_target_xcconfig = {

package/ios/Sources/AmplyReactNative/AmplyModule.mm

@@ -44,9 +44,7 @@ static NSString* AmplyLogLevelToString(AmplyLogLevel level) {
     return @"none";
 }
 
-// Note: ASDKLogListener is not yet available in KMP SDK iOS XCFramework
-// Logging support will be enabled when the KMP SDK iOS exports these APIs
-@interface Amply : NativeAmplyModuleSpecBase <NativeAmplyModuleSpec, ASDKDeepLinkListener, ASDKSystemEventsListener>
+@interface Amply : NativeAmplyModuleSpecBase <NativeAmplyModuleSpec, ASDKDeepLinkListener, ASDKSystemEventsListener, ASDKLogListener>
 @property (nonatomic, strong) ASDKAmply *amplyInstance;
 @property (nonatomic, assign) BOOL deepLinkListenerRegistered;
 @property (nonatomic, assign) BOOL systemEventsListenerRegistered;
@@ -63,6 +61,9 @@ RCT_EXPORT_MODULE()
             reject:(RCTPromiseRejectBlock)reject
 {
   @try {
+    // Clear any existing log listener from previous instance (prevents crash on hot reload)
+    [[ASDKLogger shared] setListenerListener:nil];
+
     NSString *appId = config.appId();
     NSString *apiKeyPublic = config.apiKeyPublic();
     NSString *apiKeySecret = config.apiKeySecret();
@@ -101,10 +102,7 @@ RCT_EXPORT_MODULE()
 
     ASDKAmplyConfig *amplyConfig = [configBuilder build];
 
-    // Create Amply instance
-    self.amplyInstance = [[ASDKAmply alloc] initWithConfig:amplyConfig];
-
-    // Parse debug and logLevel options
+    // Parse debug and logLevel options BEFORE creating instance
     std::optional<bool> debugOpt = config.debug();
     BOOL debug = debugOpt.has_value() && debugOpt.value();
     NSString *logLevelStr = config.logLevel();
@@ -118,13 +116,15 @@ RCT_EXPORT_MODULE()
       self.currentLogLevel = AmplyLogLevelNone;
     }
 
+    // Set log level and listener BEFORE creating Amply instance to capture init logs
     if (self.currentLogLevel != AmplyLogLevelNone) {
-      RCTLogInfo(@"[AmplyReactNative] Debug logging enabled at level: %@", AmplyLogLevelToString(self.currentLogLevel));
+      RCTLogInfo(@"[AmplyReactNative] Setting log level to: %@ BEFORE instance creation", AmplyLogLevelToString(self.currentLogLevel));
+      [[ASDKLogger shared] setLevelLevel:AmplyLogLevelToString(self.currentLogLevel)];
+      [[ASDKLogger shared] setListenerListener:self];
     }
 
-    // TODO: Enable when KMP SDK iOS exports setLogLevel and setLogListener
-    // [self.amplyInstance setLogLevelLevel:AmplyLogLevelToString(self.currentLogLevel)];
-    // [self registerLogListenerInternal];
+    // Create Amply instance (this triggers initialization and config fetch)
+    self.amplyInstance = [[ASDKAmply alloc] initWithConfig:amplyConfig];
 
     // Register system events listener
     [self registerSystemEventsListenerInternal];
@@ -394,10 +394,12 @@ RCT_EXPORT_MODULE()
 {
   self.currentLogLevel = AmplyLogLevelFromString(level);
   RCTLogInfo(@"[AmplyReactNative] Log level set to: %@", level);
-  // TODO: Enable when KMP SDK iOS exports setLogLevel
-  // if (self.amplyInstance) {
-  //   [self.amplyInstance setLogLevelLevel:level];
-  // }
+  [[ASDKLogger shared] setLevelLevel:level];
+
+  // Ensure log listener is registered when enabling logging
+  if (self.currentLogLevel != AmplyLogLevelNone) {
+    [[ASDKLogger shared] setListenerListener:self];
+  }
 }
 
 - (NSString *)getLogLevel
@@ -461,6 +463,8 @@ RCT_EXPORT_MODULE()
 - (void)dealloc
 {
   [[NSNotificationCenter defaultCenter] removeObserver:self];
+  // Clear log listener to prevent crash when Logger tries to call deallocated object
+  [[ASDKLogger shared] setListenerListener:nil];
 }
 
 #pragma mark - ASDKSystemEventsListener
@@ -479,9 +483,41 @@ RCT_EXPORT_MODULE()
   [self emitOnSystemEvent:payload];
 }
 
-// TODO: Enable ASDKLogListener when KMP SDK iOS exports logging APIs
-// #pragma mark - ASDKLogListener
-// - (void)onLogEntry:(ASDKLogEntry *)entry { ... }
+#pragma mark - ASDKLogListener
+
+- (void)onLogEntry:(ASDKLogEntry *)entry
+{
+  // Convert log level to string
+  NSString *levelString = @"unknown";
+  if (entry.level == ASDKLogLevel.debug) {
+    levelString = @"debug";
+  } else if (entry.level == ASDKLogLevel.info) {
+    levelString = @"info";
+  } else if (entry.level == ASDKLogLevel.warn) {
+    levelString = @"warn";
+  } else if (entry.level == ASDKLogLevel.error) {
+    levelString = @"error";
+  } else if (entry.level == ASDKLogLevel.none) {
+    levelString = @"none";
+  }
+
+  NSMutableDictionary *properties = [NSMutableDictionary dictionary];
+  properties[@"level"] = levelString;
+  properties[@"category"] = entry.category ?: @"";
+  properties[@"message"] = entry.message ?: @"";
+  if (entry.details) {
+    properties[@"details"] = entry.details;
+  }
+
+  NSDictionary *payload = @{
+    @"name": @"DebugLog",
+    @"type": @"log",
+    @"timestamp": @(entry.timestamp),
+    @"properties": properties
+  };
+
+  [self emitOnSystemEvent:payload];
+}
 
 - (std::shared_ptr<TurboModule>)getTurboModule:(const ObjCTurboModule::InitParams &)params
 {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@amplytools/react-native-amply-sdk",
-  "version": "0.1.4",
+  "version": "0.1.5",
   "description": "React Native SDK for Amply: Mobile SDK to orchestrate in-app experiences and campaigns remotely, without app releases",
   "license": "MIT",
   "repository": {