@amityco/ts-sdk 0.0.1-beta.32 → 0.0.1-beta.36

package/src/channel/observers/tests/liveChannels.test.ts

@@ -1,28 +1,41 @@
-import { disableCache, enableCache, pushToCache } from '~/cache/api';
-import { getResolver } from '~/core/model';
-
-import { liveChannels } from '../liveChannels';
-import { prepareChannelPayload } from '../../utils/prepareChannelPayload';
-
+import { disableCache, enableCache } from '~/cache/api';
 import {
+  channel1,
+  channel2,
+  channelQueryResponse,
+  channelQueryResponsePage2,
+  channelRaw1,
+  channelRaw2,
   client,
-  pause,
   connectClient,
   disconnectClient,
-  channel11,
-  channelUser1,
-  channelQueryResponse,
-  channelQueryResponsePage2,
+  generateRawChannel,
+  generateRawMessage,
+  mockPage,
+  pause,
+  rawChannelUser,
+  rawChannelUser2,
+  user11,
 } from '~/utils/tests';
+import { liveChannels } from '../liveChannels';
+import { convertFromRaw, prepareChannelPayload } from '../../utils';
 
-const getSnapshot = () => {
+const getSnapshot = (params?: Record<string, any>) => {
   return {
     data: [] as Amity.Channel[],
     loading: true,
     error: undefined as any,
+    ...params,
   };
 };
 
+const convertFromRawParams = {
+  defaultSubChannelHasUnreadMention: false,
+  defaultSubChannelUnreadCount: 0,
+  localLastMentionSegment: 0,
+  localReadToSegment: 0,
+};
+
 describe('liveChannels', () => {
   beforeAll(async () => {
     await connectClient();
@@ -37,88 +50,113 @@ describe('liveChannels', () => {
   afterEach(disableCache);
 
   test('it should return channel collection', async () => {
-    // mock response of queryChannels and validate
     const callback = jest.fn();
     client.http.get = jest.fn().mockResolvedValue(channelQueryResponse);
 
     liveChannels({}, callback);
-
-    expect(callback).toHaveBeenCalledTimes(1);
-
-    const snapshot = getSnapshot();
-
-    // check if cache data returned (should be empty)
-    expect(callback).toHaveBeenCalledWith(expect.objectContaining(snapshot));
-
     await pause();
 
     expect(callback).toHaveBeenCalledTimes(2);
+    expect(callback).toHaveBeenNthCalledWith(1, expect.objectContaining(getSnapshot()));
+    expect(callback).toHaveBeenNthCalledWith(
+      2,
+      expect.objectContaining(
+        getSnapshot({
+          data: prepareChannelPayload(channelQueryResponse.data).channels,
+          loading: false,
+        }),
+      ),
+    );
+  });
 
-    // cause we apply prepareChannelPayload on channel raw data from server
-    const payload = prepareChannelPayload(channelQueryResponse.data);
+  test('it should return data from cache', async () => {
+    const callback = jest.fn();
+    client.http.get = jest.fn().mockResolvedValue(channelQueryResponse);
 
-    snapshot.data = payload.channels;
-    snapshot.loading = false;
+    liveChannels({}, () => undefined);
+    await pause();
+    liveChannels({}, callback);
+    await pause();
 
-    expect(callback).toHaveBeenCalledWith(expect.objectContaining(snapshot));
+    expect(callback).toHaveBeenCalledTimes(2);
+    expect(callback).toHaveBeenNthCalledWith(
+      1,
+      expect.objectContaining(
+        getSnapshot({
+          data: prepareChannelPayload(channelQueryResponse.data).channels,
+        }),
+      ),
+    );
+    expect(callback).toHaveBeenNthCalledWith(
+      2,
+      expect.objectContaining(
+        getSnapshot({
+          data: prepareChannelPayload(channelQueryResponse.data).channels,
+          loading: false,
+        }),
+      ),
+    );
   });
 
-  // table for channel filters
-  const filters: [string, Amity.ChannelLiveCollection, number?][] = [
-    ['deleted', { isDeleted: false }],
-    ['tagged', { tags: ['tag2'] }],
-    ['out excluded tags', { excludeTags: ['tag1'] }],
-    ['member', { membership: 'member' }],
-    ['not member', { membership: 'notMember' }, 1],
-    ['all membership', { membership: 'all' }],
+  const rawDeletedChannel = generateRawChannel({
+    channelId: 'deleted-channel-id',
+    isDeleted: true,
+  });
+  const deletedChannel = convertFromRaw(rawDeletedChannel, convertFromRawParams);
+  const rawTaggedChannel = generateRawChannel({
+    channelId: 'tagged-channel-id',
+    tags: ['tag1', 'tag2'],
+  });
+  const taggedChannel = convertFromRaw(rawTaggedChannel, convertFromRawParams);
+  const rawTaggedChannel2 = generateRawChannel({
+    channelId: 'tagged-channel-id-2',
+    tags: ['tag2'],
+  });
+  const taggedChannel2 = convertFromRaw(rawTaggedChannel2, convertFromRawParams);
+
+  const filters: [string, Amity.ChannelLiveCollection, Amity.Channel[]][] = [
+    ['deleted', { isDeleted: false }, [channel1, taggedChannel, taggedChannel2]],
+    ['tagged', { tags: ['tag2'] }, [taggedChannel, taggedChannel2]],
+    ['out excluded tags', { excludeTags: ['tag1'] }, [channel1, deletedChannel, taggedChannel2]],
+    ['member', { membership: 'member' }, [channel1]],
+    ['not member', { membership: 'notMember' }, [deletedChannel, taggedChannel, taggedChannel2]],
+    [
+      'all membership',
+      { membership: 'all' },
+      [channel1, deletedChannel, taggedChannel, taggedChannel2],
+    ],
   ];
 
-  test.each(filters)(
-    'it should filter by %s channels',
-    async (filter, params, expectedChannelIdx = 0) => {
-      const callback = jest.fn();
-      client.http.get = jest.fn().mockResolvedValue(channelQueryResponse);
-
-      const payload = prepareChannelPayload(channelQueryResponse.data);
-      let snapshotData = [payload.channels[expectedChannelIdx]];
-
-      // add channel users to cache for testing membership filter
-      if (params.membership) {
-        pushToCache(
-          [
-            'channelUsers',
-            'get',
-            getResolver('channelUsers')({
-              channelId: channelQueryResponse.data.channels[0].channelId,
-              userId: channelUser1.userId,
-            }),
-          ],
-          channelUser1,
-        );
-
-        if (params.membership === 'all') {
-          snapshotData = payload.channels;
-        }
-      }
-
-      liveChannels(params, callback);
-
-      expect(callback).toHaveBeenCalledTimes(1);
-
-      const snapshot = getSnapshot();
-      // check if cache data returned (should be empty)
-      expect(callback).toHaveBeenCalledWith(expect.objectContaining(snapshot));
+  test.each(filters)('it should filter by %s channels', async (filter, params, expected) => {
+    const callback = jest.fn();
+    client.http.get = jest.fn().mockResolvedValue({
+      data: {
+        channels: [channelRaw1, rawDeletedChannel, rawTaggedChannel, rawTaggedChannel2],
+        channelUsers: [rawChannelUser],
+        files: [],
+        users: [user11],
+        ...mockPage,
+      },
+    });
 
-      await pause();
+    liveChannels(params, callback);
 
-      expect(callback).toHaveBeenCalledTimes(2);
+    expect(callback).toHaveBeenCalledTimes(1);
+    // check if cache data returned (should be empty)
+    expect(callback).toHaveBeenCalledWith(expect.objectContaining(getSnapshot()));
 
-      snapshot.loading = false;
-      snapshot.data = snapshotData;
+    await pause();
 
-      expect(callback).toHaveBeenCalledWith(expect.objectContaining(snapshot));
-    },
-  );
+    expect(callback).toHaveBeenCalledTimes(2);
+    expect(callback).toHaveBeenCalledWith(
+      expect.objectContaining(
+        getSnapshot({
+          loading: false,
+          data: expected,
+        }),
+      ),
+    );
+  });
 
   test('it should return method to fetch next page', async () => {
     const callback = jest.fn();
@@ -128,11 +166,9 @@ describe('liveChannels', () => {
       .mockResolvedValueOnce(channelQueryResponsePage2);
 
     liveChannels({}, callback);
-
-    expect(callback).toHaveBeenCalled();
-
     await pause();
 
+    expect(callback).toHaveBeenCalled();
     expect(callback.mock.lastCall).toHaveLength(1);
 
     const { onNextPage, hasNextPage } = callback.mock.lastCall[0];
@@ -141,70 +177,293 @@ describe('liveChannels', () => {
     expect(onNextPage).toBeTruthy();
 
     onNextPage();
-
     await pause();
 
-    // 4 -> becuase 1 local & server call each per call (2)
+    // 4 -> because 1 local & server call each per call (2)
     expect(callback).toHaveBeenCalledTimes(4);
+    expect(callback).toHaveBeenNthCalledWith(
+      4,
+      expect.objectContaining(
+        getSnapshot({
+          loading: false,
+          data: [
+            ...prepareChannelPayload(channelQueryResponsePage2.data).channels,
+            ...prepareChannelPayload(channelQueryResponse.data).channels,
+          ],
+        }),
+      ),
+    );
+  });
 
-    const payload = prepareChannelPayload(channelQueryResponse.data);
-    const payload2 = prepareChannelPayload(channelQueryResponsePage2.data);
+  describe('events', () => {
+    const rawNewChannel = generateRawChannel({ channelId: 'new-channel-id' });
+
+    const cases: [string, keyof Amity.Events, Amity.ChannelRaw, Amity.Channel[]][] = [
+      [
+        'it should add new channel to collection onCreate',
+        'channel.created',
+        rawNewChannel,
+        [convertFromRaw(rawNewChannel, convertFromRawParams), channel1, channel2],
+      ],
+      [
+        'it should add new channel to collection onJoin',
+        'channel.joined',
+        rawNewChannel,
+        [convertFromRaw(rawNewChannel, convertFromRawParams), channel1, channel2],
+      ],
+      [
+        'it should update channel in collection onUpdate',
+        'channel.updated',
+        channelRaw1,
+        [channel1, channel2],
+      ],
+      [
+        'it should update channel in collection onMuted',
+        'channel.setMuted',
+        { ...channelRaw1, isMuted: true },
+        [{ ...channel1, isMuted: true }, channel2],
+      ],
+      [
+        'it should remove channel from collection onDelete',
+        'channel.deleted',
+        { ...channelRaw1, isDeleted: true },
+        [channel2],
+      ],
+      [
+        'it should remove channel from collection onLeft',
+        'channel.left',
+        { ...channelRaw1, isDeleted: true },
+        [channel2],
+      ],
+    ];
+
+    test.each(cases)('%s', async (test, event, rawChannel, expected) => {
+      const callback = jest.fn();
+      client.http.get = jest.fn().mockResolvedValue(channelQueryResponse);
 
-    const snapshot = getSnapshot();
-    snapshot.loading = false;
-    snapshot.data = [...payload2.channels, ...payload.channels];
+      liveChannels({ isDeleted: false }, callback);
+      await pause();
+      client.emitter.emit(event, {
+        channels: [rawChannel],
+        channelUsers: [rawChannelUser],
+        users: [],
+        files: [],
+      });
+      await pause();
 
-    expect(callback).toHaveBeenNthCalledWith(4, expect.objectContaining(snapshot));
-  });
+      expect(callback).toHaveBeenNthCalledWith(
+        3,
+        expect.objectContaining(
+          getSnapshot({
+            data: expected,
+            loading: false,
+          }),
+        ),
+      );
+    });
 
-  const events: [string, keyof Amity.Events, Amity.Channel][] = [
-    [
-      'it should add new channel to collection onCreate',
-      'v3.channel.didCreate',
-      { ...channel11, channelId: 'new-channel-id' },
-    ],
-    ['it should edit channel in collection onUpdate', 'v3.channel.didUpdate', channel11],
-    ['it should remove channel from collection onDelete', 'v3.channel.didDelete', channel11],
-  ];
+    it('should add the channel to collection if user is added to the channel and member filter is applied', async () => {
+      const callback = jest.fn();
+      client.http.get = jest.fn().mockResolvedValue({
+        data: {
+          channels: [channelRaw2],
+          channelUsers: [rawChannelUser2],
+          files: [],
+          users: [user11],
+          ...mockPage,
+        },
+      });
+
+      liveChannels({ membership: 'member' }, callback);
+      await pause();
+      client.emitter.emit('channel.membersAdded', {
+        channels: [channelRaw1],
+        channelUsers: [rawChannelUser],
+        users: [user11],
+        files: [],
+      });
+      await pause();
 
-  test.each(events)('%s', async (test, event, channel) => {
-    const snapshot = getSnapshot();
+      expect(callback).toHaveBeenNthCalledWith(
+        3,
+        expect.objectContaining(getSnapshot({ data: [channel1, channel2], loading: false })),
+      );
+    });
 
-    const callback = jest.fn();
-    client.http.get = jest.fn().mockResolvedValue(channelQueryResponse);
+    it('should add the channel to collection if user is removed from the channel and nonMember filter is applied', async () => {
+      const callback = jest.fn();
+      client.http.get = jest.fn().mockResolvedValue({
+        data: {
+          channels: [channelRaw2],
+          channelUsers: [],
+          files: [],
+          users: [user11],
+          ...mockPage,
+        },
+      });
+
+      liveChannels({ membership: 'notMember' }, callback);
+      await pause();
+      client.emitter.emit('channel.membersRemoved', {
+        channels: [channelRaw1],
+        channelUsers: [{ ...rawChannelUser, membership: 'none' }],
+        users: [user11],
+        files: [],
+      });
+      await pause();
 
-    liveChannels({}, callback);
+      expect(callback).toHaveBeenNthCalledWith(
+        3,
+        expect.objectContaining(getSnapshot({ data: [channel1, channel2], loading: false })),
+      );
+    });
 
-    await pause();
-    expect(callback).toHaveBeenCalledTimes(2);
+    it('should add the channel to collection if tag is added to the channel and tags is applied', async () => {
+      const callback = jest.fn();
+      client.http.get = jest.fn().mockResolvedValue({
+        data: {
+          channels: [channelRaw2],
+          channelUsers: [rawChannelUser2],
+          files: [],
+          users: [user11],
+          ...mockPage,
+        },
+      });
+
+      liveChannels({ tags: ['tag1'] }, callback);
+      await pause();
+      client.emitter.emit('channel.updated', {
+        channels: [{ ...channelRaw1, tags: ['tag1'] }],
+        channelUsers: [rawChannelUser],
+        users: [user11],
+        files: [],
+      });
+      await pause();
 
-    client.emitter.emit(event, {
-      channels: [channel],
-      channelUsers: [channelUser1],
-      users: [],
-      files: [],
+      expect(callback).toHaveBeenNthCalledWith(
+        3,
+        expect.objectContaining(
+          getSnapshot({ data: [{ ...channel1, tags: ['tag1'] }, channel2], loading: false }),
+        ),
+      );
     });
 
-    const payload = prepareChannelPayload(channelQueryResponse.data);
-    const deletePayload = payload.channels.filter(
-      channel => channel.channelId !== channel11.channelId,
-    );
+    test.each([
+      [
+        'should remove the channel from the collection if user is removed from the channel and member filter is applied',
+        'channel.membersRemoved',
+      ],
+      [
+        'should remove the channel from the collection if user is left from the channel and member filter is applied',
+        'channel.left',
+      ],
+    ] as [string, keyof Amity.Events][])('%s', async (test, event) => {
+      const callback = jest.fn();
+      client.http.get = jest.fn().mockResolvedValue({
+        data: {
+          channels: [channelRaw1, channelRaw2],
+          channelUsers: [rawChannelUser, rawChannelUser2],
+          files: [],
+          users: [user11],
+          ...mockPage,
+        },
+      });
+
+      liveChannels({ membership: 'member' }, callback);
+      await pause();
+      client.emitter.emit(event, {
+        channels: [channelRaw1],
+        channelUsers: [{ ...rawChannelUser, membership: 'none' }],
+        users: [user11],
+        files: [],
+      });
+      await pause();
 
-    snapshot.loading = false;
-    // get data based on event
-    switch (event) {
-      case 'v3.channel.didCreate':
-        snapshot.data = [channel, ...payload.channels];
-        break;
+      expect(callback).toHaveBeenNthCalledWith(
+        3,
+        expect.objectContaining(getSnapshot({ data: [channel2], loading: false })),
+      );
+    });
 
-      case 'v3.channel.didUpdate':
-        snapshot.data = payload.channels;
-        break;
+    test.each([
+      [
+        'should remove the channel from the collection if user is added to the channel and notMember filter is applied',
+        'channel.membersAdded',
+      ],
+      [
+        'should remove the channel from the collection if user is joined to the channel and notMember filter is applied',
+        'channel.joined',
+      ],
+    ] as [string, keyof Amity.Events][])('%s', async (test, event) => {
+      const callback = jest.fn();
+      client.http.get = jest.fn().mockResolvedValue({
+        data: {
+          channels: [channelRaw1, channelRaw2],
+          channelUsers: [],
+          files: [],
+          users: [user11],
+          ...mockPage,
+        },
+      });
+
+      liveChannels({ membership: 'notMember' }, callback);
+      await pause();
+      client.emitter.emit('channel.membersAdded', {
+        channels: [channelRaw1],
+        channelUsers: [rawChannelUser],
+        users: [user11],
+        files: [],
+      });
+      await pause();
+
+      expect(callback).toHaveBeenNthCalledWith(
+        3,
+        expect.objectContaining(getSnapshot({ data: [channel2], loading: false })),
+      );
+    });
+  });
 
-      default:
-        snapshot.data = deletePayload;
-    }
+  it('should increase the unread count once message is created', async () => {
+    const callback = jest.fn();
+    client.http.get = jest.fn().mockResolvedValue({
+      data: {
+        channels: [channelRaw1],
+        channelUsers: [rawChannelUser],
+        files: [],
+        users: [user11],
+        ...mockPage,
+      },
+    });
 
-    expect(callback).toHaveBeenNthCalledWith(3, expect.objectContaining(snapshot));
+    liveChannels({}, callback);
+    await pause();
+    client.emitter.emit('message.created', {
+      messages: [
+        generateRawMessage({
+          channelPublicId: channelRaw1.channelId,
+          messageFeedId: channelRaw1._id,
+          segment: channelRaw1.messageCount + 1,
+        }),
+      ],
+    });
+    await pause(500);
+
+    expect(callback).toHaveBeenNthCalledWith(
+      3,
+      expect.objectContaining(
+        getSnapshot({
+          data: [
+            {
+              ...channel1,
+              defaultSubChannelUnreadCount: 1,
+              lastActivity: expect.anything(),
+              messageCount: channel1.messageCount + 1,
+              updatedAt: expect.anything(),
+            },
+          ],
+          loading: false,
+        }),
+      ),
+    );
   });
 });

package/src/channel/utils/index.ts

@@ -1 +1,54 @@
-export * from './prepareChannelPayload';
+import { pullFromCache } from '~/cache/api';
+
+export function convertFromRaw(
+  { _id, ...rest }: Amity.ChannelRaw,
+  params: Pick<
+    Amity.Channel,
+    | 'defaultSubChannelHasUnreadMention'
+    | 'defaultSubChannelUnreadCount'
+    | 'localLastMentionSegment'
+    | 'localReadToSegment'
+  >,
+): Amity.Channel {
+  return {
+    ...rest,
+    ...params,
+    defaultSubChannelId: _id,
+  };
+}
+
+function getSegmentParams(rawChannel: Amity.ChannelRaw) {
+  let cached;
+
+  try {
+    cached = pullFromCache<Amity.Channel>(['channel', 'get', rawChannel.channelId]);
+    // eslint-disable-next-line no-empty
+  } catch {}
+
+  if (cached) {
+    return {
+      defaultSubChannelHasUnreadMention: cached.data.defaultSubChannelHasUnreadMention,
+      defaultSubChannelUnreadCount: cached.data.defaultSubChannelUnreadCount,
+      localReadToSegment: cached.data.localReadToSegment,
+      localLastMentionSegment: cached.data.localLastMentionSegment,
+    };
+  }
+
+  return {
+    defaultSubChannelHasUnreadMention: false,
+    defaultSubChannelUnreadCount: 0,
+    // @ts-ignore
+    localReadToSegment: rawChannel.messageCount > 0 ? rawChannel.messageCount - 1 : 0,
+    localLastMentionSegment: 0,
+  };
+}
+
+export const prepareChannelPayload = (
+  payload: Amity.ChannelPayload,
+): Amity.ChannelPayload<any, Amity.Channel> => {
+  const channels: Amity.Channel[] = payload.channels.map(channel =>
+    convertFromRaw(channel, getSegmentParams(channel)),
+  );
+
+  return { ...payload, channels };
+};