npm - @amityco/social-plus-vise - Versions diffs - 1.1.1 → 1.3.0 - Mend

@amityco/social-plus-vise 1.1.1 → 1.3.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (18) hide show

package/CHANGELOG.md +43 -0
package/README.md +22 -10
package/dist/capabilities.js +6 -3
package/dist/explore.js +51 -0
package/dist/humanFormat.js +226 -0
package/dist/outcomes.js +15 -14
package/dist/server.js +275 -37
package/dist/solutionPath.js +274 -0
package/dist/tools/compliance.js +289 -35
package/dist/tools/debug.js +83 -26
package/dist/tools/design.js +24 -4
package/dist/tools/harness.js +30 -2
package/dist/tools/integration.js +161 -10
package/dist/tools/project.js +39 -13
package/dist/tools/sdkFacts.js +8 -1
package/dist/tools/sensors.js +1 -1
package/dist/uikitCustomization.js +384 -0
package/package.json +1 -1

package/dist/tools/design.js CHANGED Viewed

@@ -764,11 +764,15 @@ export async function generateDesignReference(repoPath, contract, title) {
         .join("\n      ");
     const digestShort = esc(contract.digest.slice(0, 23));
     const logoLetter = esc(title.slice(0, 1).toUpperCase());
+    const rootDecls = [...tokenCss.matchAll(/(--[a-z0-9-]+)\s*:\s*([^;]+);/gi)]
+        .map((m) => `  ${m[1]}: ${safeCss(m[2].trim())};`)
+        .join("\n");
+    const rootCss = rootDecls ? `:root{\n${rootDecls}\n}` : "";
     return `<!doctype html><html lang="en"><head><meta charset="utf-8"/>
 <meta name="viewport" content="width=device-width,initial-scale=1"/>
 <title>${esc(title)} — Design System</title>
 <style>
-${tokenCss}
+${rootCss}
 *,*::before,*::after{box-sizing:border-box;margin:0;padding:0}
 html{scroll-behavior:smooth}
 body{
@@ -1094,6 +1098,8 @@ export async function runDesignCheck(repoPath) {
     const declaredTokens = contract.tokens.filter((token) => token.provenance === "declared");
     const contractColorValues = new Set(contract.tokens.filter((token) => token.category === "color").map((token) => token.value));
     const referenced = new Set();
+    const referencedInApp = new Set();
+    const seedTokensRel = SP_TOKENS_PATH.split("/").join(path.sep);
     const colorSample = [];
     const definedVars = new Set();
     const varRefs = [];
@@ -1115,13 +1121,18 @@ export async function runDesignCheck(repoPath) {
         scanned += 1;
         const rel = path.relative(repoRoot, file);
         const isCss = file.toLowerCase().endsWith(".css") || file.toLowerCase().endsWith(".scss");
+        const isSeedFile = rel === SP_TOKENS_PATH || rel === seedTokensRel;
+        const contentLower = content.toLowerCase();
         for (const token of declaredTokens) {
             const key = tokenKey(token);
-            if (referenced.has(key)) {
+            if (referenced.has(key) && referencedInApp.has(key)) {
                 continue;
             }
-            if ((token.name && content.includes(token.name)) || content.includes(token.value)) {
+            if ((token.name && content.includes(token.name)) || contentLower.includes(token.value.toLowerCase())) {
                 referenced.add(key);
+                if (!isSeedFile) {
+                    referencedInApp.add(key);
+                }
             }
         }
         for (const value of scanColorLiterals(content)) {
@@ -1144,12 +1155,19 @@ export async function runDesignCheck(repoPath) {
     }
     const referencedTokens = declaredTokens.filter((token) => referenced.has(tokenKey(token))).map((token) => token.name ?? token.value);
     const unreferencedTokens = declaredTokens.filter((token) => !referenced.has(tokenKey(token))).map((token) => token.name ?? token.value);
+    const seededOnlyTokens = declaredTokens
+        .filter((token) => referenced.has(tokenKey(token)) && !referencedInApp.has(tokenKey(token)))
+        .map((token) => token.name ?? token.value);
     const contractTokenNames = new Set(contract.tokens.map((token) => token.name).filter((name) => Boolean(name)));
     const undefinedRefs = dedupeByToken(varRefs.filter((ref) => !definedVars.has(ref.token) && !contractTokenNames.has(ref.token)));
     return {
         status: "advisory",
         message: `Checked ${scanned} source file(s) against design contract ${contract.digest}. ` +
-            `${referencedTokens.length}/${declaredTokens.length} declared tokens referenced; ${totalColors - onContract} of ${totalColors} color literal(s) are off-contract (review hints)` +
+            `${referencedTokens.length}/${declaredTokens.length} declared tokens referenced` +
+            (seededOnlyTokens.length > 0
+                ? ` (${referencedTokens.length - seededOnlyTokens.length} used in your code, ${seededOnlyTokens.length} only in the Vise-seeded ${SP_TOKENS_PATH} — apply them to count)`
+                : "") +
+            `; ${totalColors - onContract} of ${totalColors} color literal(s) are off-contract (review hints)` +
             (undefinedRefs.length > 0 ? `; ${undefinedRefs.length} undefined token reference(s) (likely broken styles)` : "") +
             ".",
         contract: contractSummary(contract),
@@ -1158,6 +1176,8 @@ export async function runDesignCheck(repoPath) {
             referenced: referencedTokens.length,
             referenced_tokens: referencedTokens,
             unreferenced_tokens: unreferencedTokens,
+            referenced_in_app: referencedTokens.length - seededOnlyTokens.length,
+            seeded_only_tokens: seededOnlyTokens,
         },
         colorLiterals: {
             scanned_files: scanned,

package/dist/tools/harness.js CHANGED Viewed

@@ -160,10 +160,38 @@ export async function detectCommandSensors(repoPath, platforms) {
         });
     }
     if (platforms.includes("ios")) {
+        sensors.push(...(await swiftPackageSensors(root)));
         sensors.push(...(await iosBuildSensors(root)));
     }
     return sensors;
 }
+async function swiftPackageSensors(root) {
+    if (!(await exists(path.join(root, "Package.swift")))) {
+        return [];
+    }
+    if (!(await commandOnPath("swift"))) {
+        return [
+            {
+                name: "iOS SwiftPM manifest",
+                command: ["swift"],
+                timing: "after-change",
+                purpose: "Parse the SwiftPM manifest after iOS SDK setup changes.",
+                source: "Package.swift",
+                skip: "Package.swift was detected, but swift is not on PATH in this environment. Install Xcode or Swift toolchain support to enable the SwiftPM manifest sensor; static iOS rule checks run regardless.",
+            },
+        ];
+    }
+    return [
+        {
+            name: "iOS SwiftPM manifest",
+            command: ["swift", "package", "describe", "--type", "json"],
+            timing: "after-change",
+            purpose: "Parse the SwiftPM manifest after iOS SDK setup changes without compiling or requiring simulator/signing assets.",
+            source: "Package.swift",
+            timeoutReason: "SwiftPM manifest parsing (`swift package describe`) did not finish before the sensor timeout. This is reported as a timeout (NOT a clean pass): a stall can be a slow toolchain OR an unresolvable/circular dependency. Static iOS rule checks still run; rerun with a longer `--timeout-ms` if the toolchain is just slow.",
+        },
+    ];
+}
 const XCODEBUILD_ENVIRONMENT_SKIPS = [
     {
         pattern: "requires Xcode|command line tools instance",
@@ -330,8 +358,8 @@ function assessHarnessability(platforms, commandSensors, designSignalCount) {
     if (designSignalCount > 0) {
         affordances.push(`Detected ${designSignalCount} design/theme signal(s) for UI integration grounding.`);
     }
-    if (platforms.includes("ios")) {
-        gaps.push("iOS: static compliance rules are fully operational. No build/compile sensor is wired yet (xcodebuild environment requirements make it fragile); run-sensors will return no-sensors for iOS projects.");
+    if (platforms.includes("ios") && commandSensors.length === 0) {
+        gaps.push("iOS: static compliance rules are fully operational, but no SwiftPM or Xcode command sensor was detected for this project root.");
     }
     if (platforms.length === 0) {
         return { level: "weak", affordances, gaps };

package/dist/tools/integration.js CHANGED Viewed

@@ -10,6 +10,8 @@ import { detectCommandSensors } from "./harness.js";
 import { inspectProject } from "./project.js";
 import { creativeSurfaceHints, readCreativeSelection } from "./creative.js";
 import { buildUxHarness, uxHarnessPlanContext } from "./uxHarness.js";
+import { recommendSolutionPath } from "../solutionPath.js";
+import { recommendUIKitCustomization } from "../uikitCustomization.js";
 export const planIntegrationTool = {
     name: "plan_integration",
     description: "Create a grounded, evidence-backed implementation packet before an AI coding agent edits a customer project.",
@@ -72,7 +74,7 @@ async function buildIntegrationPlan(repoPath, request, surfacePath, answers = {}
     const uxHarnessOutcome = BROAD_SOCIAL_REGEX.test(request) && !hasAnswer(answers, "feature_surface") ? undefined : outcome;
     const uxHarnessContext = uxHarness ? uxHarnessPlanContext(uxHarness, uxHarnessOutcome) : undefined;
     const platform = preferredPlatform(inspection.platforms);
-    const supportLevel = supportFor(outcome, platform);
+    const baseSupportLevel = supportFor(outcome, platform);
     const sensors = await detectCommandSensors(root, inspection.platforms);
     const ctx = planContextFor({
         request,
@@ -84,6 +86,9 @@ async function buildIntegrationPlan(repoPath, request, surfacePath, answers = {}
     });
     const definition = getOutcomeDefinition(outcome);
     const capabilityAvailability = await platformCapabilityAvailability(outcome, platform);
+    const solutionPath = recommendSolutionPath(request, answers);
+    const uikitCustomization = recommendUIKitCustomization({ request, answers, platform, solutionPath });
+    const supportLevel = supportLevelForPlan(outcome, platform, baseSupportLevel, uikitCustomization);
     const designContract = await readDesignContract(repoRoot);
     const designReview = designReviewGuidance(repoRoot, designContract, answers);
     const acceptedDesignContract = designReview.status === "accepted" ? designContract : null;
@@ -108,6 +113,8 @@ async function buildIntegrationPlan(repoPath, request, surfacePath, answers = {}
     const packageJsonText = await readFile(path.join(root, "package.json"), "utf8").catch(() => undefined);
     const sdkVersion = await sdkVersionGuidance(platform, packageJsonText);
     const decisionsRequired = [
+        ...solutionPathDecisions(solutionPath, answers),
+        ...uikitCustomizationDecisions(uikitCustomization, answers),
         ...(creativeContext
             ? [
                 `[selected creative variant] Carry "${creativeContext.selectedVariant.title}" into the implementation plan. If any selected experience object is intentionally deferred, state that scope decision explicitly.`,
@@ -125,8 +132,10 @@ async function buildIntegrationPlan(repoPath, request, surfacePath, answers = {}
     return {
         outcome,
         platform,
+        solutionPath,
+        uikitCustomization,
         supportLevel,
-        intent: intentFor(request, definition.interpretation),
+        intent: intentFor(request, definition.interpretation, uikitCustomization),
         creativeContext,
         uxHarness: uxHarnessContext,
         socialWorkplan,
@@ -136,24 +145,28 @@ async function buildIntegrationPlan(repoPath, request, surfacePath, answers = {}
         implementationSteps: [
             ...creativeImplementationSteps(creativeSelection),
             ...uxHarnessImplementationSteps(uxHarnessContext),
+            ...solutionPathImplementationSteps(solutionPath),
+            ...uikitCustomizationImplementationSteps(uikitCustomization),
             ...definition.implementationSteps(ctx),
         ],
         validation: ["validate_setup", "run_sensors", ...definition.validation(platform)],
-        nextStep: "After implementing every step above, run `vise check .` and fix findings until green. You are not done until the check passes or each finding is explicitly attested.",
+        nextStep: nextStepForPlan(outcome, uikitCustomization, solutionPath),
         requiredInputs: composeRequiredInputs(ctx, definition.requiredInputs(ctx)),
         targetFiles: await targetFilesFor(root, outcome, platform, inspection.designSignals),
         implementationRules: [
             ...composeImplementationRules(ctx, definition.implementationRules(ctx)),
             ...creativeImplementationRules(creativeSelection),
             ...uxHarnessImplementationRules(uxHarnessContext),
+            ...solutionPathImplementationRules(solutionPath),
+            ...uikitCustomizationImplementationRules(uikitCustomization),
         ],
         intake,
-        docs: definition.docs(platform).filter((doc) => doc.path !== "unknown"),
+        docs: docsForPlan(definition.docs(platform), uikitCustomization),
         surface: inspection.selectedSurface ? { path: inspection.selectedSurface.path, platforms: inspection.selectedSurface.platforms } : undefined,
         availableSurfaces: inspection.surfaces,
         applicableRules: await applicableCompliancePlanRuleSummaries(outcome, inspection.platforms),
         sensors: sensors.map((sensor) => ({ name: sensor.name, command: sensor.command, source: sensor.source })),
-        stopConditions: composeStopConditions(ctx, definition.stopConditions(ctx), inspection.surfaces, surfacePath, Boolean(socialWorkplan)),
+        stopConditions: composeStopConditions(ctx, definition.stopConditions(ctx), inspection.surfaces, surfacePath, Boolean(socialWorkplan), uikitCustomization),
         evidencePolicy: "Every implementation step must cite at least one detected file, docs page, validator rule, or required user input. If evidence is missing, stop and ask the user instead of inventing details.",
         designContract: acceptedDesignContract ? designContractGuidance(acceptedDesignContract) : undefined,
         completenessChecklist: completenessChecklistFor(outcome),
@@ -188,6 +201,137 @@ function optionalCapabilitiesFor(outcome, answers, request, availability) {
         selected: selectedOptionalCapabilityIds(outcome, answers, request, availableIds),
     };
 }
+function solutionPathDecisions(solutionPath, answers) {
+    if (hasAnswer(answers, solutionPath.answerId)) {
+        return [];
+    }
+    if (!solutionPath.decision.requiredBeforeHandRolledUi) {
+        return [];
+    }
+    return [
+        `[solution path] ${solutionPath.summary} Answer with --answer ${solutionPath.answerId}=uikit, =sdk, or =hybrid before hand-rolling standard social UI.`,
+    ];
+}
+function solutionPathImplementationSteps(solutionPath) {
+    if (!solutionPath.decision.requiredBeforeHandRolledUi) {
+        return [];
+    }
+    return [
+        {
+            step: solutionPath.recommendation === "uikit"
+                ? "Confirm the social.plus UIKit path before building standard social UI from SDK primitives; use UIKit install/auth/customization docs as the primary implementation source. The SDK feed/chat/profile steps that follow apply ONLY to the direct-SDK (or hybrid SDK-side) route — do not hand-roll the standard surface from them when the customer is using UIKit."
+                : "Resolve whether this is a UIKit, SDK, or hybrid build before starting UI implementation; the SDK implementation steps that follow apply to the SDK/hybrid route, not to a UIKit build. Do not let mixed speed/customization signals collapse into a hand-rolled SDK UI by default.",
+            evidence: ["solutionPath", ...solutionPath.evidence],
+        },
+    ];
+}
+function solutionPathImplementationRules(solutionPath) {
+    if (solutionPath.recommendation === "sdk" && !solutionPath.decision.requiredBeforeHandRolledUi) {
+        return [];
+    }
+    return [
+        solutionPath.advisoryOnly,
+        ...solutionPath.implementationGuidance,
+    ];
+}
+function uikitCustomizationDecisions(uikitCustomization, answers) {
+    if (!uikitCustomization) {
+        return [];
+    }
+    if (hasAnswer(answers, uikitCustomization.answerId)) {
+        return [];
+    }
+    if (uikitCustomization.decision.requiredBeforeCustomization) {
+        return [
+            `[UIKit customization] ${uikitCustomization.summary} Answer with --answer ${uikitCustomization.answerId}=dynamic-ui, =component-styling, =localization, =behavior-overrides, =fork-and-extend, =sdk-custom-ui, or =hybrid before editing UIKit UI/customization code.`,
+        ];
+    }
+    return [
+        `[UIKit customization] ${uikitCustomization.summary} State this chosen route in the implementation summary, or re-plan with --answer ${uikitCustomization.answerId}=<route> if the customer chooses a different level.`,
+    ];
+}
+function uikitCustomizationImplementationSteps(uikitCustomization) {
+    if (!uikitCustomization) {
+        return [];
+    }
+    return [
+        {
+            step: `Apply the UIKit customization ladder before writing custom UI: start with ${uikitCustomization.recommendedLevel}, then escalate only if the customer goal cannot be expressed there.`,
+            evidence: ["uikitCustomization", ...uikitCustomization.evidence],
+        },
+    ];
+}
+function uikitCustomizationImplementationRules(uikitCustomization) {
+    if (!uikitCustomization) {
+        return [];
+    }
+    return [
+        uikitCustomization.advisoryOnly,
+        ...uikitCustomization.implementationGuidance,
+        ...uikitCustomization.platformGuidance,
+    ];
+}
+function docsForPlan(outcomeDocs, uikitCustomization) {
+    const docs = outcomeDocs.filter((doc) => doc.path !== "unknown");
+    if (!uikitCustomization) {
+        return docs;
+    }
+    const customizationLabel = labelForUIKitCustomizationLevel(uikitCustomization.recommendedLevel);
+    for (const docPath of uikitCustomization.docs) {
+        docs.push({
+            path: docPath,
+            reason: `UIKit ${customizationLabel} customization guidance for this solution path.`,
+        });
+    }
+    return dedupeDocsByPath(docs);
+}
+function supportLevelForPlan(outcome, platform, baseSupportLevel, uikitCustomization) {
+    if (platform !== "unknown" && outcome === "unknown" && uikitCustomization) {
+        return "guided";
+    }
+    return baseSupportLevel;
+}
+function nextStepForPlan(outcome, uikitCustomization, solutionPath) {
+    if (outcome === "unknown" && uikitCustomization) {
+        return "Treat this as UIKit customization guidance first: resolve the UIKit route and concrete app/platform target, then implement customer-owned config, localization, behavior, fork, or SDK custom UI changes with local build evidence. Do not claim `vise check` deterministically validates hidden UIKit internals.";
+    }
+    if (solutionPath.decision.requiredBeforeHandRolledUi) {
+        return "First resolve the solution-path decision (UIKit vs SDK vs hybrid). The SDK implementation steps above apply only if you build this surface directly with the SDK (or the SDK side of a hybrid); if the customer uses social.plus UIKit for the standard surface, follow the UIKit guidance instead of hand-rolling those steps. Once the route is settled, implement the applicable steps, then run `vise check .` and fix findings until green — you are not done until the check passes or each finding is explicitly attested.";
+    }
+    return "After implementing every step above, run `vise check .` and fix findings until green. You are not done until the check passes or each finding is explicitly attested.";
+}
+function dedupeDocsByPath(docs) {
+    const seen = new Set();
+    const out = [];
+    for (const doc of docs) {
+        if (seen.has(doc.path)) {
+            continue;
+        }
+        seen.add(doc.path);
+        out.push(doc);
+    }
+    return out;
+}
+function labelForUIKitCustomizationLevel(level) {
+    switch (level) {
+        case "dynamic-ui":
+            return "Dynamic UI";
+        case "component-styling":
+            return "Component Styling";
+        case "localization":
+            return "Localization";
+        case "behavior-overrides":
+            return "Behavior Overrides";
+        case "fork-and-extend":
+            return "Fork and Extend";
+        case "sdk-custom-ui":
+            return "SDK Custom UI";
+        case "hybrid":
+            return "Hybrid";
+        case "needs-decision":
+            return "decision";
+    }
+}
 function creativeContextForPlan(selection) {
     const selectedVariant = selection.selectedVariant;
     const surfaceHints = creativeSurfaceHints(selection);
@@ -484,13 +628,17 @@ function designContractGuidance(contract) {
         advisoryOnly: "This contract is advisory generation guidance — it adds no deterministic enforcement and never fails `vise check`.",
     };
 }
-function intentFor(request, interpretation) {
+function intentFor(request, interpretation, uikitCustomization) {
     const broadSocialRequest = BROAD_SOCIAL_REGEX.test(request);
     const designRequest = DESIGN_REGEX.test(request);
+    const uikitOnlyCustomization = interpretation === "Implement unknown." && uikitCustomization;
+    const uikitInterpretation = uikitOnlyCustomization
+        ? `${uikitCustomization.summary} No deterministic SDK outcome was selected, so keep this as guided UIKit customization until the customer names the concrete social surface or app-owned customization target.`
+        : interpretation;
     return {
         rawRequest: request,
-        interpretation,
-        ambiguity: broadSocialRequest || designRequest ? "high" : "medium",
+        interpretation: uikitInterpretation,
+        ambiguity: broadSocialRequest || designRequest || uikitCustomization?.status === "needs-decision" || uikitOnlyCustomization ? "high" : "medium",
     };
 }
 function intakeFor(ctx, outcomeQuestions, outcome, brief, availability, designReview) {
@@ -611,15 +759,18 @@ function composeImplementationRules(ctx, outcomeRules) {
     }
     return rules;
 }
-function composeStopConditions(ctx, outcomeStops, surfaces, surfacePath, hasSocialWorkplan = false) {
+function composeStopConditions(ctx, outcomeStops, surfaces, surfacePath, hasSocialWorkplan = false, uikitCustomization) {
     const stops = [
         "A required secret is missing and no safe ignored local env file or non-secret template path is clear.",
         "The target file is ambiguous or missing and no safe conventional location is detected.",
         "Docs lookup does not return the canonical page named in this plan.",
     ];
-    if (ctx.platform === "unknown" || ctx.outcome === "unknown") {
+    if (ctx.platform === "unknown" || (ctx.outcome === "unknown" && !uikitCustomization)) {
         stops.push("The request or platform is unsupported; do not implement until clarified.");
     }
+    if (ctx.outcome === "unknown" && uikitCustomization) {
+        stops.push("No deterministic SDK outcome was selected; do not run `vise init` or claim compliance coverage until a concrete social surface or app-owned UIKit customization target is confirmed.");
+    }
     if (ctx.platforms.length > 1 && !surfacePath) {
         stops.push(`Multiple platform signals detected (${ctx.platforms.join(", ")}); confirm which app surface should be modified.`);
     }

package/dist/tools/project.js CHANGED Viewed

@@ -204,7 +204,7 @@ async function validateAndroid(root) {
     const loginFiles = filesMatching(sourceContent, [/AmityCoreClient\s*\.\s*login/, /AmityClient\s*\.\s*login/]);
     const pushRegistrationFiles = filesMatching(sourceContent, [/registerPushNotification/, /enablePushNotification/, /PushNotification/]);
     const pushUnregisterFiles = filesMatching(sourceContent, [/unregisterPushNotification/, /disablePushNotification/, /unregister.*DeviceToken/i]);
-    const liveDataFiles = filesMatching(sourceContent, [/LiveCollection/, /LiveObject/, /\.observe\s*\(/, /\.subscribe\s*\(/, /queryPosts\s*\(/, /getPost\s*\(/]);
+    const liveDataFiles = filesMatching(sourceContent, [/LiveCollection/, /LiveObject/, /\.observe\s*\(/, /AmitySocialClient\s*\.\s*newPostRepository/, /\bgetPosts\s*\(/, /queryPosts\s*\(/, /getPost\s*\(/]);
     if (!manifest) {
         findings.push(finding("android.manifest.present", "warning", "No AndroidManifest.xml found at the default app path.", manifestPath, "Confirm the Android app module path, then validate permissions and Application wiring."));
     }
@@ -220,7 +220,7 @@ async function validateAndroid(root) {
         findings.push(finding("android.dependency.sdk", "warning", "No obvious social.plus Android SDK dependency was found in Gradle files.", relativeFile(root, buildFiles[0]), "Add the SDK dependency from the Android quick-start docs and keep all Amity dependencies on compatible versions."));
     }
     else if (containsAny(buildContent, [/co\.amity\.android:amity-sdk:\+/, /co\.amity\.android:amity-sdk:latest/i, /version\s*=\s*["']\+["']/])) {
-        findings.push(finding("android.sdk.version.pinned", "warning", "The Android SDK dependency appears to use a floating version.", relativeFile(root, buildFiles[0]), "Pin the social.plus Android SDK to an explicit version or reviewed semver range so CI does not pick up unreviewed SDK APIs."));
+        findings.push(finding("android.sdk.version.pinned", "warning", "The Android SDK dependency uses an uncontrolled version (e.g. latest / + / a moving branch), not a pinned version or reviewed semver range.", relativeFile(root, buildFiles[0]), "Pin the social.plus Android SDK to an explicit version or reviewed semver range so CI does not pick up unreviewed SDK APIs."));
     }
     if (setupFiles.length === 0) {
         findings.push(finding("android.setup.present", "warning", "No obvious AmityCoreClient.setup call was found in Kotlin/Java files.", undefined, "Call SDK setup once during application startup before any social.plus API usage."));
@@ -317,8 +317,8 @@ async function validateFlutter(root) {
     const dartContent = await readMany(dartFiles);
     const setupFiles = filesMatching(dartContent, [/AmityCoreClient\s*\.\s*setup/]);
     const loginFiles = filesMatching(dartContent, [/AmityCoreClient\s*\.\s*login/]);
-    const pushRegistrationFiles = filesMatching(dartContent, [/registerPushNotification/, /enablePushNotification/, /PushNotification/]);
-    const pushUnregisterFiles = filesMatching(dartContent, [/unregisterPushNotification/, /disablePushNotification/]);
+    const pushRegistrationFiles = filesMatching(dartContent, [/registerPushNotification/, /registerDeviceNotification/, /enablePushNotification/, /PushNotification/]);
+    const pushUnregisterFiles = filesMatching(dartContent, [/unregisterPushNotification/, /unregisterDeviceNotification/, /disablePushNotification/]);
     const liveDataFiles = filesMatching(dartContent, [/LiveCollection/, /LiveObject/, /\.listen\s*\(/, /\.observe\s*\(/, /queryPosts\s*\(/, /getPost\s*\(/]);
     if (!pubspec) {
         findings.push(finding("flutter.pubspec.present", "warning", "No pubspec.yaml file was found.", "pubspec.yaml", "Point repoPath at the Flutter project root."));
@@ -327,7 +327,7 @@ async function validateFlutter(root) {
         findings.push(finding("flutter.dependency.sdk", "warning", "No obvious social.plus/Amity dependency was found in pubspec.yaml.", "pubspec.yaml", "Add the Flutter SDK dependency from the Flutter quick-start docs."));
     }
     else if (/\bamity_sdk\s*:\s*(?:any|\*|latest)\b/i.test(pubspec)) {
-        findings.push(finding("flutter.sdk.version.pinned", "warning", "The Flutter SDK dependency appears to use a floating version.", "pubspec.yaml", "Pin amity_sdk to an explicit version or reviewed semver range so CI does not pick up unreviewed SDK APIs."));
+        findings.push(finding("flutter.sdk.version.pinned", "warning", "The Flutter SDK dependency uses an uncontrolled version (e.g. any / a moving git ref), not a pinned version or reviewed semver range.", "pubspec.yaml", "Pin amity_sdk to an explicit version or reviewed semver range so CI does not pick up unreviewed SDK APIs."));
     }
     if (setupFiles.length === 0) {
         findings.push(finding("flutter.setup.present", "warning", "No obvious AmityCoreClient.setup call was found in lib/*.dart.", undefined, "Call AmityCoreClient.setup before any social.plus API usage."));
@@ -424,7 +424,7 @@ async function validateTypeScript(root, platform) {
         findings.push(finding("typescript.dependency.sdk", "warning", "No obvious social.plus/Amity package was found in package.json.", "package.json", "Add the TypeScript SDK dependency from the web quick-start docs."));
     }
     else if (isFloatingPackageDependency(packageJson, "@amityco/ts-sdk")) {
-        findings.push(finding(`${platform}.sdk.version.pinned`, "warning", "The TypeScript SDK dependency appears to use a floating version.", "package.json", "Pin @amityco/ts-sdk to an explicit version or reviewed semver range so CI does not pick up unreviewed SDK APIs."));
+        findings.push(finding(`${platform}.sdk.version.pinned`, "warning", "The TypeScript SDK dependency uses an uncontrolled version (latest / * / x), not a pinned version or reviewed semver range (^/~ is accepted).", "package.json", "Pin @amityco/ts-sdk to an explicit version or reviewed semver range so CI does not pick up unreviewed SDK APIs."));
     }
     if (setupFiles.length === 0) {
         findings.push(finding("typescript.client.create", "warning", "No obvious TypeScript client initialization pattern was found.", undefined, "Create the social.plus client before login and before API usage."));
@@ -715,6 +715,9 @@ function validateFeedUiStates(root, platform, sourceContent) {
         if (isNonUiSourceFile(file)) {
             continue;
         }
+        if (platform === "android" && /\bclass\s+\w+\s*:\s*Application\s*\(/.test(content)) {
+            continue;
+        }
         const observes = observationPatterns.some((pattern) => pattern.test(content));
         if (!observes) {
             continue;
@@ -741,7 +744,7 @@ const UI_STATE_PATTERNS_BY_PLATFORM = {
     typescript: [/\bisLoading\b/i, /\bloading\b/, /\berror\b/, /\bempty\b/i, /\.length\s*===?\s*0/, /\busestate\b/i],
     "react-native": [/\bisLoading\b/i, /\bloading\b/, /\berror\b/, /\bempty\b/i, /\.length\s*===?\s*0/, /ActivityIndicator/],
     flutter: [/\bisLoading\b/i, /\bloading\b/, /\berror\b/, /\bisEmpty\b/, /CircularProgressIndicator/, /AsyncSnapshot/, /ConnectionState/],
-    android: [/\bisLoading\b/i, /\bloading\b/, /\berror\b/, /\bempty\b/i, /CircularProgressIndicator/, /LoadingState/, /\.collectAsState\b/],
+    android: [/\bisLoading\b/i, /\bloading\b/, /\berror\b/, /\bempty\b/i, /CircularProgressIndicator/, /LoadingState/, /FeedUiState\.(?:Loading|Empty|Error)\b/, /\.collectAsState\b/],
     ios: [/\bisLoading\b/i, /\bloading\b/, /\berror\b/, /\bempty\b/i, /ProgressView/, /LoadingState/, /AsyncImage/],
 };
 const FEED_LIST_OBSERVATION_PATTERNS_BY_PLATFORM = {
@@ -937,13 +940,18 @@ function validateComments(root, platform, sourceContent) {
             break;
         }
     }
-    const hasReactiveCommentObserver = [...sourceContent.values()].some((c) => {
+    const isObserverContent = (c) => {
         const stripped = c.replace(/\bawait\b[^\n;]*?(?:get|query)Comments\s*\(/g, "");
         return /(?:get|query)Comments\s*\(/.test(stripped)
             || /CommentLiveCollection|AmityCommentCollection|commentCollection/.test(c);
-    });
+    };
+    const observerFiles = [...sourceContent.entries()].filter(([, c]) => isObserverContent(c)).map(([f]) => f);
+    const hasReactiveCommentObserver = observerFiles.length > 0;
     const cleanupMarkers = COMMENT_OBSERVER_CLEANUP_MARKERS_BY_PLATFORM[platform] ?? COMMENT_OBSERVER_CLEANUP_MARKERS_BY_PLATFORM.typescript;
-    if (commentFiles.length > 0 && hasReactiveCommentObserver && !containsAny(sourceContent, cleanupMarkers)) {
+    const ANDROID_OBSERVER_SELF_CLEAN = /(?:(?:get|query)Comments\s*\(|CommentLiveCollection|AmityCommentCollection|commentCollection)[^;{}]{0,300}?(?:\.stateIn\s*\([^;{}]*\bviewModelScope\b|\.asLiveData\s*\(|\.collectAsStateWithLifecycle\s*\(|\brepeatOnLifecycle\b|\bDisposableEffect\b)/;
+    const observerSelfCleans = platform === "android" &&
+        observerFiles.some((file) => ANDROID_OBSERVER_SELF_CLEAN.test(commentStripped(file, platform, sourceContent.get(file) ?? "")));
+    if (commentFiles.length > 0 && hasReactiveCommentObserver && !observerSelfCleans && !containsAny(sourceContent, cleanupMarkers)) {
         findings.push(finding(`${platform}.comments.observer-cleanup`, "warning", "Comment observer/subscription was found but no obvious cleanup was detected.", relativeFile(root, commentFiles[0]), "Dispose or unsubscribe comment observers when the lifecycle owner is destroyed."));
     }
     const strippedCommentFiles = new Map();
@@ -1029,6 +1037,16 @@ const CHAT_PRESENCE_PATTERNS = [
     /\bchatClient\b/i,
     /\bmessage\s*live\s*collection\b/i,
 ];
+const CHAT_SEND_CALL_PATTERNS = [
+    /\bsendMessage\s*\(/,
+    /\bcreateMessage\b/,
+    /\bcreateTextMessage\b/,
+    /\bcreateImageMessage\b/,
+    /\bcreateFileMessage\b/,
+    /\bcreateVideoMessage\b/,
+    /\bcreateAudioMessage\b/,
+    /\bcreateCustomMessage\b/,
+];
 const CHAT_OBSERVER_CLEANUP_MARKERS_BY_PLATFORM = {
     typescript: [/\bunsubscribe\b/, /\bdispose\b/, /\bremoveListener\b/, /\buseEffect\b.*\breturn\b/s],
     "react-native": [/\bunsubscribe\b/, /\bdispose\b/, /\bremoveListener\b/, /\buseEffect\b.*\breturn\b/s],
@@ -1068,6 +1086,7 @@ function validateChat(root, platform, sourceContent) {
     const chatFileContent = new Map();
     for (const f of chatFiles)
         chatFileContent.set(f, sourceContent.get(f) ?? "");
+    const hasSendCall = containsAny(chatFileContent, CHAT_SEND_CALL_PATTERNS);
     const hasErrorHandling = containsAny(chatFileContent, [
         /\bcatch\b/,
         /\b\.catch\b/,
@@ -1077,7 +1096,7 @@ function validateChat(root, platform, sourceContent) {
         /\berror\s*:/,
         /\btry\b/,
     ]);
-    if (!hasErrorHandling) {
+    if (hasSendCall && !hasErrorHandling) {
         findings.push(finding(`${platform}.chat.send-error-handling`, "warning", "Message send calls found without error handling.", relativeFile(root, chatFiles[0]), "Wrap sendMessage in try/catch or handle the error callback to show send failure state."));
     }
     if (!containsAny(chatFileContent, MODERATION_MARKERS)) {
@@ -1434,7 +1453,9 @@ function validatePostsStatusFilter(root, platform, sourceContent) {
     ];
     const FILTER_MARKERS = [
         /\bfeedTypes?\s*[:(]/,
+        /\breviewStatus\s*[:(]/,
         /\bincludeDeleted\s*\(\s*false\s*\)/,
+        /\bdeletedOption\s*:\s*\.notDeleted\b/,
         /\bisDeleted\s*:\s*false\b/,
         /\bisFlagged\s*:\s*false\b/,
         /\bstatuses\s*[:(]/,
@@ -1445,6 +1466,8 @@ function validatePostsStatusFilter(root, platform, sourceContent) {
         /\/\/\s*vise:\s*moderation review feed/i
     ];
     for (const [file, content] of sourceContent) {
+        if (path.basename(file).endsWith('.d.ts'))
+            continue;
         const rel = relativeFile(root, file);
         const hasPostQuery = POST_QUERY_PATTERNS.some((p) => p.test(content));
         if (hasPostQuery) {
@@ -2296,8 +2319,11 @@ async function validateIos(root) {
     else if (!containsAny(manifestContent, [/Amity/i, /AmitySDK/i])) {
         findings.push(finding("ios.dependency.sdk", "warning", "No obvious social.plus/Amity dependency was found in Podfile or Package.swift.", relativeFile(root, manifestFiles[0]), "Add the iOS SDK dependency from the iOS quick-start docs."));
     }
+    else if (containsAny(manifestContent, [/Amity-Social-Cloud-SDK-iOS-IPA/i])) {
+        findings.push(finding("ios.dependency.swiftpm-repo", "warning", "The iOS SwiftPM dependency points at the obsolete Amity-Social-Cloud-SDK-iOS-IPA package repository.", relativeFile(root, manifestFiles[0]), "Use https://github.com/AmityCo/Amity-Social-Cloud-SDK-iOS-SwiftPM.git with product AmitySDK so SwiftPM can resolve the social.plus iOS SDK."));
+    }
     else if (containsAny(manifestContent, [/\.package\s*\([^)]*\bbranch\s*:/s, /pod\s+['"][^'"]*Amity[^'"]*['"]\s*$/m])) {
-        findings.push(finding("ios.sdk.version.pinned", "warning", "The iOS SDK dependency appears to use a floating branch or unspecified CocoaPods version.", relativeFile(root, manifestFiles[0]), "Pin the social.plus iOS SDK to an explicit version or reviewed semver range so CI does not pick up unreviewed SDK APIs."));
+        findings.push(finding("ios.sdk.version.pinned", "warning", "The iOS SDK dependency uses an uncontrolled version (a moving branch or unspecified CocoaPods version), not a pinned version or reviewed semver range.", relativeFile(root, manifestFiles[0]), "Pin the social.plus iOS SDK to an explicit version or reviewed semver range so CI does not pick up unreviewed SDK APIs."));
     }
     if (setupFiles.length === 0) {
         findings.push(finding("ios.setup.present", "warning", "No obvious AmityClient initialization was found in Swift files.", undefined, "Initialize AmityClient before login and before social.plus API usage."));
@@ -2944,7 +2970,7 @@ function validateNotificationsPreferencesConfigured(root, platform, sourceConten
     let hasPreferences = false;
     let firstPushRegistrationFile = '';
     for (const [filename, text] of sourceContent) {
-        if (/\b(registerPushNotification|enablePushNotification)\b/.test(text)) {
+        if (/\b(registerPushNotification|registerDeviceNotification|enablePushNotification)\b/.test(text)) {
             hasPushRegistration = true;
             if (!firstPushRegistrationFile) {
                 firstPushRegistrationFile = (typeof filename === 'string' && root) ? (filename.startsWith(root) ? filename.slice(root.length).replace(/^\//, '') : filename) : filename;

package/dist/tools/sdkFacts.js CHANGED Viewed

@@ -174,9 +174,16 @@ export async function getSdkFacts(options) {
         notes: [
             "Symbol facts are existence-only: Vise confirms public symbols in the normalized SDK surface, but semantic correctness and idiomatic usage still require rules, docs, and sensors.",
             modelFacts.facts
-                ? `Field-level model facts are extraction-grounded (${modelFacts.facts.fieldsGrounding}) by ${modelFacts.facts.extraction.extractor}; names-only grounding means the source proves field names but no types.`
+                ? `Field-level model facts are extraction-grounded (${modelFacts.facts.fieldsGrounding}) by ${modelFacts.facts.extraction.extractor}.${modelFacts.facts.fieldsGrounding === "names-only"
+                    ? " names-only grounding means the source proves field names but no types."
+                    : ""}`
                 : "No field-level model facts for this platform snapshot: model claims stay symbol-only (absence over fabrication).",
             "Remote SP_SDK_SURFACE_URL resolution is recorded in the manifest for a future online snapshot source; this MVP uses local override/env/bundled directories only.",
+            ...(platform !== "typescript"
+                ? [
+                    `Capability anchors are authored TypeScript-first at this MVP, so capabilities is empty for ${platform}. This means capability mapping is not yet available on ${platform} — it does NOT mean the SDK lacks the feature. The symbol and model facts above are extracted from the ${platform} surface and remain authoritative.`,
+                ]
+                : []),
         ],
     };
     if (options.includeSymbols) {

package/dist/tools/sensors.js CHANGED Viewed

@@ -112,7 +112,7 @@ async function runSensor(cwd, sensor, timeoutMs) {
                 durationMs: Date.now() - startedAt,
                 stdout: truncate(stdout),
                 stderr: truncate(stderr),
-                reason: `Timed out after ${timeoutMs}ms.`,
+                reason: sensor.timeoutReason ?? `Timed out after ${timeoutMs}ms.`,
             });
         }, timeoutMs);
         child.stdout?.on("data", (chunk) => {