@amityco/social-plus-vise 1.1.1 → 1.2.0

package/dist/tools/harness.js

@@ -160,10 +160,38 @@ export async function detectCommandSensors(repoPath, platforms) {
         });
     }
     if (platforms.includes("ios")) {
+        sensors.push(...(await swiftPackageSensors(root)));
         sensors.push(...(await iosBuildSensors(root)));
     }
     return sensors;
 }
+async function swiftPackageSensors(root) {
+    if (!(await exists(path.join(root, "Package.swift")))) {
+        return [];
+    }
+    if (!(await commandOnPath("swift"))) {
+        return [
+            {
+                name: "iOS SwiftPM manifest",
+                command: ["swift"],
+                timing: "after-change",
+                purpose: "Parse the SwiftPM manifest after iOS SDK setup changes.",
+                source: "Package.swift",
+                skip: "Package.swift was detected, but swift is not on PATH in this environment. Install Xcode or Swift toolchain support to enable the SwiftPM manifest sensor; static iOS rule checks run regardless.",
+            },
+        ];
+    }
+    return [
+        {
+            name: "iOS SwiftPM manifest",
+            command: ["swift", "package", "describe", "--type", "json"],
+            timing: "after-change",
+            purpose: "Parse the SwiftPM manifest after iOS SDK setup changes without compiling or requiring simulator/signing assets.",
+            source: "Package.swift",
+            timeoutReason: "SwiftPM manifest parsing (`swift package describe`) did not finish before the sensor timeout. This is reported as a timeout (NOT a clean pass): a stall can be a slow toolchain OR an unresolvable/circular dependency. Static iOS rule checks still run; rerun with a longer `--timeout-ms` if the toolchain is just slow.",
+        },
+    ];
+}
 const XCODEBUILD_ENVIRONMENT_SKIPS = [
     {
         pattern: "requires Xcode|command line tools instance",
@@ -330,8 +358,8 @@ function assessHarnessability(platforms, commandSensors, designSignalCount) {
     if (designSignalCount > 0) {
         affordances.push(`Detected ${designSignalCount} design/theme signal(s) for UI integration grounding.`);
     }
-    if (platforms.includes("ios")) {
-        gaps.push("iOS: static compliance rules are fully operational. No build/compile sensor is wired yet (xcodebuild environment requirements make it fragile); run-sensors will return no-sensors for iOS projects.");
+    if (platforms.includes("ios") && commandSensors.length === 0) {
+        gaps.push("iOS: static compliance rules are fully operational, but no SwiftPM or Xcode command sensor was detected for this project root.");
     }
     if (platforms.length === 0) {
         return { level: "weak", affordances, gaps };

package/dist/tools/integration.js

@@ -10,6 +10,8 @@ import { detectCommandSensors } from "./harness.js";
 import { inspectProject } from "./project.js";
 import { creativeSurfaceHints, readCreativeSelection } from "./creative.js";
 import { buildUxHarness, uxHarnessPlanContext } from "./uxHarness.js";
+import { recommendSolutionPath } from "../solutionPath.js";
+import { recommendUIKitCustomization } from "../uikitCustomization.js";
 export const planIntegrationTool = {
     name: "plan_integration",
     description: "Create a grounded, evidence-backed implementation packet before an AI coding agent edits a customer project.",
@@ -72,7 +74,7 @@ async function buildIntegrationPlan(repoPath, request, surfacePath, answers = {}
     const uxHarnessOutcome = BROAD_SOCIAL_REGEX.test(request) && !hasAnswer(answers, "feature_surface") ? undefined : outcome;
     const uxHarnessContext = uxHarness ? uxHarnessPlanContext(uxHarness, uxHarnessOutcome) : undefined;
     const platform = preferredPlatform(inspection.platforms);
-    const supportLevel = supportFor(outcome, platform);
+    const baseSupportLevel = supportFor(outcome, platform);
     const sensors = await detectCommandSensors(root, inspection.platforms);
     const ctx = planContextFor({
         request,
@@ -84,6 +86,9 @@ async function buildIntegrationPlan(repoPath, request, surfacePath, answers = {}
     });
     const definition = getOutcomeDefinition(outcome);
     const capabilityAvailability = await platformCapabilityAvailability(outcome, platform);
+    const solutionPath = recommendSolutionPath(request, answers);
+    const uikitCustomization = recommendUIKitCustomization({ request, answers, platform, solutionPath });
+    const supportLevel = supportLevelForPlan(outcome, platform, baseSupportLevel, uikitCustomization);
     const designContract = await readDesignContract(repoRoot);
     const designReview = designReviewGuidance(repoRoot, designContract, answers);
     const acceptedDesignContract = designReview.status === "accepted" ? designContract : null;
@@ -108,6 +113,8 @@ async function buildIntegrationPlan(repoPath, request, surfacePath, answers = {}
     const packageJsonText = await readFile(path.join(root, "package.json"), "utf8").catch(() => undefined);
     const sdkVersion = await sdkVersionGuidance(platform, packageJsonText);
     const decisionsRequired = [
+        ...solutionPathDecisions(solutionPath, answers),
+        ...uikitCustomizationDecisions(uikitCustomization, answers),
         ...(creativeContext
             ? [
                 `[selected creative variant] Carry "${creativeContext.selectedVariant.title}" into the implementation plan. If any selected experience object is intentionally deferred, state that scope decision explicitly.`,
@@ -125,8 +132,10 @@ async function buildIntegrationPlan(repoPath, request, surfacePath, answers = {}
     return {
         outcome,
         platform,
+        solutionPath,
+        uikitCustomization,
         supportLevel,
-        intent: intentFor(request, definition.interpretation),
+        intent: intentFor(request, definition.interpretation, uikitCustomization),
         creativeContext,
         uxHarness: uxHarnessContext,
         socialWorkplan,
@@ -136,24 +145,28 @@ async function buildIntegrationPlan(repoPath, request, surfacePath, answers = {}
         implementationSteps: [
             ...creativeImplementationSteps(creativeSelection),
             ...uxHarnessImplementationSteps(uxHarnessContext),
+            ...solutionPathImplementationSteps(solutionPath),
+            ...uikitCustomizationImplementationSteps(uikitCustomization),
             ...definition.implementationSteps(ctx),
         ],
         validation: ["validate_setup", "run_sensors", ...definition.validation(platform)],
-        nextStep: "After implementing every step above, run `vise check .` and fix findings until green. You are not done until the check passes or each finding is explicitly attested.",
+        nextStep: nextStepForPlan(outcome, uikitCustomization, solutionPath),
         requiredInputs: composeRequiredInputs(ctx, definition.requiredInputs(ctx)),
         targetFiles: await targetFilesFor(root, outcome, platform, inspection.designSignals),
         implementationRules: [
             ...composeImplementationRules(ctx, definition.implementationRules(ctx)),
             ...creativeImplementationRules(creativeSelection),
             ...uxHarnessImplementationRules(uxHarnessContext),
+            ...solutionPathImplementationRules(solutionPath),
+            ...uikitCustomizationImplementationRules(uikitCustomization),
         ],
         intake,
-        docs: definition.docs(platform).filter((doc) => doc.path !== "unknown"),
+        docs: docsForPlan(definition.docs(platform), uikitCustomization),
         surface: inspection.selectedSurface ? { path: inspection.selectedSurface.path, platforms: inspection.selectedSurface.platforms } : undefined,
         availableSurfaces: inspection.surfaces,
         applicableRules: await applicableCompliancePlanRuleSummaries(outcome, inspection.platforms),
         sensors: sensors.map((sensor) => ({ name: sensor.name, command: sensor.command, source: sensor.source })),
-        stopConditions: composeStopConditions(ctx, definition.stopConditions(ctx), inspection.surfaces, surfacePath, Boolean(socialWorkplan)),
+        stopConditions: composeStopConditions(ctx, definition.stopConditions(ctx), inspection.surfaces, surfacePath, Boolean(socialWorkplan), uikitCustomization),
         evidencePolicy: "Every implementation step must cite at least one detected file, docs page, validator rule, or required user input. If evidence is missing, stop and ask the user instead of inventing details.",
         designContract: acceptedDesignContract ? designContractGuidance(acceptedDesignContract) : undefined,
         completenessChecklist: completenessChecklistFor(outcome),
@@ -188,6 +201,137 @@ function optionalCapabilitiesFor(outcome, answers, request, availability) {
         selected: selectedOptionalCapabilityIds(outcome, answers, request, availableIds),
     };
 }
+function solutionPathDecisions(solutionPath, answers) {
+    if (hasAnswer(answers, solutionPath.answerId)) {
+        return [];
+    }
+    if (!solutionPath.decision.requiredBeforeHandRolledUi) {
+        return [];
+    }
+    return [
+        `[solution path] ${solutionPath.summary} Answer with --answer ${solutionPath.answerId}=uikit, =sdk, or =hybrid before hand-rolling standard social UI.`,
+    ];
+}
+function solutionPathImplementationSteps(solutionPath) {
+    if (!solutionPath.decision.requiredBeforeHandRolledUi) {
+        return [];
+    }
+    return [
+        {
+            step: solutionPath.recommendation === "uikit"
+                ? "Confirm the social.plus UIKit path before building standard social UI from SDK primitives; use UIKit install/auth/customization docs as the primary implementation source. The SDK feed/chat/profile steps that follow apply ONLY to the direct-SDK (or hybrid SDK-side) route — do not hand-roll the standard surface from them when the customer is using UIKit."
+                : "Resolve whether this is a UIKit, SDK, or hybrid build before starting UI implementation; the SDK implementation steps that follow apply to the SDK/hybrid route, not to a UIKit build. Do not let mixed speed/customization signals collapse into a hand-rolled SDK UI by default.",
+            evidence: ["solutionPath", ...solutionPath.evidence],
+        },
+    ];
+}
+function solutionPathImplementationRules(solutionPath) {
+    if (solutionPath.recommendation === "sdk" && !solutionPath.decision.requiredBeforeHandRolledUi) {
+        return [];
+    }
+    return [
+        solutionPath.advisoryOnly,
+        ...solutionPath.implementationGuidance,
+    ];
+}
+function uikitCustomizationDecisions(uikitCustomization, answers) {
+    if (!uikitCustomization) {
+        return [];
+    }
+    if (hasAnswer(answers, uikitCustomization.answerId)) {
+        return [];
+    }
+    if (uikitCustomization.decision.requiredBeforeCustomization) {
+        return [
+            `[UIKit customization] ${uikitCustomization.summary} Answer with --answer ${uikitCustomization.answerId}=dynamic-ui, =component-styling, =localization, =behavior-overrides, =fork-and-extend, =sdk-custom-ui, or =hybrid before editing UIKit UI/customization code.`,
+        ];
+    }
+    return [
+        `[UIKit customization] ${uikitCustomization.summary} State this chosen route in the implementation summary, or re-plan with --answer ${uikitCustomization.answerId}=<route> if the customer chooses a different level.`,
+    ];
+}
+function uikitCustomizationImplementationSteps(uikitCustomization) {
+    if (!uikitCustomization) {
+        return [];
+    }
+    return [
+        {
+            step: `Apply the UIKit customization ladder before writing custom UI: start with ${uikitCustomization.recommendedLevel}, then escalate only if the customer goal cannot be expressed there.`,
+            evidence: ["uikitCustomization", ...uikitCustomization.evidence],
+        },
+    ];
+}
+function uikitCustomizationImplementationRules(uikitCustomization) {
+    if (!uikitCustomization) {
+        return [];
+    }
+    return [
+        uikitCustomization.advisoryOnly,
+        ...uikitCustomization.implementationGuidance,
+        ...uikitCustomization.platformGuidance,
+    ];
+}
+function docsForPlan(outcomeDocs, uikitCustomization) {
+    const docs = outcomeDocs.filter((doc) => doc.path !== "unknown");
+    if (!uikitCustomization) {
+        return docs;
+    }
+    const customizationLabel = labelForUIKitCustomizationLevel(uikitCustomization.recommendedLevel);
+    for (const docPath of uikitCustomization.docs) {
+        docs.push({
+            path: docPath,
+            reason: `UIKit ${customizationLabel} customization guidance for this solution path.`,
+        });
+    }
+    return dedupeDocsByPath(docs);
+}
+function supportLevelForPlan(outcome, platform, baseSupportLevel, uikitCustomization) {
+    if (platform !== "unknown" && outcome === "unknown" && uikitCustomization) {
+        return "guided";
+    }
+    return baseSupportLevel;
+}
+function nextStepForPlan(outcome, uikitCustomization, solutionPath) {
+    if (outcome === "unknown" && uikitCustomization) {
+        return "Treat this as UIKit customization guidance first: resolve the UIKit route and concrete app/platform target, then implement customer-owned config, localization, behavior, fork, or SDK custom UI changes with local build evidence. Do not claim `vise check` deterministically validates hidden UIKit internals.";
+    }
+    if (solutionPath.decision.requiredBeforeHandRolledUi) {
+        return "First resolve the solution-path decision (UIKit vs SDK vs hybrid). The SDK implementation steps above apply only if you build this surface directly with the SDK (or the SDK side of a hybrid); if the customer uses social.plus UIKit for the standard surface, follow the UIKit guidance instead of hand-rolling those steps. Once the route is settled, implement the applicable steps, then run `vise check .` and fix findings until green — you are not done until the check passes or each finding is explicitly attested.";
+    }
+    return "After implementing every step above, run `vise check .` and fix findings until green. You are not done until the check passes or each finding is explicitly attested.";
+}
+function dedupeDocsByPath(docs) {
+    const seen = new Set();
+    const out = [];
+    for (const doc of docs) {
+        if (seen.has(doc.path)) {
+            continue;
+        }
+        seen.add(doc.path);
+        out.push(doc);
+    }
+    return out;
+}
+function labelForUIKitCustomizationLevel(level) {
+    switch (level) {
+        case "dynamic-ui":
+            return "Dynamic UI";
+        case "component-styling":
+            return "Component Styling";
+        case "localization":
+            return "Localization";
+        case "behavior-overrides":
+            return "Behavior Overrides";
+        case "fork-and-extend":
+            return "Fork and Extend";
+        case "sdk-custom-ui":
+            return "SDK Custom UI";
+        case "hybrid":
+            return "Hybrid";
+        case "needs-decision":
+            return "decision";
+    }
+}
 function creativeContextForPlan(selection) {
     const selectedVariant = selection.selectedVariant;
     const surfaceHints = creativeSurfaceHints(selection);
@@ -484,13 +628,17 @@ function designContractGuidance(contract) {
         advisoryOnly: "This contract is advisory generation guidance — it adds no deterministic enforcement and never fails `vise check`.",
     };
 }
-function intentFor(request, interpretation) {
+function intentFor(request, interpretation, uikitCustomization) {
     const broadSocialRequest = BROAD_SOCIAL_REGEX.test(request);
     const designRequest = DESIGN_REGEX.test(request);
+    const uikitOnlyCustomization = interpretation === "Implement unknown." && uikitCustomization;
+    const uikitInterpretation = uikitOnlyCustomization
+        ? `${uikitCustomization.summary} No deterministic SDK outcome was selected, so keep this as guided UIKit customization until the customer names the concrete social surface or app-owned customization target.`
+        : interpretation;
     return {
         rawRequest: request,
-        interpretation,
-        ambiguity: broadSocialRequest || designRequest ? "high" : "medium",
+        interpretation: uikitInterpretation,
+        ambiguity: broadSocialRequest || designRequest || uikitCustomization?.status === "needs-decision" || uikitOnlyCustomization ? "high" : "medium",
     };
 }
 function intakeFor(ctx, outcomeQuestions, outcome, brief, availability, designReview) {
@@ -611,15 +759,18 @@ function composeImplementationRules(ctx, outcomeRules) {
     }
     return rules;
 }
-function composeStopConditions(ctx, outcomeStops, surfaces, surfacePath, hasSocialWorkplan = false) {
+function composeStopConditions(ctx, outcomeStops, surfaces, surfacePath, hasSocialWorkplan = false, uikitCustomization) {
     const stops = [
         "A required secret is missing and no safe ignored local env file or non-secret template path is clear.",
         "The target file is ambiguous or missing and no safe conventional location is detected.",
         "Docs lookup does not return the canonical page named in this plan.",
     ];
-    if (ctx.platform === "unknown" || ctx.outcome === "unknown") {
+    if (ctx.platform === "unknown" || (ctx.outcome === "unknown" && !uikitCustomization)) {
         stops.push("The request or platform is unsupported; do not implement until clarified.");
     }
+    if (ctx.outcome === "unknown" && uikitCustomization) {
+        stops.push("No deterministic SDK outcome was selected; do not run `vise init` or claim compliance coverage until a concrete social surface or app-owned UIKit customization target is confirmed.");
+    }
     if (ctx.platforms.length > 1 && !surfacePath) {
         stops.push(`Multiple platform signals detected (${ctx.platforms.join(", ")}); confirm which app surface should be modified.`);
     }

package/dist/tools/project.js

@@ -204,7 +204,7 @@ async function validateAndroid(root) {
     const loginFiles = filesMatching(sourceContent, [/AmityCoreClient\s*\.\s*login/, /AmityClient\s*\.\s*login/]);
     const pushRegistrationFiles = filesMatching(sourceContent, [/registerPushNotification/, /enablePushNotification/, /PushNotification/]);
     const pushUnregisterFiles = filesMatching(sourceContent, [/unregisterPushNotification/, /disablePushNotification/, /unregister.*DeviceToken/i]);
-    const liveDataFiles = filesMatching(sourceContent, [/LiveCollection/, /LiveObject/, /\.observe\s*\(/, /\.subscribe\s*\(/, /queryPosts\s*\(/, /getPost\s*\(/]);
+    const liveDataFiles = filesMatching(sourceContent, [/LiveCollection/, /LiveObject/, /\.observe\s*\(/, /AmitySocialClient\s*\.\s*newPostRepository/, /\bgetPosts\s*\(/, /queryPosts\s*\(/, /getPost\s*\(/]);
     if (!manifest) {
         findings.push(finding("android.manifest.present", "warning", "No AndroidManifest.xml found at the default app path.", manifestPath, "Confirm the Android app module path, then validate permissions and Application wiring."));
     }
@@ -317,8 +317,8 @@ async function validateFlutter(root) {
     const dartContent = await readMany(dartFiles);
     const setupFiles = filesMatching(dartContent, [/AmityCoreClient\s*\.\s*setup/]);
     const loginFiles = filesMatching(dartContent, [/AmityCoreClient\s*\.\s*login/]);
-    const pushRegistrationFiles = filesMatching(dartContent, [/registerPushNotification/, /enablePushNotification/, /PushNotification/]);
-    const pushUnregisterFiles = filesMatching(dartContent, [/unregisterPushNotification/, /disablePushNotification/]);
+    const pushRegistrationFiles = filesMatching(dartContent, [/registerPushNotification/, /registerDeviceNotification/, /enablePushNotification/, /PushNotification/]);
+    const pushUnregisterFiles = filesMatching(dartContent, [/unregisterPushNotification/, /unregisterDeviceNotification/, /disablePushNotification/]);
     const liveDataFiles = filesMatching(dartContent, [/LiveCollection/, /LiveObject/, /\.listen\s*\(/, /\.observe\s*\(/, /queryPosts\s*\(/, /getPost\s*\(/]);
     if (!pubspec) {
         findings.push(finding("flutter.pubspec.present", "warning", "No pubspec.yaml file was found.", "pubspec.yaml", "Point repoPath at the Flutter project root."));
@@ -715,6 +715,9 @@ function validateFeedUiStates(root, platform, sourceContent) {
         if (isNonUiSourceFile(file)) {
             continue;
         }
+        if (platform === "android" && /\bclass\s+\w+\s*:\s*Application\s*\(/.test(content)) {
+            continue;
+        }
         const observes = observationPatterns.some((pattern) => pattern.test(content));
         if (!observes) {
             continue;
@@ -741,7 +744,7 @@ const UI_STATE_PATTERNS_BY_PLATFORM = {
     typescript: [/\bisLoading\b/i, /\bloading\b/, /\berror\b/, /\bempty\b/i, /\.length\s*===?\s*0/, /\busestate\b/i],
     "react-native": [/\bisLoading\b/i, /\bloading\b/, /\berror\b/, /\bempty\b/i, /\.length\s*===?\s*0/, /ActivityIndicator/],
     flutter: [/\bisLoading\b/i, /\bloading\b/, /\berror\b/, /\bisEmpty\b/, /CircularProgressIndicator/, /AsyncSnapshot/, /ConnectionState/],
-    android: [/\bisLoading\b/i, /\bloading\b/, /\berror\b/, /\bempty\b/i, /CircularProgressIndicator/, /LoadingState/, /\.collectAsState\b/],
+    android: [/\bisLoading\b/i, /\bloading\b/, /\berror\b/, /\bempty\b/i, /CircularProgressIndicator/, /LoadingState/, /FeedUiState\.(?:Loading|Empty|Error)\b/, /\.collectAsState\b/],
     ios: [/\bisLoading\b/i, /\bloading\b/, /\berror\b/, /\bempty\b/i, /ProgressView/, /LoadingState/, /AsyncImage/],
 };
 const FEED_LIST_OBSERVATION_PATTERNS_BY_PLATFORM = {
@@ -1434,7 +1437,9 @@ function validatePostsStatusFilter(root, platform, sourceContent) {
     ];
     const FILTER_MARKERS = [
         /\bfeedTypes?\s*[:(]/,
+        /\breviewStatus\s*[:(]/,
         /\bincludeDeleted\s*\(\s*false\s*\)/,
+        /\bdeletedOption\s*:\s*\.notDeleted\b/,
         /\bisDeleted\s*:\s*false\b/,
         /\bisFlagged\s*:\s*false\b/,
         /\bstatuses\s*[:(]/,
@@ -2296,6 +2301,9 @@ async function validateIos(root) {
     else if (!containsAny(manifestContent, [/Amity/i, /AmitySDK/i])) {
         findings.push(finding("ios.dependency.sdk", "warning", "No obvious social.plus/Amity dependency was found in Podfile or Package.swift.", relativeFile(root, manifestFiles[0]), "Add the iOS SDK dependency from the iOS quick-start docs."));
     }
+    else if (containsAny(manifestContent, [/Amity-Social-Cloud-SDK-iOS-IPA/i])) {
+        findings.push(finding("ios.dependency.swiftpm-repo", "warning", "The iOS SwiftPM dependency points at the obsolete Amity-Social-Cloud-SDK-iOS-IPA package repository.", relativeFile(root, manifestFiles[0]), "Use https://github.com/AmityCo/Amity-Social-Cloud-SDK-iOS-SwiftPM.git with product AmitySDK so SwiftPM can resolve the social.plus iOS SDK."));
+    }
     else if (containsAny(manifestContent, [/\.package\s*\([^)]*\bbranch\s*:/s, /pod\s+['"][^'"]*Amity[^'"]*['"]\s*$/m])) {
         findings.push(finding("ios.sdk.version.pinned", "warning", "The iOS SDK dependency appears to use a floating branch or unspecified CocoaPods version.", relativeFile(root, manifestFiles[0]), "Pin the social.plus iOS SDK to an explicit version or reviewed semver range so CI does not pick up unreviewed SDK APIs."));
     }
@@ -2944,7 +2952,7 @@ function validateNotificationsPreferencesConfigured(root, platform, sourceConten
     let hasPreferences = false;
     let firstPushRegistrationFile = '';
     for (const [filename, text] of sourceContent) {
-        if (/\b(registerPushNotification|enablePushNotification)\b/.test(text)) {
+        if (/\b(registerPushNotification|registerDeviceNotification|enablePushNotification)\b/.test(text)) {
             hasPushRegistration = true;
             if (!firstPushRegistrationFile) {
                 firstPushRegistrationFile = (typeof filename === 'string' && root) ? (filename.startsWith(root) ? filename.slice(root.length).replace(/^\//, '') : filename) : filename;

package/dist/tools/sensors.js

@@ -112,7 +112,7 @@ async function runSensor(cwd, sensor, timeoutMs) {
                 durationMs: Date.now() - startedAt,
                 stdout: truncate(stdout),
                 stderr: truncate(stderr),
-                reason: `Timed out after ${timeoutMs}ms.`,
+                reason: sensor.timeoutReason ?? `Timed out after ${timeoutMs}ms.`,
             });
         }, timeoutMs);
         child.stdout?.on("data", (chunk) => {