@amenophis1er/foreman 0.1.10 → 0.1.12

package/README.md

@@ -230,7 +230,7 @@ result.
 ```sh
 npm ci && npm run setup      # dependencies, then the dashboard build
 npm start                    # serves http://localhost:4177
-npm test                     # 364 tests, node:test
+npm test                     # 365 tests, node:test
 npm run typecheck            # server and dashboard
 npm run dev                  # API + Vite together
 scripts/dev-restart.sh       # restarts the server only when nothing would be lost

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@amenophis1er/foreman",
-  "version": "0.1.10",
+  "version": "0.1.12",
   "description": "Autonomous mission runner on the Claude Agent SDK: a director plans, delegates to workers, verifies, and reports — from one dashboard, your phone, or the CLI.",
   "keywords": [
     "claude",

package/src/provider.test.ts

@@ -364,3 +364,19 @@ test('a role provider carries the role’s model, so every alias resolves on its
   assert.equal(withRoleModel(bare, '').model, undefined);
   assert.equal(withRoleModel(bare, undefined), bare, 'no change returns the same object');
 });
+
+
+test('agents do not inherit the server\'s own environment: PORT and FOREMAN_* are dropped', async () => {
+  const saved = { PORT: process.env.PORT, FOREMAN_HOME: process.env.FOREMAN_HOME, FOREMAN_BIND: process.env.FOREMAN_BIND };
+  process.env.PORT = '4177'; process.env.FOREMAN_HOME = '/tmp/fh'; process.env.FOREMAN_BIND = 'all';
+  try {
+    const p = await resolveProvider({ kind: 'claude-code' }, '/tmp/foreman-test-root');
+    const env = providerEnv(p).env ?? {};
+    assert.equal(env.PORT, undefined, 'a dev server a worker starts must not bind the dashboard port');
+    assert.equal(env.FOREMAN_HOME, undefined);
+    assert.equal(env.FOREMAN_BIND, undefined);
+    assert.ok(env.PATH, 'the rest of the environment survives');
+  } finally {
+    for (const [k, v] of Object.entries(saved)) { if (v === undefined) delete process.env[k]; else process.env[k] = v; }
+  }
+});

package/src/provider.ts

@@ -427,8 +427,22 @@ export interface AgentEnv {
  * programming error rather than a user error, and the failure mode it guards
  * against is a leaked token, so it fails loudly instead of degrading.
  */
+/**
+ * The server's own knobs, which an agent must not inherit. `PORT` is the one
+ * that bit: the service sets it for the dashboard, an agent's dev server
+ * honoured it, bound Foreman's port on a wildcard address and shadowed the
+ * dashboard on localhost until it exited. The rest are Foreman's operating
+ * settings — none of them means anything to a project's own tooling, and a
+ * worker reading `FOREMAN_HOME` would only find somewhere it should not be.
+ */
+const SERVER_ONLY_VARS = [
+  'PORT', 'FOREMAN_SERVICES_PORT', 'FOREMAN_HOME', 'FOREMAN_BIND', 'FOREMAN_BROWSER',
+  'FOREMAN_AUTH_MODE', 'FOREMAN_CLAUDE_CONFIG_DIR', 'FOREMAN_CLAUDE_EXECUTABLE', 'FOREMAN_NO_TELEGRAM', 'FOREMAN_LOG',
+];
+
 export function providerEnv(p: ResolvedProvider, gatewayUrl?: string): AgentEnv {
   const env: Record<string, string | undefined> = { ...process.env };
+  for (const v of SERVER_ONLY_VARS) delete env[v];
   env.CLAUDE_CONFIG_DIR = p.configDir;
 
   if (p.wire === 'anthropic-native') {