@amazon-devices/expo-file-system 3.0.0 → 3.0.2

package/kepler/ExponentFileSystem.cpp

@@ -338,11 +338,49 @@ Promise ExponentFileSystem::copyAsync(NativeJSObject options) {
             return;
         }
 
+        // Run the copy on a background thread to avoid blocking the JS thread.
+        // std::filesystem::copy is synchronous and blocks for the whole copy
+        // duration, which trips the KeplerScript thread watchdog on large files.
         try {
-            std::filesystem::copy(from, to, std::filesystem::copy_options::recursive);
-            promise->resolve(NULL);
-        } catch (std::filesystem::filesystem_error& e) {
-            TMERROR(std::string("[ExponentFileSystem] file transfer exception, reason: ") + e.what());
+            std::thread([promise, from, to]() {
+                // If we cannot tell whether the destination already exists,
+                // assume it does. Then a failed copy never deletes data we did
+                // not create.
+                std::error_code existsError;
+                bool destExisted = true;
+                bool destExistsResult = std::filesystem::exists(to, existsError);
+                if (!existsError) {
+                    destExisted = destExistsResult;
+                }
+                // A failed copy can leave a truncated destination, but only if
+                // this copy created it. Remove just that.
+                auto removePartialDestination = [&to, destExisted]() {
+                    if (destExisted) {
+                        return;
+                    }
+                    std::error_code cleanupError;
+                    std::filesystem::remove_all(to, cleanupError);
+                    if (cleanupError) {
+                        TMERROR(std::string("[ExponentFileSystem] could not remove partial destination, reason: ") + cleanupError.message());
+                    }
+                };
+                try {
+                    std::filesystem::copy(from, to, std::filesystem::copy_options::recursive);
+                    promise->resolve(NULL);
+                } catch (std::exception& e) {
+                    TMERROR(std::string("[ExponentFileSystem] file transfer exception, reason: ") + e.what());
+                    removePartialDestination();
+                    promise->reject(e.what());
+                } catch (...) {
+                    TMERROR(std::string("[ExponentFileSystem] file transfer failed with an unknown exception"));
+                    removePartialDestination();
+                    promise->reject("unknown file transfer error");
+                }
+            }).detach();
+        } catch (std::exception& e) {
+            // The thread could not start. Reject here so the promise always
+            // settles and the JS caller does not wait forever.
+            TMERROR(std::string("[ExponentFileSystem] could not start copy thread, reason: ") + e.what());
             promise->reject(e.what());
         }
     });

package/package.json

@@ -1 +1 @@
-{"name": "@amazon-devices/expo-file-system", "version": "3.0.0+15.8.0", "description": "Provides access to the local file system on the device.", "main": "build/index.js", "types": "build/index.d.ts", "sideEffects": false, "scripts": {"build": "expo-module build", "clean": "expo-module clean", "lint": "expo-module lint", "test": "expo-module test", "prepublishOnly": "expo-module prepublishOnly", "expo-module": "expo-module"}, "kepler": {"temporary-alias-for-package": {"name": "expo-file-system", "version": "15.8.0"}}, "keywords": ["react-native", "expo", "file-system", "file"], "repository": {"type": "git", "url": "https://github.com/expo/expo.git", "directory": "packages/expo-file-system"}, "bugs": {"url": "https://github.com/expo/expo/issues"}, "author": "650 Industries, Inc.", "license": "See license in LICENSE", "homepage": "https://docs.expo.dev/versions/latest/sdk/filesystem/", "dependencies": {"uuid": "^3.4.0", "@amazon-devices/keplerscript-turbomodule-api": "^1.0.0"}, "devDependencies": {"expo-module-scripts": "^3.0.0", "jest-expo": "~50.0.0-alpha.0", "@types/glob": "^7.2.0", "@types/minimatch": "^3.0.5"}, "peerDependencies": {"expo": "^50.0.0-alpha.1"}}
+{"name": "@amazon-devices/expo-file-system", "version": "3.0.2+15.8.0", "description": "Provides access to the local file system on the device.", "main": "build/index.js", "types": "build/index.d.ts", "sideEffects": false, "scripts": {"build": "expo-module build", "clean": "expo-module clean", "lint": "expo-module lint", "test": "expo-module test", "prepublishOnly": "expo-module prepublishOnly", "expo-module": "expo-module"}, "kepler": {"temporary-alias-for-package": {"name": "expo-file-system", "version": "15.8.0"}}, "keywords": ["react-native", "expo", "file-system", "file"], "repository": {"type": "git", "url": "https://github.com/expo/expo.git", "directory": "packages/expo-file-system"}, "bugs": {"url": "https://github.com/expo/expo/issues"}, "author": "650 Industries, Inc.", "license": "See license in LICENSE", "homepage": "https://docs.expo.dev/versions/latest/sdk/filesystem/", "dependencies": {"uuid": "^3.4.0", "@amazon-devices/keplerscript-turbomodule-api": "^1.0.0"}, "devDependencies": {"expo-module-scripts": "^3.0.0", "jest-expo": "~50.0.0-alpha.0", "@types/glob": "^7.2.0", "@types/minimatch": "^3.0.5"}, "peerDependencies": {"expo": "^50.0.0-alpha.1"}}