@amaster.ai/employee-runtime-connector 0.1.1-beta.1 → 0.1.1-beta.2

package/dist/amaster-runtime-daemon.mjs

@@ -1828,19 +1828,161 @@ function escapeLiteralJsonStringControlCharacters(value) {
   }
   return changed ? output : value;
 }
+function escapeLikelyLiteralJsonStringQuotes(value) {
+  let output = "";
+  let inString = false;
+  let escaped = false;
+  let changed = false;
+  let stringRole = null;
+  let previousSignificantCharacter = null;
+  function followingObjectProperty(offset) {
+    let cursor = offset;
+    while (cursor < value.length && /\s/u.test(value[cursor])) cursor += 1;
+    if (value[cursor] !== '"') return { valid: false, simpleIdentifier: false };
+    cursor += 1;
+    let propertyName = "";
+    let propertyEscaped = false;
+    for (; cursor < value.length; cursor += 1) {
+      const propertyCharacter = value[cursor];
+      if (propertyEscaped) {
+        propertyName += propertyCharacter;
+        propertyEscaped = false;
+        continue;
+      }
+      if (propertyCharacter === "\\") {
+        propertyEscaped = true;
+        continue;
+      }
+      if (propertyCharacter !== '"') {
+        propertyName += propertyCharacter;
+        continue;
+      }
+      cursor += 1;
+      while (cursor < value.length && /\s/u.test(value[cursor])) cursor += 1;
+      return {
+        valid: value[cursor] === ":",
+        simpleIdentifier: /^[A-Za-z_][A-Za-z0-9_-]*$/u.test(propertyName)
+      };
+    }
+    return { valid: false, simpleIdentifier: false };
+  }
+  for (let index = 0; index < value.length; index += 1) {
+    const character = value[index];
+    if (!inString) {
+      output += character;
+      if (character === '"') {
+        inString = true;
+        stringRole = previousSignificantCharacter === ":" ? "object_value" : null;
+      } else if (!/\s/u.test(character)) {
+        previousSignificantCharacter = character;
+      }
+      continue;
+    }
+    if (escaped) {
+      output += character;
+      escaped = false;
+      continue;
+    }
+    if (character === "\\") {
+      output += character;
+      escaped = true;
+      continue;
+    }
+    if (character !== '"') {
+      output += character;
+      continue;
+    }
+    let nextIndex = index + 1;
+    while (nextIndex < value.length && /\s/u.test(value[nextIndex])) nextIndex += 1;
+    const nextCharacter = value[nextIndex];
+    if (nextCharacter === "," && stringRole === "object_value") {
+      const following = followingObjectProperty(nextIndex + 1);
+      if (!following.valid && !following.simpleIdentifier) {
+        output += '\\"';
+        changed = true;
+        continue;
+      }
+    }
+    if (nextCharacter === void 0 || [":", ",", "}", "]"].includes(nextCharacter)) {
+      output += character;
+      inString = false;
+      stringRole = null;
+      previousSignificantCharacter = character;
+    } else {
+      output += '\\"';
+      changed = true;
+    }
+  }
+  return changed ? output : value;
+}
+function insertSingleMissingObjectPropertyComma(value) {
+  let parseError;
+  try {
+    JSON.parse(value);
+    return value;
+  } catch (error) {
+    parseError = error;
+  }
+  const positionMatch = String(parseError?.message ?? "").match(
+    /Expected ',' or '\}' after property value in JSON at position (\d+)/u
+  );
+  if (!positionMatch) return value;
+  const position = Number(positionMatch[1]);
+  if (!Number.isSafeInteger(position) || position < 1 || position >= value.length) return value;
+  let propertyStart = position;
+  while (propertyStart < value.length && /\s/u.test(value[propertyStart])) propertyStart += 1;
+  if (value[propertyStart] !== '"') return value;
+  let cursor = propertyStart + 1;
+  let escaped = false;
+  let propertyName = "";
+  for (; cursor < value.length; cursor += 1) {
+    const character = value[cursor];
+    if (escaped) {
+      propertyName += character;
+      escaped = false;
+      continue;
+    }
+    if (character === "\\") {
+      escaped = true;
+      continue;
+    }
+    if (character === '"') break;
+    propertyName += character;
+  }
+  if (cursor >= value.length || !/^[A-Za-z_][A-Za-z0-9_-]*$/u.test(propertyName)) return value;
+  cursor += 1;
+  while (cursor < value.length && /\s/u.test(value[cursor])) cursor += 1;
+  if (value[cursor] !== ":") return value;
+  let previous = position - 1;
+  while (previous >= 0 && /\s/u.test(value[previous])) previous -= 1;
+  if (previous < 0 || !['"', "}", "]", "e", "l"].includes(value[previous]) && !/[0-9]/u.test(value[previous])) {
+    return value;
+  }
+  const candidate = `${value.slice(0, position)},${value.slice(position)}`;
+  try {
+    return isJsonObject(JSON.parse(candidate)) ? candidate : value;
+  } catch {
+    return value;
+  }
+}
 function normalizePiMcpProxyArgs(value) {
   if (typeof value !== "string") return { value, repaired: false };
   try {
     JSON.parse(value);
     return { value, repaired: false };
   } catch {
-    const repairedValue = escapeLiteralJsonStringControlCharacters(value);
-    if (repairedValue === value) return { value, repaired: false };
-    try {
-      return isJsonObject(JSON.parse(repairedValue)) ? { value: repairedValue, repaired: true } : { value, repaired: false };
-    } catch {
-      return { value, repaired: false };
+    const repairedControlCharacters = escapeLiteralJsonStringControlCharacters(value);
+    const repairedValue = escapeLikelyLiteralJsonStringQuotes(repairedControlCharacters);
+    if (repairedValue !== value) {
+      try {
+        if (isJsonObject(JSON.parse(repairedValue))) {
+          return { value: repairedValue, repaired: true };
+        }
+      } catch {
+      }
     }
+    const commaRepairedValue = insertSingleMissingObjectPropertyComma(repairedControlCharacters);
+    return commaRepairedValue !== value ? { value: commaRepairedValue, repaired: true } : { value, repaired: false };
   }
 }
 function registerManagedPiMcpArgsNormalizer(pi) {
@@ -1854,6 +1996,8 @@ function managedPiMcpArgsNormalizerExtensionSource() {
   return [
     isJsonObject.toString(),
     escapeLiteralJsonStringControlCharacters.toString(),
+    escapeLikelyLiteralJsonStringQuotes.toString(),
+    insertSingleMissingObjectPropertyComma.toString(),
     normalizePiMcpProxyArgs.toString(),
     `export default ${registerManagedPiMcpArgsNormalizer.toString()};`,
     ""
@@ -2270,7 +2414,7 @@ function createManagedPiMcpProfileApi(options = {}) {
     } catch {
       throw new Error(`pi_managed_mcp_attestation_failed: configured ${MANAGED_WEB_ACCESS_PACKAGE} package metadata is invalid`);
     }
-    if (packageMetadata.name !== MANAGED_WEB_ACCESS_PACKAGE) {
+    if (!packageMetadata || packageMetadata.name !== MANAGED_WEB_ACCESS_PACKAGE) {
       throw new Error(`pi_managed_mcp_attestation_failed: configured ${MANAGED_WEB_ACCESS_PACKAGE} package identity mismatch`);
     }
     return {
@@ -2479,6 +2623,9 @@ ${result3.stderr ?? ""}`, "Pi", MINIMUM_PI_VERSION);
       const restoredNativeSession = restoreManagedPiSessionRollout(input, sessionsRoot, runDir, executorHome, authority);
       const configPath = join4(piCodingAgentDir, "mcp.json");
       const config = {
+        settings: {
+          toolPrefix: "none"
+        },
         mcpServers: {
           [SUPPORTED_SERVER_NAME2]: {
             type: "http",
@@ -3369,13 +3516,16 @@ function wikiAccessRuleLine(input) {
   return "";
 }
 function fixedRules(input, includeIssueLine) {
+  const issue = asRecord(asRecord(input.context).paperclipIssue);
+  const businessOutcome = asRecord(asRecord(issue.taskRequirements).businessOutcome);
+  const serverOwnedBusinessOutcomeReview = businessOutcome.mode === "required";
   return [
     "## AMaster Runtime Connector Task",
     "MirrorX task.",
     "Use only the declared workspace; make concrete progress and report concisely.",
     "Before changing the task status to done, audit every explicit requirement in the task against the final evidence. A successful tool or document write proves delivery, not acceptance: inspect the delivered content for required sections, diagrams, tables, and factual constraints.",
     "Do not leave stale in-progress wording such as \u201Ccurrent run\u201D in a terminal deliverable; rewrite it to the final observed state. Do not list finalization itself as remaining or next work in a terminal deliverable.",
-    "If any requirement is missing or cannot be verified, do not mark done. To request review, use create_interaction with kind request_confirmation and payload.resolutionMode review; never call update_parent with status in_review. Otherwise keep the issue todo or blocked with the exact gap and next owner.",
+    serverOwnedBusinessOutcomeReview ? "If any requirement is missing or cannot be verified, do not mark done or request final completion or Business Outcome review. Keep the issue in_progress or blocked with the exact gap and next owner. An intermediate review remains available only for an exact document revision that must be approved before execution can continue: use create_interaction with kind request_confirmation, payload.resolutionMode review, and purposeCode review_document_revision; never use that interaction as final completion or Outcome acceptance." : "If any requirement is missing or cannot be verified, do not mark done. To request review, use create_interaction with kind request_confirmation and payload.resolutionMode review; never call update_parent with status in_review. Otherwise keep the issue todo or blocked with the exact gap and next owner.",
     DEADLINE_POSTURE_GUARD,
     "Do not install operating-system or user-global packages, and do not use host package managers such as brew, apt, yum, or global pip/npm installs. Use tools already available or workspace-local dependencies or virtual environments. If a required renderer or evaluator is unavailable, keep the source artifact, record the exact verification gap, and do not mutate the host.",
     `- command id: ${input.commandId}`,
@@ -3409,7 +3559,7 @@ function interactionResolutionText(context) {
   if (Object.keys(resolution).length === 0) return "";
   const target = asRecord(resolution.target);
   const exactDocumentRevisionDirective = readString(resolution.status) === "changes_requested" && readString(target.type) === "issue_document" && readString(target.issueId) && readString(target.documentId) && readString(target.key) && readString(target.revisionId) ? [
-    "The review target is an exact issue_document revision. Revise that same document with upsert_document_revision: copy target.issueId, target.documentId, and target.key, and use target.revisionId as baseRevisionId.",
+    "The review target is an exact issue_document revision. Revise that same document with upsert_document_revision: copy target.issueId, target.documentId, and target.key, use target.revisionId as baseRevisionId, and put the complete revised markdown in the required action.body; metadata-only revisions are invalid.",
     "Do not copy the reviewed document into the current issue and do not restart its revision lineage at 1."
   ].join(" ") : "";
   return [
@@ -3520,7 +3670,10 @@ function runtimeAuthorizationText(context, mode, { suppressOrdinaryCompletionCon
     optionId: readString(optionId)
   })).filter((entry) => entry.optionId && !allowed.has(entry.authorizationClass));
   const issue = asRecord(context.paperclipIssue);
-  const completion = asRecord(asRecord(issue.taskRequirements).completion);
+  const requirements = asRecord(issue.taskRequirements);
+  const completion = asRecord(requirements.completion);
+  const delivery = asRecord(requirements.delivery);
+  const businessOutcome = asRecord(requirements.businessOutcome);
   const completionRole = readString(completion.role);
   const completionDeliverable = readString(completion.deliverable);
   const manifestRefreshOnly = isManifestRefreshOnly(context);
@@ -3530,13 +3683,26 @@ function runtimeAuthorizationText(context, mode, { suppressOrdinaryCompletionCon
     firstDocumentCheckpoint,
     "If work remains in an ordinary productive run, call update_parent with status: in_progress and a concrete next action so bounded continuation recovery can preserve a live path. Status: todo does not queue a normal continuation from an ordinary productive run. Only a server-issued successful-run handoff recovery may use status: todo, and only according to its exact Recovery Instruction. Otherwise use a supported terminal or waiting disposition."
   ].filter(Boolean).join(" ") : "";
+  const businessOutcomeOwnershipContract = businessOutcome.mode === "required" ? [
+    "Business Outcome review is owned by the Server terminal reconciler.",
+    "Do not create a generic review-mode request_confirmation to ask the Board to accept final completion or the Outcome, and do not mark the issue done yourself. This does not prohibit an explicit intermediate review of an exact document revision before execution continues."
+  ].join(" ") : "";
+  const businessOutcomeTerminalContract = !suppressOrdinaryCompletionContract && businessOutcome.mode === "required" ? [
+    delivery.mode === "required" ? "When every acceptance criterion is satisfied and the exact current Delivery Manifest is ready, record the final execution disposition with update_parent status in_progress and a concise evidence summary, then end the run successfully without creating a final review interaction." : "When every acceptance criterion is satisfied, record the final execution disposition with update_parent status in_progress and a concise evidence summary, then end the run successfully without creating a final review interaction.",
+    delivery.mode === "required" ? "Only after the run and command succeed does the Server bind the exact current Delivery Manifest and terminal Outcome evidence, create the formal Board review before generic continuation handoff is evaluated, and move the issue to in_review. Board acceptance then finalizes the issue as done atomically." : "Only after the run and command succeed does the Server bind the terminal Outcome evidence, create the formal Board review before generic continuation handoff is evaluated, and move the issue to in_review. Board acceptance then finalizes the issue as done atomically."
+  ].join(" ") : "";
   const authorizationContract = missing.length > 0 ? [
     `Current allowed action classes: ${[...allowed].join(", ") || "task_governance"}.`,
     "If the task requires a missing runtime action class, create a request_checkbox_confirmation interaction using the exact option id below and wait for its accepted continuation:",
     ...missing.map((entry) => `- ${entry.authorizationClass}: ${entry.optionId}`),
     "Never use request_confirmation to authorize a runtime action class."
   ].join("\n") : "";
-  return [completionContract, authorizationContract].filter(Boolean).join("\n");
+  return [
+    completionContract,
+    businessOutcomeOwnershipContract,
+    businessOutcomeTerminalContract,
+    authorizationContract
+  ].filter(Boolean).join("\n");
 }
 function runtimeDecompositionRequirementText(context) {
   const issue = asRecord(context.paperclipIssue);
@@ -3661,12 +3827,13 @@ function piMcpProxyExamplesText(input) {
     args: JSON.stringify(args)
   });
   return [
-    "The Pi native tool is the outer `mcp` proxy. Emit these as actual tool calls; `args` is the stringified inner canonical object:",
+    "The Pi native tool is the outer `mcp` proxy. Emit these as actual tool calls; `args` is the stringified inner canonical object. Pi validates this string schema before extension hooks, so never send object-valued `args`:",
     "Keep review payload strings short. Reference the exact document key and revision in `target`; do not duplicate the reviewed document body in `prompt` or `detailsMarkdown`.",
+    "payload.supersedesInteractionId is invalid. provenance.supersedesInteractionId is only for replacing a currently pending governed interaction; after changes_requested or rejected resolution, do not send a supersession id.",
     "update_parent.comment creates a separate persistent issue comment. Omit it when add_comment already recorded the message.",
     `- describe: ${proxy("runtime_action.describe", { schemaVersion: "runtime-action-v1", actionType: "update_parent" })}`,
     `- submit: ${proxy("runtime_action.submit", { schemaVersion: "runtime-action-v1", idempotencyKey: "task-123-progress", action: { type: "update_parent", status: "in_progress" } })}`,
-    `- submit review interaction: ${proxy("runtime_action.submit", { schemaVersion: "runtime-action-v1", idempotencyKey: "task-123-review", action: { type: "create_interaction", kind: "request_confirmation", continuationPolicy: "wake_assignee_on_accept", provenance: { purposeCode: "review_document_revision", requirementRefs: ["acceptance:document_review"], attentionOwner: { kind: "board", id: "board" }, epochKey: "document_revision:22222222-2222-4222-8222-222222222222" }, payload: { version: 1, resolutionMode: "review", prompt: "Review `plan` revision 1.", target: { type: "issue_document", issueId: "11111111-1111-4111-8111-111111111111", documentId: "33333333-3333-4333-8333-333333333333", key: "plan", revisionId: "22222222-2222-4222-8222-222222222222", revisionNumber: 1 } } } })}`,
+    `- submit intermediate document review interaction: ${proxy("runtime_action.submit", { schemaVersion: "runtime-action-v1", idempotencyKey: "task-123-review", action: { type: "create_interaction", kind: "request_confirmation", continuationPolicy: "wake_assignee_on_accept", provenance: { purposeCode: "review_document_revision", requirementRefs: ["acceptance:document_review"], attentionOwner: { kind: "board", id: "board" }, epochKey: "document_revision:22222222-2222-4222-8222-222222222222" }, payload: { version: 1, resolutionMode: "review", prompt: "Review `plan` revision 1.", target: { type: "issue_document", issueId: "11111111-1111-4111-8111-111111111111", documentId: "33333333-3333-4333-8333-333333333333", key: "plan", revisionId: "22222222-2222-4222-8222-222222222222", revisionNumber: 1 } } } })}`,
     `- plan: ${proxy("runtime_action.plan", { schemaVersion: "runtime-action-v1", idempotencyKey: "task-123-plan", actions: [{ type: "update_parent", status: "in_progress" }] })}`,
     `- commit the returned plan revision: ${proxy("runtime_action.commit", { schemaVersion: "runtime-action-v1", planId: "11111111-1111-4111-8111-111111111111", revision: "plan-revision-1" })}`,
     `- read document: ${proxy("amaster.read_issue_document", { issueId: "AM-123", key: "plan" })}`
@@ -4153,16 +4320,38 @@ function tcReadNumber(value, fallback = 0) {
   return typeof value === "number" && Number.isFinite(value) ? value : fallback;
 }
 var TC_PI_ARGUMENT_VALIDATION_NODE_BUDGET = 4e3;
-function tcContainsPiArgumentValidation(value, depth = 0, seen = /* @__PURE__ */ new WeakSet(), budget = { remaining: TC_PI_ARGUMENT_VALIDATION_NODE_BUDGET }) {
-  if (budget.remaining <= 0) return false;
+var TC_PI_ARGUMENT_VALIDATION_PATTERN = /\binvalid(?:[_ -]+)tool(?:[_ -]+)arguments?\b|\binvalid args json\b|\btool[- ]arguments? (?:failed )?validation\b/i;
+function tcFindPiArgumentValidationText(value, depth = 0, seen = /* @__PURE__ */ new WeakSet(), budget = { remaining: TC_PI_ARGUMENT_VALIDATION_NODE_BUDGET }) {
+  if (budget.remaining <= 0) return null;
   budget.remaining -= 1;
   if (typeof value === "string") {
-    return /\binvalid(?:[_ -]+)tool(?:[_ -]+)arguments?\b|\binvalid args json\b|\btool[- ]arguments? (?:failed )?validation\b/i.test(value.slice(0, 2e4));
+    const bounded = value.slice(0, 2e4);
+    return TC_PI_ARGUMENT_VALIDATION_PATTERN.test(bounded) ? bounded : null;
   }
-  if (!value || typeof value !== "object" || depth >= 6 || seen.has(value)) return false;
+  if (!value || typeof value !== "object" || depth >= 6 || seen.has(value)) return null;
   seen.add(value);
   const entries = Array.isArray(value) ? value.slice(0, 40).map((entry, index) => [String(index), entry]) : Object.entries(value).slice(0, 80);
-  return entries.some(([, entry]) => tcContainsPiArgumentValidation(entry, depth + 1, seen, budget));
+  for (const [, entry] of entries) {
+    const match = tcFindPiArgumentValidationText(entry, depth + 1, seen, budget);
+    if (match) return match;
+  }
+  return null;
+}
+function tcPiArgumentValidationDiagnostic(value) {
+  const text = tcFindPiArgumentValidationText(value);
+  if (!text) return null;
+  const normalized = text.toLowerCase();
+  const validationSource = /\binvalid args json\b/iu.test(text) ? "invalid_args_json" : /\binvalid(?:[_ -]+)tool(?:[_ -]+)arguments?\b/iu.test(text) ? "invalid_tool_arguments" : "tool_argument_validation";
+  const parseErrorKind = validationSource !== "invalid_args_json" ? null : normalized.includes("unexpected end") ? "unexpected_end" : normalized.includes("unexpected token") || normalized.includes("unexpected non-whitespace") ? "unexpected_token" : normalized.includes("unterminated string") ? "unterminated_string" : normalized.includes("bad control character") ? "bad_control_character" : normalized.includes("bad escaped character") || normalized.includes("invalid escape") ? "bad_escape" : /expected (?:','|'\}'|':'|property name|double-quoted property)/u.test(normalized) ? "missing_delimiter" : "other";
+  const rawPosition = validationSource === "invalid_args_json" ? text.match(/\bposition\s+(\d{1,9})\b/iu)?.[1] : null;
+  const parseErrorPosition = rawPosition ? Number(rawPosition) : null;
+  return {
+    validationSource,
+    validationPath: validationSource === "invalid_args_json" ? "$.args" : "$",
+    pathPrecision: validationSource === "invalid_args_json" ? "exact" : "root_only",
+    ...parseErrorKind ? { parseErrorKind } : {},
+    ...typeof parseErrorPosition === "number" && Number.isSafeInteger(parseErrorPosition) && parseErrorPosition >= 0 ? { parseErrorPosition } : {}
+  };
 }
 function tcTruncateText(value, maxChars = 16e3) {
   const text = String(value ?? "");
@@ -4535,7 +4724,7 @@ function summarizePiEvent(event) {
   if (type === "tool_execution_start" || type === "tool_execution_end") {
     const toolName = tcReadString(event.toolName) ?? "unknown";
     const completed = type === "tool_execution_end";
-    const argumentValidationFailed = completed && event.isError === true && tcContainsPiArgumentValidation(event.result);
+    const argumentValidationDiagnostic = completed && event.isError === true ? tcPiArgumentValidationDiagnostic(event.result) : null;
     return {
       stream: "system",
       level: completed && event.isError === true ? "error" : "info",
@@ -4546,7 +4735,7 @@ function summarizePiEvent(event) {
         toolName,
         toolCallId: tcReadString(event.toolCallId),
         status: completed ? event.isError === true ? "failed" : "completed" : "started",
-        ...argumentValidationFailed ? { errorCode: "invalid_tool_arguments" } : {}
+        ...argumentValidationDiagnostic ? { errorCode: "invalid_tool_arguments", ...argumentValidationDiagnostic } : {}
       }
     };
   }
@@ -8021,7 +8210,7 @@ function assertSourceAcquisitionRuntimeAuthority({
 }
 
 // src/amaster-runtime-daemon.mjs
-var CONNECTOR_VERSION = "0.1.1-beta.1";
+var CONNECTOR_VERSION = "0.1.1-beta.2";
 var CONNECTOR_CONTRACT_VERSION = "2026-06-04.v1";
 var SOURCE_ACQUISITION_CAPABILITY = "source_acquisition_v1";
 var SOURCE_ACQUISITION_PROFILE_VERSION = "source_acquisition_v1";

package/dist/amaster-runtime.mjs

@@ -5,7 +5,7 @@ import { dirname, join, resolve } from "node:path";
 import { homedir, hostname } from "node:os";
 import { fileURLToPath } from "node:url";
 
-const CONNECTOR_VERSION = "0.1.1-beta.1";
+const CONNECTOR_VERSION = "0.1.1-beta.2";
 
 const CAPABILITIES = [
   "remote_registration",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@amaster.ai/employee-runtime-connector",
-  "version": "0.1.1-beta.1",
+  "version": "0.1.1-beta.2",
   "description": "MirrorX runtime connector CLI and daemon",
   "license": "MIT",
   "type": "module",