@amaster.ai/employee-runtime-connector 0.1.0-beta.12 → 0.1.0-beta.13

package/dist/amaster-runtime-daemon.mjs

@@ -2335,7 +2335,7 @@ import { chmodSync, copyFileSync, existsSync, lstatSync, mkdirSync, readFileSync
 import { homedir, hostname } from "node:os";
 import { basename, delimiter, dirname, extname, isAbsolute, join, relative, resolve } from "node:path";
 import { spawn, spawnSync } from "node:child_process";
-const CONNECTOR_VERSION = "0.1.0-beta.12";
+const CONNECTOR_VERSION = "0.1.0-beta.13";
 const MAX_INFERRED_ARTIFACT_UPLOADS = 20;
 const MAX_CHECKPOINT_BYTES = 20 * 1024 * 1024;
 const CHECKPOINT_TTL_MS = 24 * 60 * 60 * 1000;
@@ -3562,7 +3562,7 @@ function runtimeActionsInstruction(options = {}) {
     "If direct AMaster API requests are unavailable from the executor sandbox, do not stop at blocked. Use the runtime action bridge for the unapplied mutations.",
     "Use runtime actions as a continuation patch, not as a full replay. If the wake reason or latest comments say a confirmation was accepted, rejected, or that no more child tasks/interactions should be created, do not recreate those earlier actions. Add the final result comment and update the parent task instead.",
     "On an accepted request_confirmation or request_checkbox_confirmation continuation, any new confirmation must include payload.target.type and a non-empty payload.target.key. Missing decision identity fields fail before mutation with accepted_confirmation_decision_target_required. The server reuses identical content for the same target identity and rejects changed prompt, options, or labels until the action uses the genuinely new target revision.",
-    "Every request_confirmation and request_checkbox_confirmation should bind the concrete decision to payload.target using {type:\"custom\", key, label, revisionId} or the applicable issue_document target. Keep target.key stable for the same decision purpose and change target.revisionId only when the target content changes. Replace example target values with task-specific values; when no business revision exists, use the current run id as revisionId instead of omitting target.",
+    "Every request_confirmation and request_checkbox_confirmation should bind the concrete decision to payload.target using {type:\"custom\", key, label, revisionId} or the applicable issue_document target. Keep target.key stable for the same decision purpose and change target.revisionId only when the target content changes. Replace example target values with task-specific values. For a custom target with no business revision, use the current run id as revisionId. For an existing issue_document target, use only the exact current revision from task context and never invent a revision id. When the same runtime action batch first upserts the target issue document, omit target.revisionId; the connector binds the created revision before posting the confirmation.",
     "If the wake reason is issue_children_completed, treat the completed child tasks as already resolved blockers. Do not recreate blocker child tasks, do not repeat the first-run blocker plan, and do not create another review path unless new human input is truly required. Summarize the completed child work and use update_parent status done when no human review is needed.",
     "Use update_parent status done when no human review is needed. Prefer creating a pending review path such as request_confirmation, request_checkbox_confirmation, ask_user_questions, or suggest_tasks before status in_review; if a bare in_review update is emitted, AMaster will create a fallback request_confirmation before PATCH.",
     "For create_child_task, do not create ownerless executable todo tasks. Set assigneeAgentId only when the target agent id came from the current AMaster task context or an agent_hire action in this same batch. Do not invent agent ids, role ids, or ids from another company. If you are unsure, omit assigneeAgentId and assigneeUserId; AMaster will assign the current executing agent for todo/in_progress children. Use backlog only when a task is intentionally unassigned.",
@@ -7555,7 +7555,7 @@ function assertRuntimeConfirmationTarget(target) {
     key.length <= 64 && /^[a-z0-9][a-z0-9_-]*$/.test(key),
     "confirmation issue_document target key must use lowercase letters, numbers, _ or -",
   );
-  assertRuntimeActionValid(revisionId && uuidPattern.test(revisionId), "confirmation issue_document target revisionId must be a UUID");
+  assertRuntimeActionValid(!revisionId || uuidPattern.test(revisionId), "confirmation issue_document target revisionId must be a UUID");
   for (const field of ["issueId", "documentId"]) {
     const value = readString(record[field]);
     assertRuntimeActionValid(!value || uuidPattern.test(value), `confirmation issue_document target ${field} must be a UUID`);
@@ -7930,6 +7930,33 @@ function preflightRuntimeActionBatch(actions, options = {}) {
     }
     documentActionIndexByKey.set(key, actionIndex);
   }
+  for (const action of orderedActions) {
+    const fields = runtimeActionBusinessFields(action);
+    if (readRuntimeActionType(fields) !== "create_interaction") continue;
+    const kind = inferCreateInteractionKind(fields);
+    if (!["request_confirmation", "request_checkbox_confirmation"].includes(kind ?? "")) continue;
+    const target = asRecord(asRecord(fields.payload).target);
+    if (readString(target.type) !== "issue_document") continue;
+    const key = readString(target.key);
+    if (!key) continue;
+    const actionIndex = actionIndexByObject.get(action);
+    const sameBatchDocumentActionIndex = documentActionIndexByKey.get(key);
+    const sameBatchDocumentUpsert = Number.isInteger(sameBatchDocumentActionIndex);
+    const revisionId = readString(target.revisionId);
+    if (sameBatchDocumentUpsert && !revisionId && sameBatchDocumentActionIndex < actionIndex) continue;
+    if (!sameBatchDocumentUpsert && revisionId) continue;
+    const err = runtimeActionValidationError(
+      sameBatchDocumentUpsert
+        ? revisionId
+          ? `same-batch issue document confirmation for ${key} must omit revisionId so the connector can bind the created revision`
+          : `same-batch issue document confirmation for ${key} requires an earlier upsert_document action so the connector can bind the created revision before applying the interaction`
+        : `issue document confirmation for ${key} requires revisionId when the document is not upserted in the same batch`,
+    );
+    err.runtimeActionType = "create_interaction";
+    err.runtimeActionKind = kind;
+    err.runtimeActionFieldPath = `actions[${actionIndex}].payload.target.revisionId`;
+    throw err;
+  }
   assertRuntimeActionsAllowedByContinuationScope(orderedActions, options.continuationScope);
   assertNoAmbiguousApprovalGatedSideEffects(orderedActions);
   const preflightContext = {
@@ -7983,11 +8010,9 @@ function preflightRuntimeActionBatch(actions, options = {}) {
 
 async function preflightRuntimeDocumentRevisions(runtimeAuth, issueId, actions) {
   const baseRevisionIdsByKey = new Map();
-  for (const [actionIndex, action] of actions.entries()) {
-    if (readRuntimeActionType(action) !== "upsert_document") continue;
-    const fields = runtimeActionBusinessFields(action);
-    const key = readBoundedActionString(fields, "key", 64);
-    if (!key) continue;
+  const existingDocumentsByKey = new Map();
+  const readExistingDocument = async (key) => {
+    if (existingDocumentsByKey.has(key)) return existingDocumentsByKey.get(key);
     let existingDocument = null;
     try {
       existingDocument = asRecord(await runtimeApiJson(
@@ -7998,6 +8023,15 @@ async function preflightRuntimeDocumentRevisions(runtimeAuth, issueId, actions)
     } catch (err) {
       if (err?.httpStatus !== 404) throw err;
     }
+    existingDocumentsByKey.set(key, existingDocument);
+    return existingDocument;
+  };
+  for (const [actionIndex, action] of actions.entries()) {
+    if (readRuntimeActionType(action) !== "upsert_document") continue;
+    const fields = runtimeActionBusinessFields(action);
+    const key = readBoundedActionString(fields, "key", 64);
+    if (!key) continue;
+    const existingDocument = await readExistingDocument(key);
 
     const explicitBaseRevisionId = readString(fields.baseRevisionId);
     const currentRevisionId = readString(existingDocument?.latestRevisionId);
@@ -8028,6 +8062,29 @@ async function preflightRuntimeDocumentRevisions(runtimeAuth, issueId, actions)
     }
     baseRevisionIdsByKey.set(key, currentRevisionId);
   }
+  for (const [actionIndex, action] of actions.entries()) {
+    const fields = runtimeActionBusinessFields(action);
+    if (readRuntimeActionType(fields) !== "create_interaction") continue;
+    const kind = inferCreateInteractionKind(fields);
+    if (!["request_confirmation", "request_checkbox_confirmation"].includes(kind ?? "")) continue;
+    const target = asRecord(asRecord(fields.payload).target);
+    if (readString(target.type) !== "issue_document") continue;
+    const key = readString(target.key);
+    if (!key || baseRevisionIdsByKey.has(key)) continue;
+    const existingDocument = await readExistingDocument(key);
+    const currentRevisionId = readString(existingDocument?.latestRevisionId);
+    const targetRevisionId = readString(target.revisionId);
+    if (currentRevisionId && currentRevisionId === targetRevisionId) continue;
+    const err = runtimeActionValidationError(
+      currentRevisionId
+        ? `issue document confirmation target ${key} is stale; current revision is ${currentRevisionId}`
+        : `issue document confirmation target ${key} does not exist`,
+    );
+    err.runtimeActionType = "create_interaction";
+    err.runtimeActionKind = kind;
+    err.runtimeActionFieldPath = `actions[${actionIndex}].payload.target.revisionId`;
+    throw err;
+  }
   return baseRevisionIdsByKey;
 }
 
@@ -8434,10 +8491,23 @@ async function applyRuntimeAction(config, command, runtimeAuth, issueId, action,
     if (!["request_confirmation", "request_checkbox_confirmation", "ask_user_questions", "suggest_tasks"].includes(kind)) {
       throw new Error(`create_interaction action does not support kind: ${kind}`);
     }
-    const payload = normalizeCreateInteractionPayload(fields, kind);
+    let payload = normalizeCreateInteractionPayload(fields, kind);
     if (Object.keys(payload).length === 0) {
       throw new Error("create_interaction action requires payload");
     }
+    const interactionTarget = asRecord(payload.target);
+    if (
+      ["request_confirmation", "request_checkbox_confirmation"].includes(kind) &&
+      readString(interactionTarget.type) === "issue_document" &&
+      !readString(interactionTarget.revisionId)
+    ) {
+      const key = readString(interactionTarget.key);
+      const boundTarget = key ? actionContext.issueDocumentTargetsByKey.get(key) : null;
+      if (!boundTarget) {
+        throw new Error(`issue document confirmation target ${String(key)} was not created earlier in the runtime action batch`);
+      }
+      payload = { ...payload, target: boundTarget };
+    }
     const defaultContinuationPolicy = "wake_assignee";
     const createBody = {
       kind,
@@ -8492,13 +8562,30 @@ async function applyRuntimeAction(config, command, runtimeAuth, issueId, action,
           ?? null,
       },
     ));
+    const latestRevisionId = readString(document.latestRevisionId);
+    const latestRevisionNumber = readNumber(document.latestRevisionNumber, null) ?? undefined;
+    const documentId = readString(document.id);
+    if (actionContext.issueDocumentConfirmationKeysNeedingBinding.has(key)) {
+      if (!documentId || !latestRevisionId || !latestRevisionNumber) {
+        throw new Error(`upsert_document ${key} response did not expose the created document revision`);
+      }
+      actionContext.issueDocumentTargetsByKey.set(key, {
+        type: "issue_document",
+        issueId,
+        documentId,
+        key,
+        revisionId: latestRevisionId,
+        revisionNumber: latestRevisionNumber,
+      });
+    }
     return {
       type,
       ...(originalType && originalType !== type ? { originalType } : {}),
       issueId,
       key,
-      documentId: readString(document.id),
-      revisionNumber: typeof document.latestRevisionNumber === "number" ? document.latestRevisionNumber : undefined,
+      documentId,
+      revisionId: latestRevisionId ?? undefined,
+      revisionNumber: latestRevisionNumber,
     };
   }
 
@@ -9694,6 +9781,16 @@ async function applyRuntimeActionBridge(config, command, parsed, execution, cwd)
   const results = [];
   const skipped = [];
   const actionLedgerEntries = [];
+  const issueDocumentConfirmationKeysNeedingBinding = new Set(actions.flatMap((action) => {
+    const fields = runtimeActionBusinessFields(action);
+    if (readRuntimeActionType(fields) !== "create_interaction") return [];
+    const kind = inferCreateInteractionKind(fields);
+    if (!["request_confirmation", "request_checkbox_confirmation"].includes(kind ?? "")) return [];
+    const target = asRecord(asRecord(fields.payload).target);
+    if (readString(target.type) !== "issue_document" || readString(target.revisionId)) return [];
+    const key = readString(target.key);
+    return key ? [key] : [];
+  }));
   const actionContext = {
     rootIssueId: issueId,
     cwd,
@@ -9706,6 +9803,8 @@ async function applyRuntimeActionBridge(config, command, parsed, execution, cwd)
     acceptedConfirmationContinuation,
     answeredQuestionContinuation,
     documentBaseRevisionIdsByKey,
+    issueDocumentConfirmationKeysNeedingBinding,
+    issueDocumentTargetsByKey: new Map(),
     finalCommentBodies: [],
   };
   for (const [actionIndex, action] of actions.entries()) {

package/dist/amaster-runtime.mjs

@@ -5,7 +5,7 @@ import { dirname, join, resolve } from "node:path";
 import { homedir, hostname } from "node:os";
 import { fileURLToPath } from "node:url";
 
-const CONNECTOR_VERSION = "0.1.0-beta.12";
+const CONNECTOR_VERSION = "0.1.0-beta.13";
 
 const CAPABILITIES = [
   "remote_registration",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@amaster.ai/employee-runtime-connector",
-  "version": "0.1.0-beta.12",
+  "version": "0.1.0-beta.13",
   "description": "AMaster Employee runtime connector CLI and daemon",
   "license": "MIT",
   "type": "module",