@amafil/react-native-pdf-toolkit 1.0.4 → 1.0.5

package/android/src/main/java/org/wonday/pdf/PdfView.java

@@ -99,6 +99,7 @@ public class PdfView extends PDFView implements OnPageChangeListener,OnLoadCompl
     private float autoScrollPixels = 15f;   // pixels per second
     private long autoScrollResumeDelay = 3000L;
     private long lastFrameTimeNanos = 0;
+    private float accumulatedScrollOffset = 0f; // float accumulator – avoids re-reading the rendering-quantised offset
 
     public PdfView(Context context, AttributeSet set){
         super(context, set);
@@ -578,6 +579,9 @@ public class PdfView extends PDFView implements OnPageChangeListener,OnLoadCompl
         this.autoScrollResumeDelay = resumeDelayMs;
         this.isAutoScrolling = true;
         this.lastFrameTimeNanos = 0;
+        // Capture current position into float accumulator so doFrame never reads back
+        // the rendering-quantised offset from getCurrentYOffset().
+        this.accumulatedScrollOffset = -getCurrentYOffset(); // getCurrentYOffset() is negative
 
         if (autoScrollFrameCallback == null) {
             autoScrollFrameCallback = new Choreographer.FrameCallback() {
@@ -597,9 +601,13 @@ public class PdfView extends PDFView implements OnPageChangeListener,OnLoadCompl
 
                     float elapsedSeconds = (frameTimeNanos - lastFrameTimeNanos) / 1_000_000_000f;
                     lastFrameTimeNanos = frameTimeNanos;
-                    float scrollAmount = autoScrollPixels * elapsedSeconds;
 
-                    float currentY = getCurrentYOffset();
+                    // Accumulate into our own float – do NOT read getCurrentYOffset() back.
+                    // barteksc may snap the rendered position to pixel boundaries; re-reading
+                    // that snapped value each frame loses the fractional part and makes low
+                    // speeds (< ~20 px/s) invisible.
+                    accumulatedScrollOffset += autoScrollPixels * elapsedSeconds;
+
                     float totalHeight = 0;
                     int pageCount = getPageCount();
                     for (int i = 0; i < pageCount; i++) {
@@ -614,18 +622,14 @@ public class PdfView extends PDFView implements OnPageChangeListener,OnLoadCompl
                         return;
                     }
 
-                    // currentY is negative in barteksc (0 = top, more negative = further down)
-                    float newY = currentY - scrollAmount;
-                    float minY = -maxScroll;
-
-                    if (newY <= minY) {
-                        moveTo(0, minY);
+                    if (accumulatedScrollOffset >= maxScroll) {
+                        moveTo(0, -maxScroll);
                         stopAutoScroll();
                         dispatchAutoScrollEndEvent();
                         return;
                     }
 
-                    moveTo(0, newY);
+                    moveTo(0, -accumulatedScrollOffset);
                     Choreographer.getInstance().postFrameCallback(this);
                 }
             };
@@ -637,6 +641,8 @@ public class PdfView extends PDFView implements OnPageChangeListener,OnLoadCompl
                 public void run() {
                     if (isAutoScrolling && !isUserTouching) {
                         lastFrameTimeNanos = 0;
+                        // Re-sync accumulator after user may have scrolled manually during pause.
+                        accumulatedScrollOffset = -getCurrentYOffset();
                         Choreographer.getInstance().postFrameCallback(autoScrollFrameCallback);
                     }
                 }

package/ios/RNPDFPdf/RNPDFPdfView.mm

@@ -85,6 +85,7 @@ const float MIN_SCALE = 1.0f;
     BOOL _isUserDragging;
     UIScrollView *_pdfScrollView;
     __weak id<UIScrollViewDelegate> _originalScrollDelegate;
+    CGFloat _autoScrollCurrentOffset; // float accumulator – avoids re-reading UIKit's quantized contentOffset
 }
 
 #ifdef RCT_NEW_ARCH_ENABLED
@@ -308,6 +309,7 @@ using namespace facebook::react;
     _isUserDragging = NO;
     _pdfScrollView = nil;
     _originalScrollDelegate = nil;
+    _autoScrollCurrentOffset = 0.0;
 
     [self addSubview:_pdfView];
 
@@ -972,7 +974,12 @@ using namespace facebook::react;
     _autoScrollResumeDelay = resumeDelay;
     _isAutoScrolling = YES;
 
-    [self findPdfScrollView];
+    UIScrollView *sv = [self findPdfScrollView];
+    // Capture the current scroll position into our float accumulator so that
+    // displayLinkTick never reads back UIKit's pixel-quantized contentOffset.
+    if (sv) {
+        _autoScrollCurrentOffset = sv.contentOffset.y;
+    }
     [self startDisplayLink];
 }
 
@@ -1004,7 +1011,12 @@ using namespace facebook::react;
 
     // Frame-rate-independent: use actual elapsed frame time (e.g. 1/60 or 1/120 on ProMotion)
     CGFloat frameDuration = (CGFloat)(link.targetTimestamp - link.timestamp);
-    CGFloat pixelsThisFrame = _autoScrollPixels * frameDuration;
+
+    // Accumulate into our own float – do NOT read contentOffset back from UIKit.
+    // UIKit / PDFKit quantises contentOffset to physical pixel boundaries (1/scale pts
+    // on Retina displays). If we re-read that quantised value every frame we lose the
+    // fractional part, making scrollSpeeds below ~20 px/s invisible on @3x devices.
+    _autoScrollCurrentOffset += _autoScrollPixels * frameDuration;
 
     CGFloat maxOffsetY = scrollView.contentSize.height - scrollView.bounds.size.height;
     if (maxOffsetY <= 0) {
@@ -1013,17 +1025,14 @@ using namespace facebook::react;
         return;
     }
 
-    CGPoint offset = scrollView.contentOffset;
-    CGFloat newY = offset.y + pixelsThisFrame;
-
-    if (newY >= maxOffsetY) {
-        [scrollView setContentOffset:CGPointMake(offset.x, maxOffsetY) animated:NO];
+    if (_autoScrollCurrentOffset >= maxOffsetY) {
+        [scrollView setContentOffset:CGPointMake(scrollView.contentOffset.x, maxOffsetY) animated:NO];
         [self stopAutoScroll];
         [self notifyOnChangeWithMessage:@"autoScrollEnd"];
         return;
     }
 
-    [scrollView setContentOffset:CGPointMake(offset.x, newY) animated:NO];
+    [scrollView setContentOffset:CGPointMake(scrollView.contentOffset.x, _autoScrollCurrentOffset) animated:NO];
 }
 
 - (void)scheduleAutoScrollResume
@@ -1039,6 +1048,11 @@ using namespace facebook::react;
 - (void)autoScrollResumeFromTimer:(NSTimer *)timer
 {
     if (_isAutoScrolling && !_isUserDragging) {
+        // Re-sync the float accumulator with the actual scroll position after
+        // the user may have scrolled manually during the pause.
+        if (_pdfScrollView) {
+            _autoScrollCurrentOffset = _pdfScrollView.contentOffset.y;
+        }
         [self startDisplayLink];
     }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@amafil/react-native-pdf-toolkit",
-    "version": "1.0.4",
+    "version": "1.0.5",
     "summary": "A react native PDF view component",
     "description": "A react native PDF view component, support ios and android platform",
     "main": "index.js",