@ama-sdk/core 11.6.0-prerelease.2 → 11.6.0-prerelease.21

package/esm2015/clients/api-fetch-client.js

@@ -225,10 +225,10 @@ function _ts_generator(thisArg, body) {
         };
     }
 }
-import { ExceptionReply } from '../plugins/exception';
-import { ReviverReply } from '../plugins/reviver';
 import { extractQueryParams, filterUndefinedValues, getResponseReviver, prepareUrl, processFormData, tokenizeRequestOptions } from '../fwk/api.helpers';
 import { CanceledCallError, EmptyResponseError, ResponseJSONParseError } from '../fwk/errors';
+import { ExceptionReply } from '../plugins/exception';
+import { ReviverReply } from '../plugins/reviver';
 var DEFAULT_OPTIONS = {
     replyPlugins: [
         new ReviverReply(),
@@ -410,17 +410,12 @@ var DEFAULT_OPTIONS = {
                             case 2:
                                 canStart = _state.sent();
                                 isCanceledBy = canStart.indexOf(false);
-                                if (isCanceledBy >= 0) {
-                                    // One of the fetch plugins cancelled the execution of the call
-                                    asyncResponse = Promise.reject(new CanceledCallError("Is canceled by the plugin ".concat(isCanceledBy), isCanceledBy, _this.options.fetchPlugins[isCanceledBy], {
-                                        apiName: apiName,
-                                        operationId: operationId,
-                                        url: url,
-                                        origin: origin
-                                    }));
-                                } else {
-                                    asyncResponse = fetch(url, options);
-                                }
+                                asyncResponse = isCanceledBy === -1 ? fetch(url, options) : Promise.reject(new CanceledCallError("Is canceled by the plugin ".concat(isCanceledBy), isCanceledBy, _this.options.fetchPlugins[isCanceledBy], {
+                                    apiName: apiName,
+                                    operationId: operationId,
+                                    url: url,
+                                    origin: origin
+                                }));
                                 _iteratorNormalCompletion = true, _didIteratorError = false, _iteratorError = undefined;
                                 try {
                                     for(_iterator = loadedPlugins[Symbol.iterator](); !(_iteratorNormalCompletion = (_step = _iterator.next()).done); _iteratorNormalCompletion = true){
@@ -459,16 +454,12 @@ var DEFAULT_OPTIONS = {
                                 ];
                             case 5:
                                 e = _state.sent();
-                                if (_instanceof(e, CanceledCallError)) {
-                                    exception = e;
-                                } else {
-                                    exception = new EmptyResponseError(e.message || 'Fail to Fetch', undefined, {
-                                        apiName: apiName,
-                                        operationId: operationId,
-                                        url: url,
-                                        origin: origin
-                                    });
-                                }
+                                exception = _instanceof(e, CanceledCallError) ? e : new EmptyResponseError(e.message || 'Fail to Fetch', undefined, {
+                                    apiName: apiName,
+                                    operationId: operationId,
+                                    url: url,
+                                    origin: origin
+                                });
                                 return [
                                     3,
                                     6
@@ -484,7 +475,7 @@ var DEFAULT_OPTIONS = {
                                         origin: origin
                                     });
                                 }
-                                // eslint-disable-next-line no-console
+                                // eslint-disable-next-line no-console -- `console.error` is supposed to be the default value if the `options` argument is not provided, can be removed in Otter v12.
                                 reviver = getResponseReviver(revivers, response, operationId, {
                                     disableFallback: _this.options.disableFallback,
                                     log: console.error

package/esm2015/fwk/api.helper.spec.js

@@ -1,4 +1,4 @@
-/* eslint-disable @typescript-eslint/naming-convention */ /* eslint-disable no-console */ import { getResponseReviver } from '@ama-sdk/core';
+/* eslint-disable no-console -- only using the reference */ import { getResponseReviver } from '@ama-sdk/core';
 describe('getResponseReviver - revivers by status code', function() {
     var revivers = {
         202: jest.fn(),

package/esm2015/fwk/api.helpers.js

@@ -83,8 +83,8 @@ function _unsupported_iterable_to_array(o, minLen) {
     }).map(function(name) {
         return "".concat(name, "=").concat(queryParameters[name]);
     }).join('&');
-    var paramsPrefix = url.indexOf('?') > -1 ? '&' : '?';
-    return url + (!queryPart ? '' : paramsPrefix + queryPart);
+    var paramsPrefix = url.includes('?') ? '&' : '?';
+    return url + (queryPart ? paramsPrefix + queryPart : '');
 }
 /**
  * Returns a map containing the query parameters
@@ -104,36 +104,34 @@ function _unsupported_iterable_to_array(o, minLen) {
  * @param object JSON object to filter
  * @returns an object without undefined values
  */ export function filterUndefinedValues(object) {
-    return !object ? {} : Object.keys(object).filter(function(objectKey) {
+    return object ? Object.keys(object).filter(function(objectKey) {
         return typeof object[objectKey] !== 'undefined';
     }).reduce(function(acc, objectKey) {
         acc[objectKey] = object[objectKey];
         return acc;
-    }, {});
+    }, {}) : {};
 }
 /**
  * Receives an object containing key/value pairs
  * Encodes this object to match application/x-www-urlencoded or multipart/form-data
  * @param data
  * @param type
- * @param data
- * @param type
  */ export function processFormData(data, type) {
     var encodedData;
-    /* eslint-disable guard-for-in */ if (type === 'multipart/form-data') {
+    if (type === 'multipart/form-data') {
         var formData = new FormData();
-        for(var i in data){
-            formData.append(i, data[i]);
-        }
+        Object.entries(data).forEach(function(param) {
+            var _param = _sliced_to_array(param, 2), key = _param[0], value = _param[1];
+            return formData.append(key, value);
+        });
         encodedData = formData;
     } else {
-        var formData1 = [];
-        for(var i1 in data){
-            formData1.push("".concat(i1, "=").concat(encodeURIComponent(data[i1])));
-        }
-        encodedData = formData1.join('&');
+        encodedData = Object.entries(data).map(function(param) {
+            var _param = _sliced_to_array(param, 2), key = _param[0], value = _param[1];
+            return "".concat(key, "=").concat(encodeURIComponent(value));
+        }).join('&');
     }
-    /* eslint-enable guard-for-in */ return encodedData;
+    return encodedData;
 }
 /**
  * Computes tokens based on the given list of PII parameter names.
@@ -177,29 +175,25 @@ function _unsupported_iterable_to_array(o, minLen) {
  * Fallback to the lowest status code's reviver.
  * Does not try to match non-successful responses as error are handled separately
  * @param revivers
- * @param endpoint
  * @param response
- * @param options
- * @param options.disableFallback
- * @param options.log
- */ export function getResponseReviver(revivers, response, // eslint-disable-next-line no-console
-endpoint) {
-    var options = arguments.length > 3 && arguments[3] !== void 0 ? arguments[3] : {
-        disableFallback: false,
-        log: console.error
-    };
+ * @param endpoint
+ * @param options `{ disableFallback: false, log: console.error }` by default
+ * @param options.disableFallback `false` by default
+ * @param options.log `() => {}` by default -- warning: default value will change to `console.error` in Otter v12.
+ */ export function getResponseReviver(revivers, response, endpoint, options) {
+    // eslint-disable-next-line no-console -- set as default value
+    var _ref = options !== null && options !== void 0 ? options : {}, _ref_disableFallback = _ref.disableFallback, disableFallback = _ref_disableFallback === void 0 ? false : _ref_disableFallback, tmp = _ref.log, logMsg = tmp === void 0 ? options ? function() {} : console.error : tmp;
     var logPrefix = "API status code error for ".concat(endpoint || 'unknown', " endpoint");
-    var logMsg = options.log || function() {};
     if (!response || !response.ok) {
         return undefined;
     }
     if (typeof revivers === 'function' || typeof revivers === 'undefined') {
         return revivers;
     }
-    if (response.status && Object.keys(revivers).indexOf("".concat(response.status)) > -1) {
+    if (response.status && Object.keys(revivers).includes("".concat(response.status))) {
         return revivers[response.status];
     }
-    if (options === null || options === void 0 ? void 0 : options.disableFallback) {
+    if (disableFallback) {
         logMsg("".concat(logPrefix, " - Missing ").concat(response.status, " from API specification - fallback is deactivated, no revive will run on this response"));
         return undefined;
     }
@@ -219,7 +213,7 @@ endpoint) {
         statusCode: Number.MAX_SAFE_INTEGER,
         reviver: undefined
     });
-    var fallbackLog = Number.MAX_SAFE_INTEGER !== fallback.statusCode ? "Fallback to ".concat(fallback.statusCode, "'s reviver") : 'No fallback found';
+    var fallbackLog = Number.MAX_SAFE_INTEGER === fallback.statusCode ? 'No fallback found' : "Fallback to ".concat(fallback.statusCode, "'s reviver");
     logMsg("".concat(logPrefix, " - Unknown ").concat(response.status || 'undefined', " code returned by the API - ").concat(fallbackLog));
     return fallback.reviver;
 }

package/esm2015/fwk/core/api-client.js

@@ -2,5 +2,6 @@
  * Check if the object is an Api Client object
  * @param client object to check
  */ export function isApiClient(client) {
-    return client && !!client.options && typeof client.extractQueryParams === 'function' && typeof client.getRequestOptions === 'function' && typeof client.prepareUrl === 'function' && typeof client.processFormData === 'function' && typeof client.processCall === 'function';
+    var apiClient = client;
+    return !!apiClient && !!apiClient.options && typeof apiClient.extractQueryParams === 'function' && typeof apiClient.getRequestOptions === 'function' && typeof apiClient.prepareUrl === 'function' && typeof apiClient.processFormData === 'function' && typeof apiClient.processCall === 'function';
 }

package/esm2015/fwk/core/index.js

@@ -1,2 +1,2 @@
-export * from './base-api-constructor';
 export * from './api-client';
+export * from './base-api-constructor';

package/esm2015/fwk/date.js

@@ -1,4 +1,5 @@
-/* eslint-disable */ function _array_like_to_array(arr, len) {
+// eslint-disable-next-line @typescript-eslint/naming-convention -- keep to not introduce breaking change
+function _array_like_to_array(arr, len) {
     if (len == null || len > arr.length) len = arr.length;
     for(var i = 0, arr2 = new Array(len); i < len; i++)arr2[i] = arr[i];
     return arr2;
@@ -149,10 +150,10 @@ function _is_native_reflect_construct() {
         return !!result;
     })();
 }
+// eslint-disable-next-line @typescript-eslint/naming-convention, no-underscore-dangle -- keep to not introduce breaking change
 export var _NativeDateClass = Date;
 /**
  * Specific padding for number
- *
  * @param val number
  * @param digits minimal number of digits to display
  */ export function pad(val) {
@@ -160,7 +161,9 @@ export var _NativeDateClass = Date;
     var str = "".concat(val);
     return '0'.repeat(Math.max(0, digits - str.length)) + str;
 }
-export var CommonDate = /*#__PURE__*/ function(Date1) {
+/**
+ * Removes timezone information from ISO8601 strings
+ */ export var CommonDate = /*#__PURE__*/ function(Date1) {
     "use strict";
     _inherits(CommonDate, Date1);
     function CommonDate() {
@@ -168,27 +171,23 @@ export var CommonDate = /*#__PURE__*/ function(Date1) {
             args[_key] = arguments[_key];
         }
         _class_call_check(this, CommonDate);
-        if (args) {
-            if (typeof args[0] === 'string') {
-                var idxT = args[0].lastIndexOf('T');
-                // TZD  = time zone designator (Z or +hh:mm or -hh:mm)
-                var idx = args[0].lastIndexOf('Z');
-                if (idx < 0) {
-                    idx = args[0].lastIndexOf('+');
-                }
-                if (idx < 0 && idxT > 0) {
-                    var relativeIdx = args[0].substring(idxT).lastIndexOf('-');
-                    idx = relativeIdx > 0 ? relativeIdx + idxT : relativeIdx;
-                }
-                if (idx > 0) {
-                    args[0] = args[0].substring(0, idx);
-                }
-                var TIME_ZONE_OFFSET = _construct(Date, _to_consumable_array(args)).getTimezoneOffset();
-                if (idxT > 0) {
-                    args[0] += "".concat(TIME_ZONE_OFFSET < 0 ? '+' : '-').concat(pad(Math.floor(Math.abs(TIME_ZONE_OFFSET / 60))), ":").concat(pad(Math.abs(TIME_ZONE_OFFSET % 60)));
-                }
-            } else if (_instanceof(args[0], CommonDate)) {
-                args[0] = args[0];
+        if (args && typeof args[0] === 'string') {
+            var idxT = args[0].lastIndexOf('T');
+            // TZD  = time zone designator (Z or +hh:mm or -hh:mm)
+            var idx = args[0].lastIndexOf('Z');
+            if (idx < 0) {
+                idx = args[0].lastIndexOf('+');
+            }
+            if (idx < 0 && idxT > 0) {
+                var relativeIdx = args[0].substring(idxT).lastIndexOf('-');
+                idx = relativeIdx > 0 ? relativeIdx + idxT : relativeIdx;
+            }
+            if (idx > 0) {
+                args[0] = args[0].substring(0, idx);
+            }
+            var TIME_ZONE_OFFSET = _construct(Date, _to_consumable_array(args)).getTimezoneOffset();
+            if (idxT > 0) {
+                args[0] += "".concat(TIME_ZONE_OFFSET < 0 ? '+' : '-').concat(pad(Math.floor(Math.abs(TIME_ZONE_OFFSET / 60))), ":").concat(pad(Math.abs(TIME_ZONE_OFFSET % 60)));
             }
         }
         return _call_super(this, CommonDate, _to_consumable_array(args));
@@ -214,7 +213,7 @@ export var CommonDate = /*#__PURE__*/ function(Date1) {
                 args[_key] = arguments[_key];
             }
             _class_call_check(this, Date1);
-            if (args && typeof args[0] === 'string' && args[0].lastIndexOf('T') < 0) {
+            if (args && typeof args[0] === 'string' && !args[0].includes('T')) {
                 args[0] = "".concat(args[0], "T00:00:00Z");
             } else if (_instanceof(args[0], _NativeDateClass)) {
                 args[0] = "".concat(args[0].getFullYear(), "-").concat(pad(args[0].getMonth() + 1), "-").concat(pad(args[0].getDate()), "T00:00:00Z");
@@ -226,7 +225,8 @@ export var CommonDate = /*#__PURE__*/ function(Date1) {
                 key: "_Date",
                 value: /**
      * To ensure that users cannot use a standard Date instead of utils.Date
-     */ function _Date() {}
+     */ // eslint-disable-next-line @typescript-eslint/naming-convention -- keep to not introduce breaking change
+                function _Date() {}
             },
             {
                 key: "toJSON",
@@ -240,9 +240,8 @@ export var CommonDate = /*#__PURE__*/ function(Date1) {
                 key: "equals",
                 value: /**
      * Compare if two dates are equals.
-     *
      * @param  {Date}    date the date to compare
-     * @return {boolean}      true if the dates are equals.
+     * @returns {boolean}      true if the dates are equals.
      */ function equals(date) {
                     if (!date) {
                         return false;
@@ -261,6 +260,7 @@ export var CommonDate = /*#__PURE__*/ function(Date1) {
                 args[_key] = arguments[_key];
             }
             _class_call_check(this, DateTime);
+            // eslint-disable-next-line @typescript-eslint/no-unsafe-argument -- type is explicitly `any`
             return _call_super(this, DateTime, _to_consumable_array(args));
         }
         _create_class(DateTime, [
@@ -268,7 +268,8 @@ export var CommonDate = /*#__PURE__*/ function(Date1) {
                 key: "_DateTime",
                 value: /**
      * To ensure that users cannot use a standard Date instead of utils.DateTime
-     */ function _DateTime() {}
+     */ // eslint-disable-next-line @typescript-eslint/naming-convention -- keep to not introduce breaking change
+                function _DateTime() {}
             }
         ]);
         return DateTime;

package/esm2015/fwk/date.spec.js

@@ -1,7 +1,7 @@
 import { utils } from './date';
 describe('DateTime', function() {
     it('should support timestamp', function() {
-        var ts = new Date().getTime();
+        var ts = Date.now();
         var dateUtils = new utils.DateTime(ts);
         expect(dateUtils.getTime()).toEqual(ts);
     });
@@ -15,6 +15,7 @@ describe('DateTime', function() {
     });
     it('should support json conversions', function() {
         var originalDate = new utils.DateTime(new Date());
+        // eslint-disable-next-line unicorn/prefer-structured-clone -- we test the JSON conversion
         var jsonDate = JSON.parse(JSON.stringify(originalDate));
         expect(new utils.DateTime(jsonDate)).toEqual(originalDate);
     });
@@ -52,7 +53,7 @@ describe('DateTime', function() {
 });
 describe('Date', function() {
     it('should support timestamp', function() {
-        var ts = new Date().getTime();
+        var ts = Date.now();
         var dateUtils = new utils.Date(ts);
         expect(dateUtils.getTime()).toEqual(ts);
     });
@@ -66,6 +67,7 @@ describe('Date', function() {
     });
     it('should support json conversions', function() {
         var originalDate = new utils.Date(new Date());
+        // eslint-disable-next-line unicorn/prefer-structured-clone -- we test the JSON conversion
         var jsonDate = JSON.parse(JSON.stringify(originalDate));
         expect(new utils.Date(jsonDate)).toEqual(originalDate);
     });

package/esm2015/fwk/ignore-enum.type.js

@@ -1,2 +1 @@
-/** Type helper to ignore the constraint on literal union type (enum) of an SDK model */ // eslint-disable-next-line @typescript-eslint/ban-types
-export { };
+/** Type helper to ignore the constraint on literal union type (enum) of an SDK model */ export { };

package/esm2015/fwk/index.js

@@ -7,4 +7,4 @@ export * from './errors';
 export * from './ignore-enum.type';
 export * from './logger';
 export * from './mocks/index';
-export * from './Reviver';
+export * from './reviver';

package/esm2015/fwk/mocks/alf-mock-adapter.js

@@ -178,19 +178,19 @@ import { getOperationId, getPath } from './helpers';
 import { SequentialMockAdapter } from './sequential-mock-adapter';
 /**
  * a new call is detected thanks to the timestamp printed by ALF on a new line, ex: "2021/12/16 18:21:28.312472 "
- */ var logNewCallRegex = RegExp(/^\d{4}\/\d{2}\/\d{2} \d{2}:\d{2}:\d{2}\.\d{6}\b/gm);
+ */ var logNewCallRegex = new RegExp(/^\d{4}\/\d{2}\/\d{2} \d{2}:\d{2}:\d{2}\.\d{6}\b/gm);
 /**
  * the correlation Id is printed this way by ALF, ex: CorrID=0001W37ZH480AJ,
- */ var correlationIdRegex = RegExp(/CorrID=([^,]*),/);
+ */ var correlationIdRegex = new RegExp(/CorrID=([^,]*),/);
 /**
  * a request is logged with its HTTP method and the path targetted on a new line, ex: "GET /1ASIUAIRFAC/v2/shopping..."
- */ var requestRegex = RegExp(/^(POST|GET|PATCH|DELETE) \/([^\s]*)/m);
+ */ var requestRegex = new RegExp(/^(POST|GET|PATCH|DELETE) \/(\S*)/m);
 /**
  * a request is logged with its HTTP version and the HTTP status on a new line, ex: "HTTP/1.1 200 OK"
- */ var responseRegex = RegExp(/^(HTTP\/1.1 \d{3})/m);
+ */ var responseRegex = new RegExp(/^(HTTP\/1.1 \d{3})/m);
 /**
  * the response data is logged with its JSON content on a new line
- */ var requestResponseJsonRegexp = RegExp(/(^{.*}$)/m);
+ */ var requestResponseJsonRegexp = new RegExp(/(^{.*}$)/m);
 /**
  * Split the logs
  * @param log alf log
@@ -210,7 +210,7 @@ import { SequentialMockAdapter } from './sequential-mock-adapter';
     if (match && match[1] && match[2]) {
         // the match looks like this 1ASIUAIRFAC/v2/shopping/carts/19DXNCKB931CYX3S?refresh=true
         // so we remove the SAP information at the beginning and URL parameters at the end if any
-        var requestUrl = match[2].substring(match[2].indexOf('/'), match[2].indexOf('?') > -1 ? match[2].indexOf('?') : match[2].length);
+        var requestUrl = match[2].substring(match[2].indexOf('/'), match[2].includes('?') ? match[2].indexOf('?') : match[2].length);
         var method = match[1];
         var pathObject = getPath(requestUrl, operationAdapter, method);
         if (pathObject) {
@@ -317,6 +317,7 @@ import { SequentialMockAdapter } from './sequential-mock-adapter';
             mockMap[alfCall.operationId] = [];
         }
         mockMap[alfCall.operationId].push({
+            // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment -- type is explicitly `any`
             mockData: alfCall.response ? JSON.parse(alfCall.response) : ''
         });
         return mockMap;

package/esm2015/fwk/mocks/base-mock-adapter.js

@@ -166,10 +166,10 @@ import { getOperationId, getPath } from './helpers';
         _define_property(this, "mockFactory", void 0);
         this.pathObjects = pathObjects;
         this.mocks = {};
-        if (typeof mockMap !== 'function') {
-            this.mocks = mockMap;
-        } else {
+        if (typeof mockMap === 'function') {
             this.mockFactory = mockMap;
+        } else {
+            this.mocks = mockMap;
         }
     }
     _create_class(BaseMockAdapter, [

package/esm2015/fwk/mocks/helpers.js

@@ -36,12 +36,12 @@
         return newMatches;
     }, []);
     var lastIndex = -1;
-    var nextIndex = -1;
     while(matches.length > 1){
-        matches = matches.reduce(function(newMatches, match) {
+        var result = matches.reduce(function(param, match) {
+            var newMatches = param.matches, nextIndex = param.nextIndex;
             var newIndex = match.segments.findIndex(function(segment) {
                 return segment.startsWith('{') && segment.endsWith('}');
-            }, lastIndex + 1);
+            });
             // Complete static match so use some value that can't be exceeded
             if (newIndex === -1) {
                 newIndex = Infinity;
@@ -54,11 +54,19 @@
             } else if (newIndex === nextIndex) {
                 newMatches.push(match);
             }
-            return newMatches;
-        }, []);
+            return {
+                matches: newMatches,
+                nextIndex: nextIndex
+            };
+        }, {
+            matches: [],
+            nextIndex: -1
+        });
+        var next = result.nextIndex;
+        matches = result.matches;
         // At this point we have tried to filter the matches but there are multiple matches that are identical and cannot
         // be filtered further. Trying to filter on the HTTP method if provided, then choose the first match.
-        if (lastIndex === nextIndex) {
+        if (lastIndex === next) {
             if (method) {
                 // Try to filter the multiple matches based on the HTTP method
                 matches.splice(0, matches.findIndex(function(match) {
@@ -67,7 +75,7 @@
             }
             matches.splice(1);
         }
-        lastIndex = nextIndex;
+        lastIndex = next;
     }
     return matches.length > 0 ? pathObjects[matches[0].index] : undefined;
 }

package/esm2015/fwk/mocks/index.js

@@ -1,10 +1,10 @@
 export * from './alf-mock-adapter';
+export * from './base-mock-adapter';
 export * from './encoded-api-request';
-export * from './mock-adapter';
+export * from './helpers';
 export * from './mock';
+export * from './mock-adapter';
 export * from './operation';
 export * from './path-object';
-export * from './base-mock-adapter';
-export * from './helpers';
 export * from './random-mock-adapter';
 export * from './sequential-mock-adapter';

package/esm2015/fwk/{Reviver.js → reviver.js}

@@ -1,6 +1,7 @@
 /**
  * Used in case of maps (dictionaries): All values of the map must be of the same type. reviveWithType will be called
  * for each of these elements.
+ * @param data
  * @param dictionaries
  * @param reviver
  * @param options Reviver options
@@ -11,8 +12,7 @@
     }
     var revived = {};
     for(var key in data){
-        // eslint-disable-next-line no-prototype-builtins
-        if (data.hasOwnProperty(key)) {
+        if (Object.prototype.hasOwnProperty.call(data, key)) {
             revived[key] = reviver(data[key], dictionaries, options);
         }
     }

package/esm2015/fwk/reviver.spec.js

@@ -1,4 +1,4 @@
-import { reviveArray, reviveDictionarizedArray, reviveMap } from './Reviver';
+import { reviveArray, reviveDictionarizedArray, reviveMap } from './reviver';
 describe('Revivers :', function() {
     it('reviveDictionarizedArray', function() {
         var dictionary = {

package/esm2015/plugins/additional-params/index.js

@@ -1,2 +1,2 @@
-export * from './additional-params.request';
 export * from './additional-params-sync.request';
+export * from './additional-params.request';

package/esm2015/plugins/bot-protection-fingerprint/bot-protection-fingerprint.request.js

@@ -168,7 +168,7 @@ function _ts_generator(thisArg, body) {
     var getProtection = function() {
         return new Promise(function(resolve, reject) {
             var timeout = setTimeout(function() {
-                return reject("[SDK][Plug-in][BotProtectionFingerprintRequest] Timeout: no Protection object was received in time.\nIf the application runs on a domain that is not protected by Imperva, this plugin should be disabled.");
+                return reject(new Error("[SDK][Plug-in][BotProtectionFingerprintRequest] Timeout: no Protection object was received in time.\nIf the application runs on a domain that is not protected by Imperva, this plugin should be disabled."));
             }, protectionTimeout);
             window.protectionLoaded = function(protectionObject) {
                 protection = protectionObject;
@@ -229,7 +229,7 @@ function _ts_generator(thisArg, body) {
                         ];
                     case 6:
                         e1 = _state.sent();
-                        (logger || console).error('[SDK][Plug-in][BotProtectionFingerprintRequest] Timeout: no Token was received in time.');
+                        (logger || console).error('[SDK][Plug-in][BotProtectionFingerprintRequest] Timeout: no Token was received in time.', e1);
                         return [
                             2
                         ];
@@ -250,7 +250,7 @@ function _ts_generator(thisArg, body) {
  * Will return the telemetry, or undefined if bmak object is not found
  * @param bmakOpt BMak object from Akamai. Default to `window.bmak` on browser if not provided.
  */ export function akamaiTelemetryRetrieverFactory(bmakOpt) {
-    var bmak = bmakOpt || (typeof window !== 'undefined' ? window.bmak : undefined);
+    var bmak = bmakOpt || (typeof window === 'undefined' ? undefined : window.bmak);
     return function() {
         if (!bmak || !(typeof bmak.get_telemetry === 'function')) {
             return;

package/esm2015/plugins/bot-protection-fingerprint/bot-protection-fingerprint.spec.js

@@ -137,7 +137,7 @@ describe('BotProtectionFingerprint', function() {
             };
             var protectionReject = {
                 token: function() {
-                    return Promise.reject('error');
+                    return Promise.reject(new Error('error'));
                 }
             };
             var registerEvent = function(protection) {
@@ -154,13 +154,11 @@ describe('BotProtectionFingerprint', function() {
             beforeEach(function() {
                 consoleMock = jest.spyOn(console, 'error').mockImplementation();
                 windowBackup = global.window;
-                // eslint-disable-next-line no-global-assign
                 global.window = {};
                 retriever = impervaProtectionRetrieverFactory(50, 50);
                 tokenValue = 'dummyToken';
             });
             afterEach(function() {
-                // eslint-disable-next-line no-global-assign
                 global.window = windowBackup;
                 consoleMock.mockReset();
             });
@@ -184,7 +182,7 @@ describe('BotProtectionFingerprint', function() {
                             expect.apply(void 0, [
                                 _state.sent()
                             ]).toBeUndefined();
-                            // eslint-disable-next-line no-console
+                            // eslint-disable-next-line no-console -- console.error is not called here
                             expect(console.error).toHaveBeenCalledTimes(1);
                             return [
                                 2
@@ -213,7 +211,7 @@ describe('BotProtectionFingerprint', function() {
                             expect.apply(void 0, [
                                 _state.sent()
                             ]).toBeUndefined();
-                            // eslint-disable-next-line no-console
+                            // eslint-disable-next-line no-console -- console.error is not called here
                             expect(console.error).toHaveBeenCalledTimes(1);
                             return [
                                 2
@@ -242,7 +240,7 @@ describe('BotProtectionFingerprint', function() {
                             expect.apply(void 0, [
                                 _state.sent()
                             ]).toBeUndefined();
-                            // eslint-disable-next-line no-console
+                            // eslint-disable-next-line no-console -- console.error is not called here
                             expect(console.error).toHaveBeenCalledTimes(1);
                             return [
                                 2
@@ -287,7 +285,7 @@ describe('BotProtectionFingerprint', function() {
                             expect.apply(void 0, [
                                 _state.sent()
                             ]).toBe(tokenValue);
-                            // eslint-disable-next-line no-console
+                            // eslint-disable-next-line no-console -- console.error is not called here
                             expect(console.error).not.toHaveBeenCalled();
                             return [
                                 2
@@ -300,20 +298,19 @@ describe('BotProtectionFingerprint', function() {
             it('Should return undefined if bmak object doesn\'t exist.', function() {
                 expect(akamaiTelemetryRetrieverFactory()()).toBeUndefined();
                 expect(akamaiTelemetryRetrieverFactory({})()).toBeUndefined();
-                // eslint-disable-next-line @typescript-eslint/naming-convention,camelcase
                 expect(akamaiTelemetryRetrieverFactory({
                     get_telemetry: 'test'
                 })()).toBeUndefined();
             });
             it('Should return telemetry', function() {
-                // eslint-disable-next-line @typescript-eslint/naming-convention,camelcase
+                // eslint-disable-next-line @typescript-eslint/naming-convention -- naming convention imposed by Akamai
                 expect(akamaiTelemetryRetrieverFactory({
                     get_telemetry: function() {
                         return 'telemetryValue';
                     }
                 })()).toBe('telemetryValue');
                 global.window = {};
-                // eslint-disable-next-line @typescript-eslint/naming-convention,camelcase
+                // eslint-disable-next-line @typescript-eslint/naming-convention -- naming convention imposed by Akamai
                 global.window.bmak = {
                     get_telemetry: function() {
                         return 'telemetryValue2';