@alveole/eslint-config 0.23.4 → 0.24.1

package/index.js

@@ -4,68 +4,7 @@ const sharedRules = require('./rules/_shared');
 const styleRules = require('./rules/styles');
 const serviceRules = require('./rules/services');
 
-module.exports = defineConfig([
-  expoConfig,
-  {
-    ignores: ['dist/**'],
-  },
-  {
-    files: ['**/*.{ts,tsx}'],
-    rules: {
-      'no-redeclare': 'off',
-      '@typescript-eslint/no-redeclare': ['error', { ignoreDeclarationMerge: true }],
-      'no-restricted-properties': [
-        'error',
-        {
-          object: 'window',
-          property: 'open',
-          message: 'N’utilisez pas window.open. Utilisez Linking.openURL (expo) à la place.',
-        },
-      ],
-      'no-unused-vars': 'off',
-      '@typescript-eslint/no-unused-vars': [
-        'error',
-        {
-          argsIgnorePattern: '^_',
-          varsIgnorePattern: '^_',
-          caughtErrorsIgnorePattern: '^_',
-          ignoreRestSiblings: true,
-        },
-      ],
-    },
-  },
-  {
-    files: ['**/*.styles.ts'],
-    rules: {
-      'no-restricted-syntax': [
-        'error',
-        {
-          selector: "Property[key.name='transition'], Property[key.value='transition']",
-          message:
-            'N’utilisez pas la propriété CSS transition. Utilisez transitionBehavior, transitionDelay, transitionDuration, transitionProperty ou transitionTimingFunction à la place.',
-        },
-        {
-          selector:
-            "Property[key.name='padding'] > Literal[value=/\\s+/], Property[key.value='padding'] > Literal[value=/\\s+/]",
-          message:
-            'N’utilisez pas la forme raccourcie padding avec plusieurs valeurs. Utilisez paddingTop, paddingBottom, paddingLeft et paddingRight à la place.',
-        },
-        {
-          selector: "Property[key.name='border'], Property[key.value='border']",
-          message:
-            'N’utilisez pas la propriété raccourcie border. Utilisez borderColor, borderWidth, borderStyle, etc. à la place.',
-        },
-        {
-          selector: "Property[key.name='background'], Property[key.value='background']",
-          message: 'N’utilisez pas la propriété raccourcie background. Utilisez backgroundColor, etc. à la place.',
-        },
-      ],
-    },
-  },
-  {
-    files: ['**/services/**/*.{ts,tsx}'],
-    rules: {
-      '@typescript-eslint/no-redeclare': 'off',
-    },
-  },
-]);
+/** @type {import('eslint').Linter.Config[]} */
+const config = defineConfig([expoConfig, { ignores: ['dist/**'] }, sharedRules, styleRules, serviceRules]);
+
+module.exports = config;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@alveole/eslint-config",
-  "version": "0.23.4",
+  "version": "0.24.1",
   "description": "ESLint flat config pour les projets Alveole",
   "main": "index.js",
   "scripts": {

package/rules/_shared.js

@@ -1,9 +1,130 @@
+const flashListPlugin = {
+  rules: {
+    'prefer-flash-list': {
+      meta: {
+        type: 'suggestion',
+        fixable: 'code',
+        docs: {
+          description: 'Interdit FlatList (react-native) et impose FlashList (@shopify/flash-list).',
+        },
+        messages: {
+          preferFlashList:
+            'N’utilisez pas FlatList depuis react-native. Utilisez FlashList depuis @shopify/flash-list.',
+        },
+        schema: [],
+      },
+      create(context) {
+        const sourceCode = context.sourceCode;
+
+        return {
+          ImportDeclaration(node) {
+            if (node.source.value !== 'react-native') {
+              return;
+            }
+
+            const flatListSpecifier = node.specifiers.find(
+              specifier =>
+                specifier.type === 'ImportSpecifier' &&
+                specifier.imported &&
+                specifier.imported.type === 'Identifier' &&
+                specifier.imported.name === 'FlatList',
+            );
+
+            if (!flatListSpecifier) {
+              return;
+            }
+
+            context.report({
+              node: flatListSpecifier,
+              messageId: 'preferFlashList',
+              fix(fixer) {
+                const program = node.parent;
+                if (!program || program.type !== 'Program') {
+                  return null;
+                }
+
+                const importDeclarations = program.body.filter(statement => statement.type === 'ImportDeclaration');
+                const flashListImport = importDeclarations.find(
+                  statement => statement.source.value === '@shopify/flash-list',
+                );
+                const hasFlashListAlready =
+                  !!flashListImport &&
+                  flashListImport.specifiers.some(
+                    specifier =>
+                      specifier.type === 'ImportSpecifier' &&
+                      specifier.imported &&
+                      specifier.imported.type === 'Identifier' &&
+                      specifier.imported.name === 'FlashList',
+                  );
+
+                const fixes = [];
+
+                if (node.specifiers.length === 1) {
+                  if (hasFlashListAlready) {
+                    fixes.push(fixer.remove(node));
+                  } else {
+                    fixes.push(fixer.replaceText(node, "import { FlashList } from '@shopify/flash-list';"));
+                  }
+                  return fixes;
+                }
+
+                let [start, end] = flatListSpecifier.range;
+                const tokenBefore = sourceCode.getTokenBefore(flatListSpecifier);
+                const tokenAfter = sourceCode.getTokenAfter(flatListSpecifier);
+
+                if (tokenAfter && tokenAfter.value === ',') {
+                  end = tokenAfter.range[1];
+                } else if (tokenBefore && tokenBefore.value === ',') {
+                  start = tokenBefore.range[0];
+                }
+
+                fixes.push(fixer.removeRange([start, end]));
+
+                if (!hasFlashListAlready) {
+                  if (flashListImport) {
+                    const hasNamedSpecifiers = flashListImport.specifiers.some(
+                      specifier => specifier.type === 'ImportSpecifier',
+                    );
+
+                    if (hasNamedSpecifiers) {
+                      const namedSpecifiers = flashListImport.specifiers.filter(
+                        specifier => specifier.type === 'ImportSpecifier',
+                      );
+                      const lastNamedSpecifier = namedSpecifiers[namedSpecifiers.length - 1];
+                      fixes.push(fixer.insertTextAfter(lastNamedSpecifier, ', FlashList'));
+                    } else if (flashListImport.specifiers.length > 0) {
+                      const lastSpecifier = flashListImport.specifiers[flashListImport.specifiers.length - 1];
+                      fixes.push(fixer.insertTextAfter(lastSpecifier, ', { FlashList }'));
+                    } else {
+                      fixes.push(
+                        fixer.replaceText(flashListImport, "import { FlashList } from '@shopify/flash-list';"),
+                      );
+                    }
+                  } else {
+                    fixes.push(fixer.insertTextAfter(node, "\nimport { FlashList } from '@shopify/flash-list';"));
+                  }
+                }
+
+                return fixes;
+              },
+            });
+          },
+        };
+      },
+    },
+  },
+};
+
 /** @type {import('eslint').Linter.Config} */
 const config = {
   files: ['**/*.{ts,tsx}'],
+  plugins: {
+    flashList: flashListPlugin,
+  },
   rules: {
     'no-redeclare': 'off',
     '@typescript-eslint/no-redeclare': ['error', { ignoreDeclarationMerge: true }],
+    'flashList/prefer-flash-list': 'error',
     'no-restricted-properties': [
       'error',
       {