@alumbwe/anvil 1.0.41 → 1.0.49

package/src/components/ask-user/__tests__/multiple-choice-form.test.ts

@@ -1,432 +0,0 @@
-/**
- * Integration tests for MultipleChoiceForm component logic
- *
- * NOTE: Due to React 19 + Bun + OpenTUI compatibility issues, we test the component's
- * core logic in isolation rather than rendering the full component.
- * See cli/knowledge.md for details on the testing constraints.
- */
-
-import { describe, it, expect } from 'bun:test'
-
-import { getOptionLabel, CUSTOM_OPTION_INDEX } from '../constants'
-
-import type { AccordionAnswer } from '../components/accordion-question'
-import type { AskUserOption } from '../constants'
-
-/** Question type - mirrors AskUserQuestion from chat-store */
-interface TestQuestion {
-  question: string
-  options: AskUserOption[]
-  multiSelect?: boolean
-}
-
-/**
- * Format answer for submission (mirrors component logic)
- */
-function formatAnswer(
-  question: TestQuestion,
-  answer: AccordionAnswer | undefined,
-): { question: string; answer: string } {
-  if (!answer) {
-    return { question: question.question, answer: 'Skipped' }
-  }
-
-  const selectedOptions = question.multiSelect
-    ? Array.from(answer.selectedIndices ?? [])
-        .map((idx) => getOptionLabel(question.options[idx]))
-        .filter(Boolean)
-    : answer.selectedIndex !== undefined
-      ? [getOptionLabel(question.options[answer.selectedIndex])]
-      : []
-
-  const customText =
-    answer.isCustom && (answer.customText?.trim().length ?? 0) > 0
-      ? (answer.customText ?? '').trim()
-      : ''
-
-  const parts = customText ? [...selectedOptions, customText] : selectedOptions
-  if (parts.length === 0) {
-    return { question: question.question, answer: 'Skipped' }
-  }
-
-  return {
-    question: question.question,
-    answer: question.multiSelect ? parts.join(', ') : parts[0],
-  }
-}
-
-describe('getOptionLabel', () => {
-  it('extracts label from string option', () => {
-    expect(getOptionLabel('Option A')).toBe('Option A')
-  })
-
-  it('extracts label from object option', () => {
-    expect(
-      getOptionLabel({ label: 'Option B', description: 'Description' }),
-    ).toBe('Option B')
-  })
-
-  it('extracts label from object option without description', () => {
-    expect(getOptionLabel({ label: 'Option C' })).toBe('Option C')
-  })
-
-  it('returns empty string for null-ish label', () => {
-    expect(getOptionLabel({ label: '' })).toBe('')
-  })
-})
-
-describe('formatAnswer', () => {
-  const singleSelectQuestion: TestQuestion = {
-    question: 'What is your favorite color?',
-    options: ['Red', 'Blue', 'Green'],
-    multiSelect: false,
-  }
-
-  const multiSelectQuestion: TestQuestion = {
-    question: 'Select your hobbies',
-    options: ['Reading', 'Gaming', 'Sports'],
-    multiSelect: true,
-  }
-
-  const objectOptionsQuestion: TestQuestion = {
-    question: 'Choose a plan',
-    options: [
-      { label: 'Basic', description: '$10/month' },
-      { label: 'Pro', description: '$20/month' },
-    ],
-    multiSelect: false,
-  }
-
-  describe('single-select questions', () => {
-    it('returns Skipped when no answer provided', () => {
-      const result = formatAnswer(singleSelectQuestion, undefined)
-      expect(result).toEqual({
-        question: 'What is your favorite color?',
-        answer: 'Skipped',
-      })
-    })
-
-    it('returns Skipped when answer is empty object', () => {
-      const result = formatAnswer(singleSelectQuestion, {})
-      expect(result).toEqual({
-        question: 'What is your favorite color?',
-        answer: 'Skipped',
-      })
-    })
-
-    it('returns selected option label', () => {
-      const answer: AccordionAnswer = { selectedIndex: 1 }
-      const result = formatAnswer(singleSelectQuestion, answer)
-      expect(result).toEqual({
-        question: 'What is your favorite color?',
-        answer: 'Blue',
-      })
-    })
-
-    it('returns first option when index is 0', () => {
-      const answer: AccordionAnswer = { selectedIndex: 0 }
-      const result = formatAnswer(singleSelectQuestion, answer)
-      expect(result).toEqual({
-        question: 'What is your favorite color?',
-        answer: 'Red',
-      })
-    })
-
-    it('returns custom text when isCustom is true', () => {
-      const answer: AccordionAnswer = {
-        isCustom: true,
-        customText: 'Purple',
-      }
-      const result = formatAnswer(singleSelectQuestion, answer)
-      expect(result).toEqual({
-        question: 'What is your favorite color?',
-        answer: 'Purple',
-      })
-    })
-
-    it('trims whitespace from custom text', () => {
-      const answer: AccordionAnswer = {
-        isCustom: true,
-        customText: '  Purple  ',
-      }
-      const result = formatAnswer(singleSelectQuestion, answer)
-      expect(result).toEqual({
-        question: 'What is your favorite color?',
-        answer: 'Purple',
-      })
-    })
-
-    it('returns Skipped when isCustom is true but text is empty', () => {
-      const answer: AccordionAnswer = {
-        isCustom: true,
-        customText: '',
-      }
-      const result = formatAnswer(singleSelectQuestion, answer)
-      expect(result).toEqual({
-        question: 'What is your favorite color?',
-        answer: 'Skipped',
-      })
-    })
-
-    it('returns Skipped when isCustom is true but text is only whitespace', () => {
-      const answer: AccordionAnswer = {
-        isCustom: true,
-        customText: '   ',
-      }
-      const result = formatAnswer(singleSelectQuestion, answer)
-      expect(result).toEqual({
-        question: 'What is your favorite color?',
-        answer: 'Skipped',
-      })
-    })
-  })
-
-  describe('multi-select questions', () => {
-    it('returns Skipped when no selections', () => {
-      const answer: AccordionAnswer = { selectedIndices: new Set() }
-      const result = formatAnswer(multiSelectQuestion, answer)
-      expect(result).toEqual({
-        question: 'Select your hobbies',
-        answer: 'Skipped',
-      })
-    })
-
-    it('returns single selection', () => {
-      const answer: AccordionAnswer = { selectedIndices: new Set([0]) }
-      const result = formatAnswer(multiSelectQuestion, answer)
-      expect(result).toEqual({
-        question: 'Select your hobbies',
-        answer: 'Reading',
-      })
-    })
-
-    it('returns multiple selections joined by comma', () => {
-      const answer: AccordionAnswer = { selectedIndices: new Set([0, 2]) }
-      const result = formatAnswer(multiSelectQuestion, answer)
-      expect(result).toEqual({
-        question: 'Select your hobbies',
-        answer: 'Reading, Sports',
-      })
-    })
-
-    it('returns all selections when all selected', () => {
-      const answer: AccordionAnswer = { selectedIndices: new Set([0, 1, 2]) }
-      const result = formatAnswer(multiSelectQuestion, answer)
-      expect(result).toEqual({
-        question: 'Select your hobbies',
-        answer: 'Reading, Gaming, Sports',
-      })
-    })
-
-    it('includes custom text with selections', () => {
-      const answer: AccordionAnswer = {
-        selectedIndices: new Set([0]),
-        isCustom: true,
-        customText: 'Cooking',
-      }
-      const result = formatAnswer(multiSelectQuestion, answer)
-      expect(result).toEqual({
-        question: 'Select your hobbies',
-        answer: 'Reading, Cooking',
-      })
-    })
-
-    it('returns only custom text when no other selections', () => {
-      const answer: AccordionAnswer = {
-        selectedIndices: new Set(),
-        isCustom: true,
-        customText: 'Cooking',
-      }
-      const result = formatAnswer(multiSelectQuestion, answer)
-      expect(result).toEqual({
-        question: 'Select your hobbies',
-        answer: 'Cooking',
-      })
-    })
-  })
-
-  describe('object options', () => {
-    it('extracts label from object options', () => {
-      const answer: AccordionAnswer = { selectedIndex: 0 }
-      const result = formatAnswer(objectOptionsQuestion, answer)
-      expect(result).toEqual({
-        question: 'Choose a plan',
-        answer: 'Basic',
-      })
-    })
-
-    it('works with second object option', () => {
-      const answer: AccordionAnswer = { selectedIndex: 1 }
-      const result = formatAnswer(objectOptionsQuestion, answer)
-      expect(result).toEqual({
-        question: 'Choose a plan',
-        answer: 'Pro',
-      })
-    })
-  })
-})
-
-describe('CUSTOM_OPTION_INDEX constant', () => {
-  it('is -1 for identifying custom option', () => {
-    expect(CUSTOM_OPTION_INDEX).toBe(-1)
-  })
-
-  it('is distinct from valid option indices', () => {
-    expect(CUSTOM_OPTION_INDEX).toBeLessThan(0)
-  })
-})
-
-describe('answer state management patterns', () => {
-  describe('single-select behavior', () => {
-    it('selecting an option clears isCustom flag', () => {
-      const previousAnswer: AccordionAnswer = {
-        isCustom: true,
-        customText: 'Custom text',
-      }
-
-      const optionIndex: number = 1
-      const isCustomOption = optionIndex === CUSTOM_OPTION_INDEX
-
-      const newAnswer: AccordionAnswer = isCustomOption
-        ? {
-            selectedIndex: undefined,
-            selectedIndices: undefined,
-            isCustom: true,
-            customText: previousAnswer.customText || '',
-          }
-        : {
-            selectedIndex: optionIndex,
-            selectedIndices: undefined,
-            isCustom: false,
-          }
-
-      expect(newAnswer.selectedIndex).toBe(1)
-      expect(newAnswer.isCustom).toBe(false)
-    })
-
-    it('selecting CUSTOM clears selectedIndex and enables isCustom', () => {
-      const previousAnswer: AccordionAnswer = {
-        selectedIndex: 1,
-      }
-
-      const optionIndex = CUSTOM_OPTION_INDEX
-      const isCustomOption = optionIndex === CUSTOM_OPTION_INDEX
-
-      const newAnswer: AccordionAnswer = isCustomOption
-        ? {
-            selectedIndex: undefined,
-            selectedIndices: undefined,
-            isCustom: true,
-            customText: previousAnswer.customText || '',
-          }
-        : {
-            selectedIndex: optionIndex,
-            selectedIndices: undefined,
-            isCustom: false,
-          }
-
-      expect(newAnswer.selectedIndex).toBeUndefined()
-      expect(newAnswer.isCustom).toBe(true)
-    })
-  })
-
-  describe('multi-select behavior', () => {
-    it('toggling adds option to selectedIndices', () => {
-      const currentAnswer: AccordionAnswer = {
-        selectedIndices: new Set([0]),
-      }
-
-      const optionIndex = 2
-      const newIndices = new Set(currentAnswer.selectedIndices)
-      if (newIndices.has(optionIndex)) {
-        newIndices.delete(optionIndex)
-      } else {
-        newIndices.add(optionIndex)
-      }
-
-      expect(newIndices.has(0)).toBe(true)
-      expect(newIndices.has(2)).toBe(true)
-      expect(newIndices.size).toBe(2)
-    })
-
-    it('toggling removes option if already selected', () => {
-      const currentAnswer: AccordionAnswer = {
-        selectedIndices: new Set([0, 1, 2]),
-      }
-
-      const optionIndex = 1
-      const newIndices = new Set(currentAnswer.selectedIndices)
-      if (newIndices.has(optionIndex)) {
-        newIndices.delete(optionIndex)
-      } else {
-        newIndices.add(optionIndex)
-      }
-
-      expect(newIndices.has(0)).toBe(true)
-      expect(newIndices.has(1)).toBe(false)
-      expect(newIndices.has(2)).toBe(true)
-      expect(newIndices.size).toBe(2)
-    })
-
-    it('toggling CUSTOM toggles isCustom flag', () => {
-      const currentAnswer: AccordionAnswer = {
-        selectedIndices: new Set([0]),
-        isCustom: false,
-      }
-
-      const optionIndex = CUSTOM_OPTION_INDEX
-      const toggledCustomOn =
-        optionIndex === CUSTOM_OPTION_INDEX && !currentAnswer.isCustom
-
-      expect(toggledCustomOn).toBe(true)
-    })
-  })
-})
-
-describe('navigation edge cases', () => {
-  it('clamps question index to valid range', () => {
-    const questionsLength = 3
-    const focusedQuestionIndex = 5
-
-    const currentQuestionIndex = Math.min(
-      Math.max(focusedQuestionIndex, 0),
-      questionsLength - 1,
-    )
-
-    expect(currentQuestionIndex).toBe(2)
-  })
-
-  it('clamps negative question index to 0', () => {
-    const questionsLength = 3
-    const focusedQuestionIndex = -1
-
-    const currentQuestionIndex = Math.min(
-      Math.max(focusedQuestionIndex, 0),
-      questionsLength - 1,
-    )
-
-    expect(currentQuestionIndex).toBe(0)
-  })
-
-  it('clamps option index to valid range', () => {
-    const optionCount = 4
-    const focusedOptionIndex = 10
-
-    const lastOptionIndex = Math.max(optionCount - 1, 0)
-    const currentOptionIndex = Math.min(
-      Math.max(focusedOptionIndex, 0),
-      lastOptionIndex,
-    )
-
-    expect(currentOptionIndex).toBe(3)
-  })
-
-  it('handles empty questions array', () => {
-    const questionsLength = 0
-    const expandedIndex = questionsLength > 0 ? 0 : null
-    const focusedOptionIndex = questionsLength > 0 ? 0 : null
-
-    expect(expandedIndex).toBeNull()
-    expect(focusedOptionIndex).toBeNull()
-  })
-})

package/src/components/ask-user/__tests__/validation.test.ts

@@ -1,213 +0,0 @@
-/**
- * Unit tests for validation.ts
- * Testing validation logic for text input
- */
-
-import { describe, it, expect } from 'bun:test'
-
-import {
-  validateOtherText,
-  isTextEmpty,
-  sanitizeTextInput,
-} from '../utils/validation'
-
-import type { QuestionValidation } from '../utils/validation'
-
-describe('validateOtherText', () => {
-  describe('default max length validation', () => {
-    it('accepts text within default limit (500 chars)', () => {
-      const text = 'a'.repeat(500)
-      const result = validateOtherText(text)
-      expect(result.isValid).toBe(true)
-      expect(result.error).toBeUndefined()
-    })
-
-    it('rejects text exceeding default limit', () => {
-      const text = 'a'.repeat(501)
-      const result = validateOtherText(text)
-      expect(result.isValid).toBe(false)
-      expect(result.error).toBe('Max 500 characters')
-    })
-
-    it('accepts empty text', () => {
-      const result = validateOtherText('')
-      expect(result.isValid).toBe(true)
-    })
-  })
-
-  describe('custom max length validation', () => {
-    const validation: QuestionValidation = {
-      maxLength: 10,
-    }
-
-    it('accepts text within custom limit', () => {
-      const result = validateOtherText('hello', validation)
-      expect(result.isValid).toBe(true)
-    })
-
-    it('rejects text exceeding custom limit', () => {
-      const result = validateOtherText('hello world!', validation)
-      expect(result.isValid).toBe(false)
-      expect(result.error).toBe('Max 10 characters')
-    })
-  })
-
-  describe('min length validation', () => {
-    const validation: QuestionValidation = {
-      minLength: 5,
-    }
-
-    it('accepts text meeting minimum', () => {
-      const result = validateOtherText('hello', validation)
-      expect(result.isValid).toBe(true)
-    })
-
-    it('rejects text below minimum', () => {
-      const result = validateOtherText('hi', validation)
-      expect(result.isValid).toBe(false)
-      expect(result.error).toBe('Min 5 characters')
-    })
-  })
-
-  describe('pattern (regex) validation', () => {
-    it('validates email pattern', () => {
-      const validation: QuestionValidation = {
-        pattern: '^[\\w-\\.]+@([\\w-]+\\.)+[\\w-]{2,4}$',
-        patternError: 'Please enter a valid email',
-      }
-
-      const validResult = validateOtherText('test@example.com', validation)
-      expect(validResult.isValid).toBe(true)
-
-      const invalidResult = validateOtherText('not-an-email', validation)
-      expect(invalidResult.isValid).toBe(false)
-      expect(invalidResult.error).toBe('Please enter a valid email')
-    })
-
-    it('validates number pattern', () => {
-      const validation: QuestionValidation = {
-        pattern: '^\\d+$',
-        patternError: 'Numbers only',
-      }
-
-      expect(validateOtherText('12345', validation).isValid).toBe(true)
-      expect(validateOtherText('abc123', validation).isValid).toBe(false)
-    })
-
-    it('uses default error message when patternError not provided', () => {
-      const validation: QuestionValidation = {
-        pattern: '^\\d+$',
-      }
-
-      const result = validateOtherText('abc', validation)
-      expect(result.isValid).toBe(false)
-      expect(result.error).toBe('Invalid format')
-    })
-
-    it('accepts empty text when pattern provided', () => {
-      const validation: QuestionValidation = {
-        pattern: '^\\d+$',
-      }
-
-      const result = validateOtherText('', validation)
-      expect(result.isValid).toBe(true) // Empty bypasses pattern check
-    })
-  })
-
-  describe('combined validations', () => {
-    it('checks all validations in order', () => {
-      const validation: QuestionValidation = {
-        minLength: 5,
-        maxLength: 10,
-        pattern: '^[a-zA-Z]+$',
-        patternError: 'Letters only',
-      }
-
-      // Too short
-      expect(validateOtherText('hi', validation).isValid).toBe(false)
-
-      // Too long
-      expect(validateOtherText('hello world', validation).isValid).toBe(false)
-
-      // Invalid pattern
-      const patternResult = validateOtherText('hello1', validation)
-      expect(patternResult.isValid).toBe(false)
-      expect(patternResult.error).toBe('Letters only')
-
-      // Valid
-      expect(validateOtherText('hello', validation).isValid).toBe(true)
-    })
-  })
-
-  describe('no validation rules', () => {
-    it('accepts any text when no validation provided', () => {
-      expect(validateOtherText('anything').isValid).toBe(true)
-      expect(validateOtherText('').isValid).toBe(true)
-      expect(validateOtherText('a'.repeat(1000)).isValid).toBe(false) // Still checks default max
-    })
-  })
-})
-
-describe('isTextEmpty', () => {
-  it('returns true for undefined', () => {
-    expect(isTextEmpty(undefined)).toBe(true)
-  })
-
-  it('returns true for empty string', () => {
-    expect(isTextEmpty('')).toBe(true)
-  })
-
-  it('returns true for whitespace only', () => {
-    expect(isTextEmpty('   ')).toBe(true)
-    expect(isTextEmpty('\t\n  ')).toBe(true)
-  })
-
-  it('returns false for text with content', () => {
-    expect(isTextEmpty('hello')).toBe(false)
-    expect(isTextEmpty('  hello  ')).toBe(false)
-  })
-})
-
-describe('sanitizeTextInput', () => {
-  it('removes control characters', () => {
-    const input = 'hello\x00world\x1F'
-    const result = sanitizeTextInput(input)
-    expect(result).toBe('hello world')
-  })
-
-  it('collapses multiple spaces', () => {
-    const input = 'hello    world'
-    const result = sanitizeTextInput(input)
-    expect(result).toBe('hello world')
-  })
-
-  it('trims leading and trailing whitespace', () => {
-    const input = '  hello world  '
-    const result = sanitizeTextInput(input)
-    expect(result).toBe('hello world')
-  })
-
-  it('handles tabs and newlines', () => {
-    const input = 'hello\t\nworld'
-    const result = sanitizeTextInput(input)
-    expect(result).toBe('hello world')
-  })
-
-  it('combines all sanitization', () => {
-    const input = '  hello\x00\x01    \t\n  world\x7F  '
-    const result = sanitizeTextInput(input)
-    expect(result).toBe('hello world')
-  })
-
-  it('returns empty string for whitespace-only input', () => {
-    const input = '   \t\n   '
-    const result = sanitizeTextInput(input)
-    expect(result).toBe('')
-  })
-
-  it('preserves valid special characters', () => {
-    const input = 'hello@example.com'
-    const result = sanitizeTextInput(input)
-    expect(result).toBe('hello@example.com')
-  })
-})