@alteriom/painlessmesh 1.9.4 → 1.9.5

package/CHANGELOG.md

@@ -5,6 +5,23 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.9.5] - 2025-12-03
+
+### Fixed
+
+- **Bridge Status Send Race Condition** (#224) - Fixed sendToInternet failures caused by race condition
+  - **Root Cause**: Bridge would attempt to send status messages to nodes that had already disconnected during the 500ms delay after `changedConnectionCallbacks`
+  - **Symptom**: Silent failures when the connection times out before the delayed task executes, causing sendToInternet to fail
+  - **Solution**: Added connection validation before sending bridge status:
+    - Check `findRoute()` and `conn->connected()` before attempting to send
+    - Use direct high-priority send via `conn->addMessage(msg, true)` to avoid redundant routing lookup
+    - Added debug logging for cancelled sends to aid troubleshooting
+  - **Impact**: Improved reliability of sendToInternet by ensuring bridge status is only sent to active connections
+
+- **Isolated Bridge Retry Mechanism** (#225) - Fixed isolated bridge retry when mesh network not found
+  - Nodes that fail initial bridge setup can now retry automatically via mesh connection monitoring
+  - **Impact**: More reliable bridge establishment in challenging network conditions
+
 ## [1.9.4] - 2025-12-03
 
 ### Fixed

package/library.json

@@ -6,7 +6,7 @@
     "type": "git",
     "url": "https://github.com/Alteriom/painlessMesh"
   },
-  "version": "1.9.4",
+  "version": "1.9.5",
   "frameworks": [
     "arduino"
   ],

package/library.properties

@@ -1,5 +1,5 @@
 name=Alteriom PainlessMesh
-version=1.9.4
+version=1.9.5
 author=Coopdis,Scotty Franzyshen,Edwin van Leeuwen,Germán Martín,Maximilian Schwarz,Doanh Doanh,Alteriom
 maintainer=Alteriom
 sentence=A painless way to setup a mesh with ESP8266 and ESP32 devices with Alteriom extensions

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@alteriom/painlessmesh",
-  "version": "1.9.4",
+  "version": "1.9.5",
   "description": "painlessMesh is a user-friendly library for creating mesh networks with ESP8266 and ESP32 devices. This Alteriom fork includes additional packages for sensor data (SensorPackage), device commands (CommandPackage), and status monitoring (StatusPackage). It handles routing and network management automatically, so you can focus on your application. The library uses JSON-based messaging and syncs time across all nodes, making it ideal for coordinated behaviour like synchronized light displays or sensor networks reporting to a central node.",
   "keywords": [
     "arduino",

package/src/arduino/wifi.hpp

@@ -1129,6 +1129,16 @@ class Mesh : public painlessmesh::Mesh<Connection> {
       // Small delay to ensure connection is fully stable, then send directly to the new node
       // This avoids issues with time sync blocking broadcast messages
       this->addTask(500, TASK_ONCE, [this, nodeId]() {
+        // Check if the connection is still valid - the node may have disconnected
+        // during the 500ms delay (e.g., due to timeout or network issues)
+        // This prevents attempting to send messages to dropped connections
+        // findRoute returns nullptr if node is not in the routing table
+        auto conn = router::findRoute<Connection>((*this), nodeId);
+        if (!conn || !conn->connected()) {
+          Log(CONNECTION, "Bridge status send cancelled: Node %u no longer connected\n", nodeId);
+          return;
+        }
+        
         // Create bridge status message
         JsonDocument doc;
         JsonObject obj = doc.to<JsonObject>();
@@ -1154,10 +1164,11 @@ class Mesh : public painlessmesh::Mesh<Connection> {
         Log(CONNECTION, "Sending bridge status directly to node %u (Internet: %s)\n",
             nodeId, hasInternet ? "YES" : "NO");
         
-        // Send directly to the new node using raw message to preserve type BRIDGE_STATUS
-        // Using sendSingle() would wrap it in type 1 (SINGLE) and hide type BRIDGE_STATUS
-        protocol::Variant variant(msg);
-        router::send<Connection>(variant, (*this));
+        // Send directly to the connection with high priority
+        // This ensures the message is sent immediately rather than queued
+        // The JSON message format is the same as what router::send() produces
+        // (Variant serializes to the same JSON format we built manually)
+        conn->addMessage(msg, true);
       });
     });
     

package/src/painlessMeshSTA.cpp

@@ -239,13 +239,24 @@ void ICACHE_FLASH_ATTR StationScan::connectToAP() {
           mesh->apInit(mesh->getNodeId());
           Log(CONNECTION, "connectToAP(): AP restarted on channel %d\n", detectedChannel);
         }
+        // Reset counter only when mesh is found on a new channel
+        // This allows isolated bridge retry to continue when mesh is truly absent
+        consecutiveEmptyScans = 0;
       } else if (detectedChannel == 0) {
         Log(CONNECTION,
             "connectToAP(): Mesh not found on any channel during re-scan\n");
+        // Do NOT reset consecutiveEmptyScans here - mesh is still absent
+        // This allows isolated bridge retry mechanism to trigger when
+        // the counter exceeds ISOLATED_BRIDGE_RETRY_SCAN_THRESHOLD
+      } else {
+        // detectedChannel == mesh->_meshChannel
+        // Mesh found on same channel we're already on - no channel change needed
+        // Reset counter since mesh exists, nodes may appear in subsequent scans
+        Log(CONNECTION,
+            "connectToAP(): Mesh found on current channel %d, no channel change needed\n",
+            detectedChannel);
+        consecutiveEmptyScans = 0;
       }
-      
-      // Reset counter after re-scan attempt
-      consecutiveEmptyScans = 0;
     }
     
     if (WiFi.status() == WL_CONNECTED &&