@alteriom/painlessmesh 1.9.18 → 1.9.19

package/CHANGELOG.md

@@ -13,6 +13,21 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
+## [1.9.19] - 2025-12-21
+
+### Fixed
+
+- **Gateway Connectivity Error Non-Retryable Fix** - Infrastructure errors no longer waste time with futile retries
+  - Gateway connectivity errors ("Router has no internet", "Gateway WiFi not connected") are now non-retryable
+  - Distinguishes between infrastructure issues (need user fix) and transient errors (can retry)
+  - Provides immediate failure feedback instead of retrying for ~14+ seconds
+  - Saves battery and network resources by avoiding retries that can't succeed
+  - Clear error messages help users identify and fix infrastructure problems quickly
+  - Transient errors (HTTP 203, 5xx, 429, timeouts) still retry with exponential backoff
+  - New comprehensive test suite with 25 assertions covering retry logic
+  - Documentation: ISSUE_GATEWAY_CONNECTIVITY_NON_RETRYABLE_FIX.md
+  - Fully backward compatible: No API changes required
+
 ## [1.9.18] - 2025-12-21
 
 ### Added

package/README.md

@@ -4,7 +4,7 @@
 
 <div align="center">
 
-**Version 1.9.18** - Internet connectivity check enhancement with DNS resolution verification
+**Version 1.9.19** - Gateway connectivity error non-retryable fix for infrastructure issues
 
 [![CI/CD Pipeline](https://github.com/Alteriom/painlessMesh/actions/workflows/ci.yml/badge.svg)](https://github.com/Alteriom/painlessMesh/actions/workflows/ci.yml)
 [![Documentation](https://github.com/Alteriom/painlessMesh/actions/workflows/docs.yml/badge.svg)](https://github.com/Alteriom/painlessMesh/actions/workflows/docs.yml)

package/library.json

@@ -6,7 +6,7 @@
     "type": "git",
     "url": "https://github.com/Alteriom/painlessMesh"
   },
-  "version": "1.9.18",
+  "version": "1.9.19",
   "frameworks": [
     "arduino"
   ],

package/library.properties

@@ -1,5 +1,5 @@
 name=Alteriom PainlessMesh
-version=1.9.18
+version=1.9.19
 author=Coopdis,Scotty Franzyshen,Edwin van Leeuwen,Germán Martín,Maximilian Schwarz,Doanh Doanh,Alteriom
 maintainer=Alteriom
 sentence=A painless way to setup a mesh with ESP8266 and ESP32 devices with Alteriom extensions

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@alteriom/painlessmesh",
-  "version": "1.9.18",
+  "version": "1.9.19",
   "description": "painlessMesh is a user-friendly library for creating mesh networks with ESP8266 and ESP32 devices. This Alteriom fork includes additional packages for sensor data (SensorPackage), device commands (CommandPackage), and status monitoring (StatusPackage). It handles routing and network management automatically, so you can focus on your application. The library uses JSON-based messaging and syncs time across all nodes, making it ideal for coordinated behaviour like synchronized light displays or sensor networks reporting to a central node.",
   "keywords": [
     "arduino",

package/src/AlteriomPainlessMesh.h

@@ -29,10 +29,10 @@
 /**
  * @brief AlteriomPainlessMesh library version information
  */
-#define ALTERIOM_PAINLESS_MESH_VERSION "1.9.18"
+#define ALTERIOM_PAINLESS_MESH_VERSION "1.9.19"
 #define ALTERIOM_PAINLESS_MESH_VERSION_MAJOR 1
 #define ALTERIOM_PAINLESS_MESH_VERSION_MINOR 9
-#define ALTERIOM_PAINLESS_MESH_VERSION_PATCH 18
+#define ALTERIOM_PAINLESS_MESH_VERSION_PATCH 19
 
 /**
  * @brief Library description and usage information

package/src/painlessMesh.h

@@ -5,7 +5,7 @@
  * @file painlessMesh.h
  * @brief Main header file for Alteriom painlessMesh library
  * 
- * @version 1.9.18
+ * @version 1.9.19
  * @date 2025-12-21
  * 
  * painlessMesh is a user-friendly library for creating mesh networks with 

package/src/painlessmesh/mesh.hpp

@@ -1532,10 +1532,38 @@ class Mesh : public ntp::MeshTime, public plugin::PackageHandler<T> {
       isRetryable = true;
       Log(COMMUNICATION, "handleGatewayAck(): HTTP 429 rate limit, marking as retryable\n");
     }
-    // Network errors (httpStatus == 0) are retryable
+    // Network errors (httpStatus == 0) EXCEPT gateway connectivity errors
+    // Gateway connectivity errors are infrastructure issues (not transient)
     else if (ack.httpStatus == 0) {
-      isRetryable = true;
-      Log(COMMUNICATION, "handleGatewayAck(): Network error, marking as retryable\n");
+      // Check if this is a gateway-level connectivity error (non-retryable)
+      bool isGatewayConnectivityError = false;
+      
+      // These errors indicate infrastructure issues that won't be fixed by retrying:
+      // - "Router has no internet access" - WAN connection down
+      // - "Gateway WiFi not connected" - ESP not associated with WiFi
+      // Use find() for std::string (test env) or indexOf() for Arduino String
+      bool routerError = false, wifiError = false;
+      #if defined(PAINLESSMESH_BOOST)
+        // Test environment: TSTRING is std::string, use find()
+        routerError = (ack.error.find("Router has no internet") != std::string::npos);
+        wifiError = (ack.error.find("Gateway WiFi not connected") != std::string::npos);
+      #else
+        // Arduino environment: TSTRING is String, use indexOf()
+        routerError = (ack.error.indexOf("Router has no internet") >= 0);
+        wifiError = (ack.error.indexOf("Gateway WiFi not connected") >= 0);
+      #endif
+      
+      if (routerError || wifiError) {
+        isGatewayConnectivityError = true;
+        Log(COMMUNICATION, "handleGatewayAck(): Gateway connectivity error detected (non-retryable): %s\n", 
+            ack.error.c_str());
+      }
+      
+      // Only mark as retryable if it's NOT a gateway connectivity error
+      if (!isGatewayConnectivityError) {
+        isRetryable = true;
+        Log(COMMUNICATION, "handleGatewayAck(): Network error, marking as retryable\n");
+      }
     }
     // HTTP 4xx client errors (except 429) are NOT retryable
     // HTTP 3xx redirects are NOT retryable (should be followed by HTTPClient)