@alteriom/painlessmesh 1.9.12 → 1.9.13

package/CHANGELOG.md

@@ -19,6 +19,39 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - TBD
 
+## [1.9.13] - 2025-12-19
+
+### Fixed
+
+- **HTTP 203 "Permanent Response" Issue with sendToInternet()** - Fixed issue where HTTP 203 (Non-Authoritative Information) responses from APIs like Callmebot WhatsApp appeared "permanent" without automatic recovery
+  - **Root Cause**: HTTP 203 responses (indicating cached/proxied responses) were correctly identified as failures but treated as terminal - requests were immediately removed from the pending queue without retry
+  - **Symptom**: User sees repeated "❌ Failed to send WhatsApp: Ambiguous response - HTTP 203..." messages with no automatic recovery, requiring manual intervention
+  - **Solution**: Modified `handleGatewayAck()` to implement intelligent retry logic for retryable failure types:
+    - HTTP 203 (Non-Authoritative Information) - cached/proxied responses, often temporary
+    - HTTP 5xx (Server Errors) - transient server issues (500, 502, 503, 504, etc.)
+    - HTTP 429 (Too Many Requests) - rate limiting with exponential backoff
+    - HTTP 0 (Network Errors) - connection failures, timeouts
+    - Non-retryable: HTTP 4xx client errors (except 429), HTTP 3xx redirects
+  - **Retry Behavior**: Uses exponential backoff (2s, 4s, 8s, 16s...) with configurable max retries (default: 3)
+  - **Testing**: Added comprehensive test coverage (50 assertions in 7 test cases) for retry classification and behavior
+  - **Documentation**: Added ISSUE_HTTP_203_RETRY_FIX.md with detailed analysis, examples, and HTTP 203 explanation
+  - **Impact**: Automatic recovery from temporary API caching issues, eliminating the "permanent" failure problem
+  - **API Compatibility**: Fully backward compatible, no breaking changes, existing code works unchanged
+
+- **Hard Reset on Node - AsyncClient Deletion Race Condition** - Fixed ESP32/ESP8266 heap corruption crashes caused by race condition in deletion spacing logic during network disruptions
+  - **Root Cause**: The `scheduleAsyncClientDeletion()` function was updating `lastScheduledDeletionTime` at BOTH scheduling time (line 111) and execution time (line 130), creating a race condition where scheduler jitter could cause deletions to execute with insufficient spacing
+  - **Symptom**: Device crashes with "CORRUPT HEAP: Bad head at 0x40831d54. Expected 0xabba1234 got 0x4081fae4" even with 250ms spacing constant, particularly during network disruptions, TCP retries, or WiFi reconnection cycles
+  - **Race Condition Scenario**: When Task A scheduled for time T1 executes late at T1+jitter, it updates `lastScheduledDeletionTime` to T1+jitter, potentially AFTER Task B's scheduled time (which was calculated based on T1), causing Task B to execute with less than 250ms spacing
+  - **Solution**: Removed the execution-time update of `lastScheduledDeletionTime` in the task callback, relying solely on the scheduling-time update
+    - Ensures consistent, predictable spacing based on planned execution times
+    - Eliminates race condition where execution-time updates could "rewind" the timestamp
+    - Makes spacing calculation immune to scheduler jitter
+    - Guarantees minimum 250ms spacing between AsyncClient deletions in all scenarios
+  - **Why This Works**: By only updating at scheduling time, subsequent deletions are always spaced from the PREVIOUS deletion's planned time, not its actual execution time, providing conservative spacing guarantees even with scheduler jitter
+  - **Testing**: All test suites pass (1000+ assertions), including TCP retry (52), connection (3), and timing tests (7)
+  - **Documentation**: Added ISSUE_HARD_RESET_DELETION_RACE_FIX.md with detailed mathematical proof and race condition analysis
+  - **Impact**: Eliminates heap corruption crashes during network disruptions, enables stable operation through TCP retries and WiFi reconnection cycles
+
 ## [1.9.12] - 2025-12-18
 
 ### Fixed

package/README.md

@@ -4,7 +4,7 @@
 
 <div align="center">
 
-**Version 1.9.12** - Latest release with AsyncClient abort() timing fix for heap corruption prevention
+**Version 1.9.13** - Latest release with HTTP 203 retry logic and AsyncClient deletion race condition fixes
 
 [![CI/CD Pipeline](https://github.com/Alteriom/painlessMesh/actions/workflows/ci.yml/badge.svg)](https://github.com/Alteriom/painlessMesh/actions/workflows/ci.yml)
 [![Documentation](https://github.com/Alteriom/painlessMesh/actions/workflows/docs.yml/badge.svg)](https://github.com/Alteriom/painlessMesh/actions/workflows/docs.yml)

package/library.json

@@ -6,7 +6,7 @@
     "type": "git",
     "url": "https://github.com/Alteriom/painlessMesh"
   },
-  "version": "1.9.12",
+  "version": "1.9.13",
   "frameworks": [
     "arduino"
   ],

package/library.properties

@@ -1,5 +1,5 @@
 name=Alteriom PainlessMesh
-version=1.9.12
+version=1.9.13
 author=Coopdis,Scotty Franzyshen,Edwin van Leeuwen,Germán Martín,Maximilian Schwarz,Doanh Doanh,Alteriom
 maintainer=Alteriom
 sentence=A painless way to setup a mesh with ESP8266 and ESP32 devices with Alteriom extensions

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@alteriom/painlessmesh",
-  "version": "1.9.12",
+  "version": "1.9.13",
   "description": "painlessMesh is a user-friendly library for creating mesh networks with ESP8266 and ESP32 devices. This Alteriom fork includes additional packages for sensor data (SensorPackage), device commands (CommandPackage), and status monitoring (StatusPackage). It handles routing and network management automatically, so you can focus on your application. The library uses JSON-based messaging and syncs time across all nodes, making it ideal for coordinated behaviour like synchronized light displays or sensor networks reporting to a central node.",
   "keywords": [
     "arduino",

package/src/AlteriomPainlessMesh.h

@@ -29,10 +29,10 @@
 /**
  * @brief AlteriomPainlessMesh library version information
  */
-#define ALTERIOM_PAINLESS_MESH_VERSION "1.9.12"
+#define ALTERIOM_PAINLESS_MESH_VERSION "1.9.13"
 #define ALTERIOM_PAINLESS_MESH_VERSION_MAJOR 1
 #define ALTERIOM_PAINLESS_MESH_VERSION_MINOR 9
-#define ALTERIOM_PAINLESS_MESH_VERSION_PATCH 12
+#define ALTERIOM_PAINLESS_MESH_VERSION_PATCH 13
 
 /**
  * @brief Library description and usage information

package/src/painlessMesh.h

@@ -5,8 +5,8 @@
  * @file painlessMesh.h
  * @brief Main header file for Alteriom painlessMesh library
  * 
- * @version 1.9.12
- * @date 2025-12-18
+ * @version 1.9.13
+ * @date 2025-12-19
  * 
  * painlessMesh is a user-friendly library for creating mesh networks with 
  * ESP8266 and ESP32 devices. This Alteriom fork includes additional packages 

package/src/painlessmesh/connection.hpp

@@ -124,10 +124,10 @@ inline void scheduleAsyncClientDeletion(Scheduler* scheduler, AsyncClient* clien
     using namespace logger;
     Log(CONNECTION, "%s: Deferred cleanup of AsyncClient executing now\n", logPrefix);
     
-    // Update the last deletion time when the deletion actually executes
-    // This ensures subsequent deletions are spaced from the actual execution time,
-    // not just the scheduled time, preventing concurrent cleanup operations
-    lastScheduledDeletionTime = millis();
+    // Note: lastScheduledDeletionTime is updated at scheduling time (before this task runs), not here
+    // This ensures consistent spacing based on when deletions were scheduled, preventing
+    // the race condition where execution-time updates could "rewind" the timestamp
+    // and cause subsequent deletions to be scheduled too close together
     
     delete client;
   });

package/src/painlessmesh/mesh.hpp

@@ -1503,13 +1503,63 @@ class Mesh : public ntp::MeshTime, public plugin::PackageHandler<T> {
 
     PendingInternetRequest& request = it->second;
 
-    // Call user callback
-    if (request.callback) {
-      request.callback(ack.success, ack.httpStatus, ack.error);
+    // Check if this is a success response
+    if (ack.success) {
+      // Success - call callback and remove request
+      if (request.callback) {
+        request.callback(ack.success, ack.httpStatus, ack.error);
+      }
+      pendingInternetRequests.erase(it);
+      return;
+    }
+
+    // Failure response - determine if retryable
+    bool isRetryable = false;
+    
+    // HTTP 203 (Non-Authoritative Information) indicates cached/proxied response
+    // This is often temporary and retrying may succeed when cache expires
+    if (ack.httpStatus == 203) {
+      isRetryable = true;
+      Log(COMMUNICATION, "handleGatewayAck(): HTTP 203 detected, marking as retryable\n");
+    }
+    // HTTP 5xx server errors are typically transient
+    else if (ack.httpStatus >= 500 && ack.httpStatus < 600) {
+      isRetryable = true;
+      Log(COMMUNICATION, "handleGatewayAck(): HTTP 5xx server error, marking as retryable\n");
+    }
+    // HTTP 429 (Too Many Requests) should be retried with backoff
+    else if (ack.httpStatus == 429) {
+      isRetryable = true;
+      Log(COMMUNICATION, "handleGatewayAck(): HTTP 429 rate limit, marking as retryable\n");
     }
+    // Network errors (httpStatus == 0) are retryable
+    else if (ack.httpStatus == 0) {
+      isRetryable = true;
+      Log(COMMUNICATION, "handleGatewayAck(): Network error, marking as retryable\n");
+    }
+    // HTTP 4xx client errors (except 429) are NOT retryable
+    // HTTP 3xx redirects are NOT retryable (should be followed by HTTPClient)
+    // Other status codes are NOT retryable
 
-    // Remove from pending
-    pendingInternetRequests.erase(it);
+    // If retryable and have retries left, schedule retry
+    if (isRetryable && request.retryCount < request.maxRetries) {
+      Log(COMMUNICATION, "handleGatewayAck(): Scheduling retry for msgId=%u (attempt %u/%u)\n",
+          ack.messageId, request.retryCount + 1, request.maxRetries);
+      scheduleInternetRetry(ack.messageId);
+    } else {
+      // Not retryable or max retries reached - call callback and remove
+      if (request.retryCount >= request.maxRetries) {
+        Log(ERROR, "handleGatewayAck(): Max retries reached for msgId=%u\n", ack.messageId);
+      } else {
+        Log(COMMUNICATION, "handleGatewayAck(): Non-retryable failure for msgId=%u (HTTP %u)\n",
+            ack.messageId, ack.httpStatus);
+      }
+      
+      if (request.callback) {
+        request.callback(ack.success, ack.httpStatus, ack.error);
+      }
+      pendingInternetRequests.erase(it);
+    }
   }
 
   /**