@aloth/olcli 0.15.3 → 0.16.1

package/dist/client.js

@@ -18,16 +18,28 @@ import * as cheerio from 'cheerio';
 import { readFileSync } from 'node:fs';
 import { dirname, join } from 'node:path';
 import { fileURLToPath } from 'node:url';
-import * as https from 'node:https';
-import * as http from 'node:http';
+import { routeRequest } from './proxy.js';
 import { RejectConflictError, buildUserDirectory, planRejection, renderRejectionDiff, describeAuthor, parseHistoryOtChanges, parseShareJsChanges } from './tracked-changes.js';
 import { planEntityMove } from './move-plan.js';
+import { matchProject } from './project-match.js';
+import { HttpStatusError, SessionExpiredError, httpError, isAuthStatus } from './errors.js';
 // Read version from package.json
 const __dirname = dirname(fileURLToPath(import.meta.url));
 const pkg = JSON.parse(readFileSync(join(__dirname, '..', 'package.json'), 'utf-8'));
 const USER_AGENT = `olcli/${pkg.version}`;
 const DEFAULT_BASE_URL = 'https://www.overleaf.com';
 const RESOURCE_PATH_FAILURE_HINT = ' (Perhaps the resource file you specified does not exist in the project?)';
+/**
+ * True when a redirect from `fromUrl` points at Overleaf's login page. A
+ * request to /login itself is the password flow and is never treated as one.
+ */
+export function isLoginRedirect(fromUrl, location) {
+    const from = new URL(fromUrl);
+    if (from.pathname === '/login')
+        return false;
+    const target = new URL(location, fromUrl);
+    return target.pathname === '/login' || target.pathname.endsWith('/login');
+}
 export const DEFAULT_COMMENT_CONCURRENCY = 4;
 export const MAX_COMMENT_CONCURRENCY = 8;
 /**
@@ -51,6 +63,8 @@ export class OverleafClient {
     csrf;
     baseUrl;
     verbose = false;
+    /** Email of the signed-in account, when the bootstrap page named it. */
+    accountEmail;
     timeoutMs = 10000;
     // Cache per-project folder trees so repeated uploads in sync/upload calls
     // don't re-fetch the tree via Socket.IO on every file.
@@ -163,21 +177,23 @@ export class OverleafClient {
             expect: 'text'
         });
         if (!response.ok) {
-            throw new Error(`Failed to fetch projects page: ${response.status}`);
+            throw httpError('Failed to fetch projects page', response.status);
         }
         bootstrapClient.applySetCookieHeaders(response.headers['set-cookie']);
         const html = response.body;
         const $ = cheerio.load(html);
         if (OverleafClient.isLoginPage($)) {
-            throw new Error('Authentication required. Session may have expired.');
+            throw new SessionExpiredError('Overleaf answered with its login page');
         }
         const csrf = OverleafClient.extractCsrfToken($);
         if (!csrf) {
-            throw new Error('Could not find CSRF token. Session may have expired.');
+            throw new SessionExpiredError('No CSRF token on the project page');
         }
         // Update cookies if the bootstrap request added anything
         const updatedCookies = bootstrapClient.cookies;
-        return new OverleafClient({ cookies: updatedCookies, csrf, baseUrl });
+        const client = new OverleafClient({ cookies: updatedCookies, csrf, baseUrl });
+        client.accountEmail = OverleafClient.extractAccountEmail($);
+        return client;
     }
     /**
      * Create client by submitting Overleaf's email/password login form.
@@ -189,7 +205,7 @@ export class OverleafClient {
             expect: 'text'
         });
         if (!loginPage.ok) {
-            throw new Error(`Failed to fetch login page: ${loginPage.status}`);
+            throw new HttpStatusError('Failed to fetch login page', loginPage.status);
         }
         bootstrapClient.applySetCookieHeaders(loginPage.headers['set-cookie']);
         const loginHtml = loginPage.body;
@@ -223,7 +239,7 @@ export class OverleafClient {
             if (loginFailure) {
                 throw new Error('Password login failed. Email or password may be incorrect.');
             }
-            throw new Error(`Password login failed: ${loginResponse.status}`);
+            throw new HttpStatusError('Password login failed', loginResponse.status);
         }
         const projectUrl = new URL(loginResponse.headers.location || '/project', baseUrl).toString();
         const projectPage = await bootstrapClient.httpRequest(projectUrl, {
@@ -234,7 +250,7 @@ export class OverleafClient {
             expect: 'text'
         });
         if (!projectPage.ok) {
-            throw new Error(`Failed to fetch projects page after login: ${projectPage.status}`);
+            throw httpError('Failed to fetch projects page after login', projectPage.status);
         }
         bootstrapClient.applySetCookieHeaders(projectPage.headers['set-cookie']);
         const projectHtml = projectPage.body;
@@ -246,7 +262,9 @@ export class OverleafClient {
         if (!projectCsrf) {
             throw new Error('Could not find CSRF token after password login.');
         }
-        return new OverleafClient({ cookies: bootstrapClient.cookies, csrf: projectCsrf, baseUrl });
+        const client = new OverleafClient({ cookies: bootstrapClient.cookies, csrf: projectCsrf, baseUrl });
+        client.accountEmail = OverleafClient.extractAccountEmail($project) ?? email;
+        return client;
     }
     /**
      * Pull the CSRF token out of a rendered Overleaf page.
@@ -282,6 +300,28 @@ export class OverleafClient {
         }
         return csrf;
     }
+    /**
+     * The signed-in account's email from a rendered Overleaf page, when the
+     * page carries one. `ol-usersEmail` is on the project dashboard; `ol-user`
+     * (JSON) is on the editor and on older releases. Display only.
+     */
+    static extractAccountEmail($) {
+        const direct = $('meta[name="ol-usersEmail"]').attr('content');
+        if (direct)
+            return direct;
+        const user = $('meta[name="ol-user"]').attr('content');
+        if (user) {
+            try {
+                const parsed = JSON.parse(user);
+                if (typeof parsed?.email === 'string' && parsed.email)
+                    return parsed.email;
+            }
+            catch {
+                // Not JSON on this release; no email to show.
+            }
+        }
+        return undefined;
+    }
     static isLoginPage($) {
         return $('form[name="loginForm"]').length > 0 || $('input[name="password"]').length > 0;
     }
@@ -349,12 +389,25 @@ export class OverleafClient {
         }
         const doRequest = (reqUrl, redirectsLeft) => {
             return new Promise((resolve, reject) => {
-                const parsedUrl = new URL(reqUrl);
-                const transport = parsedUrl.protocol === 'https:' ? https : http;
                 const headers = this.normalizeHeaders({ ...extraHeaders, ...options.headers });
-                const req = transport.request(reqUrl, { method, headers }, (res) => {
+                // HTTPS_PROXY / HTTP_PROXY / NO_PROXY: every request, the socket
+                // polling included, goes through here. See src/proxy.ts.
+                const route = routeRequest(reqUrl, headers);
+                if (route.proxy)
+                    this.logVerbose(`${method} ${reqUrl} via proxy ${route.proxy.host}`);
+                const req = route.transport.request(route.url, { ...route.options, method }, (res) => {
                     const status = res.statusCode || 0;
                     const resHeaders = res.headers;
+                    // Overleaf answers an expired session on any page with a redirect to
+                    // /login. Following it would hand an HTML login form to a caller
+                    // that expected JSON or a zip, and the user would see a parse error.
+                    if (status >= 300 && status < 400 && res.headers.location
+                        && isLoginRedirect(reqUrl, res.headers.location)) {
+                        this.logVerbose(`${method} ${reqUrl} -> ${status} redirect to login page`);
+                        res.resume();
+                        reject(new SessionExpiredError(`HTTP ${status} redirect to the login page from ${new URL(reqUrl).pathname}`, status));
+                        return;
+                    }
                     if (status >= 300 && status < 400 && res.headers.location && redirectsLeft > 0) {
                         this.logVerbose(`${method} ${reqUrl} -> ${status} redirect -> ${res.headers.location}`);
                         const redirectUrl = new URL(res.headers.location, reqUrl).toString();
@@ -416,7 +469,7 @@ export class OverleafClient {
             expect: 'text'
         });
         if (!response.ok) {
-            throw new Error(`Failed to fetch projects: ${response.status}`);
+            throw httpError('Failed to fetch projects', response.status);
         }
         this.applySetCookieHeaders(response.headers['set-cookie']);
         const html = response.body;
@@ -489,6 +542,19 @@ export class OverleafClient {
         const projects = await this.listProjects();
         return projects.find(p => p.name === name);
     }
+    /**
+     * Find a project by ID or by what a user typed for its name: exact name,
+     * then case-insensitive, then a unique prefix. Throws ProjectNotFoundError
+     * (with "Did you mean" suggestions) or AmbiguousProjectError.
+     * `getProject` keeps its exact-match contract for library callers.
+     */
+    async findProject(query) {
+        const projects = await this.listProjects();
+        const byId = projects.find(p => p.id === query);
+        if (byId)
+            return byId;
+        return matchProject(projects, query);
+    }
     /**
      * Get project by ID
      */
@@ -518,7 +584,7 @@ export class OverleafClient {
             expect: 'json'
         });
         if (!response.ok) {
-            throw new Error(`Failed to create project: ${response.status}`);
+            throw httpError('Failed to create project', response.status);
         }
         this.applySetCookieHeaders(response.headers['set-cookie']);
         const projectId = response.body?.project_id;
@@ -541,7 +607,7 @@ export class OverleafClient {
             expect: 'text'
         });
         if (!response.ok) {
-            throw new Error(`Failed to fetch project info: ${response.status}`);
+            throw httpError('Failed to fetch project info', response.status);
         }
         this.applySetCookieHeaders(response.headers['set-cookie']);
         const html = response.body;
@@ -697,7 +763,7 @@ export class OverleafClient {
             timeoutMs
         });
         if (!response.ok) {
-            throw new Error(`Download failed: ${response.status}`);
+            throw httpError('Download failed', response.status);
         }
         this.applySetCookieHeaders(response.headers['set-cookie']);
         return response.body;
@@ -722,7 +788,7 @@ export class OverleafClient {
             expect: 'json'
         });
         if (!response.ok) {
-            throw new Error(`Failed to compile project: ${response.status}`);
+            throw httpError('Failed to compile project', response.status);
         }
         this.applySetCookieHeaders(response.headers['set-cookie']);
         const data = response.body;
@@ -770,7 +836,7 @@ export class OverleafClient {
             throw new Error('Folder already exists');
         }
         if (!response.ok) {
-            throw new Error(`Failed to create folder: ${response.status}`);
+            throw httpError('Failed to create folder', response.status);
         }
         this.applySetCookieHeaders(response.headers['set-cookie']);
         const data = response.body;
@@ -894,9 +960,7 @@ export class OverleafClient {
             timeoutMs: 5000
         });
         if (!handshakeResponse.ok) {
-            const error = new Error(`Failed to open project socket: ${handshakeResponse.status}`);
-            error.status = handshakeResponse.status;
-            throw error;
+            throw httpError('Failed to open project socket', handshakeResponse.status);
         }
         this.applySetCookieHeaders(handshakeResponse.headers['set-cookie']);
         const sid = handshakeResponse.body.trim().split(':')[0];
@@ -932,7 +996,7 @@ export class OverleafClient {
             timeoutMs: 7000
         });
         if (!response.ok) {
-            throw new Error(`Socket poll failed: ${response.status}`);
+            throw httpError('Socket poll failed', response.status);
         }
         this.applySetCookieHeaders(response.headers['set-cookie']);
         const packets = this.decodeSocketIoPayload(response.body);
@@ -967,7 +1031,7 @@ export class OverleafClient {
             timeoutMs: 5000
         });
         if (!response.ok) {
-            throw new Error(`Socket post failed: ${response.status}`);
+            throw httpError('Socket post failed', response.status);
         }
         this.applySetCookieHeaders(response.headers['set-cookie']);
     }
@@ -1468,6 +1532,8 @@ export class OverleafClient {
                 expect: 'text'
             });
             if (!response.ok) {
+                if (isAuthStatus(response.status))
+                    throw httpError('Failed to upload file', response.status);
                 const text = response.body;
                 // Overleaf returns folder_not_found as HTTP 422 JSON.
                 // Parse the body first so caller can trigger folder probing fallback.
@@ -1531,7 +1597,7 @@ export class OverleafClient {
             expect: 'text'
         });
         if (!response.ok) {
-            throw new Error(`Failed to delete entity: ${response.status}`);
+            throw httpError('Failed to delete entity', response.status);
         }
         this.applySetCookieHeaders(response.headers['set-cookie']);
     }
@@ -1544,7 +1610,7 @@ export class OverleafClient {
             expect: 'json'
         });
         if (!response.ok) {
-            throw new Error(`Failed to get entities: ${response.status}`);
+            throw httpError('Failed to get entities', response.status);
         }
         this.applySetCookieHeaders(response.headers['set-cookie']);
         const data = response.body;
@@ -1598,7 +1664,7 @@ export class OverleafClient {
             expect: fileType === 'doc' ? 'json' : 'buffer'
         });
         if (!response.ok) {
-            throw new Error(`Failed to download file: ${response.status}`);
+            throw httpError('Failed to download file', response.status);
         }
         this.applySetCookieHeaders(response.headers['set-cookie']);
         if (fileType === 'doc') {
@@ -1622,7 +1688,7 @@ export class OverleafClient {
             expect: 'text'
         });
         if (!response.ok) {
-            throw new Error(`Failed to rename entity: ${response.status}`);
+            throw httpError('Failed to rename entity', response.status);
         }
         this.applySetCookieHeaders(response.headers['set-cookie']);
     }
@@ -1645,7 +1711,7 @@ export class OverleafClient {
             expect: 'text'
         });
         if (!response.ok) {
-            throw new Error(`Failed to rename project: ${response.status}`);
+            throw httpError('Failed to rename project', response.status);
         }
         this.applySetCookieHeaders(response.headers['set-cookie']);
     }
@@ -1672,7 +1738,7 @@ export class OverleafClient {
         });
         if (!response.ok) {
             const detail = typeof response.body === 'string' && response.body.trim() ? ` (${response.body.trim().slice(0, 200)})` : '';
-            throw new Error(`Failed to move entity: ${response.status}${detail}`);
+            throw httpError('Failed to move entity', response.status, detail.trim());
         }
         this.applySetCookieHeaders(response.headers['set-cookie']);
     }
@@ -1798,7 +1864,7 @@ export class OverleafClient {
             expect: 'json'
         });
         if (!response.ok) {
-            throw new Error(`Failed to fetch comment threads: ${response.status}`);
+            throw httpError('Failed to fetch comment threads', response.status);
         }
         this.applySetCookieHeaders(response.headers['set-cookie']);
         return response.body;
@@ -2032,7 +2098,7 @@ export class OverleafClient {
                 expect: 'text'
             });
             if (!response.ok) {
-                throw new Error(`Failed to accept tracked changes in ${changes[0].path}: ${response.status}`);
+                throw httpError(`Failed to accept tracked changes in ${changes[0].path}`, response.status);
             }
             this.applySetCookieHeaders(response.headers['set-cookie']);
         }
@@ -2179,7 +2245,7 @@ export class OverleafClient {
             expect: 'text'
         });
         if (!response.ok) {
-            throw new Error(`Failed to resolve comment: ${response.status}`);
+            throw httpError('Failed to resolve comment', response.status);
         }
         this.applySetCookieHeaders(response.headers['set-cookie']);
         return comment;
@@ -2193,7 +2259,7 @@ export class OverleafClient {
             expect: 'text'
         });
         if (!response.ok) {
-            throw new Error(`Failed to reopen comment: ${response.status}`);
+            throw httpError('Failed to reopen comment', response.status);
         }
         this.applySetCookieHeaders(response.headers['set-cookie']);
         return comment;
@@ -2207,7 +2273,7 @@ export class OverleafClient {
             expect: 'text'
         });
         if (!response.ok) {
-            throw new Error(`Failed to delete comment: ${response.status}`);
+            throw httpError('Failed to delete comment', response.status);
         }
         this.applySetCookieHeaders(response.headers['set-cookie']);
         return comment;
@@ -2313,7 +2379,7 @@ export class OverleafClient {
             expect: 'text'
         });
         if (!response.ok) {
-            throw new Error(`Failed to post comment message: ${response.status}`);
+            throw httpError('Failed to post comment message', response.status);
         }
         this.applySetCookieHeaders(response.headers['set-cookie']);
         if (!response.body)
@@ -2336,7 +2402,7 @@ export class OverleafClient {
             expect: 'json'
         });
         if (!response.ok) {
-            throw new Error(`Failed to compile project: ${response.status}`);
+            throw httpError('Failed to compile project', response.status);
         }
         this.applySetCookieHeaders(response.headers['set-cookie']);
         const data = response.body;