@almadar/eslint-plugin 2.17.0 → 2.19.0

package/index.js

@@ -8,6 +8,7 @@ const templateNoIteration = require("./rules/template-no-iteration");
 const templateSerializableProps = require("./rules/template-serializable-props");
 const noTypeProp = require("./rules/no-type-prop");
 const noAsAny = require("./rules/no-as-any");
+const noAsUnknownAs = require("./rules/no-as-unknown-as");
 const noUnknownType = require("./rules/no-unknown-type");
 const noRecordStringUnknown = require("./rules/no-record-string-unknown");
 const noEntityStringType = require("./rules/no-entity-string-type");
@@ -70,6 +71,7 @@ const plugin = {
     "template-serializable-props": templateSerializableProps,
     "no-type-prop": noTypeProp,
     "no-as-any": noAsAny,
+    "no-as-unknown-as": noAsUnknownAs,
     "no-unknown-type": noUnknownType,
     "no-record-string-unknown": noRecordStringUnknown,
     "no-entity-string-type": noEntityStringType,
@@ -136,6 +138,7 @@ plugin.configs.recommended = {
     "almadar/template-serializable-props": "error",
     "almadar/no-type-prop": "error",
     "almadar/no-as-any": "error",
+    "almadar/no-as-unknown-as": "error",
     "almadar/no-unknown-type": "error",
     "almadar/no-record-string-unknown": "error",
     "almadar/no-entity-string-type": "error",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@almadar/eslint-plugin",
-  "version": "2.17.0",
+  "version": "2.19.0",
   "private": false,
   "description": "Custom ESLint rules for Almadar component architecture",
   "main": "index.js",
@@ -14,6 +14,7 @@
   },
   "devDependencies": {
     "eslint": "10.0.0",
+    "@typescript-eslint/parser": "^8.65.0",
     "turbo": "^2.8.17"
   },
   "repository": {
@@ -28,6 +29,7 @@
     "jsonc-eslint-parser": "3.1.0"
   },
   "scripts": {
-    "lint": "eslint index.js rules/ utils/"
+    "lint": "eslint index.js rules/ utils/",
+    "test": "node --test"
   }
 }

package/rules/no-as-unknown-as.js

@@ -0,0 +1,46 @@
+"use strict";
+
+/**
+ * Forbid the `x as unknown as T` double-cast chain (CLAUDE.md "Type safety —
+ * Zero `as any` / `unknown` / `as unknown as X`"). The pattern routes an
+ * arbitrarily-typed value through `unknown` purely to defeat structural
+ * checking before landing it on a target type — the value is never actually
+ * narrowed, so the compiler stops verifying the cast at all.
+ *
+ * Flags a `TSAsExpression` whose own expression is itself a `TSAsExpression`
+ * to `unknown` — i.e. an `as unknown` that exists only as a step toward
+ * another cast, not a value genuinely left as `unknown`. A terminal
+ * `x as unknown` (nothing casts it further) is not itself reported by this
+ * rule — `almadar/no-unknown-type` already owns flagging bare `unknown`.
+ */
+module.exports = {
+  meta: {
+    type: "problem",
+    docs: {
+      description:
+        "Disallow the `x as unknown as T` double-cast chain — type the value or parse it instead",
+      category: "Almadar Architecture",
+    },
+    messages: {
+      noAsUnknownAs:
+        "Double cast via `as unknown as` is forbidden (CLAUDE.md type-safety rule) — type the value or parse it",
+    },
+    schema: [],
+  },
+
+  create(context) {
+    return {
+      TSAsExpression(node) {
+        const inner = node.expression;
+        if (
+          inner &&
+          inner.type === "TSAsExpression" &&
+          inner.typeAnnotation &&
+          inner.typeAnnotation.type === "TSUnknownKeyword"
+        ) {
+          context.report({ node, messageId: "noAsUnknownAs" });
+        }
+      },
+    };
+  },
+};

package/rules/no-record-string-unknown.js

@@ -5,7 +5,7 @@ module.exports = {
     type: "problem",
     docs: {
       description:
-        "Disallow Record<string, unknown>, Record<string, any>, and 'as unknown as' double casts. Use @almadar/core types instead.",
+        "Disallow Record<string, unknown> and Record<string, any>. Use @almadar/core types instead. (The 'as unknown as' double-cast check moved to almadar/no-as-unknown-as.)",
       category: "Almadar Architecture",
     },
     messages: {
@@ -13,8 +13,6 @@ module.exports = {
         "Use a typed interface from @almadar/core instead of Record<string, unknown>. Common replacements: OrbitalSchema, Entity, Trait, Field, PatternConfig, Effect, Transition, PayloadField.",
       noRecordStringAny:
         "Record<string, any> is never acceptable. Use Record<string, unknown> at minimum, or a proper @almadar/core type.",
-      noDoubleUnknownCast:
-        "Avoid 'as unknown as' double casts. Use a type guard, define a proper interface, or extend @almadar/core types.",
     },
     schema: [],
   },
@@ -48,18 +46,6 @@ module.exports = {
           }
         }
       },
-
-      // Catch: as unknown as X (double cast)
-      TSAsExpression(node) {
-        if (
-          node.typeAnnotation &&
-          node.typeAnnotation.type === "TSUnknownKeyword" &&
-          node.parent &&
-          node.parent.type === "TSAsExpression"
-        ) {
-          context.report({ node: node.parent, messageId: "noDoubleUnknownCast" });
-        }
-      },
     };
   },
 };