@allthings/eslint-config 3.8.0 → 4.0.0-beta.1

package/README.md

@@ -68,6 +68,33 @@ export default [
 ]
 ```
 
+## Using with ESLint 10
+
+The config supports both ESLint 9 and ESLint 10 (`peerDependencies.eslint: ">=9.33.0 <11"`). Two things to know:
+
+**Yarn install will print peer-dep warnings** for `eslint-plugin-react` and `eslint-plugin-jsx-a11y` on ESLint 10 — both plugins still cap their declared peer at `^9` but work correctly at runtime. The warnings are cosmetic; you can ignore them or silence via `YN0086` log filter in `.yarnrc.yml`. They go away when upstream releases land (tracked in [jsx-eslint/eslint-plugin-react#3977](https://github.com/jsx-eslint/eslint-plugin-react/issues/3977)).
+
+**React version is hardcoded to `'18.3'`** in `index.js`. If your project is on React 19, override it in your own config so version-specific rules behave correctly:
+
+```js
+import allthingsConfig from '@allthings/eslint-config'
+
+export default [
+  ...allthingsConfig,
+  {
+    languageOptions: {
+      parserOptions: {
+        project: './tsconfig.json',
+        tsconfigRootDir: import.meta.dirname,
+      },
+    },
+    settings: { react: { version: '19.1' } },
+  },
+]
+```
+
+Do **not** set `settings.react.version: 'detect'` on ESLint 10 — it triggers a `context.getFilename is not a function` runtime crash in `eslint-plugin-react@7.37.5` (the very reason we hardcode a string default). The crash is fixed in [PR #3972](https://github.com/jsx-eslint/eslint-plugin-react/pull/3972) but not yet released.
+
 ## Development
 
 Run `yarn link` in the project folder

package/base.js

@@ -1,7 +1,6 @@
 import stylisticPlugin from '@stylistic/eslint-plugin'
 import jestPlugin from 'eslint-plugin-jest'
 import perfectionistPlugin from 'eslint-plugin-perfectionist'
-import preferArrowPlugin from 'eslint-plugin-prefer-arrow'
 import simpleImportSortPlugin from 'eslint-plugin-simple-import-sort'
 import globals from 'globals'
 
@@ -18,10 +17,10 @@ export const baseParserOptions = {
 }
 
 export const baseSettings = {
-  'import/parsers': {
+  'import-x/parsers': {
     '@typescript-eslint/parser': ['.ts', '.mts', '.cts', '.tsx', '.d.ts'],
   },
-  'import/resolver': {
+  'import-x/resolver': {
     node: { extensions: ['.js', '.jsx', '.ts', '.tsx'] },
     typescript: { alwaysTryTypes: true },
   },
@@ -31,7 +30,6 @@ export const basePlugins = {
   '@stylistic': stylisticPlugin,
   jest: jestPlugin,
   perfectionist: perfectionistPlugin,
-  'prefer-arrow': preferArrowPlugin,
   'simple-import-sort': simpleImportSortPlugin,
 }
 
@@ -134,6 +132,7 @@ export const baseRules = {
   ],
   'constructor-super': 'error',
   eqeqeq: ['error', 'smart'],
+  'func-style': ['warn', 'expression'],
   'guard-for-in': 'error',
   'id-denylist': [
     'error',
@@ -148,7 +147,7 @@ export const baseRules = {
     'undefined',
   ],
   'id-match': 'error',
-  'import/no-anonymous-default-export': [
+  'import-x/no-anonymous-default-export': [
     'error',
     {
       allowAnonymousClass: false,
@@ -161,7 +160,7 @@ export const baseRules = {
       allowObject: true,
     },
   ],
-  'import/no-extraneous-dependencies': [
+  'import-x/no-extraneous-dependencies': [
     'error',
     {
       devDependencies: true,
@@ -204,7 +203,7 @@ export const baseRules = {
   'perfectionist/sort-heritage-clauses': 'error',
   'perfectionist/sort-interfaces': 'error',
   'perfectionist/sort-object-types': 'error',
-  'prefer-arrow/prefer-arrow-functions': 'warn',
+  'prefer-arrow-callback': 'warn',
   'prefer-const': 'error',
   'prefer-object-spread': 'error',
   'prefer-template': 'error',

package/index.js

@@ -1,6 +1,6 @@
 import tsPlugin from '@typescript-eslint/eslint-plugin'
 import vitestPlugin from '@vitest/eslint-plugin'
-import importPlugin from 'eslint-plugin-import'
+import { flatConfigs as importFlatConfigs } from 'eslint-plugin-import-x'
 import jsxA11yPlugin from 'eslint-plugin-jsx-a11y'
 import prettierConfig from 'eslint-plugin-prettier/recommended'
 import reactPlugin from 'eslint-plugin-react'
@@ -21,12 +21,12 @@ const config = [
   ...tsPlugin.configs['flat/recommended-type-checked'],
   ...tsPlugin.configs['flat/stylistic-type-checked'],
   unicornPlugin.configs['flat/recommended'],
-  importPlugin.flatConfigs.recommended,
-  importPlugin.flatConfigs.typescript,
+  importFlatConfigs.recommended,
+  importFlatConfigs.typescript,
   reactPlugin.configs.flat.recommended,
   reactPlugin.configs.flat['jsx-runtime'],
   jsxA11yPlugin.flatConfigs.recommended,
-  reactHooksPlugin.configs['recommended-latest'],
+  reactHooksPlugin.configs.flat['recommended-latest'],
   vitestPlugin.configs.recommended,
   {
     languageOptions: {
@@ -72,7 +72,7 @@ const config = [
     },
     settings: {
       ...baseSettings,
-      react: { version: 'detect' },
+      react: { version: '18.3' },
     },
   },
   baseTestOverrides,

package/node.js

@@ -1,6 +1,6 @@
 import tsPlugin from '@typescript-eslint/eslint-plugin'
 import vitestPlugin from '@vitest/eslint-plugin'
-import importPlugin from 'eslint-plugin-import'
+import { flatConfigs as importFlatConfigs } from 'eslint-plugin-import-x'
 import prettierConfig from 'eslint-plugin-prettier/recommended'
 import unicornPlugin from 'eslint-plugin-unicorn'
 
@@ -17,8 +17,8 @@ const config = [
   ...tsPlugin.configs['flat/recommended-type-checked'],
   ...tsPlugin.configs['flat/stylistic-type-checked'],
   unicornPlugin.configs['flat/recommended'],
-  importPlugin.flatConfigs.recommended,
-  importPlugin.flatConfigs.typescript,
+  importFlatConfigs.recommended,
+  importFlatConfigs.typescript,
   vitestPlugin.configs.recommended,
   {
     languageOptions: {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@allthings/eslint-config",
-  "version": "3.8.0",
+  "version": "4.0.0-beta.1",
   "type": "module",
   "description": "ESlint shareable config for Allthings style",
   "main": "index.js",
@@ -38,20 +38,19 @@
     "eslint-import-resolver-node": "^0.4.0",
     "eslint-import-resolver-typescript": "^4.4.4",
     "eslint-plugin-functional": "^9.0.5",
-    "eslint-plugin-import": "^2.32.0",
+    "eslint-plugin-import-x": "^4.16.2",
     "eslint-plugin-jest": "^29.0.0",
     "eslint-plugin-jsx-a11y": "^6.10.2",
     "eslint-plugin-perfectionist": "^5.9.0",
-    "eslint-plugin-prefer-arrow": "^1.2.3",
     "eslint-plugin-prettier": "^5.5.4",
     "eslint-plugin-react": "^7.37.5",
-    "eslint-plugin-react-hooks": "^5.2.0",
+    "eslint-plugin-react-hooks": "^7.1.1",
     "eslint-plugin-simple-import-sort": "^13.0.0",
     "eslint-plugin-unicorn": "^64.0.0",
     "globals": "^17.0.0"
   },
   "peerDependencies": {
-    "eslint": ">=9.33.0",
+    "eslint": ">=9.33.0 <11",
     "prettier": ">=3.8.0",
     "typescript": ">=5.9.0"
   },
@@ -59,7 +58,7 @@
     "@types/jest": "30.0.0",
     "@types/react": "18.3.28",
     "conventional-changelog-conventionalcommits": "9.3.1",
-    "eslint": "9.39.4",
+    "eslint": "10.4.0",
     "husky": "9.1.7",
     "prettier": "3.8.3",
     "react": "18.3.1",