@allthings/eslint-config 1.0.0 → 1.1.0

package/README.md

@@ -40,7 +40,7 @@ yarn deploy
 
 Run `yarn link` in the project folder
 
-Run `yarn link @allthings/eslint-config` in the project that you want to test it against 
+Run `yarn link @allthings/eslint-config` in the project that you want to test it against
 
 After you finish run in your project `yarn unlink @allthings/eslint-config` and then `yarn install --force`
 to restore the initial state of dependencies

package/index.js

@@ -30,6 +30,7 @@ sortedPaths.push(...keptPaths)
 
 const hookPropertyMap = new Map(
   [
+    ['eslint-plugin-jest', 'eslint-plugin-jest'],
     ['eslint-plugin-import', 'eslint-plugin-import'],
     ['eslint-plugin-react', 'eslint-plugin-react'],
     ['eslint-plugin-react-hooks', 'eslint-plugin-react-hooks'],
@@ -38,6 +39,7 @@ const hookPropertyMap = new Map(
       'eslint-plugin-typescript-sort-keys',
       'eslint-plugin-typescript-sort-keys',
     ],
+    ['eslint-plugin-prefer-arrow', 'eslint-plugin-prefer-arrow'],
     ['eslint-plugin-simple-import-sort', 'eslint-plugin-simple-import-sort'],
   ].map(([request, replacement]) => [
     request,
@@ -71,14 +73,82 @@ module.exports = {
     'plugin:prettier/recommended',
   ],
   plugins: [
+    'jest',
     'import',
     'react',
     'react-hooks',
     'jsx-a11y',
     'typescript-sort-keys',
+    'prefer-arrow',
     'simple-import-sort',
   ],
   rules: {
+    '@typescript-eslint/adjacent-overload-signatures': 'error',
+    '@typescript-eslint/array-type': [
+      'error',
+      {
+        default: 'array',
+      },
+    ],
+    '@typescript-eslint/ban-types': [
+      'error',
+      {
+        types: {
+          Object: {
+            message: 'Avoid using the `Object` type. Did you mean `object`?',
+          },
+          Function: {
+            message:
+              'Avoid using the `Function` type. Prefer a specific function type, like `() => void`.',
+          },
+          Boolean: {
+            message: 'Avoid using the `Boolean` type. Did you mean `boolean`?',
+          },
+          Number: {
+            message: 'Avoid using the `Number` type. Did you mean `number`?',
+          },
+          String: {
+            message: 'Avoid using the `String` type. Did you mean `string`?',
+          },
+          Symbol: {
+            message: 'Avoid using the `Symbol` type. Did you mean `symbol`?',
+          },
+        },
+      },
+    ],
+    '@typescript-eslint/consistent-type-assertions': 'error',
+    '@typescript-eslint/explicit-function-return-type': [
+      'warn', // TODO: strict later
+      {
+        allowExpressions: false,
+        allowTypedFunctionExpressions: false,
+        allowHigherOrderFunctions: false,
+        allowDirectConstAssertionInArrowFunctions: true,
+        allowConciseArrowFunctionExpressionsStartingWithVoid: true,
+      },
+    ],
+    '@typescript-eslint/explicit-module-boundary-types': [
+      'warn', // TODO: strict later
+      {
+        allowArgumentsExplicitlyTypedAsAny: true,
+        allowDirectConstAssertionInArrowFunctions: true,
+        allowHigherOrderFunctions: false,
+        allowTypedFunctionExpressions: false,
+      },
+    ],
+    '@typescript-eslint/member-delimiter-style': [
+      'error',
+      {
+        multiline: {
+          delimiter: 'none',
+          requireLast: true,
+        },
+        singleline: {
+          delimiter: 'semi',
+          requireLast: false,
+        },
+      },
+    ],
     '@typescript-eslint/naming-convention': [
       'error',
       {
@@ -90,7 +160,69 @@ module.exports = {
         selector: 'interface',
       },
     ],
+    '@typescript-eslint/no-empty-function': 'error',
+    '@typescript-eslint/no-empty-interface': 'error',
+    '@typescript-eslint/no-explicit-any': 'error',
+    '@typescript-eslint/no-for-in-array': 'error',
+    '@typescript-eslint/no-inferrable-types': 'error',
+    '@typescript-eslint/no-misused-new': 'error',
+    '@typescript-eslint/no-namespace': 'error',
+    '@typescript-eslint/no-shadow': [
+      'error',
+      {
+        hoist: 'all',
+      },
+    ],
+    '@typescript-eslint/no-this-alias': 'error',
+    '@typescript-eslint/no-unused-expressions': 'error',
     '@typescript-eslint/no-unused-vars': 'error',
+    '@typescript-eslint/no-use-before-define': 'error',
+    '@typescript-eslint/no-var-requires': 'error',
+    '@typescript-eslint/prefer-for-of': 'error',
+    '@typescript-eslint/prefer-function-type': 'error',
+    '@typescript-eslint/prefer-namespace-keyword': 'error',
+    '@typescript-eslint/quotes': [
+      'error',
+      'single',
+      {
+        avoidEscape: true,
+      },
+    ],
+    '@typescript-eslint/semi': ['error', 'never'],
+    '@typescript-eslint/triple-slash-reference': [
+      'error',
+      {
+        path: 'always',
+        types: 'prefer-import',
+        lib: 'always',
+      },
+    ],
+    '@typescript-eslint/type-annotation-spacing': 'error',
+    '@typescript-eslint/typedef': 'error',
+    '@typescript-eslint/unified-signatures': 'error',
+    'arrow-body-style': ['error', 'as-needed'],
+    complexity: [
+      'error',
+      {
+        max: 15,
+      },
+    ],
+    'constructor-super': 'error',
+    eqeqeq: ['error', 'smart'],
+    'guard-for-in': 'error',
+    'id-denylist': [
+      'error',
+      'any',
+      'Number',
+      'number',
+      'String',
+      'string',
+      'Boolean',
+      'boolean',
+      'Undefined',
+      'undefined',
+    ],
+    'id-match': 'error',
     'import/no-anonymous-default-export': [
       'error',
       {
@@ -104,8 +236,58 @@ module.exports = {
         allowObject: true,
       },
     ],
+    'import/no-extraneous-dependencies': [
+      'error',
+      {
+        devDependencies: true,
+      },
+    ],
+    'jest/no-disabled-tests': 'warn',
+    'jest/no-focused-tests': 'error',
+    'jest/no-identical-title': 'error',
+    'jest/valid-expect': 'error',
+    'max-classes-per-file': ['error', 1],
+    'no-bitwise': 'error',
+    'no-caller': 'error',
+    'no-cond-assign': 'error',
     'no-console': 'error',
+    'no-debugger': 'error',
+    'no-duplicate-case': 'error',
+    'no-duplicate-imports': 'error',
+    'no-empty': 'error',
+    'no-eval': 'error',
+    'no-extra-bind': 'error',
+    'no-multiple-empty-lines': 'error',
+    'no-new-func': 'error',
+    'no-new-wrappers': 'error',
+    'no-param-reassign': 'error',
+    'no-redeclare': 'error',
+    'no-return-await': 'error',
+    'no-sequences': 'error',
+    'no-sparse-arrays': 'error',
+    'no-template-curly-in-string': 'error',
+    'no-throw-literal': 'error',
+    'no-trailing-spaces': 'error',
+    'no-undef-init': 'error',
+    'no-unsafe-finally': 'error',
+    'no-unused-labels': 'error',
+    'no-var': 'error',
+    'object-shorthand': 'error',
+    'one-var': ['error', 'never'],
+    'padding-line-between-statements': [
+      'error',
+      {
+        blankLine: 'always',
+        prev: '*',
+        next: 'return',
+      },
+    ],
+    'prefer-arrow/prefer-arrow-functions': 'error',
+    'prefer-const': 'error',
+    'prefer-object-spread': 'error',
+    'prefer-template': 'error',
     quotes: ['error', 'single', { avoidEscape: true }],
+    radix: 'error',
     'react-hooks/exhaustive-deps': 'error',
     'react/jsx-curly-brace-presence': [
       'error',
@@ -124,6 +306,14 @@ module.exports = {
     'simple-import-sort/imports': 'error',
     'simple-import-sort/exports': 'error',
     'sort-keys': 'error',
+    'spaced-comment': [
+      'error',
+      'always',
+      {
+        markers: ['/'],
+      },
+    ],
+    'use-isnan': 'error',
   },
   parser: '@typescript-eslint/parser',
   parserOptions: {
@@ -159,6 +349,30 @@ module.exports = {
   env: {
     browser: true,
     node: true,
+    'jest/globals': true,
+  },
+  globals: {
+    describe: true,
+    expect: true,
+    fetch: false,
+    it: true,
+    jest: true,
+    MutationObserver: true,
   },
+  overrides: [
+    {
+      // because of jest
+      files: ['*.test.ts'],
+      rules: {
+        '@typescript-eslint/explicit-function-return-type': [
+          'warn',
+          {
+            allowTypedFunctionExpressions: true,
+          },
+        ],
+        '@typescript-eslint/no-explicit-any': 'off',
+      },
+    },
+  ],
   root: true,
 }

package/node.js

@@ -28,6 +28,7 @@ sortedPaths.push(...keptPaths.reverse())
 
 const hookPropertyMap = new Map(
   [
+    ['eslint-plugin-jest', 'eslint-plugin-jest'],
     ['eslint-plugin-import', 'eslint-plugin-import'],
     [
       'eslint-plugin-typescript-sort-keys',
@@ -64,6 +65,7 @@ module.exports = {
     'plugin:prettier/recommended',
   ],
   plugins: [
+    'jest',
     'import',
     'typescript-sort-keys',
     'prefer-arrow',
@@ -230,6 +232,10 @@ module.exports = {
         devDependencies: true,
       },
     ],
+    'jest/no-disabled-tests': 'warn',
+    'jest/no-focused-tests': 'error',
+    'jest/no-identical-title': 'error',
+    'jest/valid-expect': 'error',
     'max-classes-per-file': ['error', 1],
     'no-bitwise': 'error',
     'no-caller': 'error',
@@ -316,6 +322,30 @@ module.exports = {
   env: {
     node: true,
     es6: true,
+    'jest/globals': true,
   },
+  globals: {
+    describe: true,
+    expect: true,
+    fetch: false,
+    it: true,
+    jest: true,
+    MutationObserver: true,
+  },
+  overrides: [
+    {
+      // because of jest
+      files: ['*.test.ts'],
+      rules: {
+        '@typescript-eslint/explicit-function-return-type': [
+          'warn',
+          {
+            allowTypedFunctionExpressions: true,
+          },
+        ],
+        '@typescript-eslint/no-explicit-any': 'off',
+      },
+    },
+  ],
   root: true,
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@allthings/eslint-config",
-  "version": "1.0.0",
+  "version": "1.1.0",
   "description": "ESlint shareable config for Allthings style",
   "main": "index.js",
   "files": [
@@ -22,6 +22,7 @@
     "eslint-import-resolver-node": "^0.3.9",
     "eslint-import-resolver-typescript": "^3.6.0",
     "eslint-plugin-import": "^2.28.1",
+    "eslint-plugin-jest": "^27.4.0",
     "eslint-plugin-jsx-a11y": "^6.7.1",
     "eslint-plugin-n": "^16.0.2",
     "eslint-plugin-prefer-arrow": "^1.2.3",